Code review comment for lp:~vanvugt/compiz-core/fix-880707.2

Revision history for this message
Tim Penhey (thumper) wrote :

> bool scheduled, painting, reschedule;

Many coding standards say only one variable declaration per line. I'm not entirely sure what the compiz-core one says.

Also, please prefer initializer lists to setting variables in the constructor.

+ scheduled = false;
+ painting = false;
+ reschedule = false;

These should all be in the initializer list.

review: Needs Fixing

« Back to merge proposal