Code review comment for lp:~vanvugt/compiz-core/fix-764330-trunk

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Part 2 of your fix may indeed fix most of the problem. However, its dangerous. The whole reason why that locking code was there in the first place is because the move plugin was incorrectly updating the internal window geometry, which is only supposed to be updated whenever the server sends a ConfigureNotify event. There is a race condition where if we have pending configure notify events and the move plugin goes ahead and writes directly to w->geometry () or w->serverGeometry (), incoming events won't be matched because w->geometry () is not being updated in the same order that the server is sending us requests in.

The API reworking that I did in order to correctly fix this problem's root cause are still unfortunately blocked pending review. We have someone who might be able to review them this week, but that really depends on availability.

« Back to merge proposal