lp:~vanvugt/compiz-core/fix-1039843

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:compiz-core

Daniel van Vugt: Disapprove on 2012-11-12

Sam Spilsbury: Approve on 2012-11-12

Diff: 28 lines (+8/-0)

2 files modified

plugins/imgsvg/CMakeLists.txt (+6/-0)
plugins/imgsvg/src/imgsvg.h (+2/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1039843: make fails if librsvg-2.0 >= 2.36.2

High

Won't Fix

Link a bug report

Related blueprints

3122. By Daniel van Vugt on 2012-11-12

Make the code buildable on newer systems with librsvg-2.0>=2.36.2
(LP: #1039843)

3121. By Daniel van Vugt on 2012-10-08

Fix leakage of destroyed_pixmaps_table, containing pointers to freed decor_t's
which could result in a freed GHashTable being passed into g_hash_table_remove
and causing a crash.
(LP: #1060171)

3120. By Daniel van Vugt on 2012-10-02

Avoid a NULL dereference and give a useful error message instead.
(LP: #944653)

3119. By Daniel van Vugt on 2012-10-02

Some decoration pixmaps get leaked on window resize, due to race conditions
between gtk-window-decorator and the decor plugin.

That's a complex problem which requires a better interprocess communication
and resource ownership design. So I'm not trying to fix that directly.

Instead, what this does is limits pixmap leaks to the lifetime of the frame
window. So if any leaks do occur, they will be cleaned up and freed next
time the window is minimized or closed. Or to garbage collect for all windows,
just hit Ctrl+Alt+D twice.

(LP: #1057263)

3118. By Sam Spilsbury on 2012-10-02

Fix window handle leak causing gradual degradation in desktop performance.
(LP: #1050610)

3117. By Rock on 2012-09-14

Fix multiple window placement bugs (LP: #974242) (LP: #976032)
By: Rock <email address hidden>

3116. By Daniel van Vugt on 2012-08-30

Fix crash when imgsvg is loaded, due to missing symbol (decor_apply_gravity
from libdecoration). (LP: #956986)

3115. By Sam Spilsbury on 2012-07-17

Cherry-picked from compiz trunk (rev 3258):

Check if the window would actually paint before painting the shadow, since it
is possible that another plugin could be inhibiting paint of the dock window.
(LP: #1012956)

3114. By Daniel van Vugt on 2012-07-17

Fix crash LP: #1019337 properly this time.

The original fix did not handle the case where:
    (win != NULL && xid != None && !valid_window(xid))
so would still exit with an X error.

Now we trap and handle such errors gracefully, instead of hitting the
default handler which kills gtk-window-decorator.

3113. By Daniel van Vugt on 2012-07-12

Backport from compiz 0.9.8:
Add extra checks to avoid passing an invalid xid to XGetWindowProperty which
would result in fatal error: BadWindow (invalid Window parameter).
(LP: #1019337)