Code review comment for lp:~vanvugt/compiz-core/backport-unredirection-fixes-0.9.7

Sam Spilsbury (smspillaz) wrote :

Well, gtest_add_tests is a sed script, and the script requires a that
there be no space between TEST_F and TEST and the ().

It also does not support TEST_P or TYPED_TEST :(

On Thu, Nov 15, 2012 at 9:43 AM, Daniel van Vugt
<email address hidden> wrote:
> Hmm, yes that makes sense. Especially since macros require no space in their definition. Because the preprocessor has a much smaller brain than a compiler and macros are quite different to functions anyway. Though I heard cpp was Turing complete :)
> --
> https://code.launchpad.net/~vanvugt/compiz-core/backport-unredirection-fixes-0.9.7/+merge/133883
> You are reviewing the proposed merge of lp:~vanvugt/compiz-core/backport-unredirection-fixes-0.9.7 into lp:compiz-core.

--
Sam Spilsbury

« Back to merge proposal