Code review comment for lp:~vanvugt/compiz-core/backport-unredirection-fixes-0.9.7

On Wed, Nov 14, 2012 at 6:36 PM, Daniel van Vugt
<email address hidden> wrote:
> Fixed typos naming the wrong test. I noticed that 'make test' never reaches it though, despite the fact that the test is a real target that gets built and is in Makefile. Not yet sure why 'make test' doesn't know it's a test.

It is because gtest_discover_tests does not know how to handle
whitespace between the TEST and the ()

You need to do

TEST()

and not

TEST ()

(compiz_discover_tests was to solve this problem and many more, but
its obviously not in compiz-core)

> --
> https://code.launchpad.net/~vanvugt/compiz-core/backport-unredirection-fixes-0.9.7/+merge/133883
> You are reviewing the proposed merge of lp:~vanvugt/compiz-core/backport-unredirection-fixes-0.9.7 into lp:compiz-core.

--
Sam Spilsbury