Code review comment for lp:~vanvugt/compiz-core/backport-unredirection-fixes-0.9.7

Sam Spilsbury (smspillaz) wrote :

This can be cleaned up slightly:

168 +include_directories (${GTEST_INCLUDE_DIRS} ..)
169 +set (exe "compiz_opengl_test_fsregion")
170 +add_executable (${exe} test-fsregion.cpp)
171 +target_link_libraries (${exe}
172 + compiz_opengl_fsregion
173 + compiz_core
174 + ${GTEST_BOTH_LIBRARIES}
175 +)
176 +#compiz_discover_tests(${exe} COVERAGE compiz_opengl_fsregion)
177 +gtest_add_tests (compiz_test_decor_clip_groups "" test-fsregion.cpp)

instead of ${exe} use compiz_opengl_test_fsregion.

Remove the commented out bit.

Other than that:

review: Approve

« Back to merge proposal