Merge lp:~vanvugt/compiz-compizconfig-gconf/fix-979770 into lp:compiz-compizconfig-gconf

Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 163
Proposed branch: lp:~vanvugt/compiz-compizconfig-gconf/fix-979770
Merge into: lp:compiz-compizconfig-gconf
Diff against target: 38 lines (+5/-4)
1 file modified
src/gconf.c (+5/-4)
To merge this branch: bzr merge lp:~vanvugt/compiz-compizconfig-gconf/fix-979770
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
Review via email: mp+101859@code.launchpad.net

Description of the change

Fixed: The config for the Default profile was not copied to the user's
gconf tree unless they had previously logged into the Ubuntu (unity) profile
(LP: #979770)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The gconf tree was not being copied because in checkProfile(), lastProfile==currentProfile=="Default". So that meant the code to copy the profile tree was never called.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/gconf.c'
2--- src/gconf.c 2012-03-19 14:34:30 +0000
3+++ src/gconf.c 2012-04-13 05:13:20 +0000
4@@ -1876,7 +1876,7 @@
5 return ret;
6 }
7
8- return strdup (DEFAULTPROF);
9+ return NULL;
10 }
11
12 static Bool
13@@ -1927,7 +1927,8 @@
14 updateCurrentProfileName (currentProfile);
15 }
16
17- free (lastProfile);
18+ if (lastProfile)
19+ free (lastProfile);
20
21 return TRUE;
22 }
23@@ -2069,13 +2070,13 @@
24 g_slist_free (data);
25
26 name = getCurrentProfileName ();
27- if (strcmp (name, DEFAULTPROF) != 0)
28+ if (name && strcmp (name, DEFAULTPROF) != 0)
29 {
30 CCSString *str = calloc (1, sizeof (CCSString));
31 str->value = name;
32 ret = ccsStringListAppend (ret, str);
33 }
34- else
35+ else if (name)
36 free (name);
37
38 return ret;

Subscribers

People subscribed via source and target branches