Merge ~valentinviennot/ubuntu-docker-images:update-apache2-readme into ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:edge

Proposed by Valentin Viennot
Status: Merged
Merged at revision: 90b4a57dd7976e5bbad24752e51a9ef5e87140c6
Proposed branch: ~valentinviennot/ubuntu-docker-images:update-apache2-readme
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:edge
Diff against target: 25 lines (+4/-2)
1 file modified
README.md (+4/-2)
Reviewer Review Type Date Requested Status
Lucas Kanashiro Approve
Sergio Durigan Junior Pending
Review via email: mp+394057@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

There is one proposed change to the k8s config that will not work by default (see inline comments).

review: Needs Fixing
Revision history for this message
Valentin Viennot (valentinviennot) wrote :

> There is one proposed change to the k8s config that will not work by default
> (see inline comments).

Thanks for noticing, changed it. (Consistency with the run command doesn't matter, consistency with the "Access at" text is; you're right.)

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

+1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README.md b/README.md
2index 4da0f7e..1804ca6 100644
3--- a/README.md
4+++ b/README.md
5@@ -28,9 +28,9 @@ You can now point your browser to http://localhost:8080/ and verify that it work
6 |---|---|
7 | `-e TZ=UTC` | Timezone. |
8 | `-v /local/path/to/website:/var/www/html` | Mount and serve a local website. |
9-| `-v /my/config/apache2.conf:/etc/apache2/apache2.conf` | Mount a local configuration `apache2.conf`. |
10+| `-p 8080:80` | Expose apache2 on `localhost:8080`. |
11+| `-v /my/config/apache2.conf:/etc/apache2/apache2.conf` | Mount a local configuration `apache2.conf` (download this [example file](https://git.launchpad.net/~canonical-server/ubuntu-server-oci/+git/apache2/plain/examples/config/apache2.conf)). |
12 | `-v /local/path/to/website.conf:/etc/apache2/sites-enabled/website.conf` | Mount and serve a local website, usually as a `VirtualHost`. |
13-| `-p 8080:80` | Expose apache2 on `localhost:8080` |
14
15 #### Testing/Debugging
16
17@@ -121,6 +121,8 @@ spec:
18 $ microk8s kubectl apply -f apache2-deployment.yml
19 ```
20
21+You will now be able to connect to the Apache server on `localhost:30080`.
22+
23 ## Bugs and Features request
24
25 If you find a bug in our image or want to request a specific feature file a bug here:

Subscribers

People subscribed via source and target branches