Merge lp:~valavanisalex/ubuntu/oneiric/gedit-latex-plugin/fix-897346 into lp:ubuntu/oneiric-backports/gedit-latex-plugin

Proposed by Alex Valavanis
Status: Rejected
Rejected by: Evan Broder
Proposed branch: lp:~valavanisalex/ubuntu/oneiric/gedit-latex-plugin/fix-897346
Merge into: lp:ubuntu/oneiric-backports/gedit-latex-plugin
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~valavanisalex/ubuntu/oneiric/gedit-latex-plugin/fix-897346
Reviewer Review Type Date Requested Status
Evan Broder (community) Disapprove
Review via email: mp+83678@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Evan Broder (broder) wrote :

I'm going to go ahead and reject this merge proposal for a handful of reasons:

First, and most importantly, we don't fix bugs directly in backports. This bug should be fixed first in the development release, at which point it could be re-backported to oneiric.

Second, I would prefer to hit two birds with one stone and upgrade to 3.3.2, which switches to gvfs-open instead of gnome-open. I've opened a bug with the Debian maintainer requesting this (Debian bug #650355)

Finally, and this is much more minor, because this package requires gnome-open for proper functioning, the libgnome2-0 should be added as a dependency of gedit-latex-plugin, not a recommendation.

review: Disapprove

Unmerged revisions

12. By Alex Valavanis

Recommend libgnome2-0 to allow use of gnome-open (LP: #897346)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-10-24 09:15:49 +0000
3+++ debian/changelog 2011-11-28 19:42:25 +0000
4@@ -1,3 +1,9 @@
5+gedit-latex-plugin (3.3.1-1~oneiric2) oneiric-backports; urgency=low
6+
7+ * Recommend libgnome2-0 to allow use of gnome-open (LP: #897346)
8+
9+ -- Alex Valavanis <a.valavanis@leeds.ac.uk> Mon, 28 Nov 2011 19:08:36 +0000
10+
11 gedit-latex-plugin (3.3.1-1~oneiric1) oneiric-backports; urgency=low
12
13 * Automated backport upload; no source changes.
14
15=== modified file 'debian/control'
16--- debian/control 2011-10-24 09:15:49 +0000
17+++ debian/control 2011-11-28 19:42:25 +0000
18@@ -12,7 +12,7 @@
19 Architecture: all
20 Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}, gedit (>= 3.0.6), rubber, python-dbus,
21 python (>=2.6.6-3~) | python-multiprocessing, python-glade2
22-Recommends: texlive, python-enchant
23+Recommends: texlive, python-enchant, libgnome2-0
24 Description: gedit plugin for composing and compiling LaTeX documents
25 This plugin assist you in a number of task:
26 - Code Completion: if you type a prefix it shows you all matching commands

Subscribers

People subscribed via source and target branches