Merge lp:~vaab/openobject-server/fix-ircron-utf8-error2 into lp:openobject-server/6.1

[Valentin Lab]

job['name'] can be quite long and not very system friendly (unicode, spaces, and other characters).

The unicode part is translated in threading module thanks to "str(name)", which fails on non-ASCII characters. See the linked bug report.

It happens that I use the thread name in my logging facility, and having very long thread name is not very convenient. And conversion towards unicode is done back in the logging facility. So explicit "utf-8" encoding seems bad.

So it seems to make sense to me to use a full ASCII, small, and unique identifier as the threadname here.

Any comments ?

Unmerged revisions

4160. By Valentin Lab on 2012-05-04

[FIX] ir_cron should encode the unicode job name.

=== modified file 'openerp/addons/base/ir/ir_cron.py'
--- openerp/addons/base/ir/ir_cron.py	2012-02-02 09:21:05 +0000
+++ openerp/addons/base/ir/ir_cron.py	2012-05-04 14:43:20 +0000
@@ -234,12 +234,12 @@
                         task_cr.close()
 
                 # Got the lock on the job row, now spawn a thread to execute it in the transaction with the lock
-                task_thread = threading.Thread(target=self._run_job, name=job['name'], args=(task_cr, job, now))
+                task_thread = threading.Thread(target=self._run_job, name="ir_cron-%d" % (job['id'], ), args=(task_cr, job, now))
                 # force non-daemon task threads (the runner thread must be daemon, and this property is inherited by default)
                 task_thread.setDaemon(False)
                 openerp.cron.take_thread_slot()
                 task_thread.start()
-                _logger.debug('Cron execution thread for job `%s` spawned', job['name'])
+                _logger.debug('Cron execution thread for job `%s` spawned (thread-id: %s)', job['name'], task_thread.name)
 
             # Find next earliest job ignoring currently processed jobs (by this and other cron threads)
             find_next_time_query = """SELECT min(nextcall) AS min_next_call