Merge lp:~uweigand/gcc-linaro/neon-extendsidi-4.7-v3 into lp:gcc-linaro/4.7

Proposed by Ulrich Weigand
Status: Rejected
Rejected by: Ulrich Weigand
Proposed branch: lp:~uweigand/gcc-linaro/neon-extendsidi-4.7-v3
Merge into: lp:gcc-linaro/4.7
To merge this branch: bzr merge lp:~uweigand/gcc-linaro/neon-extendsidi-4.7-v3
Reviewer Review Type Date Requested Status
Yvan Roux Needs Information
Linaro Toolchain Developers Pending
Review via email: mp+127263@code.launchpad.net

This proposal supersedes a proposal from 2012-09-26.

Description of the change

Better optimize SI->DI extends that move from core to NEON registers.

2012-09-26: Rebase to neon-shifts-4.7-v3 branch. Add patch to fix regression by making lower-subreg pass less aggressive.
2012-10-01: Disable lower-subreg-1.c test on arm*-*-* instead of just arm-*-*.

Lower-subreg patch posted upstream here:
http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01764.html
and committed to mainline.

Update 2012-12-17: Patch now upstream. OK to backport?

To post a comment you must log in.
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

cbuild has taken a snapshot of this branch at r115024 and queued it for build.

The diff against the ancestor r115022 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3.diff

and will be built on the following builders:
 a9-builder a9hf-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3
cbuild-ancestor: lp:gcc-linaro+bzr115022
cbuild-state: check

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote : Posted in a previous version of this proposal
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote : Posted in a previous version of this proposal
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote : Posted in a previous version of this proposal

cbuild successfully built this on armv7l-precise-cbuild369-ursa3-cortexa9hfr1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-precise-cbuild369-ursa3-cortexa9hfr1

-PASS: gcc.dg/lower-subreg-1.c (test for excess errors)
-PASS: gcc.dg/lower-subreg-1.c scan-rtl-dump subreg1 "Splitting reg"
+UNSUPPORTED: gcc.dg/lower-subreg-1.c
+PASS: gcc.target/arm/neon-extend-1.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vshr.u64
+PASS: gcc.target/arm/neon-extend-2.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vshr.s64

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-precise-cbuild369-ursa3-cortexa9hfr1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-precise-cbuild369-ursa3-cortexa9hfr1/gcc-testsuite.txt

cbuild-checked: armv7l-precise-cbuild369-ursa3-cortexa9hfr1

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote : Posted in a previous version of this proposal

cbuild successfully built this on armv7l-natty-cbuild369-tcpanda04-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild369-tcpanda04-cortexa9r1

-PASS: gcc.dg/lower-subreg-1.c (test for excess errors)
-PASS: gcc.dg/lower-subreg-1.c scan-rtl-dump subreg1 "Splitting reg"
+UNSUPPORTED: gcc.dg/lower-subreg-1.c
-FAIL: gcc.dg/simulate-thread/atomic-load-longlong.c -O2 -g thread simulation test
+UNSUPPORTED: gcc.dg/simulate-thread/atomic-load-longlong.c -O2 -g thread simulation test
+PASS: gcc.target/arm/neon-extend-1.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vshr.u64
+PASS: gcc.target/arm/neon-extend-2.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vshr.s64

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild369-tcpanda04-cortexa9r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild369-tcpanda04-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild369-tcpanda04-cortexa9r1

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote : Posted in a previous version of this proposal

cbuild successfully built this on armv7l-natty-cbuild369-tcpanda04-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild369-tcpanda04-cortexa9r1

-PASS: gcc.dg/lower-subreg-1.c (test for excess errors)
-PASS: gcc.dg/lower-subreg-1.c scan-rtl-dump subreg1 "Splitting reg"
+UNSUPPORTED: gcc.dg/lower-subreg-1.c
-FAIL: gcc.dg/simulate-thread/atomic-load-longlong.c -O2 -g thread simulation test
+UNSUPPORTED: gcc.dg/simulate-thread/atomic-load-longlong.c -O2 -g thread simulation test
+PASS: gcc.target/arm/neon-extend-1.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vshr.u64
+PASS: gcc.target/arm/neon-extend-2.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vshr.s64

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild369-tcpanda04-cortexa9r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild369-tcpanda04-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild369-tcpanda04-cortexa9r1

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote : Posted in a previous version of this proposal

cbuild successfully built this on armv7l-natty-cbuild369-tcpanda03-armv5r2.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild369-tcpanda03-armv5r2

-PASS: gcc.dg/lower-subreg-1.c scan-rtl-dump subreg1 "Splitting reg"
+FAIL: gcc.dg/lower-subreg-1.c scan-rtl-dump subreg1 "Splitting reg"
+PASS: gcc.target/arm/neon-extend-1.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vshr.u64
+PASS: gcc.target/arm/neon-extend-2.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vshr.s64

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild369-tcpanda03-armv5r2/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115024~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild369-tcpanda03-armv5r2/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild369-tcpanda03-armv5r2

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild has taken a snapshot of this branch at r115025 and queued it for build.

The diff against the ancestor r115022 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3.diff

and will be built on the following builders:
 a9-builder a9hf-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3
cbuild-ancestor: lp:gcc-linaro+bzr115022
cbuild-state: check

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild successfully built this on armv7l-precise-cbuild381-ursa3-cortexa9hfr1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-precise-cbuild381-ursa3-cortexa9hfr1

-PASS: gcc.dg/lower-subreg-1.c (test for excess errors)
-PASS: gcc.dg/lower-subreg-1.c scan-rtl-dump subreg1 "Splitting reg"
+UNSUPPORTED: gcc.dg/lower-subreg-1.c
+PASS: gcc.target/arm/neon-extend-1.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vshr.u64
+PASS: gcc.target/arm/neon-extend-2.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vshr.s64

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-precise-cbuild381-ursa3-cortexa9hfr1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-precise-cbuild381-ursa3-cortexa9hfr1/gcc-testsuite.txt

cbuild-checked: armv7l-precise-cbuild381-ursa3-cortexa9hfr1

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild successfully built this on armv7l-natty-cbuild381-tcpanda04-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild381-tcpanda04-cortexa9r1

-PASS: gcc.dg/lower-subreg-1.c (test for excess errors)
-PASS: gcc.dg/lower-subreg-1.c scan-rtl-dump subreg1 "Splitting reg"
+UNSUPPORTED: gcc.dg/lower-subreg-1.c
+PASS: gcc.target/arm/neon-extend-1.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vshr.u64
+PASS: gcc.target/arm/neon-extend-2.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vshr.s64

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild381-tcpanda04-cortexa9r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild381-tcpanda04-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild381-tcpanda04-cortexa9r1

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild successfully built this on armv7l-natty-cbuild389-tcpanda02-armv5r2.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild389-tcpanda02-armv5r2

-PASS: gcc.dg/lower-subreg-1.c (test for excess errors)
-PASS: gcc.dg/lower-subreg-1.c scan-rtl-dump subreg1 "Splitting reg"
+UNSUPPORTED: gcc.dg/lower-subreg-1.c
+PASS: gcc.target/arm/neon-extend-1.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-1.c scan-assembler vshr.u64
+PASS: gcc.target/arm/neon-extend-2.c (test for excess errors)
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vdup.32
+PASS: gcc.target/arm/neon-extend-2.c scan-assembler vshr.s64

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild389-tcpanda02-armv5r2/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr115025~uweigand~neon-extendsidi-4.7-v3/logs/armv7l-natty-cbuild389-tcpanda02-armv5r2/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild389-tcpanda02-armv5r2

Revision history for this message
Ulrich Weigand (uweigand) wrote :

Now checked in to GCC mainline as r194558.

Revision history for this message
Yvan Roux (yvan-roux) wrote :

The proposed merge diff is not available

* Test results are clean for all architectures

review: Needs Information
Revision history for this message
Ulrich Weigand (uweigand) wrote :

Huh, for some reason the diff linked above is no longer there ...

I'll create a new branch to show a clean diff against current Linaro 4.7 tip of tree.

Revision history for this message
Yvan Roux (yvan-roux) wrote :

I think that the link is broken due to the migration in the Lava lab.

Matt just pointed me that launchpad is broken w.r.t. GCC and cannot produce
the diff, I'll checkout your branch and do it on my side.

Revision history for this message
Ulrich Weigand (uweigand) wrote :

Updated merge request against current Linaro GCC now available here:
https://code.launchpad.net/~uweigand/gcc-linaro/neon-extendsidi-4.7-v4/+merge/140448

Subscribers

People subscribed via source and target branches