Merge lp:~utlemming/popularity-contest/oneiric.lp707311 into lp:ubuntu/oneiric/popularity-contest

Proposed by Ben Howard on 2012-10-29
Status: Rejected
Rejected by: Stéphane Graber on 2012-11-09
Proposed branch: lp:~utlemming/popularity-contest/oneiric.lp707311
Merge into: lp:ubuntu/oneiric/popularity-contest
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/cron.daily (+1/-1)
To merge this branch: bzr merge lp:~utlemming/popularity-contest/oneiric.lp707311
Reviewer Review Type Date Requested Status
Ubuntu branches 2012-10-29 Pending
Review via email: mp+131878@code.launchpad.net

Description of the Change

Don't run cronjob if config file is missing (LP: #707311)

To post a comment you must log in.
Sebastien Bacher (seb128) wrote :

Thank you for your work, this bug doesn't seem important enough to justify an SRU in the Oneiric serie though since that version is neither the current stable one nor a LTS

Unmerged revisions

26. By Ben Howard on 2012-10-29

Don't run cronjob if config file is missing (LP: #707311)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-07-01 23:19:31 +0000
3+++ debian/changelog 2012-10-29 11:59:25 +0000
4@@ -1,3 +1,9 @@
5+popularity-contest (1.53ubuntu2) UNRELEASED; urgency=low
6+
7+ * Don't run cronjob if /etc configuration file is missing (LP: #707311).
8+
9+ -- Ben Howard <ben.howard@ubuntu.com> Mon, 29 Oct 2012 12:41:56 +0100
10+
11 popularity-contest (1.53ubuntu1) oneiric; urgency=low
12
13 * Merge from debian unstable. (LP: #804167) Remaining changes:
14
15=== modified file 'debian/cron.daily'
16--- debian/cron.daily 2011-05-23 15:38:47 +0000
17+++ debian/cron.daily 2012-10-29 11:59:25 +0000
18@@ -15,7 +15,7 @@
19
20 # get configuration information
21 . /usr/share/popularity-contest/default.conf
22-. /etc/popularity-contest.conf
23+. /etc/popularity-contest.conf || exit 0
24
25 # don't run if MAILTO address is blank, and not configured to use HTTP POST!
26 if [ -z "$MAILTO" ] && [ "yes" != "$USEHTTP" ]; then exit 0; fi

Subscribers

People subscribed via source and target branches

to all changes: