Merge lp:~utlemming/livecd-rootfs/v380 into lp:livecd-rootfs

Proposed by Ben Howard on 2016-02-22
Status: Merged
Merged at revision: 1318
Proposed branch: lp:~utlemming/livecd-rootfs/v380
Merge into: lp:livecd-rootfs
Diff against target: 29 lines (+12/-0)
2 files modified
debian/changelog (+7/-0)
live-build/ubuntu-cpc/hooks/042-vagrant.binary (+5/-0)
To merge this branch: bzr merge lp:~utlemming/livecd-rootfs/v380
Reviewer Review Type Date Requested Status
Dimitri John Ledkov 2016-02-22 Approve on 2016-02-22
Review via email: mp+286806@code.launchpad.net

Description of the Change

Fix for Vagrant Images (LP: #1546108).

To post a comment you must log in.
Dimitri John Ledkov (xnox) wrote :

¯\_(ツ)_/¯

review: Approve
Kevin W Monroe (kwmonroe) wrote :

I don't think this will work, at least not on OSX with vagrant-1.8.1. Attempting to 'vagrant up <foo>' based on this box results in:

-----
There are errors in the configuration of this machine. Please fix
the following errors and try again:

Vagrant:
* Unknown configuration section 'customize'.
-----

I altered your patch to 042-vagrant.binary like this:

http://paste.ubuntu.com/15174464/

And it worked for me. Just my $0.02.

Kevin W Monroe (kwmonroe) wrote :

I should have explained my changes a bit better.. I think 'customize' is a provider-specific thing, so config.customize won't work. The only refs I can find to customize from vagrantup.com are from the "VBOXMANAGE CUSTOMIZATIONS" section here [0], which call '.customize' on a config.vm.provider object.

The other change I made was to add a File.join(Dir.pwd, foo) instead of the bare 'console.log'. Without that, I was getting:

-----
RawFile#0 failed to create the raw output file console.log (VERR_ACCESS_DENIED).
-----

So I included an explicit path (pwd) so the console log was created in the same dir as my Vagrantfile. I also named the console.log with a xenial prefix in case you have multiple boxes that you want to define console.logs for.

[0] - https://www.vagrantup.com/docs/virtualbox/configuration.html

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2016-02-18 13:44:01 +0000
3+++ debian/changelog 2016-02-22 14:30:54 +0000
4@@ -1,3 +1,10 @@
5+livecd-rootfs (2.380) UNRELEASED; urgency=medium
6+
7+ * live-build/ubuntu-cpc/hooks/042-vagrant.binary: add serial device for
8+ Vagrant images (LP: #1546108).
9+
10+ -- Ben Howard <ben.howard@ubuntu.com> Mon, 22 Feb 2016 07:25:55 -0700
11+
12 livecd-rootfs (2.379) xenial; urgency=medium
13
14 * add /var/lib/systemd/rfkill to pre-created dirs to use as writable
15
16=== modified file 'live-build/ubuntu-cpc/hooks/042-vagrant.binary'
17--- live-build/ubuntu-cpc/hooks/042-vagrant.binary 2016-02-06 07:39:56 +0000
18+++ live-build/ubuntu-cpc/hooks/042-vagrant.binary 2016-02-22 14:30:54 +0000
19@@ -112,6 +112,11 @@
20 config.ssh.username = "ubuntu"
21 config.ssh.password = "${ubuntu_user_pass}"
22 config.vm.synced_folder '.', '/vagrant', disabled: true
23+
24+ # Needed due to the default commandline, which expects a console.
25+ config.customize [ "modifyvm", :id, "--uart1", "0x3F8", "4" ]
26+ config.customize [ "modifyvm", :id, "--uartmode1", "file", "console.log" ]
27+
28 end
29 EOF
30

Subscribers

People subscribed via source and target branches