Merge ~utkarsh/ubuntu/+source/python-rtslib-fb:fix-service-fail-in-container-focal into ubuntu/+source/python-rtslib-fb:ubuntu/focal-devel

Proposed by Utkarsh Gupta
Status: Merged
Approved by: Utkarsh Gupta
Approved revision: b55b4e85e00df3bb5a9e2088abb92c79f007dfc9
Merged at revision: b55b4e85e00df3bb5a9e2088abb92c79f007dfc9
Proposed branch: ~utkarsh/ubuntu/+source/python-rtslib-fb:fix-service-fail-in-container-focal
Merge into: ubuntu/+source/python-rtslib-fb:ubuntu/focal-devel
Diff against target: 28 lines (+9/-0)
2 files modified
debian/changelog (+8/-0)
debian/python3-rtslib-fb.rtslib-fb-targetctl.service (+1/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Team Pending
git-ubuntu developers Pending
Review via email: mp+404765@code.launchpad.net

Description of the change

Hiya,

This MP fixes the installation of python3-rtslib-fb package in Focal.
PPA at https://launchpad.net/~utkarsh/+archive/ubuntu/experimental-dump.

The (only superficial) autopkgtest is passing. Besides, I've manually confirmed that this issue is indeed fixed when installing the package with this fix on top.

Should you need any more details, let me know. Requesting you to please review and sponsor the upload. TIA.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

While I have a gut feeling That we have had a reason for not changing it in Focal when we first time touched this I can't find any evidence/reference.

Aside from that the change looks good to me +1

review: Approve
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Thanks, Christian! Uploaded! \o/

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/python-rtslib-fb
 * [new tag] upload/2.1.71-0ubuntu1.1 -> upload/2.1.71-0ubuntu1.1

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading python-rtslib-fb_2.1.71-0ubuntu1.1.dsc: done.
  Uploading python-rtslib-fb_2.1.71-0ubuntu1.1.debian.tar.xz: done.
  Uploading python-rtslib-fb_2.1.71-0ubuntu1.1_source.buildinfo: done.
  Uploading python-rtslib-fb_2.1.71-0ubuntu1.1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 1c8bea4..d19d850 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+python-rtslib-fb (2.1.71-0ubuntu1.1) focal; urgency=medium
7+
8+ * d/python3-rtslib-fb.rtslib-fb-targetctl.service: Add check
9+ to skip starting this service when running in a container.
10+ (LP: #1865037)
11+
12+ -- Utkarsh Gupta <utkarsh.gupta@canonical.com> Fri, 25 Jun 2021 18:31:16 +0530
13+
14 python-rtslib-fb (2.1.71-0ubuntu1) focal; urgency=medium
15
16 * New upstream release.
17diff --git a/debian/python3-rtslib-fb.rtslib-fb-targetctl.service b/debian/python3-rtslib-fb.rtslib-fb-targetctl.service
18index f5b4ce9..69063d4 100644
19--- a/debian/python3-rtslib-fb.rtslib-fb-targetctl.service
20+++ b/debian/python3-rtslib-fb.rtslib-fb-targetctl.service
21@@ -2,6 +2,7 @@
22 Description=Restore LIO kernel target configuration
23 Requires=sys-kernel-config.mount
24 After=sys-kernel-config.mount network.target local-fs.target
25+ConditionVirtualization=!container
26
27 [Service]
28 Type=oneshot

Subscribers

People subscribed via source and target branches