Merge lp:~usc-isi/nova/lp798714 into lp:~hudson-openstack/nova/trunk

Proposed by Lorin Hochstein
Status: Merged
Approved by: Matt Dietz
Approved revision: 1189
Merged at revision: 1195
Proposed branch: lp:~usc-isi/nova/lp798714
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 15 lines (+6/-0)
1 file modified
run_tests.py (+6/-0)
To merge this branch: bzr merge lp:~usc-isi/nova/lp798714
Reviewer Review Type Date Requested Status
Matt Dietz (community) Approve
Josh Kearney (community) Approve
Review via email: mp+65005@code.launchpad.net

Commit message

Fixes a bug where a misleading error message is outputted when there's a sqlalchemy-migrate version conflict.

To post a comment you must log in.
Revision history for this message
Josh Kearney (jk0) wrote :

This is a great fix, but the merge prop. will need a Commit Message or Description to succeed in merging.

review: Needs Fixing
Revision history for this message
Lorin Hochstein (lorinh) wrote :

> This is a great fix, but the merge prop. will need a Commit Message or
> Description to succeed in merging.

Commit message added.

Revision history for this message
Josh Kearney (jk0) wrote :

Thanks :)

review: Approve
Revision history for this message
Matt Dietz (cerberus) wrote :

Awesome

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'run_tests.py'
2--- run_tests.py 2011-06-15 04:05:37 +0000
3+++ run_tests.py 2011-06-17 14:20:33 +0000
4@@ -211,6 +211,12 @@
5 break
6 sys.stdout = stdout
7
8+ # NOTE(lorinh): Initialize start_time in case a sqlalchemy-migrate
9+ # error results in it failing to be initialized later. Otherwise,
10+ # _handleElapsedTime will fail, causing the wrong error message to
11+ # be outputted.
12+ self.start_time = time.time()
13+
14 def getDescription(self, test):
15 return str(test)
16