Code review comment for lp:~ursinha/uci-engine/private-lp-mthood

Revision history for this message
Ursula Junque (ursinha) wrote :

> > > === modified file 'branch-source-builder/watch_ppa.py'
> >
> > def get_launchpad_log(url):
> > > '''Retrieves the build log from launchpad (thanks to celso).'''
> > > if not url:
> > > return None
> > > - api_url = url.replace('/launchpad.net/','/api.launchpad.net/devel/')
> > > - lp = launchpadmanager.get_launchpad()
> > > + api_url = launchpad.get_lp_api_url(api_version="devel")
> > > + lp = launchpad.lp_login()
> > > return lp._browser.get(api_url)
> >
> > looks like the "url" parameter to this function is now ignored. Should
> > we remove it and refactor the caller of it?
>
> You are not only right, I think you found a bug. :) I'm fixing it right now.

Fixed in 441.

« Back to merge proposal