Merge lp:~ursinha/launchpad/db-patch-bug-474462 into lp:launchpad/db-devel

[Ursula Junque]

db patch that adds translation_focus field to products as they exist in distributions.

[Ursula Junque (ursinha)]

This is a database patch to allow the fix of bug 422056.

It adds a new column to Product table, translation_focus, and adds the constraint that defines that Product.translation_focus should reference a ProductSeries.

[Данило Шеган (danilo)]

Just a note: this is not in focus for our 'bridging the gap' theme, but is a nice, easy way for Ursula to experience some other bits of Launchpad development, like writing a DB patch.

[Данило Шеган (danilo)]

It also mirrors the translation_focus field we already have on Distribution.

[Stuart Bishop (stub)]

Looks good and matches the existing Distribution.translation_focus.

Patch number is patch-2207-10-0.sql

review: Approve (db)

[Jonathan Lange (jml)]

Thanks, this looks good to me. I'm glad to see increased consistency between products and distros.

FWIW, it would have been easier for me to review this if more context were included in the cover letter.

review: Approve

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2009-11-10 07:23:32 +0000
+++ database/schema/comments.sql	2009-11-18 04:11:11 +0000
@@ -581,6 +581,7 @@
 COMMENT ON COLUMN Product.bug_supervisor IS 'Person who is responsible for managing bugs on this product.';
 COMMENT ON COLUMN Product.security_contact IS 'The person or team who handles security-related issues in the product.';
 COMMENT ON COLUMN Product.driver IS 'This is a driver for the overall product. This driver will be able to approve nominations of bugs and specs to any series in the product, including backporting to old stable series. You want the smallest group of "overall drivers" here, because you can add specific drivers to each series individually.';
+COMMENT ON COLUMN Product.translation_focus IS 'The ProductSeries that should get the translation effort focus.';
 --COMMENT ON COLUMN Product.bugtracker IS 'The external bug tracker that is used to track bugs primarily for this product, if it''s different from the project bug tracker.';
 COMMENT ON COLUMN Product.development_focus IS 'The product series that is the current focus of development.';
 COMMENT ON COLUMN Product.homepage_content IS 'A home page for this product in the Launchpad.';

=== added file 'database/schema/patch-2207-10-0.sql'
--- database/schema/patch-2207-10-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2207-10-0.sql	2009-11-18 04:11:11 +0000
@@ -0,0 +1,8 @@
+SET client_min_messages=ERROR;
+
+ALTER TABLE Product
+    ADD COLUMN translation_focus int,
+    ADD CONSTRAINT product__translation_focus__fk
+        FOREIGN KEY (translation_focus) REFERENCES productseries(id);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2207, 10, 0);