Hi Ursula,

This is a nice branch. All my comments are for minor changes.

merge-conditional

-Edwin


>=== modified file 'lib/lp/translations/browser/product.py'
>--- lib/lp/translations/browser/product.py	2010-01-15 14:44:39 +0000
>+++ lib/lp/translations/browser/product.py	2010-01-20 18:38:55 +0000
>@@ -16,7 +16,8 @@
>     LaunchpadView, Link, canonical_url, enabled_with_permission)
> from canonical.launchpad.webapp.authorization import check_permission
> from canonical.launchpad.webapp.menu import NavigationMenu
>-from lp.registry.interfaces.product import IProduct, IProductSeries
>+from lp.registry.interfaces.product import IProduct
>+from lp.registry.interfaces.productseries import IProductSeries
> from lp.registry.browser.product import ProductEditView
> from lp.translations.browser.translations import TranslationsMixin
> 
>@@ -63,7 +64,8 @@
> class ProductChangeTranslatorsView(TranslationsMixin, ProductEditView):
>     label = "Set permissions and policies"
>     page_title = "Permissions and policies"
>-    field_names = ["translationgroup", "translationpermission"]
>+    field_names = ["translationgroup", "translationpermission",
>+        "translation_focus"]


This does not follow the style guide for multiline lists.
https://dev.launchpad.net/PythonStyleGuide#Multiline braces


>     @property
>     def cancel_url(self):
>
>=== added directory 'lib/lp/translations/stories/translationfocus'
>=== added file 'lib/lp/translations/stories/translationfocus/xx-product-translationfocus.txt'
>--- lib/lp/translations/stories/translationfocus/xx-product-translationfocus.txt	1970-01-01 00:00:00 +0000
>+++ lib/lp/translations/stories/translationfocus/xx-product-translationfocus.txt	2010-01-20 18:38:55 +0000
>@@ -0,0 +1,89 @@
>+The translation focus of a product can be explicitly set to a specific series.
>+When not set, launchpad recommends the development focus to translate.
>+
>+    >>> login('<email address hidden>')
>+    >>> fooproject = factory.makeProduct(name="fooproject")
>+    >>> fooproject.official_rosetta = True
>+    >>> fooproject_trunk = fooproject.getSeries("trunk")
>+    >>> fooproject_url = canonical_url(
>+    ...     fooproject, rootsite="translations")
>+    >>> logout()
>+
>+Only admin users are able to change the translation focus of a product. 
>+Unprivileged users visualize the recommended series for translation, 


Whitespace at end of line.
s/visualize/can see/


>+but have no access to the 'Change permissions' menu.
>+
>+    >>> admin_browser.open(fooproject_url)
>+    >>> print extract_text(
>+    ...     find_tags_by_class(admin_browser.contents, 'edit sprite')[0])
>+    Change permissions
>+
>+    >>> browser.open(fooproject_url)
>+    >>> print extract_text(
>+    ...     find_tags_by_class(browser.contents, 'edit sprite')[0])
>+    Traceback (most recent call last):
>+    ...
>+    IndexError: list index out of range
>+    


Whitespace at end of line.



>+
>+== Setting the translation focus ==
>+
>+    >>> login('<email address hidden>')
>+    >>> from zope.security.proxy import removeSecurityProxy
>+    >>> pot_main = factory.makePOTemplate(
>+    ...     productseries=fooproject_trunk, name="pot1")
>+    >>> removeSecurityProxy(pot_main).messagecount = 10
>+    >>> pofile = factory.makePOFile("pt_BR", potemplate=pot_main)
>+    >>> logout()
>+
>+When the translation focus is not set, Launchpad suggests the 
>+development focus as the current series to be translated. 



Whitespace at end of line.


>
>+It needs to be translatable.
>+
>+    >>> print fooproject.translation_focus
>+    None
>+
>+    >>> browser.open(fooproject_url)
>+    >>> print extract_text(find_tags_by_class(browser.contents, 'portlet')[0])
>+    Translation details...
>+    Launchpad currently recommends translating... Fooproject trunk series.
>+    ...
>+
>+We can set an untranslatable series as the translation focus, but Launchpad
>+won't consider it because there'll be nothing to translate.
>+
>+    >>> login('<email address hidden>')
>+    >>> fooproject_untranslatableseries = factory.makeProductSeries(
>+    ...     product=fooproject,
>+    ...     name="untranslatable-series")
>+    >>> fooproject.translation_focus = fooproject_untranslatableseries
>+    >>> logout()
>+
>+    >>> print removeSecurityProxy(fooproject.translation_focus.name)
>+    untranslatable-series
>+
>+    >>> browser.open(fooproject_url)
>+    >>> print extract_text(find_tags_by_class(browser.contents, 'portlet')[0])
>+    Translation details...
>+    Launchpad currently recommends translating... Fooproject trunk series.
>+    ...
>+
>+We need to create a translatable series so we can set it as translation focus.
>+
>+    >>> login('<email address hidden>')
>+    >>> fooproject_otherseries = factory.makeProductSeries(product=fooproject,
>+    ...     name="other-series")
>+    >>> pot_other = factory.makePOTemplate(
>+    ...     productseries=fooproject_otherseries, name="pot2")
>+    >>> removeSecurityProxy(pot_other).messagecount = 10
>+    >>> pofile1 = factory.makePOFile('pt_BR', potemplate=pot_other)
>+
>+    >>> fooproject.translation_focus = fooproject_otherseries
>+    >>> logout()
>+
>+    >>> browser.open(fooproject_url)
>+    >>> print extract_text(find_tags_by_class(browser.contents, 'portlet')[0])
>+    Translation details...
>+    Launchpad currently recommends translating... Fooproject other-series series.
>+    ...
>+
>
>=== added file 'lib/lp/translations/stories/webservice/xx-translationfocus.txt'
>--- lib/lp/translations/stories/webservice/xx-translationfocus.txt	1970-01-01 00:00:00 +0000
>+++ lib/lp/translations/stories/webservice/xx-translationfocus.txt	2010-01-20 18:38:55 +0000
>@@ -0,0 +1,34 @@
>+= Translation focus =
>+
>+The translation focus of a project is the series chosen as the preferred
>+one to be translated. It's optional. When not set, Launchpad suggests
>+the development focus as the preferred series to translate, which is
>+outside the scope of this test.
>+
>+    >>> evolution = webservice.get('/evolution').jsonBody()
>+    >>> print evolution['development_focus_link']
>+    http://api.launchpad.dev/beta/evolution/trunk


To avoid conflicts later on when the api version changes,
we usually only match the part of the url relevant to the test.
For example:
    http://.../evolution/trunk

>
>+    >>> print evolution['translation_focus_link']
>+    None
>+
>+It's possible to set the translation focus through the API 


Trailing whitespace.


>+if you're an admin. The translation focus should be a project series.
>+
>+    >>> from simplejson import dumps
>+    >>> print webservice.patch(
>+    ...     evolution['self_link'], 'application/json',
>+    ...     dumps({'translation_focus_link' : 


Trailing whitespace.


>+    ...         evolution['development_focus_link']}))
>+    HTTP/1.1 209 Content Returned
>+    ...
>+
>+    >>> print webservice.get('/evolution').jsonBody()['translation_focus_link']
>+    http://api.launchpad.dev/beta/evolution/trunk


s/api.*beta/.../


>+
>+Unprivileged users cannot set the translation focus.
>+
>+    >>> print user_webservice.patch(
>+    ...     evolution['self_link'], 'application/json',
>+    ...     dumps({'translation_focus_link': None}))
>+    HTTP... 401 Unauthorized
>+    ...
>