Code review comment for lp:~uriboni/webbrowser-app/reset-focus-tab-change

Revision history for this message
Olivier Tilloy (osomon) wrote :

33 + if not self.main_window.wide:
34 + self.skipTest("Only on wide form factors")

This is not the correct check. "desktop" and wide are not equivalent. A tablet in landscape mode is a wide form factor, but it doesn’t necessarily have a physical keyboard plugged in. I am aware that this "desktop" form factor thing will break easily when we get to corner cases (tablet with a keyboard, or desktop with a touch screen, …), and this will need fixing, but for now this is what we use to identify a device that has a reasonably wide screen and a physical keyboard.

review: Needs Fixing

« Back to merge proposal