Merge lp:~uriboni/webbrowser-app/larger-close-tab-button into lp:webbrowser-app
Proposed by
Ugo Riboni
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Olivier Tilloy | ||||
Approved revision: | 1211 | ||||
Merged at revision: | 1211 | ||||
Proposed branch: | lp:~uriboni/webbrowser-app/larger-close-tab-button | ||||
Merge into: | lp:webbrowser-app | ||||
Diff against target: |
80 lines (+30/-15) 2 files modified
src/app/webbrowser/TabItem.qml (+21/-13) tests/unittests/qml/tst_TabsBar.qml (+9/-2) |
||||
To merge this branch: | bzr merge lp:~uriboni/webbrowser-app/larger-close-tab-button | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Needs Fixing | |
Olivier Tilloy | Approve | ||
Review via email: mp+272557@code.launchpad.net |
Commit message
Extend the clickable area to close a tab on mobile, as taps are less precise and often end up missing it.
Description of the change
Extend the clickable area to close a tab on mobile, as taps are less precise and often end up missing it
To post a comment you must log in.
With this change the area looks correct on mobile, but it’s not on desktop.
To verify that, I added a semi-transparent red rectangle that fills the abstract button, and this is how it looks:
- on desktop: http:// people. canonical. com/~osomon/ tab-close- button- desktop. png people. canonical. com/~osomon/ tab-close- button- mobile. png
- on mobile: http://
On desktop, the area shouldn’t cover the entire height of the tab, it should be limited to the height of the X icon. And the horizontal center of the area and that of the X icon should be aligned.