Code review comment for lp:~uriboni/webbrowser-app/bookmark-folders-from-contextual-menu

Revision history for this message
Olivier Tilloy (osomon) wrote :

test_bookmark_options_from_contextual_menu can now be updated and unskipped, since the context menu implementation has custom delegates (and the emulator has a get_context_menu() method, which returns an object that has a click_action() method).

The _invoke_contextual_menu_on_item() could be made an emulator method, since it duplicates code in test_contextmenu.py (have a look at the open_context_menu() method there, which takes into account the height of the chrome to determine where to invoke the context menu).

In UrlUtils.js, the naming of the 'authority' variable in the new removeScheme function is confusing, since it’s not actually extracting the authority, only removing the scheme. Call it 'remainder', or 'tail', or something more accurate please.

« Back to merge proposal