Merge lp:~uriboni/webbrowser-app/basic-auth into lp:webbrowser-app
Proposed by
Ugo Riboni
Status: | Rejected |
---|---|
Rejected by: | Olivier Tilloy |
Proposed branch: | lp:~uriboni/webbrowser-app/basic-auth |
Merge into: | lp:webbrowser-app |
Diff against target: |
292 lines (+181/-5) 7 files modified
debian/control (+4/-4) src/Ubuntu/Web/UbuntuWebView02.qml (+1/-1) src/app/BasicAuthenticationDialog.qml (+76/-0) src/app/WebViewImpl.qml (+5/-0) tests/autopilot/webbrowser_app/emulators/browser.py (+18/-0) tests/autopilot/webbrowser_app/tests/http_server.py (+20/-0) tests/autopilot/webbrowser_app/tests/test_basic_authentication.py (+57/-0) |
To merge this branch: | bzr merge lp:~uriboni/webbrowser-app/basic-auth |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Tilloy | Disapprove | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email: mp+261491@code.launchpad.net |
Description of the change
Handle basic authentication requests by showing an authentication dialog
Depends on https:/
To post a comment you must log in.
FAILED: Continuous integration, rev:999 jenkins. qa.ubuntu. com/job/ webbrowser- app-ci/ 1860/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 3116/console jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- amd64-ci/ 617/console jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 617/console jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- i386-ci/ 617/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 3114/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/webbrowser- app-ci/ 1860/rebuild
http://