Merge lp:~uriboni/unity-2d/spread-geometries-same-as-real-ones into lp:unity-2d/3.0

Proposed by Ugo Riboni
Status: Merged
Approved by: Florian Boucault
Approved revision: 545
Merged at revision: 545
Proposed branch: lp:~uriboni/unity-2d/spread-geometries-same-as-real-ones
Merge into: lp:unity-2d/3.0
Diff against target: 46 lines (+5/-2)
3 files modified
spread/GnomeBackground.qml (+1/-1)
spread/Windows.qml (+1/-1)
spread/app/spread.cpp (+3/-0)
To merge this branch: bzr merge lp:~uriboni/unity-2d/spread-geometries-same-as-real-ones
Reviewer Review Type Date Requested Status
Florian Boucault Pending
Review via email: mp+58314@code.launchpad.net

Description of the change

[spread] Make sure the geometry of the windows and background in spread is exactly the same as the real ones so that intro and outro animations are correct

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'spread/GnomeBackground.qml'
2--- spread/GnomeBackground.qml 2011-03-22 06:04:20 +0000
3+++ spread/GnomeBackground.qml 2011-04-19 14:29:23 +0000
4@@ -83,7 +83,7 @@
5 height: screen.geometry.height
6
7 smooth: true
8- x: - screen.availableGeometry.x
9+ x: - launcherMaximumWidth
10 y: - screen.availableGeometry.y
11
12 /* Possible modes are:
13
14=== modified file 'spread/Windows.qml'
15--- spread/Windows.qml 2011-04-11 09:23:01 +0000
16+++ spread/Windows.qml 2011-04-19 14:29:23 +0000
17@@ -150,7 +150,7 @@
18 target: spreadWindow
19 /* Note that we subtract the availableGeometry x and y since window.location is
20 expressed in global screen coordinates. */
21- x: window.position.x - screen.availableGeometry.x
22+ x: window.position.x - launcherMaximumWidth
23 y: window.position.y - screen.availableGeometry.y
24 width: window.size.width
25 height: window.size.height
26
27=== modified file 'spread/app/spread.cpp'
28--- spread/app/spread.cpp 2011-03-07 14:52:11 +0000
29+++ spread/app/spread.cpp 2011-04-19 14:29:23 +0000
30@@ -26,6 +26,7 @@
31
32 #include "spreadview.h"
33 #include "spreadcontrol.h"
34+#include "launcherclient.h"
35
36 #include <unity2ddebug.h>
37
38@@ -88,6 +89,8 @@
39 control.connect(&view, SIGNAL(visibleChanged(bool)), SLOT(setIsShown(bool)));
40 view.rootContext()->setContextProperty("control", &control);
41
42+ view.rootContext()->setContextProperty("launcherMaximumWidth", LauncherClient::MaximumWidth);
43+
44 /* Load the QML UI, focus and show the window */
45 view.setResizeMode(QDeclarativeView::SizeRootObjectToView);
46 view.rootContext()->setContextProperty("spreadView", &view);

Subscribers

People subscribed via source and target branches

to all changes: