Merge lp:~uriboni/unity-2d/launcher-padding-fully-inside-items into lp:unity-2d/3.0
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Olivier Tilloy | ||||||||
Approved revision: | 436 | ||||||||
Merged at revision: | 445 | ||||||||
Proposed branch: | lp:~uriboni/unity-2d/launcher-padding-fully-inside-items | ||||||||
Merge into: | lp:unity-2d/3.0 | ||||||||
Diff against target: | 0 lines | ||||||||
To merge this branch: | bzr merge lp:~uriboni/unity-2d/launcher-padding-fully-inside-items | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Tilloy (community) | code | Approve | |
Review via email:
|
Commit message
[launcher] Implement padding in the list entirely with padding inside the items
Description of the change
The changes in this MR basically remove the padding at top and bottom of the AutoscrollingLi
Then I put back this padding by simply using the already existing padding inside the items and just aligning the tile to the bottom of the item instead of the middle.
Everything works as before, but there's one regression. When there are more items than fit the screen and the launcher is scrolled all the way to the bottom, there's a difference in the spacing between the last item in the launcher and the first item in the shelf, as illustrated here: http://
Florian saw this and deemed the regression acceptable, especially since he may remove the shelf entirely when the accordion effect is implemented.
The tooltips and active arrows are not vertically aligned. Not sure which one is shifted (maybe both actually).