Merge lp:~uriboni/unity-2d/autoscroll-on-urgent into lp:unity-2d/3.0

[Ugo Riboni]

[launcher] Whenever a tile requires attention, make sure it's scrolled into view.

Whenever a tile requires attention, make sure it's scrolled into view.

When you test this, please make sure that you test the bahavior also while click-and-hold scrolling the list, while autoscrolling the list and while dragging a tile, and verify that the visual effect is satisfactory.

[Olivier Tilloy (osomon)]

Note to self for testing: to make a window claim urgency at will, issue the following command in a terminal, and then click the window:

    xprop -f _NET_WM_STATE 32a -set _NET_WM_STATE _NET_WM_STATE_DEMANDS_ATTENTION

[Olivier Tilloy (osomon)]

This doesn’t seem to work at all here. Additionally, it easily causes crashes for items that become urgent while out of view when they subsequently become visible.

This logic should not be in the delegate: delegate are instantiated only for visible items, so it’s definitely not going to work if an item out of view becomes urgent, which is precisely the use case we want to fix.
Instead the list model itself should notify the view that one of its items requests attention. I’m working on such an implementation in a separate branch.

review: Disapprove

Unmerged revisions

507. By Ugo Riboni on 2011-04-04

Make sure that the launcher tile requiring attention is scrolled into view as soon as it starts requiring it

=== modified file 'launcher/LauncherList.qml'
--- launcher/LauncherList.qml	2011-03-31 08:12:28 +0000
+++ launcher/LauncherList.qml	2011-04-04 17:09:12 +0000
@@ -167,6 +167,8 @@
             }
         }
 
+        onUrgentChanged: if (urgent) list.positionViewAtIndex(index, ListView.Visible)
+
         Connections {
             target: item.menu
             /* The menu had the keyboard focus because the launcher had