lp:~uriboni/oxide/basic-authentication

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~oxide-developers/oxide/oxide.trunk at revision 1152

Chris Coulson: Needs Fixing on 2015-06-30

Olivier Tilloy (community): Needs Fixing on 2015-06-09

Diff: 1029 lines (+714/-5)

23 files modified

qt/core/api/oxideqhttpauthenticationrequest.cc (+103/-0)
qt/core/api/oxideqhttpauthenticationrequest.h (+64/-0)
qt/core/api/oxideqhttpauthenticationrequest_p.h (+47/-0)
qt/core/browser/oxide_qt_web_view.cc (+8/-0)
qt/core/browser/oxide_qt_web_view.h (+3/-0)
qt/core/core.gyp (+9/-0)
qt/core/glue/oxide_qt_web_view_proxy_client.h (+4/-0)
qt/qmlplugin/oxide_qml_plugin.cc (+5/-0)
qt/quick/api/oxideqquickwebview.cc (+26/-0)
qt/quick/api/oxideqquickwebview_p.h (+1/-0)
qt/quick/api/oxideqquickwebview_p_p.h (+2/-0)
qt/tests/qmltests/TestWebView.qml (+1/-1)
qt/tests/qmltests/api/tst_httpAuthentication.py (+31/-0)
qt/tests/qmltests/api/tst_httpAuthentication.qml (+142/-0)
shared/browser/oxide_resource_dispatcher_host_delegate.cc (+14/-3)
shared/browser/oxide_resource_dispatcher_host_delegate.h (+8/-0)
shared/browser/oxide_resource_dispatcher_host_login_delegate.cc (+162/-0)
shared/browser/oxide_resource_dispatcher_host_login_delegate.h (+65/-0)
shared/browser/oxide_web_view.cc (+6/-1)
shared/browser/oxide_web_view.h (+4/-0)
shared/browser/oxide_web_view_client.cc (+3/-0)
shared/browser/oxide_web_view_client.h (+4/-0)
shared/shared.gyp (+2/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1422339: Missing API to wire in basic access authentication

High

Fix Released

Link a bug report

Related blueprints

1104. By Ugo Riboni on 2015-06-18

Deny the authentication if the request object is ignored and gets destroyed. Add test for this case.

1103. By Ugo Riboni on 2015-06-18

Simplify the code to access the WebView

1102. By Ugo Riboni on 2015-06-18

Remove Qt code that for some bizarre reason ended up in oxide and still compiles

1101. By Ugo Riboni on 2015-06-18

Move ResourceDispatcherHostLoginDelegate to is own source files, and remove another case of accessing the UrlRequest outside of the IO thread.

1100. By Ugo Riboni on 2015-06-18

Clear the callback in the right destructor

1099. By Ugo Riboni on 2015-06-18

More properly ensure that data is accessed from the right thread

1098. By Ugo Riboni on 2015-06-17

Remove non-useful null pointer check

1097. By Ugo Riboni on 2015-06-17

Rename tests

1096. By Ugo Riboni on 2015-06-17

Fix some indentation

1095. By Ugo Riboni on 2015-06-17

Invalidate the pointer to the delegate when the request is cancelled, as it will be deleted by chromium immediately after. Check that we have a valid pointer before calling through it elsewhere.