Merge lp:~uriboni/camera-app/shutter-sound-settings into lp:camera-app

Proposed by Ugo Riboni
Status: Superseded
Proposed branch: lp:~uriboni/camera-app/shutter-sound-settings
Merge into: lp:camera-app
Diff against target: 63 lines (+26/-2)
2 files modified
OptionButton.qml (+1/-1)
ViewFinderOverlay.qml (+25/-1)
To merge this branch: bzr merge lp:~uriboni/camera-app/shutter-sound-settings
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Ubuntu Phablet Team Pending
Review via email: mp+278438@code.launchpad.net

This proposal has been superseded by a proposal from 2015-11-25.

Commit message

Add option to disable shutter sound

Description of the change

Add option to disable shutter sound.

Requires lp:~uriboni/qtubuntu-camera/shutter-sound-settings for the setting to actually take effect.

To post a comment you must log in.
607. By Ugo Riboni

Fix OptionButton so that toggles can also have icons

608. By Ugo Riboni

Make shutter sound a toggle and display it only when taking still pictures

609. By Ugo Riboni

Fix mistake

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'OptionButton.qml'
2--- OptionButton.qml 2015-10-22 12:21:14 +0000
3+++ OptionButton.qml 2015-11-24 16:18:26 +0000
4@@ -23,7 +23,7 @@
5 property var model
6 property string settingsProperty: model.settingsProperty
7
8- iconName: model.isToggle || !model.get(model.selectedIndex).icon ? model.icon : model.get(model.selectedIndex).icon
9+ iconName: !model.get(model.selectedIndex).icon ? model.icon : model.get(model.selectedIndex).icon
10 iconSource: (model && model.iconSource) ? model.iconSource : ""
11 on: model.isToggle ? model.get(model.selectedIndex).value : true
12 enabled: model.available
13
14=== modified file 'ViewFinderOverlay.qml'
15--- ViewFinderOverlay.qml 2015-10-22 12:21:14 +0000
16+++ ViewFinderOverlay.qml 2015-11-24 16:18:26 +0000
17@@ -50,6 +50,7 @@
18 property bool gridEnabled: false
19 property bool preferRemovableStorage: false
20 property string videoResolution: "1920x1080"
21+ property bool playShutterSound: true
22
23 onFlashModeChanged: if (flashMode != Camera.FlashOff) hdrEnabled = false;
24 onHdrEnabledChanged: if (hdrEnabled) flashMode = Camera.FlashOff
25@@ -404,6 +405,29 @@
26 property bool available: true
27 property bool visible: camera.captureMode == Camera.CaptureVideo
28 property bool showInIndicators: false
29+ },
30+ ListModel {
31+ id: shutterSoundOptionsModel
32+
33+ property string settingsProperty: "playShutterSound"
34+ property string icon: ""
35+ property string label: ""
36+ property bool isToggle: true
37+ property int selectedIndex: bottomEdge.indexForValue(shutterSoundOptionsModel, settings.playShutterSound)
38+ property bool available: true
39+ property bool visible: camera.captureMode === Camera.CaptureStillImage
40+ property bool showInIndicators: false
41+
42+ ListElement {
43+ icon: "audio-volume-high"
44+ label: QT_TR_NOOP("On")
45+ value: true
46+ }
47+ ListElement {
48+ icon: "audio-volume-muted"
49+ label: QT_TR_NOOP("Off")
50+ value: false
51+ }
52 }
53 ]
54
55@@ -582,7 +606,7 @@
56 id: shootingTimer
57 repeat: true
58 triggeredOnStart: true
59-
60+
61 property int remainingSecs: 0
62
63 onTriggered: {

Subscribers

People subscribed via source and target branches