Merge lp:~uriboni/camera-app/query-manual-focus-supported into lp:camera-app/staging

Proposed by Ugo Riboni
Status: Merged
Approved by: Florian Boucault
Approved revision: 638
Merged at revision: 639
Proposed branch: lp:~uriboni/camera-app/query-manual-focus-supported
Merge into: lp:camera-app/staging
Diff against target: 20 lines (+2/-5)
1 file modified
ViewFinderOverlay.qml (+2/-5)
To merge this branch: bzr merge lp:~uriboni/camera-app/query-manual-focus-supported
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+283287@code.launchpad.net

Commit message

Query the manual focus support to enable/disable tap-to-focus as the backend supports it

Description of the change

Query the manual focus support to enable/disable tap-to-focus as the backend supports it

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Florian Boucault (fboucault) wrote :

Attempt to merge into lp:camera-app/staging failed due to conflicts:

text conflict in ViewFinderOverlay.qml

638. By Ugo Riboni

Merge changes from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ViewFinderOverlay.qml'
2--- ViewFinderOverlay.qml 2016-01-20 12:36:02 +0000
3+++ ViewFinderOverlay.qml 2016-01-21 17:12:46 +0000
4@@ -885,15 +885,12 @@
5 leftMargin: -bottomEdgeIndicators.height
6 rightMargin: -bottomEdgeIndicators.height
7 }
8-
9- enabled: !camera.photoCaptureInProgress
10+ enabled: camera.focus.isFocusPointModeSupported(Camera.FocusPointCustom) &&
11+ !camera.photoCaptureInProgress
12 onClicked: {
13 camera.manualFocus(mouse.x, mouse.y);
14 mouse.accepted = false;
15 }
16- // FIXME: calling 'isFocusPointModeSupported' fails with
17- // "Error: Unknown method parameter type: QDeclarativeCamera::FocusPointMode"
18- //enabled: camera.focus.isFocusPointModeSupported(Camera.FocusPointCustom)
19 }
20 }
21

Subscribers

People subscribed via source and target branches