lp:~urbanape/bindwood/complete-sync

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:bindwood

Eric Casteleijn (community): Approve on 2009-09-18

Rick McBride (community): Approve on 2009-09-16

Diff: None lines api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #396186: Correctly observe Firefox bookmark manipulation events	High	Fix Released
Bug #404193: bookmark records only partially added	High	Fix Released
Bug #406839: Update record_type to http://www.freedesktop.org/wiki/Specifications/desktopcouch/bookmark	Undecided	Fix Released
Bug #408282: Handle multiple firefox profiles	Medium	Fix Released

Link a bug report

Related blueprints

26. By Zachery Bir on 2009-09-16

renamed this shell script

25. By Zachery Bir on 2009-09-15

Belt and suspenders when dealing with onItemAdded.

24. By Zachery Bir on 2009-09-15

Small changes to clarify, and add back in some debugging

Mostly, I've made all references to bookmarks "list" -> "folder", for
consistency's sake.

I had a few places where I was still referring to a (now, absent)
Bindwood.pushSettings object. Now, I just use the strings "ENABLED"
and "DISABLED".

Only perform the onItemChanged for regular attributes, not for
annotations.

Make all makeLocalChangeOnly calls explicitly return, in case we need
to assign the results.

23. By Zachery Bir on 2009-09-15

SUMMARY: reorganization and reimplementation to support complete
syncing of bookmarks, and prevent unnecessary network traffic.

This branch fixes bugs #404193, #408282, #406839, and #396186.

Bindwood was not initially implemented to be re-entrant. When we were
first annotating newly created bookmarks in preparation for storage in
CouchDB, the act of annotation caused a change notification, which
then went through and performed additional network checks. Similarly,
when pulling records from CoucDB, if any local modifications were
necessary, those changes would prompt notifications which would turn
around and propagate those changes back over the network, where they
originated.

Now Bindwood operates in one of two modes when it comes to propagating
changes over the network. Only when absolutely necessary, do we save
documents back to Couch. In cases where only a local change is
warranted, we set a flag to avoid network traffic.

Previously, Bindwood operated on the assumption that all methods for
adding a bookmark were like "New Bookmark", i.e., prompting an
onItemAdded event for the initial bookmark, and onItemChanged events
for each subsequent property that is changed. When adding a bookmark
via "Bookmark this Page", however, at least the title and URI are
provided in the onItemAdded event. This information was lost, as we
expected to send it via the subsequent change event. Now, when
onItemAdded is called, we try to glean as much information about the
bookmark as possible (at least title and URI).

Bindwood never made any attempts to keep syncing behavior constrained
to the current profile. This could lead to all profiles' bookmarks
being effectively replicated across all profiles. Now, Bindwood
restricts itself to operating only on the "default" profile. When
launched under a different profile with Bindwood installed, we log an
error message and do nothing. There is room in the future to support
syncing profiles, so long as the profiles are named the same across
machines.

22. By Zachery Bir on 2009-09-15

Removed Bindwood debugging

21. By Zachery Bir on 2009-09-08

Woops, renamed this variable

20. By Zachery Bir on 2009-09-08

Finally finished wrestling this to the ground. I was accidentally throwing away anything but the headers from requestOptions in this.request.

Now, Bindwood actually speaks OAuth.

19. By Zachery Bir on 2009-09-04

- We don't need to do the three-legged oauth dance, so rip out the authentication/authorization code.

- OAuth.completeRequest also signs the message, so no need to do it again

- Pad the message with more empty keys, and don't append a trailing slash. This enables the oauth code to generate the same signature as our python code does.

18. By Zachery Bir on 2009-09-03

Send all OAuth information in headers, regardless of request method. More instrumentation.

17. By Zachery Bir on 2009-09-02

Slightly more instrumentation and separated the try/catch block for authentication