britney

Merge ~upils/britney/+git/hints-ubuntu:python-tornado-flaky-tests into ~ubuntu-release/britney/+git/hints-ubuntu:devel

  1. Git
  2. lp:~upils/britney/+git/hints-ubuntu
  3. python-tornado-flaky-tests
  4. Merge into devel
Proposed by Paul Mars
Status: Needs review
Proposed branch: ~upils/britney/+git/hints-ubuntu:python-tornado-flaky-tests
Merge into: ~ubuntu-release/britney/+git/hints-ubuntu:devel
Diff against target: 12 lines (+4/-0)
1 file modified
ubuntu-release (+4/-0)
Reviewer Review Type Date Requested Status
Steve Langasek Disapprove
Julian Andres Klode (community) Approve
Graham Inggs Pending
Review via email: mp+461142@code.launchpad.net

Commit message

force-badtest armhf tests for python-tornado

Description of the change

The SimpleHTTPSClientTestCase.test_request_timeout test is flaky apparently due to a timeout while establishing the SSL connection.

Test logs show it can pass, but after retrying several times without success, I think a hint maybe better suited.

I did not notice this issue on other architectures.

To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote :

There is no python-tornado upload in proposed-migration that we could skip tests for, I assume you mean to force-badtest - i.e. ignore the python-tornado tests triggered by other packages.

review: Needs Fixing
Reply
~upils/britney/+git/hints-ubuntu:python-tornado-flaky-tests updated
1527958... by Paul Mars

force-badtest armhf tests for python-tornado

Revision history for this message
Julian Andres Klode (juliank) :
review: Approve
Reply
Revision history for this message
Steve Langasek (vorlon) wrote :

I don't see that anyone has attempted a python-tornado baseline retest? (retry-autopkgtest-regressions --no-proposed) I've triggered one now; depending on how non-flaky it is, this may be sufficient.

review: Needs Information
Reply
Revision history for this message
Julian Andres Klode (juliank) wrote :

The annoying thing with a baseline retest on a flaky test is it just keeps bouncing back eventually so the issue comes up again and again.

Reply
Revision history for this message
Steve Langasek (vorlon) wrote :

And the annoying thing about a badtest hint for a flaky test is that if the test ever gets fixed to not be flaky, the hint will prevent us from detecting any future regressions 😉

Reply
Revision history for this message
Steve Langasek (vorlon) wrote :

python-tornado baseline also failed so this is no longer blocking.

review: Disapprove
Reply

Unmerged commits

1527958... by Paul Mars

force-badtest armhf tests for python-tornado

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu-release b/ubuntu-release
2index d3d6e27..613f352 100644
3--- a/ubuntu-release
4+++ b/ubuntu-release
5@@ -81,3 +81,7 @@ force-skiptest apt/2.7.12
6 # dpkg already running, some fail to connect to servers like exim4, datefudge
7 # has a hilarious off-by-one-second error.
8 force-skiptest glibc/2.39-0ubuntu2
9+
10+# The SimpleHTTPSClientTestCase.test_request_timeout test is flaky apparently due to a
11+# timeout while establishing the SSL connection.
12+force-badtest python-tornado/all/armhf

Subscribers

People subscribed via source and target branches