Merge lp:~unity-team/unity8/unity8-card-overlay into lp:unity8
Proposed by
Michał Karnicki
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 698 |
Merged at revision: | 703 |
Proposed branch: | lp:~unity-team/unity8/unity8-card-overlay |
Merge into: | lp:unity8 |
Diff against target: |
227 lines (+93/-6) 5 files modified
qml/Dash/Card.qml (+64/-3) qml/Dash/CardHeader.qml (+8/-1) qml/Dash/CardTool.qml (+5/-1) tests/qmltests/Dash/tst_Card.qml (+9/-0) tests/qmltests/Dash/tst_CardTool.qml (+7/-1) |
To merge this branch: | bzr merge lp:~unity-team/unity8/unity8-card-overlay |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Albert Astals Cid (community) | Approve | ||
Michał Sawicz | Needs Fixing | ||
Michał Karnicki (community) | Approve | ||
Review via email: mp+204790@code.launchpad.net |
Commit message
* Add overlay to card.
* Fix implicit card height.
Description of the change
* Add overlay to card.
* Fix implicit card height.
Saviq's code, so I'll do the review.
Are there any related MPs required for this MP to build/function as expected? Please list.
* No
Did you perform an exploratory manual test run of your code change and any related functionality?
* Yes
If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
* N/A
If you changed the UI, has there been a design review?
* Will be reviewed in a bigger context.
To post a comment you must log in.
This code was written by Saviq, so I'm +1'ing it after reviewing it.