Code review comment for lp:~unity-team/unity8/stagedFullscreen.form-factor

Revision history for this message
Michael Zanetti (mzanetti) wrote :

I don't think having the repeater in the AbstractStage is the right thing to do. For example, in the case of an external display, we'd have 2 screens, however, the Stage would run only on one of them. Still it sets both screens to FormFactorMonitor.

I guess the current circumstances still make it work for all the cases we support atm, but it really doesn't look like this is gonna be future proof like this.

Do I understand something wrong?

review: Needs Information

« Back to merge proposal