Merge lp:~unity-team/unity8/rtm-20150121 into lp:unity8/rtm-14.09

Proposed by kevin gunn
Status: Merged
Approved by: Michael Zanetti
Approved revision: 1419
Merged at revision: 1416
Proposed branch: lp:~unity-team/unity8/rtm-20150121
Merge into: lp:unity8/rtm-14.09
Diff against target: 56 lines (+28/-3)
2 files modified
debian/changelog (+13/-0)
qml/Shell.qml (+15/-3)
To merge this branch: bzr merge lp:~unity-team/unity8/rtm-20150121
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
Review via email: mp+247251@code.launchpad.net

Commit message

merge bug fixes from vivid, for bugs 1409003, 1410830, 1413065, 1398427

Description of the change

rtm bug fix cherrypicks for
power dialogs on resume bug #1409003, #1410830
don't refocus the dialer-app bug #1413065
support for earpiece media buttons bug #1398427

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

looking good

review: Approve
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Note! For bug #1398427 (earpiece) the required telephony framework changes have not landed in RTM yet!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-01-20 11:18:22 +0000
3+++ debian/changelog 2015-01-22 03:13:04 +0000
4@@ -1,3 +1,16 @@
5+unity8 (8.02+15.04.20150121~rtm-0ubuntu1) UNRELEASED; urgency=medium
6+
7+ [ Michael Terry ]
8+ * Don't show any power dialogs while the screen is off. (LP: #1409003,
9+ #1410830)
10+ * Don't refocus the dialer-app when a call is started by the user. (LP:
11+ #1413065)
12+
13+ [ Michael Zanetti ]
14+ * Add support for earpiece media buttons (LP: #1398427)
15+
16+ -- Kevin Gunn <kevin.gunn@canonical.com> Wed, 21 Jan 2015 20:48:55 -0600
17+
18 unity8 (8.02+15.04.20150120~rtm-0ubuntu1) 14.09; urgency=medium
19
20 [ Albert Astals ]
21
22=== modified file 'qml/Shell.qml'
23--- qml/Shell.qml 2015-01-14 09:09:08 +0000
24+++ qml/Shell.qml 2015-01-22 03:13:04 +0000
25@@ -157,8 +157,20 @@
26
27 WindowKeysFilter {
28 Keys.onPressed: {
29- if (event.key == Qt.Key_PowerOff || event.key == Qt.Key_PowerDown) {
30- dialogs.onPowerKeyPressed();
31+ // Nokia earpieces give TogglePlayPause, while the iPhone's earpiece gives Play
32+ if (event.key == Qt.Key_MediaTogglePlayPause || event.key == Qt.Key_MediaPlay) {
33+ event.accepted = callManager.handleMediaKey(false);
34+ } else if (event.key == Qt.Key_PowerOff || event.key == Qt.Key_PowerDown) {
35+ // FIXME: We only consider power key presses if the screen is
36+ // on because of bugs 1410830/1409003. The theory is that when
37+ // those bugs are encountered, there is a >2s delay between the
38+ // power press event and the power release event, which causes
39+ // the shutdown dialog to appear on resume. So to avoid that
40+ // symptom while we investigate the root cause, we simply won't
41+ // initiate any dialogs when the screen is off.
42+ if (Powerd.status === Powerd.On) {
43+ dialogs.onPowerKeyPressed();
44+ }
45 event.accepted = true;
46 } else {
47 volumeKeyFilter.onKeyPressed(event.key);
48@@ -610,7 +622,7 @@
49 target: callManager
50
51 onHasCallsChanged: {
52- if (shell.locked && callManager.hasCalls) {
53+ if (shell.locked && callManager.hasCalls && greeter.lockedApp !== "dialer-app") {
54 // We just received an incoming call while locked. The
55 // indicator will have already launched dialer-app for us, but
56 // there is a race between "hasCalls" changing and the dialer

Subscribers

People subscribed via source and target branches

to all changes: