Merge lp:~unity-team/unity8/right-edge-2 into lp:unity8

[Michał Sawicz]

Implement the right edge app switching with an App Spread.

* Reworks interaction with ApplicationManager (This will end SurfaceFlinger support)
* Reworks Stage and SideStage
* Implements the App Spread for the Phone form factor right edge
* Reimplements the overlay mode side stage for the tablet form factor

* Are there any related MPs required for this MP to build/function as expected? Please list.

https://code.launchpad.net/~mzanetti/unity-api/new-screenshot-and-focusing-api/+merge/199810
https://code.launchpad.net/~mzanetti/unity-mir/screenshotting-focusing-api/+merge/199811
https://code.launchpad.net/~mzanetti/unity-scopes-shell/activate-appid-2/+merge/205443
https://code.launchpad.net/~gerboland/unity-mir/phone-surface-bad-position/+merge/212695
https://code.launchpad.net/~mzanetti/qtubuntu/drop-appmanager/+merge/212697

Here are packages for everything related: https://chinstrap.canonical.com/~mzanetti/right-edge-pkgs/

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes (MWC image)

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Yes

 * If you changed the UI, has there been a design review?

lots of them :)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:661
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mzanetti/unity8/right-edge-2/+merge/204798/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity8-ci/2423/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3644/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3249/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1293/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/944/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/948/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/944/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3648/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3251/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2423/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:663
http://jenkins.qa.ubuntu.com/job/unity8-ci/2425/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3652/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3257/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1295/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/946/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/950/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/946/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3656/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3259/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2425/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:664
http://jenkins.qa.ubuntu.com/job/unity8-ci/2427/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3657/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3262/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1297/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/948/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/952/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/948/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3661/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3264/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2427/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:665
http://jenkins.qa.ubuntu.com/job/unity8-ci/2429/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3669/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3268/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1299/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/950/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/954/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/950/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3674/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3270/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2429/rebuild

review: Needs Fixing (continuous-integration)

[Daniel d'Andrada (dandrader)]

1785 +// Rectangle { anchors.fill: parent; color: "blue"; opacity: 0.5 }

Leftover

[Daniel d'Andrada (dandrader)]

1901 + onApplicationAdded: {
1902 + priv.startingAppId = appId;
1903 +// var application = ApplicationManager.findApplication(appId)
1904 +// print("Application added:", appId, application.state)
1905 +// if (application.stage == ApplicationInfoInterface.SideStage) {
1906 +// priv.sideStageAppId = appId;
1907 +// mainStageImage.switchTo(application)
1908 +// mainStageImage.visible = true;
1909 +// } else if (application.stage == ApplicationInfoInterface.MainStage) {
1910 +// priv.mainStageAppId = appId;
1911 +// sideStageImage.switchTo(application)
1912 +// sideStageImage.visible = true;
1913 +// }
1914 + }

Do we want to have this commented-out code?

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:667
http://jenkins.qa.ubuntu.com/job/unity8-ci/2432/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3675/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3274/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1302/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/953/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/957/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/953/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3680/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3276/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2432/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:668
http://jenkins.qa.ubuntu.com/job/unity8-ci/2434/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3678/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3277/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1304/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/955/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/959/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/955/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3683/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3279/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2434/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:669
http://jenkins.qa.ubuntu.com/job/unity8-ci/2461/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3813/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3398/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1331/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/982/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/986/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/982/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3831/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3400/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2461/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:670
http://jenkins.qa.ubuntu.com/job/unity8-ci/2462/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3815/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3400/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1332/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/983/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/987/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/983/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3833/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3402/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2462/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:671
http://jenkins.qa.ubuntu.com/job/unity8-ci/2464/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3818/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3403/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1334/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/985/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/989/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/985/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3836/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3405/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2464/rebuild

review: Needs Fixing (continuous-integration)

[Gerry Boland (gerboland)]

Please mention in the commit message that this branch marks the end of SurfaceFlinger support, so unity8 is not Mir only.

[Gerry Boland (gerboland)]

> Please mention in the commit message that this branch marks the end of
> SurfaceFlinger support, so unity8 is not Mir only.
I meant: *now* Mir only
/hittip tsdgeos

[Daniel d'Andrada (dandrader)]

In PhoneStage.qml:

"""
+ property bool fullscreen: ApplicationManager.findApplication(ApplicationManager.focusedApplicationId).fullscreen
"""

That generates errors, polluting the console, when there's no focused application. Having it the following way is more concise and solves this issue:

property bool fullscreen: priv.focusedApplication ? priv.focusedApplication.fullscreen : false

[Daniel d'Andrada (dandrader)]

Likewise here:

"""
        PropertyAction { target: fadeInScreenshotImage; property: "source"; value: ApplicationManager.findApplication(priv.newFocusedAppId).screenshot }
"""

[Daniel d'Andrada (dandrader)]

I'm getting the following error on start up:

qml/Stages/PhoneStage.qml:356: ReferenceError: shift is not defined

Which is solved by:

"""
         SequentialAnimation {
             id: snapAnimation
- property int targetContentX: -shift
+ property int targetContentX: -spreadView.shift

             UbuntuNumberAnimation {
                 target: spreadView
"""

[Gerry Boland (gerboland)]

+++ qml/Shell.qml
+ property bool sideStageEnabled: shell.width >= units.gu(60)
Can be readonly.

+ property bool fullyCovered: panel.indicators.fullyOpened && shell.width <= panel.indicatorsMenuWidth
Do no harm here either

[Daniel d'Andrada (dandrader)]

And this other error on start up:

qml/Stages/PhoneStage.qml:47: TypeError: Cannot read property 'screenshot' of null

"""
                mainScreenshotImage.src = ApplicationManager.get(0).screenshot
"""

So gotta check if there's indeed a running app before querying its screenshot.

[Gerry Boland (gerboland)]

+ readonly property bool applicationRunning: ApplicationManager.focusedApplicationId.length > 0
I don't see this used anywhere actually.

[Gerry Boland (gerboland)]

Functional bugs (phone testing only)
1. I launch Contacts app from dash. Wait for it to appear. Left edge swipe it away. I'm not able to bring back Contacts by tapping its preview, nor its dahs or launcher icon.

2. I launch Contacts app from dash. Wait for it to appear. Left edge swipe it away. I then launch Dialer app from dash, I don't get a starting animation: instead Contacts app immediately shown, and eventually Dialer pops up on top

review: Needs Fixing

[Gerry Boland (gerboland)]

3. With 2 apps open, doing a full right edge swipe, the animation is linked to my finger distance from the right edge, until about 70% of the way, when it just stops. Then only finger release completes the animation. It feels like the animation locks up. Did Design want this?

4. Have app open and active. Press power to turn off display, and again to show greeter. Do a slow right-edge swipe - a black rectangle is revealed. Only on finger release does the app appear.

5. I've 2 apps open. I open a third from the dash. Once it has appeared (giving it a second more just in case), I start a right edge gesture. I only see 2 apps in the spread, the latest one has disappeared

review: Needs Fixing

[Gerry Boland (gerboland)]

Sorry about the hopeless picture, but this was something minor I noticed:
http://imgur.com/O6EFlQh
I opened 3 apps, dialer, contacts & system settings. With the order in the spread of contacts, settings, dialer, I grabbed the dialer screenshot and brought it as far left as I could. I noticed that a bit of the system settings image could be made visible over the dialer. See the image above, I marked it in red

[Gerry Boland (gerboland)]

6. With spread open, opening launcher and tapping dash icon does nothing

7. Have a couple of apps open, and engage the spread. Now open the (as example) sound indicator, and tap the "Sound settings" entry. Indicators close, but spread remains. Tapping the system settings does bring me to the correct screen.

8. Strangely, if I open System Settings app via indicators (same steps as in 7 above), it often opens with incorrect x position of the surface (i.e there's a 2-3GU gap on the left). Need to check with trunk.

[Gerry Boland (gerboland)]

9. Have system settings & dialer app open, dialer app to the front. Open indicators, select Sound and tap "Sound settings". You see the dialer app slide to the right, but a black rectangle remains, until suddenly system settings appears

[Gerry Boland (gerboland)]

http://imgur.com/gz5p3Gg I managed to get somehow, not sure how

[Gerry Boland (gerboland)]

> http://imgur.com/gz5p3Gg I managed to get somehow, not sure how
Ah I had started Gmail app. Seems it took an ultra long time to start up, so appeared in the running apps list, but no screenshot for it existed?? So the delegate was too narrow?

[Gerry Boland (gerboland)]

10. Starting Gallery app does not make panel hide (which it should)

11. Quick right edge swipe can be a little flickery. I'd forgive this however, I know what's going on.

12. With multiple apps open, bring up the OSK somehow. Then do right edge swipe to show spread. OSK stuck open

[Gerry Boland (gerboland)]

13. seems running apps icons are not all the same width: http://imgur.com/altNLT7 The second row doesn't match the first, column-wise. Note that not all apps are fullscreen any more.

[Gerry Boland (gerboland)]

Question: in the spread, the edges of the transformed screenshots are not antialiased. Turning on smoothing bad?

[Gerry Boland (gerboland)]

14. this is a tricky one to reproduce: open like 8+ apps. Right edge to open spread. Flick list to the left so you see top-most screenshot. Now flick it again, and while it is bouncing, do a right-edge swipe. When I do this, I switch to the second last app in the list (like the quick right-edge Alt-Tab swipe)

[Gerry Boland (gerboland)]

nitpick: with 8+ apps open, when you flick spread to the the left, so you see top-most screenshot, the framerate drops a bit. Optimisation can be left for later naturally

[Gerry Boland (gerboland)]

15. with spread open (3+ apps running), a long left swipe causes launcher to open, then close again. Would be better if it stayed open IMO. Short left swipe open it fine

[Michael Zanetti (mzanetti)]

> > Please mention in the commit message that this branch marks the end of
> > SurfaceFlinger support, so unity8 is not Mir only.
> I meant: *now* Mir only
> /hittip tsdgeos

done

[Michael Zanetti (mzanetti)]

> In PhoneStage.qml:
>
> """
> + property bool fullscreen: ApplicationManager.findApplication(ApplicationMana
> ger.focusedApplicationId).fullscreen
> """
>
> That generates errors, polluting the console, when there's no focused
> application. Having it the following way is more concise and solves this
> issue:
>
> property bool fullscreen: priv.focusedApplication ?
> priv.focusedApplication.fullscreen : false

done

[Michael Zanetti (mzanetti)]

> Likewise here:
>
> """
> PropertyAction { target: fadeInScreenshotImage; property: "source";
> value: ApplicationManager.findApplication(priv.newFocusedAppId).screenshot }
> """

done

[Michael Zanetti (mzanetti)]

> I'm getting the following error on start up:
>
> qml/Stages/PhoneStage.qml:356: ReferenceError: shift is not defined
>
> Which is solved by:
>
> """
> SequentialAnimation {
> id: snapAnimation
> - property int targetContentX: -shift
> + property int targetContentX: -spreadView.shift
>
> UbuntuNumberAnimation {
> target: spreadView
> """

Dammit. I fixed this already and forgot to push it to this branch... Too many branches floating around right now. Thanks for pointing out!

fixed.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:674
http://jenkins.qa.ubuntu.com/job/unity8-ci/2477/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3869/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3454/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1347/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/998/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1002/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/998/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3896/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3456/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2477/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> Functional bugs (phone testing only)
> 1. I launch Contacts app from dash. Wait for it to appear. Left edge swipe it
> away. I'm not able to bring back Contacts by tapping its preview, nor its dahs
> or launcher icon.
>
> 2. I launch Contacts app from dash. Wait for it to appear. Left edge swipe it
> away. I then launch Dialer app from dash, I don't get a starting animation:
> instead Contacts app immediately shown, and eventually Dialer pops up on top

Both were caused because unity8 still called activateApplication() which was changed to reqeastFocusApplication() in the other branches by now.

Both fixed.

[Michael Zanetti (mzanetti)]

> > Functional bugs (phone testing only)
> > 1. I launch Contacts app from dash. Wait for it to appear. Left edge swipe
> it
> > away. I'm not able to bring back Contacts by tapping its preview, nor its
> dahs
> > or launcher icon.
> >
> > 2. I launch Contacts app from dash. Wait for it to appear. Left edge swipe
> it
> > away. I then launch Dialer app from dash, I don't get a starting animation:
> > instead Contacts app immediately shown, and eventually Dialer pops up on top
>
> Both were caused because unity8 still called activateApplication() which was
> changed to reqeastFocusApplication() in the other branches by now.
>
> Both fixed.

Sorry #2 was something else. I disabled one of the screenshotting workarounds in order to be faster writing the tests and forgot to reenable it back. Now both fixed for real.

[Michael Zanetti (mzanetti)]

> + readonly property bool applicationRunning:
> ApplicationManager.focusedApplicationId.length > 0
> I don't see this used anywhere actually.

correct. removed it

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:677
http://jenkins.qa.ubuntu.com/job/unity8-ci/2478/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3871/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3456/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1348/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/999/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1003/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/999/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3898/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3458/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2478/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> 3. With 2 apps open, doing a full right edge swipe, the animation is linked to
> my finger distance from the right edge, until about 70% of the way, when it
> just stops. Then only finger release completes the animation. It feels like
> the animation locks up. Did Design want this?

Turns out the spread shouldn't be disabled at all if there are only 2 apps. => fixed.

>
> 4. Have app open and active. Press power to turn off display, and again to
> show greeter. Do a slow right-edge swipe - a black rectangle is revealed. Only
> on finger release does the app appear.

Fixed. good catch. The app was still suspended by ApplicationManager.suspended. I'm waking things now as soon as the greeter is moved, not only when we commit to unlock it.

>
> 5. I've 2 apps open. I open a third from the dash. Once it has appeared
> (giving it a second more just in case), I start a right edge gesture. I only
> see 2 apps in the spread, the latest one has disappeared

Caused by a dumb mistake in the latest unity-mir change. fixed, updated pacakges will show up on chinstrap soon.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:681
http://jenkins.qa.ubuntu.com/job/unity8-ci/2479/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3872/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3457/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1349/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1000/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1004/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1000/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3899/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3459/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2479/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> 13. seems running apps icons are not all the same width:
> http://imgur.com/altNLT7 The second row doesn't match the first, column-wise.
> Note that not all apps are fullscreen any more.

Hmm... True. That's because they keep their aspect ratio now. I could wrap then in an Item to keep them aligned but that would look quite bad in the tablet scenario where portrait and landscape apps mixed in this view. Not really sure how to deal with this tbh. Any suggestions?

[Michael Zanetti (mzanetti)]

> Sorry about the hopeless picture, but this was something minor I noticed:
> http://imgur.com/O6EFlQh
> I opened 3 apps, dialer, contacts & system settings. With the order in the
> spread of contacts, settings, dialer, I grabbed the dialer screenshot and
> brought it as far left as I could. I noticed that a bit of the system settings
> image could be made visible over the dialer. See the image above, I marked it
> in red

fixed.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:682
http://jenkins.qa.ubuntu.com/job/unity8-ci/2480/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3873/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3458/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1350/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1001/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1005/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1001/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3900/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3460/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2480/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> 6. With spread open, opening launcher and tapping dash icon does nothing

fixed.

>
> 7. Have a couple of apps open, and engage the spread. Now open the (as
> example) sound indicator, and tap the "Sound settings" entry. Indicators
> close, but spread remains. Tapping the system settings does bring me to the
> correct screen.

Should be fixed now.

>
> 8. Strangely, if I open System Settings app via indicators (same steps as in 7
> above), it often opens with incorrect x position of the surface (i.e there's a
> 2-3GU gap on the left). Need to check with trunk.

hmm... quite unlikely this has anything to do with this branches. the misplaced surface is the real app surface whereas this branch only deals with screenshots which are placed correctly.

[Michael Zanetti (mzanetti)]

> 9. Have system settings & dialer app open, dialer app to the front. Open
> indicators, select Sound and tap "Sound settings". You see the dialer app
> slide to the right, but a black rectangle remains, until suddenly system
> settings appears

This is the default app starting white rectangle which will eventually be replaced by a splash screen I believe, but a bit out of scope of this branch imo.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:685
http://jenkins.qa.ubuntu.com/job/unity8-ci/2482/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3875/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3460/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1352/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1003/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1007/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1003/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3902/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3462/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2482/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:686
http://jenkins.qa.ubuntu.com/job/unity8-ci/2484/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3878/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3463/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1354/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1005/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1009/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1005/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3905/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3465/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2484/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:687
http://jenkins.qa.ubuntu.com/job/unity8-ci/2485/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3881/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3466/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1355/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1006/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1010/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1006/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3908/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3468/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2485/rebuild

review: Needs Fixing (continuous-integration)

[Daniel d'Andrada (dandrader)]

The problem handles by spreadDragArea's code (collecting gesturePoints, etc) looks remarkably like what EdgeDragEvaluator does. Have you considered using it before you went with this implementation?

[Daniel d'Andrada (dandrader)]

> The problem handles by spreadDragArea's code (collecting gesturePoints, etc)
> looks remarkably like what EdgeDragEvaluator does. Have you considered using
> it before you went with this implementation?

Look how DragHandle uses it.

[Michael Zanetti (mzanetti)]

> 10. Starting Gallery app does not make panel hide (which it should)

Fixed.

>
> 11. Quick right edge swipe can be a little flickery. I'd forgive this however,
> I know what's going on.

Hmm... seems to work perfectly fine here... But I guess if you flick really quick and the device is busy otherwise you might manage to see some screenshot updating action.

>
> 12. With multiple apps open, bring up the OSK somehow. Then do right edge
> swipe to show spread. OSK stuck open

Yeah... that's a bit of an issue. Right now there's no way to hide the OSK except unfocing the app. As that causes the whole state machine to update it causes effects like the panel coming in for half a second (you you transition from fullscreen to fullscreen) and some more such issues. Changing the code to deal with that would be quite intrusive and afaik the plan is to make the OSK part of the app surface anyways. Can we ignore this for this merge?

[Michael Zanetti (mzanetti)]

> Question: in the spread, the edges of the transformed screenshots are not
> antialiased. Turning on smoothing bad?

I've enabled antialiasing on the tiles now. Doesn't seem to badly impact performance. Thanks for the hint. Didn't even know that property existed since QtQuick 2.0

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:688
http://jenkins.qa.ubuntu.com/job/unity8-ci/2487/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3885/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3470/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1357/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1008/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1012/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1008/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3912/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3472/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2487/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> 14. this is a tricky one to reproduce: open like 8+ apps. Right edge to open
> spread. Flick list to the left so you see top-most screenshot. Now flick it
> again, and while it is bouncing, do a right-edge swipe. When I do this, I
> switch to the second last app in the list (like the quick right-edge Alt-Tab
> swipe)

Ok, now that the DirectionalDragArea can handle being disabled while being used, I disabled it when entering stage 2. That prevents this from happening, however there's still a possibility to mess it a little up. If you quickly put down the Finger into the "empty" area while the Flickable overshoots and keep the finger there, the Flickable seems to get a mouseMove even, but releasing the finger now does not produce the mouseReleased event. If you now touch the flickable somewhere, it counts the distance as a movement and you can make it jump a bit before it follows the finger again. I'll try to improve it further but it doesn't seem as bad any more as before.

[Michael Zanetti (mzanetti)]

> nitpick: with 8+ apps open, when you flick spread to the the left, so you see
> top-most screenshot, the framerate drops a bit. Optimisation can be left for
> later naturally

The thing is, if you open 8+ apps, the overall framerate drops. Just opening 8+ apps without even using the spread (or even in trunk) makes all animations (Launcher, Dash etc) become sluggish. AlbertA and Anpok have improved this a lot already (used to happen with 4+ apps a month ago) and I believe there's still some improvements upcoming (e.g. opaque surfaces).

While there might well be room for improvements in the Spread, I think this particular issue is rather Mir related.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:689
http://jenkins.qa.ubuntu.com/job/unity8-ci/2488/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3886/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3471/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1358/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1009/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1013/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1009/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3913/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3473/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2488/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> > http://imgur.com/gz5p3Gg I managed to get somehow, not sure how
> Ah I had started Gmail app. Seems it took an ultra long time to start up, so
> appeared in the running apps list, but no screenshot for it existed?? So the
> delegate was too narrow?

Yeah... There is still a little issue if you minimize an app before it paints on the screen for the first time. In that case we can't grab a screenshot. Current trunk has empty tiles in here which I guess is a bit better than this. Again, the fact that we're keeping the aspect ration here doesn't ease things up. But I can try to find a workaround for the time being (until we get rid of the screenshotting stuff) if you want me to.

[Michael Zanetti (mzanetti)]

> > The problem handles by spreadDragArea's code (collecting gesturePoints, etc)
> > looks remarkably like what EdgeDragEvaluator does. Have you considered using
> > it before you went with this implementation?
>
> Look how DragHandle uses it.

As discussed on IRC, design wants this to complete the gesture if the user does a one-way flick but they explicitly said that the gesture speed should not have any impact on it. I'm struggling a bit to make the EdgeDragEvaluator do exactly that, so we agreed to keep it as is.

However, I'll bring up the topic of consistent edge gestures behavior (in terms of speed, distance and direction) in the next design meeting.

[Albert Astals Cid (aacid)]

Doesn't merge with current unity8 trunk
Text conflict in plugins/Utils/plugin.cpp
Text conflict in qml/Shell.qml
2 conflicts encountered.

review: Needs Fixing

[Michael Zanetti (mzanetti)]

> Doesn't merge with current unity8 trunk
> Text conflict in plugins/Utils/plugin.cpp
> Text conflict in qml/Shell.qml
> 2 conflicts encountered.

fixed

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:690
http://jenkins.qa.ubuntu.com/job/unity8-ci/2527/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4002/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3587/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1397/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1048/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1052/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1048/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4043/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3589/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2527/rebuild

review: Needs Fixing (continuous-integration)

[Gerry Boland (gerboland)]

+ function hide() {
+ if (locked) {
+ return;
+ }
+ forceHide();
+ }
Why does hide not do anything if the spreadView is visible? Well more like, it sounds like an error that hide is called when spreadView is visible.

+ blockInput: ApplicationManager.focusedApplicationId.length === 0
Nitpick: checking length of the appId to be zero to prove there's no focused app? Not wrong, just reads a bit funny. Maybe String::isEmpty() works in QML, never tried it.

+ property string focusedAppId: ApplicationManager.focusedApplicationId
+ property var focusedApplication: ApplicationManager.findApplication(focusedAppId)
Just checking: the extra focusedAppId property needed to properly update the focusedApplication property? (you do this in a few places, so just curious why)

+++ qml/Stages/PhoneStage.qml
+ onMovingChanged: {
...
+ } else {
+ mainScreenshotImage.visible = false;
Maybe setting mainScreenshotImage.src = "" might free a little memory when spread not open? Probably more GPU memory than system memory. It might have cost too though, so just an idea

+ Image {
+ id: mainScreenshotImage
+ property string src
+ source: src
why not just use source everywhere?

[Gerry Boland (gerboland)]

General JS comment: sometimes you use semicolons, other times you don't. Think it better to just use them.

[Gerry Boland (gerboland)]

+++ qml/Stages/PhoneStage.qml
+ onFocusedApplicationIdChanged: {
+ var application = ApplicationManager.findApplication(ApplicationManager.focusedApplicationId)
Might as well use priv.focusedApplication, no?

+ id: priv
+ property string focusedAppId: ApplicationManager.focusedApplicationId
+ property var focusedApplication: ApplicationManager.findApplication(focusedAppId)
+ property url focusedScreenshot: focusedApplication ? focusedApplication.screenshot : ""
Times like these I wish QML properties were readonly by default, and you had to use a specifier to specify otherwise

+ onFocusedScreenshotChanged: {
+ mainScreenshotImage.src = ApplicationManager.findApplication(ApplicationManager.focusedApplicationId).screenshot;
mainScreenshotImage.src = focusedApplication.screenshot would do, no?

+ function requestNewScreenshot() {
+ ApplicationManager.updateScreenshot(ApplicationManager.focusedApplicationId);
ApplicationManager.updateScreenshot(focusedAppId)

+ function indexOf(appId) {
I see why you need it, but not a giant fan of scanning the whole model for an index, just to reposition the spreadView. Not that I have a better idea however!

+ // FIXME: the signal connections seems to get lost.
+ // Check with Qt 5.2, see if we can remove this Connections and Binding objects
5.2 landed, fancy giving this a look?

+ // PropertyAction seems to fail when secondApplicationStarting and we didn't have another screenshot before
+ ScriptAction { script: mainScreenshotImage.src = priv.focusedScreenshot }
+ spreadView.snapTo(0)
Weird, I don't see why a PropertyAction would be incorrect here. Did you try setting a binding instead of a value, just as an experiment?

+ PropertyAction { target: fadeInScreenshotImage; property: "source"; value: ApplicationManager.findApplication(priv.newFocusedAppId) ? ApplicationManager.findApplication(priv.newFocusedAppId).screenshot : "" }
pity you need to search twice here, could you not store the value temporarily?

+ PropertyAction { target: fadeInScreenshotImage; property: "visible"; value: false }
+ PropertyAction { target: mainScreenshotImage; property: "visible"; value: false }
Fun fact: can replace this with
  PropertyAction { targets: [fadeInScreenshotImage, mainScreenshotImage]; property: "visible"; value: false }
not a demand though, both ways are fine.

+ UbuntuNumberAnimation { target: fadeInScreenshotImage; property: "opacity"; to: 1; }
+ UbuntuNumberAnimation { target: fadeInScreenshotImage; property: "scale"; to: 1; }
similarly, this can be
  UbuntuNumberAnimation { target: fadeInScreenshotImage; properties: ["opacity", "scale"]; to: 1; }

[Gerry Boland (gerboland)]

Questions: there are 2 appSplash instances? Is that if user starts 2 apps quickly?

+ property bool attachedToView: true
a comment explaining this would be nice. In fact, the logic in the EdgeDragArea could do with the same.

+ if (oneWayFlick && spreadView.shiftedContentX > units.gu(2) && spreadView.shiftedContentX < spreadView.positionMarker1 * spreadView.width) {
please wrap that line a bit

+ property real positionMarker3: 0.6
+ property real positionMarker4: .9
Consistency please

+ // Stage of the animation:
+ property int stage: not a fan of the term, as "Stage" has a particular meaning for us. Would the Flickable's "States" system be useful here, as instead of numbers, can give the animation stages names?

+ onShiftedContentXChanged: {
+ case 1:
/me pedant, but adding "break" here too might spare a future coder some pain

+// duration: UbuntuAnimation.SleepyDuration
remove?

+ spreadView.stage = 4;
leftover?

+ if (spreadView.shiftedContentX == spreadView.width * spreadView.positionMarker2) {
what's going on here? floating point equality comparison makes me suspicious

+ id: spreadRow
+ width: Math.max(3, ApplicationManager.count) * spreadView.tileDistance + (spreadView.width - spreadView.tileDistance) * 1.5
fancy maths could do with a comment explaining it :)

+++ qml/Stages/SpreadDelegate.qml
+ anchors { left: parent.left; bottom: parent.bottom; top: parent.top; topMargin: priv.heightDifference * Math.max(0, 1 - root.topMarginProgress) }
please wrap so topMargin is on its own line, as that's the nontrivial bit.

+ scale: 1
unnecessary, that's the default value.

[Gerry Boland (gerboland)]

+++ qml/Stages/StageWithSideStage.qml
How closely would you like me to review this? Since there's plenty of commented out lines and stuff, would you prefer a functional & code-sanity review only?

review: Needs Information

[Michael Zanetti (mzanetti)]

> + function hide() {
> + if (locked) {
> + return;
> + }
> + forceHide();
> + }
> Why does hide not do anything if the spreadView is visible? Well more like, it
> sounds like an error that hide is called when spreadView is visible.

It's needed to be able to press the home button in the launcher and return to the dash even while the spread is visible. Usually something calling hide() in the shell should not be able to hide the spread with a few exceptions. The user pressing the home button in the launcher is one of them.

>
> + blockInput: ApplicationManager.focusedApplicationId.length === 0
> Nitpick: checking length of the appId to be zero to prove there's no focused
> app? Not wrong, just reads a bit funny. Maybe String::isEmpty() works in QML,
> never tried it.

No, isEmpty() doesn't work as it's not really a QString (QString is not a QObject). It's the JavaScript string class.

>
> + property string focusedAppId: ApplicationManager.focusedApplicationId
> + property var focusedApplication:
> ApplicationManager.findApplication(focusedAppId)
> Just checking: the extra focusedAppId property needed to properly update the
> focusedApplication property? (you do this in a few places, so just curious
> why)

No... One is not to properly update the other, but rather to have everything at hands in the surrounding code without having to call functions in ApplicationManager each time and reduce length of the code.

>
> +++ qml/Stages/PhoneStage.qml
> + onMovingChanged: {
> ...
> + } else {
> + mainScreenshotImage.visible = false;
> Maybe setting mainScreenshotImage.src = "" might free a little memory when
> spread not open? Probably more GPU memory than system memory. It might have
> cost too though, so just an idea
>

That causes an issue: When you swipe the stage away with a left edge swipe and then pull it back in, this is the screenshot that is visible. If you think it's worth reworking this to unset and re-set the image for that case I'll do, but I'm not sure we should "polish" the screenshotting stuff that's supposed to go away.

> + Image {
> + id: mainScreenshotImage
> + property string src
> + source: src
> why not just use source everywhere?

There is a bug in our imageprovider. changing source does not emit sourceChanged.
https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1194778
I've added a FIXME comment with the link to the bug report.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:691
http://jenkins.qa.ubuntu.com/job/unity8-ci/2551/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4055/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3640/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1421/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1072/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1076/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1072/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4107/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3642/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2551/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> General JS comment: sometimes you use semicolons, other times you don't. Think
> it better to just use them.

ack. added them.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:692
http://jenkins.qa.ubuntu.com/job/unity8-ci/2552/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4057/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3642/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1422/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1073/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1077/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1073/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4109/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3644/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2552/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> +++ qml/Stages/StageWithSideStage.qml
> How closely would you like me to review this? Since there's plenty of
> commented out lines and stuff, would you prefer a functional & code-sanity
> review only?

Yeah, this is really the part that's subject to be reworked when the right edge animation for the tablet comes in. So all I'd ask you to do here is to check out if its "good enough" to not totally break the tablet experience. It definitely has issues.

[Gerry Boland (gerboland)]

+++ qml/Stages/SwitchingApplicationImage.qml
+ onApplicationChanged: print("setting app to", application.appId, application.screenshot)
debug info necessary?

+ signal switched()
I prefer roughly sticking to the guidelines (http://qt-project.org/doc/qt-4.8/qml-coding-conventions.html) and declaring signals after properties, but before javascript function definitions

+ Image {
+ visible: true
should not be necessary

You have a couple of commented out lines in this file too, please remove them.

[Gerry Boland (gerboland)]

+++ qml/Stages/TransformedSpreadDelegate.qml

Since this relies heavily on the animation "stages" reported by the spreadView, a comment explaining the different behaviours of the tile in each stage (mentioning the position markers) would help a lot.

+ property real animatedProgress: 0
purpose not obvious to me how it's different to "progress", add comment please

+ property real tile1StartScale: startScale + .4
+ property real tile0SnapAngle: 10
could be made readonly, or private actually.

+ priv.stage2startTranslate = priv.easingAnimation(0, spreadView.positionMarker4, 0, -spreadView.width, spreadView.positionMarker4) + spreadView.width;
confuses me, why the -spreadView.width offset for the animation?

+ // As they are static values, lets caluclate
typo

+ property real xTranslate: {
in many of the calculations in this block, there's a "-spreadView.width" being used in the calculation of the start or end value in a linearAnimation. Could you add a note justifying it?

+ return linearAnimation(selectedProgress, negativeProgress, selectedXTranslate, selectedXTranslate - spreadView.tileDistance, root.progress);
please wrap

+ } else if(spreadView.stage == 1) {
space needed after "if"

[Gerry Boland (gerboland)]

+++ tests/mocks/Unity/Application/ApplicationInfo.cpp
- ,m_state(Starting)
+ ,m_state(Running)
looks wrong to me, why would an app start immediately in a "running" state. Real AppMan does not do that.

+++ tests/mocks/Unity/Application/ApplicationInfo.h
+#include <QDebug>
not needed

+++ tests/mocks/Unity/Application/ApplicationManager.cpp
do we need the qDebugs?

[Gerry Boland (gerboland)]

+++ tests/mocks/Unity/Application/ApplicationScreenshotProvider.cpp

+ * Copyright (C) 2013 Canonical, Ltd.
2014

+ if (app == NULL) {
nullptr

+ QGuiApplication *unity = qobject_cast<QGuiApplication*>(qApp);
can go inside the else block where it's actually used. Quick comment explaining what's going on would be handy too for the causal reader (you're scaling the image the the width of the window for all main stage apps).

qDebug needed?

[Gerry Boland (gerboland)]

+++ tests/mocks/Unity/Application/ApplicationScreenshotProvider.h
+ * Copyright (C) 2013 Canonical, Ltd.
2014

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:693
http://jenkins.qa.ubuntu.com/job/unity8-ci/2557/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4069/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3654/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1427/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1078/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1082/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1078/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4121/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3656/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2557/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> +++ qml/Stages/PhoneStage.qml
> + onFocusedApplicationIdChanged: {
> + var application =
> ApplicationManager.findApplication(ApplicationManager.focusedApplicationId)
> Might as well use priv.focusedApplication, no?

yes. fixed.

>
> + id: priv
> + property string focusedAppId: ApplicationManager.focusedApplicationId
> + property var focusedApplication:
> ApplicationManager.findApplication(focusedAppId)
> + property url focusedScreenshot: focusedApplication ?
> focusedApplication.screenshot : ""
> Times like these I wish QML properties were readonly by default, and you had
> to use a specifier to specify otherwise

Hmm... due to a workaround for something I believe is a bug in Qt/QML I need to write them. Besides its not public API so I don't think its much of an issue.

>
> + onFocusedScreenshotChanged: {
> + mainScreenshotImage.src = ApplicationManager.findApplication(ApplicationMana
> ger.focusedApplicationId).screenshot;
> mainScreenshotImage.src = focusedApplication.screenshot would do, no?

yep. fixed.

>
> + function requestNewScreenshot() {
> +
> ApplicationManager.updateScreenshot(ApplicationManager.focusedApplicationId);
> ApplicationManager.updateScreenshot(focusedAppId)

fixed

> + function indexOf(appId) {
> I see why you need it, but not a giant fan of scanning the whole model for an
> index, just to reposition the spreadView. Not that I have a better idea
> however!

Hmm... This is only used in the corner case that the user launches an app using the launcher while in spread view. So not really critical performance wise. I can see why you dislike it, but as you said: not really a better idea around.

>
>
> + // FIXME: the signal connections seems to get lost.
> + // Check with Qt 5.2, see if we can remove this Connections and Binding
> objects
> 5.2 landed, fancy giving this a look?

Yep, checked. still an issue. I removed the "check with 5.2 phrase".

>
> + // PropertyAction seems to fail when secondApplicationStarting and we didn't
> have another screenshot before
> + ScriptAction { script: mainScreenshotImage.src = priv.focusedScreenshot }
> + spreadView.snapTo(0)
> Weird, I don't see why a PropertyAction would be incorrect here. Did you try
> setting a binding instead of a value, just as an experiment?

Oh yeah... this one gave me quite a headache to figure why the heck it was failing. Tried the binding as you proposed too. Doesn't work. I've added a FIXME to the comment.

>
> + PropertyAction { target: fadeInScreenshotImage; property: "source"; value:
> ApplicationManager.findApplication(priv.newFocusedAppId) ?
> ApplicationManager.findApplication(priv.newFocusedAppId).screenshot : "" }
> pity you need to search twice here, could you not store the value temporarily?

done.

>
> + PropertyAction { target: fadeInScreenshotImage; property: "visible"; value:
> false }
> + PropertyAction { target: mainScreenshotImage; property: "visible"; value:
> false }
> Fun fact: can replace this with
> PropertyAction { targets: [fadeInScreenshotImage, mainScreenshotImage];
> property: "visible"; value: false }
> not a demand though, both ways are fine.

nice one. didn't know this. Love it!

>
> + UbuntuNumberAnimation { target:...

[Michael Zanetti (mzanetti)]

> Questions: there are 2 appSplash instances? Is that if user starts 2 apps
> quickly?

Yeah, it mostly catches the case that the screenshot is not available for some reason, for example the one you mentioned.

>
>
> + property bool attachedToView: true
> a comment explaining this would be nice. In fact, the logic in the
> EdgeDragArea could do with the same.

very valid. added.

>
> + if (oneWayFlick && spreadView.shiftedContentX > units.gu(2) &&
> spreadView.shiftedContentX < spreadView.positionMarker1 * spreadView.width) {
> please wrap that line a bit

wrapped all to 120 chars now.

>
> + property real positionMarker3: 0.6
> + property real positionMarker4: .9
> Consistency please

fixed.

>
> + // Stage of the animation:
> + property int stage: not a fan of the term, as "Stage" has a particular
> meaning for us. Would the Flickable's "States" system be useful here, as
> instead of numbers, can give the animation stages names?

Don't really want to go for strings as I do <, > comparison etc. While that would still work with strings its imo much more fail prone if someone renames or adds a stage. I did, however rename it to "phase" now to avoid the naming collision.

>
> + onShiftedContentXChanged: {
> + case 1:
> /me pedant, but adding "break" here too might spare a future coder some pain

fair enough, fixed.

>
> +// duration: UbuntuAnimation.SleepyDuration
> remove?

done.

>
> + spreadView.stage = 4;
> leftover?

seems so... dropped it.
>
> + if (spreadView.shiftedContentX == spreadView.width *
> spreadView.positionMarker2) {
> what's going on here? floating point equality comparison makes me suspicious

Turns out its not needed any more at all as I later changed the logic to always hit the branch before in this case already.

>
> + id: spreadRow
> + width: Math.max(3, ApplicationManager.count) * spreadView.tileDistance +
> (spreadView.width - spreadView.tileDistance) * 1.5
> fancy maths could do with a comment explaining it :)

done.

> +++ qml/Stages/SpreadDelegate.qml
> + anchors { left: parent.left; bottom: parent.bottom; top: parent.top;
> topMargin: priv.heightDifference * Math.max(0, 1 - root.topMarginProgress) }
> please wrap so topMargin is on its own line, as that's the nontrivial bit.

done.
>
> + scale: 1
> unnecessary, that's the default value.

done

[Michael Zanetti (mzanetti)]

> +++ qml/Stages/SwitchingApplicationImage.qml
> + onApplicationChanged: print("setting app to", application.appId,
> application.screenshot)
> debug info necessary?
>
> + signal switched()
> I prefer roughly sticking to the guidelines (http://qt-project.org/doc/qt-4.8
> /qml-coding-conventions.html) and declaring signals after properties, but
> before javascript function definitions
>
> + Image {
> + visible: true
> should not be necessary
>
>
> You have a couple of commented out lines in this file too, please remove them.

all done. Sorry for that. Forgot to clean this one up before putting up for review.

[Gerry Boland (gerboland)]

<greyback> old query of mine too: with spread open, long left edge swipe has launcher appear, then disappear, and nothing else happens
<greyback> that ok?
<mzanetti> ah right... so yes, the spread should not go away, that is wanted
<mzanetti> now the question is whether the launcher should hide again (as it does normally) or not
* greyback thinks it should stay open
<mzanetti> probably, yes

[Gerry Boland (gerboland)]

<greyback> mind checking this: open 1 app, left swipe it away. Then tap it's entry in running apps. The slide in animation seems wrong
<mzanetti> mhm... true... wonder when that happened. will fix

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:695
http://jenkins.qa.ubuntu.com/job/unity8-ci/2564/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4079/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3664/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1434/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1085/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1089/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1085/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4131/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3666/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2564/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> +++ qml/Stages/TransformedSpreadDelegate.qml
>
> Since this relies heavily on the animation "stages" reported by the
> spreadView, a comment explaining the different behaviours of the tile in each
> stage (mentioning the position markers) would help a lot.

done

>
> + property real animatedProgress: 0
> purpose not obvious to me how it's different to "progress", add comment please

done.

>
> + property real tile1StartScale: startScale + .4
> + property real tile0SnapAngle: 10
> could be made readonly, or private actually.

actually intentional in public api as I hope to be able to reuse the TransformedAppDelegate for the tablet which has a less 3D look and feel because of the bigger screen space.

>
> + priv.stage2startTranslate = priv.easingAnimation(0,
> spreadView.positionMarker4, 0, -spreadView.width, spreadView.positionMarker4)
> + spreadView.width;
> confuses me, why the -spreadView.width offset for the animation?

tiles are attached to the right edge (outside) in the beginning and travel a distance of -spreadView.width during the progress of 0..1. So -spreadView.width is the end position. Should be more clear now that I added tons of comments all over the place.

>
> + // As they are static values, lets caluclate
> typo

fixed.

>
> + property real xTranslate: {
> in many of the calculations in this block, there's a "-spreadView.width" being
> used in the calculation of the start or end value in a linearAnimation. Could
> you add a note justifying it?

as explained above.

>
> + return linearAnimation(selectedProgress, negativeProgress,
> selectedXTranslate, selectedXTranslate - spreadView.tileDistance,
> root.progress);
> please wrap

done

>
> + } else if(spreadView.stage == 1) {
> space needed after "if"

done

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:706
http://jenkins.qa.ubuntu.com/job/unity8-ci/2567/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4091/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3675/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1437/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1088/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1092/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1088/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4143/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3677/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2567/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:707
http://jenkins.qa.ubuntu.com/job/unity8-ci/2569/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4097/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3681/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1439/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1090/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1094/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1090/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4150/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3683/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2569/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> +++ tests/mocks/Unity/Application/ApplicationInfo.cpp
> - ,m_state(Starting)
> + ,m_state(Running)
> looks wrong to me, why would an app start immediately in a "running" state.
> Real AppMan does not do that.

Ok. changed to start 'em up "Starting" and added a timer that switches them to "Running" after 300ms.

>
> +++ tests/mocks/Unity/Application/ApplicationInfo.h
> +#include <QDebug>
> not needed

gone

>
> +++ tests/mocks/Unity/Application/ApplicationManager.cpp
> do we need the qDebugs?

gone

[Michael Zanetti (mzanetti)]

> +++ tests/mocks/Unity/Application/ApplicationScreenshotProvider.cpp
>
> + * Copyright (C) 2013 Canonical, Ltd.
> 2014

fixed.

>
> + if (app == NULL) {
> nullptr

fixed.

>
> + QGuiApplication *unity = qobject_cast<QGuiApplication*>(qApp);
> can go inside the else block where it's actually used. Quick comment
> explaining what's going on would be handy too for the causal reader (you're
> scaling the image the the width of the window for all main stage apps).

fixed.

>
> qDebug needed?

removed most debugs. changed one to be a qWarning in case we can't find an image for the given app.

[Michael Zanetti (mzanetti)]

> <greyback> old query of mine too: with spread open, long left edge swipe has
> launcher appear, then disappear, and nothing else happens
> <greyback> that ok?
> <mzanetti> ah right... so yes, the spread should not go away, that is wanted
> <mzanetti> now the question is whether the launcher should hide again (as it
> does normally) or not
> * greyback thinks it should stay open
> <mzanetti> probably, yes

fixed. actually it even got me around the hide() vs forceHide() you disliked in an earlier comment

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:709
http://jenkins.qa.ubuntu.com/job/unity8-ci/2574/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4105/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3689/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1444/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1095/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1099/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1095/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4166/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3691/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2574/rebuild

review: Needs Fixing (continuous-integration)

[Gerry Boland (gerboland)]

Tablet testing issues [MS=main stage, SS=side stage]
1) opening just 1 SS app, unable to swipe it away with SS handle
2) open some apps, then close them all, "Running apps" section of apps lens does not disappear like it used to
3) with 1 SS app open, unable to interact with Dash (missing InputFilterArea perhaps)
4) with only SS app open, open MS app (via launcher) - MS starting animation incorrect
5) with only SS app open, open MS app (via launcher) - SS dismissed
6) dismissed SS keeps a shadow on the right of the screen
7) 1 MS & 1 SS app open. Return to dash. Tap SS recent app - only SS app appears. Used to be that both MS & SS app appeared.
8) App lens - MS app preview much wider than it used to be, it used to be intentionally cropped
9) not sure why, but SS app preview image in the apps lens sometimes incorrect, sometimes stretched, sometimes offset wrong and being tiled inside the preview, and sometimes the wrong image entirely. Possibly a Nexus10 bug, just strange as the window animation screenshots seem to always look fine
10) 2 MS apps open: Clock & Browser, Browser focused. Return to dash and tap the Clock entry. The animation to bring Clock to the front isn't right, looks like mix of spread animation with usual slide in animation.
11) no right edge gesture at all now (for switching apps, think it was SS app switching)?

review: Needs Fixing (functional: tablet)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:714
http://jenkins.qa.ubuntu.com/job/unity8-ci/2575/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4108/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3692/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1445/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1096/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1100/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1096/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4169/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3694/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2575/rebuild

review: Needs Fixing (continuous-integration)

[Gerry Boland (gerboland)]

Phone functional testing pass 2 issues
1) Open 2 apps, return to dash. Tap preview on one app - the "bring to front" animation looks wrong
2) open 2 apps, go to spread. Open launcher and tap icon of focused app - nothing happens. Tapping icon of other app focuses it.
3)

>
> 12. With multiple apps open, bring up the OSK somehow. Then do right edge
> swipe to show spread. OSK stuck open

Yeah... that's a bit of an issue. Right now there's no way to hide the OSK except unfocing the app. ... Can we ignore this for this merge?
Ok, I can live with that.

review: Needs Fixing (functional: phone)

[Michael Zanetti (mzanetti)]

> <greyback> mind checking this: open 1 app, left swipe it away. Then tap
> it's entry in running apps. The slide in animation seems wrong
> <mzanetti> mhm... true... wonder when that happened. will fix

fixed.

> + Image {
> + id: mainScreenshotImage
> + property string src
> + source: src
> why not just use source everywhere?

along the way I got rid of this too, which also get away with this

+ // PropertyAction seems to fail when secondApplicationStarting and we didn't have another screenshot before

[Michael Zanetti (mzanetti)]

> Phone functional testing pass 2 issues
> 1) Open 2 apps, return to dash. Tap preview on one app - the "bring to front"
> animation looks wrong

fixed

> 2) open 2 apps, go to spread. Open launcher and tap icon of focused app -
> nothing happens. Tapping icon of other app focuses it.
> 3)

fixed.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:715
http://jenkins.qa.ubuntu.com/job/unity8-ci/2582/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4118/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3702/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1452/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1103/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1107/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1103/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4179/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3704/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2582/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:717
http://jenkins.qa.ubuntu.com/job/unity8-ci/2583/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4121/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3705/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1453/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1104/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1108/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1104/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4182/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3707/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2583/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:718
http://jenkins.qa.ubuntu.com/job/unity8-ci/2585/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4124/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3708/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1455/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1106/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1110/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1106/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4185/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3710/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2585/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:719
http://jenkins.qa.ubuntu.com/job/unity8-ci/2586/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4125/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3709/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1456/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1107/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1111/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1107/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4186/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3711/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2586/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> Tablet testing issues [MS=main stage, SS=side stage]
> 1) opening just 1 SS app, unable to swipe it away with SS handle

fixed.

> 2) open some apps, then close them all, "Running apps" section of apps lens
> does not disappear like it used to

fixed.

> 3) with 1 SS app open, unable to interact with Dash (missing InputFilterArea
> perhaps)

fixed.

> 4) with only SS app open, open MS app (via launcher) - MS starting animation
> incorrect

Hmm... I did change something in this regard but not sure if this is h

> 5) with only SS app open, open MS app (via launcher) - SS dismissed

Uhm... ok. reverted the "fix" :)

> 6) dismissed SS keeps a shadow on the right of the screen

fixed.

> 7) 1 MS & 1 SS app open. Return to dash. Tap SS recent app - only SS app
> appears. Used to be that both MS & SS app appeared.

Yeah, but this time I really believe trunk's behavior is the wrong one :D

> 8) App lens - MS app preview much wider than it used to be, it used to be
> intentionally cropped

fixed.

> 9) not sure why, but SS app preview image in the apps lens sometimes
> incorrect, sometimes stretched, sometimes offset wrong and being tiled inside
> the preview, and sometimes the wrong image entirely. Possibly a Nexus10 bug,
> just strange as the window animation screenshots seem to always look fine

uhm... happens very rarely - I've seen it too today. Can we let this go and focus on eliminating the screenshots?

> 10) 2 MS apps open: Clock & Browser, Browser focused. Return to dash and tap
> the Clock entry. The animation to bring Clock to the front isn't right, looks
> like mix of spread animation with usual slide in animation.

Hmm.. not sure if I fixed this with other changed, but looks correct here.

> 11) no right edge gesture at all now (for switching apps, think it was SS app
> switching)?

I hoped to get a bypass ticket on that one instead of juggling screenshots around just to remove them with my next task again. But if it turns out this is too much breakage, I'll obviously do my best to fix this too.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:720
http://jenkins.qa.ubuntu.com/job/unity8-ci/2587/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4130/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3714/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1457/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1108/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1112/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1108/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4191/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3716/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2587/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:722
http://jenkins.qa.ubuntu.com/job/unity8-ci/2588/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4132/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3716/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1458/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1109/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1113/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1109/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4193/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3718/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2588/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:724
http://jenkins.qa.ubuntu.com/job/unity8-ci/2589/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4134/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3718/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1459/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1110/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1114/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1110/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4195/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3720/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2589/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:725
http://jenkins.qa.ubuntu.com/job/unity8-ci/2597/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4152/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3736/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1467/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1118/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1122/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1118/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4216/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3738/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2597/rebuild

review: Needs Fixing (continuous-integration)

[Gerry Boland (gerboland)]

Running AP tests, here are my results: http://studio.sketchpad.cc/Cggnfp2Eiq
Unity8 fails some tests

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:726
http://jenkins.qa.ubuntu.com/job/unity8-ci/2598/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4153/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3737/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1468/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1119/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1123/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1119/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4218/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3739/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2598/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:727
http://jenkins.qa.ubuntu.com/job/unity8-ci/2600/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4156/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3740/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1470/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1121/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1125/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1121/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4221/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3742/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2600/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:728
http://jenkins.qa.ubuntu.com/job/unity8-ci/2601/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4158/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3742/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1471/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1122/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1126/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1122/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4223/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3744/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2601/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:729
http://jenkins.qa.ubuntu.com/job/unity8-ci/2607/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4184/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3768/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1477/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1128/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1132/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1128/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4252/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3770/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2607/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:730
http://jenkins.qa.ubuntu.com/job/unity8-ci/2613/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4193/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3777/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1483/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1134/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1138/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1134/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4263/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3779/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2613/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Needs merging with trunk
  Text conflict in qml/Dash/DashApps.qml
  Contents conflict in qml/Dash/DashPreview.qml
  Text conflict in qml/Dash/GenericScopeView.qml
  Text conflict in qml/Shell.qml
  Text conflict in tests/autopilot/unity8/shell/emulators/dash.py

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:731
http://jenkins.qa.ubuntu.com/job/unity8-ci/2617/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4222/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3806/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1487/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1138/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1142/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1138/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4295/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3808/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2617/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:732
http://jenkins.qa.ubuntu.com/job/unity8-ci/2618/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4223/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3807/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1488/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1139/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1143/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1139/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4296/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3809/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2618/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:733
http://jenkins.qa.ubuntu.com/job/unity8-ci/2621/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4228/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3812/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1491/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1142/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1146/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1142/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4301/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3814/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2621/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:734
http://jenkins.qa.ubuntu.com/job/unity8-ci/2622/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4230/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3814/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1492/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1143/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1147/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1143/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4303/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3816/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2622/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:735
http://jenkins.qa.ubuntu.com/job/unity8-ci/2624/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4235/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3819/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1494/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1145/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1149/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1145/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4309/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3821/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2624/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:736
http://jenkins.qa.ubuntu.com/job/unity8-ci/2627/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4239/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3823/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1497/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1148/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1152/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1148/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4313/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3825/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2627/rebuild

review: Needs Fixing (continuous-integration)

[Mirco Müller (macslow)]

I ran ppa:ci-train-ppa-service/landing-015 with r261 on my N4 through https://wiki.ubuntu.com/Process/Merges/TestPlans/Unity8 and it held up pretty good. Especially the new right-edge feels robust and slick. But I came across this issue with starting the Notes app...

http://ubuntuone.com/6TmrkBPbLkqPiVdhkXalvQ
http://ubuntuone.com/1zSsYq6czLOiPI58Y6yGeL
http://ubuntuone.com/2DwRiTX61Pbmrosd0xlA3p
http://ubuntuone.com/4SKadILKJ6RqirwYqreCsn

Before that I had up to ten applications running (among them camera-app and browser) and there was no single glitch. I'm still trying to find a way to trigger this bug in a reproducable manner.

review: Needs Fixing

[Mirco Müller (macslow)]

Here's a screencast better showing off the "invisible" apps and the empty app-previews: https://www.youtube.com/watch?v=C66Y0vNSboI

[Michael Zanetti (mzanetti)]

> I ran ppa:ci-train-ppa-service/landing-015 with r261 on my N4 through
> https://wiki.ubuntu.com/Process/Merges/TestPlans/Unity8 and it held up pretty
> good. Especially the new right-edge feels robust and slick. But I came across
> this issue with starting the Notes app...
>
> http://ubuntuone.com/6TmrkBPbLkqPiVdhkXalvQ
> http://ubuntuone.com/1zSsYq6czLOiPI58Y6yGeL
> http://ubuntuone.com/2DwRiTX61Pbmrosd0xlA3p
> http://ubuntuone.com/4SKadILKJ6RqirwYqreCsn
>
> Before that I had up to ten applications running (among them camera-app and
> browser) and there was no single glitch. I'm still trying to find a way to
> trigger this bug in a reproducable manner.

The misplaced surface is fixed in another branch in unity-mir. I've added it to the silo. Upgrading it should get it fixed. The missing image however, happens if an app fails to start. Its the same behavior as current trunk.

[Michael Zanetti (mzanetti)]

> The missing image however,
> happens if an app fails to start. Its the same behavior as current trunk.

Some more details: This is in unity-mir and possibly even lower layers. The situation will improve once we have the live surfaces (it will fix the case where the screenshot is missing if you swipe it away before its loaded), and for apps not starting at all, we need to figure a solution in ApplicationManager. I don't adding a workaround in here is the way to go.

[Mirco Müller (macslow)]

After the second run through the test-plan with the reconfigure-fixes in the PPA, I'm ok with the results. All works nicely. Good to go.

review: Approve

[Gerry Boland (gerboland)]

Code-wise I'm happy to go too. I did a quick test of phone and it was good too. Not done a last tablet check however

review: Approve

[Gerry Boland (gerboland)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Hell yeah
 * Did CI run pass? If not, please explain why.
Dependant branches, listed in description

review: Approve

[Michał Sawicz (saviq)]

Approving as per the superseded MP. This only brought a trunk merge.

[Michał Sawicz (saviq)]

To fix:
- I got "reliable" autopilot failures on mako
- sidestage enabled on flo (shoould be >= 100gu)
- sidestage input on flo is misplaced (could be the same as above)
- we should clean up everything surfaceflinger-related (unity-mir qml installation dir, unity8 mangling import path, support for .display-mir etc.).

review: Needs Fixing

[Michał Sawicz (saviq)]

Files to clean up:

lxc-android-config: /etc/init/boot-hooks/set-display-mir.conf
ubuntu-touch-session: /etc/profile.d/qpa_plugin.sh
/etc/environment → lool/ogra/rsalveti should know where that comes from

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:737
http://jenkins.qa.ubuntu.com/job/unity8-ci/2662/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4335/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3934/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1532/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1183/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1187/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1183/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4434/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3936/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2662/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

One more:
ubuntu-touch-session: /usr/share/ubuntu-touch-session/usc-wrapper

[lp:~unity-team/unity8/right-edge-2]

738. By Michael Zanetti on 2014-03-28

make autopilot work *again*

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:738
http://jenkins.qa.ubuntu.com/job/unity8-ci/2663/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4340/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3939/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1533/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1184/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1188/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1184/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4439/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3941/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2663/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:739
http://jenkins.qa.ubuntu.com/job/unity8-ci/2665/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4344/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3943/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1535/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1186/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1190/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1186/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4443/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3945/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2665/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

2972 -class DashApps(GenericScopeView):
2973 - """Autopilot emulator for the applications scope."""
2974 -
2975 +class DashApps(emulators.UnityEmulatorBase):

I don't get why you changed the base class. You are removing the open_scope method from DashApps, and duplicating _get_category_element.

3009 - self.assertIsInstance(scope, dash_emulators.DashApps)

This check was important ^. If open_scope no longer returns a DashApps, I might need to make some changes on the unity-scope-click tests. Can you please ping me on IRC?

review: Needs Information (autopilot code review)

[Michael Zanetti (mzanetti)]

> 2972 -class DashApps(GenericScopeView):
> 2973 - """Autopilot emulator for the applications scope."""
> 2974 -
> 2975 +class DashApps(emulators.UnityEmulatorBase):
>
> I don't get why you changed the base class. You are removing the open_scope
> method from DashApps, and duplicating _get_category_element.

hmm right. Because I dropped it first as it was optimized to be a GenericScopeView, then I merged trunk which apparently prevents optimization again so I had to put it back in.

>
> 3009 - self.assertIsInstance(scope, dash_emulators.DashApps)
>
> This check was important ^. If open_scope no longer returns a DashApps, I
> might need to make some changes on the unity-scope-click tests.

Well, it is again. but its annoying to update this with every commit over and over again.

[lp:~unity-team/unity8/right-edge-2]

739. By Michael Zanetti on 2014-03-28

revert some changes in AP which are not required any more

740. By Michael Zanetti on 2014-03-28

merge

741. By Michael Zanetti on 2014-03-28

bring back some comment

742. By Michael Zanetti on 2014-03-28

oops. wrong one :D

[Michael Zanetti (mzanetti)]

ok. so I've reverted the autopilot changes again as DashApps decided to indeed be a DashApps in current configuration, but I think we should get this more robust against QML optimizations.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:742
http://jenkins.qa.ubuntu.com/job/unity8-ci/2668/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4348/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3947/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1538/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1189/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1193/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1189/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4447/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3949/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2668/rebuild

review: Needs Fixing (continuous-integration)

[lp:~unity-team/unity8/right-edge-2]

743. By Michael Zanetti on 2014-03-31

move sidestage out of the way when the focused app changes

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:743
http://jenkins.qa.ubuntu.com/job/unity8-ci/2676/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4371/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3964/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1546/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1197/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1201/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1197/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4470/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3985/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2676/rebuild

review: Needs Fixing (continuous-integration)

[lp:~unity-team/unity8/right-edge-2]

744. By Michael Zanetti on 2014-03-31

pull in application-impl-2

745. By Michael Zanetti on 2014-03-31

also depend on application-impl (without specific version)

746. By Michael Zanetti on 2014-03-31

add missing comma

747. By Michael Zanetti on 2014-03-31

unity-private doesn't provide Unity.Application... it's libunity-mir1!

748. By Michael Zanetti on 2014-03-31

drop pulling in qtubuntu for Unity.Application. It doesn't provide it any more

749. By Michał Sawicz on 2014-03-31

Bump version to ensure incompatibility with previous Unity.Application implementations.

750. By Michael Zanetti on 2014-03-31

drop the apps killing workaround again that came in handy while developing

751. By Michael Zanetti on 2014-03-31

clean out libuntuy-mir1. It'll be pulled by shlibs now

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:746
http://jenkins.qa.ubuntu.com/job/unity8-ci/2681/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4378/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3973/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1551/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1202/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1206/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1202/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4479/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3994/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2681/rebuild

review: Needs Fixing (continuous-integration)

[lp:~unity-team/unity8/right-edge-2]

752. By Michał Sawicz on 2014-03-31

Fix indentation and drop unity8-private providing unity-application-2, since it doesn't.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:751
http://jenkins.qa.ubuntu.com/job/unity8-ci/2689/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4391/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3986/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1559/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1210/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1214/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1210/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4492/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4007/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2689/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:752
http://jenkins.qa.ubuntu.com/job/unity8-ci/2690/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4398/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3993/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1560/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1211/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1215/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1211/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4499/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4014/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2690/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:753
http://jenkins.qa.ubuntu.com/job/unity8-ci/2693/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4409/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/4007/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1563/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1214/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1218/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1214/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4513/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4028/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2693/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:753
http://jenkins.qa.ubuntu.com/job/unity8-ci/2694/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4410/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/4008/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1564/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1215/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1219/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1215/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4514/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4029/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2694/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:754
http://jenkins.qa.ubuntu.com/job/unity8-ci/2697/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4416/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/4014/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1567/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1218/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1222/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1218/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4520/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4035/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2697/rebuild

review: Needs Fixing (continuous-integration)

[lp:~unity-team/unity8/right-edge-2]

753. By Michael Zanetti on 2014-04-01

don't immediately focus a newly started app

754. By Michael Zanetti on 2014-04-01

merge

755. By Michael Zanetti on 2014-04-01

drop newline

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:755
http://jenkins.qa.ubuntu.com/job/unity8-ci/2706/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4437/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/4035/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1576/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1227/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1231/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1227/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4541/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4062/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2706/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

Yeaee.

review: Approve

[Michael Zanetti (mzanetti)]

> Yeaee.

/me goes for a beer :D

=== modified file 'debian/changelog'
--- debian/changelog	2014-03-27 12:38:21 +0000
+++ debian/changelog	2014-04-01 18:39:46 +0000
@@ -1,3 +1,10 @@
+unity8 (7.85-0ubuntu1) UNRELEASED; urgency=medium
+
+  * Bump version to ensure incompatibility with previous Unity.Application
+    implementations.
+
+ -- Michał Sawicz <[e-mail]>  Mon, 31 Mar 2014 14:44:30 +0100
+
 unity8 (7.84+14.04.20140327.1-0ubuntu1) trusty; urgency=low
 
   [ Michał Sawicz ]

=== modified file 'debian/control'
--- debian/control	2014-03-24 11:49:06 +0000
+++ debian/control	2014-04-01 18:39:46 +0000
@@ -17,7 +17,7 @@
                libnih-dev,
                libpulse-dev,
                libqmenumodel-dev (>= 0.2.7),
-               libunity-api-dev (>= 7.80.4),
+               libunity-api-dev (>= 7.80.6),
                libunity-mir-dev,
                libupstart-dev,
                libusermetricsoutput1-dev,
@@ -83,9 +83,10 @@
          qtdeclarative5-ubuntu-ui-toolkit-plugin,
          qtdeclarative5-unity-notifications-plugin | unity-notifications-impl,
          qtdeclarative5-xmllistmodel-plugin,
+         unity-application-impl-2,
          unity-launcher-impl-3,
          unity-notifications-impl-2,
-         unity8-fake-env | qtubuntu-shell,
+         unity8-fake-env | unity-application-impl,
          unity8-private (= ${binary:Version}),
          unity8-private | unity-launcher-impl,
          unity-plugin-scopes | unity-scopes-impl,
@@ -97,7 +98,8 @@
 Recommends: unity-scope-click,
             unity-scope-mediascanner2,
             unity-scope-scopes,
-Breaks: indicator-network (<< 0.5.1)
+Breaks: indicator-network (<< 0.5.1),
+        ubuntu-touch-session (<< 0.107),
 Replaces: ubuntu-touch-session (<< 0.82~)
 Description: Unity 8 shell
  The Unity 8 shell is the primary user interface for Ubuntu devices.
@@ -134,7 +136,8 @@
 Pre-Depends: ${misc:Pre-Depends},
 Depends: ${misc:Depends},
          ${shlibs:Depends},
-Provides: qtubuntu-shell,
+Provides: unity-application-impl,
+          unity-application-impl-2,
 Description: Fake environment for running Unity 8 shell
  Provides fake implementations of some QML modules used by Unity 8 shell
  (e.g Ubuntu.Application) so that you can run it in a sandboxed environment.

=== modified file 'debian/unity8.install'
--- debian/unity8.install	2014-03-05 12:52:57 +0000
+++ debian/unity8.install	2014-04-01 18:39:46 +0000
@@ -10,6 +10,6 @@
 usr/share/unity8/Notifications
 usr/share/unity8/Panel
 usr/share/unity8/Shell.qml
-usr/share/unity8/SideStage
+usr/share/unity8/Stages
 usr/share/unity8/graphics
 data/unity8.conf usr/share/upstart/sessions/

=== modified file 'plugins/Utils/CMakeLists.txt'
--- plugins/Utils/CMakeLists.txt	2014-03-17 15:50:50 +0000
+++ plugins/Utils/CMakeLists.txt	2014-04-01 18:39:46 +0000
@@ -18,6 +18,7 @@
     qsortfilterproxymodelqml.cpp
     timeformatter.cpp
     unitymenumodelpaths.cpp
+    easingcurve.cpp
     plugin.cpp
     )
 
@@ -33,7 +34,7 @@
 # files directly in targets.
 set_target_properties(Utils-qml PROPERTIES COMPILE_FLAGS -fvisibility=default)
 
-qt5_use_modules(Utils-qml Qml Quick DBus Network XmlPatterns Concurrent)
+qt5_use_modules(Utils-qml Qml Quick DBus Network XmlPatterns Gui Concurrent)
 
 # export the qmldir qmltypes and plugin files
 export_qmlfiles(Utils Utils)

=== added file 'plugins/Utils/easingcurve.cpp'
--- plugins/Utils/easingcurve.cpp	1970-01-01 00:00:00 +0000
+++ plugins/Utils/easingcurve.cpp	2014-04-01 18:39:46 +0000
@@ -0,0 +1,67 @@
+/*
+ * Copyright 2014 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Michael Zanetti <[e-mail]>
+*/
+
+#include "easingcurve.h"
+
+
+EasingCurve::EasingCurve(QObject *parent):
+    QObject(parent)
+{
+
+}
+
+QEasingCurve::Type EasingCurve::type() const
+{
+    return m_easingCurve.type();
+}
+
+void EasingCurve::setType(const QEasingCurve::Type &type)
+{
+    m_easingCurve.setType(type);
+    Q_EMIT typeChanged();
+}
+
+qreal EasingCurve::period() const
+{
+    return m_easingCurve.period();
+}
+
+void EasingCurve::setPeriod(qreal period)
+{
+    m_easingCurve.setPeriod(period);
+    Q_EMIT periodChanged();
+}
+
+qreal EasingCurve::progress() const
+{
+    return m_progress;
+}
+
+void EasingCurve::setProgress(qreal progress)
+{
+    if (m_progress != progress) {
+        m_progress = progress;
+        m_value = m_easingCurve.valueForProgress(m_progress);
+        Q_EMIT progressChanged();
+    }
+}
+
+qreal EasingCurve::value() const
+{
+    return m_value;
+}

=== added file 'plugins/Utils/easingcurve.h'
--- plugins/Utils/easingcurve.h	1970-01-01 00:00:00 +0000
+++ plugins/Utils/easingcurve.h	2014-04-01 18:39:46 +0000
@@ -0,0 +1,70 @@
+/*
+ * Copyright 2014 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Michael Zanetti <[e-mail]>
+*/
+
+#ifndef EASINGCURVE_H
+#define EASINGCURVE_H
+
+#include <QObject>
+#include <QEasingCurve>
+
+/**
+ * @brief The EasingCurve class
+ *
+ * This class exposes the QEasingCurve C++ API to QML.
+ * This is useful for user interactive animations. While the QML Animation types
+ * all require a "from", "to" and "duration", this one is based on "period" and
+ * "progress". So you can control the position of the aimation by changing the
+ * progress, also going back and forward in the animation. Depending on the type
+ * of the easing curve, value will return the transformed progress.
+ */
+
+class EasingCurve: public QObject
+{
+    Q_OBJECT
+    Q_ENUMS(QEasingCurve::Type)
+    Q_PROPERTY(QEasingCurve::Type type READ type WRITE setType NOTIFY typeChanged)
+    Q_PROPERTY(qreal period READ period WRITE setPeriod NOTIFY periodChanged)
+    Q_PROPERTY(qreal progress READ progress WRITE setProgress NOTIFY progressChanged)
+    Q_PROPERTY(qreal value READ value NOTIFY progressChanged)
+
+public:
+    EasingCurve(QObject *parent = 0);
+
+    QEasingCurve::Type type() const;
+    void setType(const QEasingCurve::Type &type);
+
+    qreal period() const;
+    void setPeriod(qreal period);
+
+    qreal progress() const;
+    void setProgress(qreal progress);
+
+    qreal value() const;
+
+Q_SIGNALS:
+    void typeChanged();
+    void periodChanged();
+    void progressChanged();
+
+private:
+    QEasingCurve m_easingCurve;
+    qreal m_progress;
+    qreal m_value;
+};
+
+#endif

=== modified file 'plugins/Utils/plugin.cpp'
--- plugins/Utils/plugin.cpp	2014-03-17 15:50:50 +0000
+++ plugins/Utils/plugin.cpp	2014-04-01 18:39:46 +0000
@@ -32,6 +32,7 @@
 #include "qsortfilterproxymodelqml.h"
 #include "timeformatter.h"
 #include "unitymenumodelpaths.h"
+#include "easingcurve.h"
 
 static const char* BOTTOM_BAR_VISIBILITY_COMMUNICATOR_DBUS_PATH = "/BottomBarVisibilityCommunicator";
 static const char* DBUS_SERVICE = "com.canonical.Shell.BottomBarVisibilityCommunicator";
@@ -46,6 +47,7 @@
     qmlRegisterType<TimeFormatter>(uri, 0, 1, "TimeFormatter");
     qmlRegisterType<GDateTimeFormatter>(uri, 0, 1, "GDateTimeFormatter");
     qmlRegisterUncreatableType<BottomBarVisibilityCommunicatorShell>(uri, 0, 1, "BottomBarVisibilityCommunicatorShell", "Can't create BottomBarVisibilityCommunicatorShell");
+    qmlRegisterType<EasingCurve>(uri, 0, 1, "EasingCurve");
 }
 
 void UtilsPlugin::initializeEngine(QQmlEngine *engine, const char *uri)

=== modified file 'qml/CMakeLists.txt'
--- qml/CMakeLists.txt	2013-12-17 16:04:47 +0000
+++ qml/CMakeLists.txt	2014-04-01 18:39:46 +0000
@@ -13,7 +13,7 @@
     Hud
     Panel
     Launcher
-    SideStage
+    Stages
     Notifications
     )
 

=== removed file 'qml/Components/ApplicationManagerWrapper.qml'
--- qml/Components/ApplicationManagerWrapper.qml	2014-03-05 12:52:57 +0000
+++ qml/Components/ApplicationManagerWrapper.qml	1970-01-01 00:00:00 +0000
@@ -1,169 +0,0 @@
-/*
- * Copyright (C) 2013 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-import QtQuick 2.0
-import Unity.Application 0.1
-
-Item {
-    id: root
-
-    property alias mainStageApplications: mainStageModel
-    property alias sideStageApplications: sideStageModel
-    property variant mainStageFocusedApplication: null
-    property variant sideStageFocusedApplication: null
-    property bool sideStageEnabled: true
-    property bool keyboardVisible: ApplicationManager.keyboardVisible
-    property int keyboardHeight: ApplicationManager.keyboardHeight
-
-    property bool fake: ApplicationManager.fake ? ApplicationManager.fake : false
-
-    signal focusRequested(string appId)
-
-    ApplicationsModelStageFiltered {
-        id: mainStageModel
-        stage: ApplicationInfo.MainStage
-    }
-
-    ApplicationsModelStageFiltered {
-        id: sideStageModel
-        stage: ApplicationInfo.SideStage
-    }
-
-    Connections {
-        target: ApplicationManager
-        onFocusedApplicationIdChanged: {
-            var app = ApplicationManager.findApplication(ApplicationManager.focusedApplicationId)
-            if (!app) { //nothing at all focused, so clear all
-                mainStageFocusedApplication = null;
-                sideStageFocusedApplication = null;
-            } else {
-                if (app.stage == ApplicationInfo.MainStage) {
-                    mainStageFocusedApplication = app;
-                    // possible the side stage app being unfocused fired this signal, so check for it
-                    if (sideStageFocusedApplication && !sideStageFocusedApplication.focused)
-                        sideStageFocusedApplication = null;
-                } else {
-                    sideStageFocusedApplication = app;
-                    // possible the main stage app being unfocused fired this signal, so check for it
-                    if (mainStageFocusedApplication && !mainStageFocusedApplication.focused)
-                        mainStageFocusedApplication = null;
-                }
-            }
-        }
-
-        onFocusRequested: {
-            // if no side stage enabled, override application's stage parameter
-            var app = ApplicationManager.findApplication(appId);
-            if (app && app.stage === ApplicationInfo.SideStage && !sideStageEnabled) {
-                app.stage = ApplicationInfo.MainStage;
-            }
-
-            root.focusRequested(appId);
-        }
-    }
-
-    function activateApplication(desktopFile, argument) {
-        var appId;
-
-        // HACK: Applications identified sometimes with with appId, but mostly with desktopFile.
-        // TODO: convert entire shell to use appId only.
-        if (desktopFile.indexOf(".desktop") >= 0) {
-            appId = desktopFileToAppId(desktopFile);
-        } else {
-            appId = desktopFile;
-        }
-
-        var application = ApplicationManager.findApplication(appId);
-        if (application !== null) {
-            return application;
-        }
-
-        var execFlags = sideStageEnabled ? ApplicationManager.NoFlag : ApplicationManager.ForceMainStage;
-
-        if (argument) {
-            return ApplicationManager.startApplication(appId, execFlags, [argument]);
-        } else {
-            return ApplicationManager.startApplication(appId, execFlags);
-        }
-    }
-
-    function stopApplication(application) {
-        var appId;
-
-        // HACK: Applications identified sometimes with with appId, but mostly with desktopFile.
-        // TODO: convert entire shell to use appId only.
-        if (typeof application == "string") {
-            appId = application;
-        } else {
-            appId = desktopFileToAppId(application.desktopFile);
-        }
-
-        ApplicationManager.stopApplication(appId);
-    }
-
-    function focusApplication(application) {
-        if (application == null || application == undefined) {
-            return;
-        }
-
-        ApplicationManager.focusApplication(application.appId);
-    }
-
-    function unfocusCurrentApplication() {
-        ApplicationManager.unfocusCurrentApplication();
-    }
-
-    function moveRunningApplicationStackPosition(from, to, stage) {
-        if (from == to || from < 0 || to < 0) return;
-
-        if (stage == ApplicationInfo.SideStage) {
-            sideStageModel.move(from, to);
-        } else {
-            mainStageModel.move(from, to);
-        }
-    }
-
-    function getApplicationFromDesktopFile(desktopFile, stage) {
-        var appId;
-
-        // HACK: Applications identified sometimes with with appId, but mostly with desktopFile.
-        // TODO: convert entire shell to use appId only.
-        if (desktopFile.indexOf(".desktop") >= 0) {
-            appId = desktopFileToAppId(desktopFile);
-        } else {
-            appId = desktopFile;
-        }
-
-        for (var i = 0, len = ApplicationManager.count; i < len; i++ ) {
-            var app = ApplicationManager.get(i);
-
-            // if stage not specified, return whichever app running on either stage
-            if (app.appId == appId && (stage == undefined || app.stage == stage)) {
-                return app;
-            }
-        }
-    }
-
-    function desktopFileToAppId(desktopFile) {
-        var right = desktopFile.lastIndexOf(".desktop");
-        var left = desktopFile.lastIndexOf("/");
-        if (left == -1 || right == -1 || left == right) {
-            console.log("ApplicationManagerWrapper: unable to extract appId from '" + desktopFile + "'");
-            return "";
-        }
-        return desktopFile.substring(left+1, right);
-    }
-}

=== removed file 'qml/Components/ApplicationScreenshot.qml'
--- qml/Components/ApplicationScreenshot.qml	2014-03-05 12:52:57 +0000
+++ qml/Components/ApplicationScreenshot.qml	1970-01-01 00:00:00 +0000
@@ -1,61 +0,0 @@
-/*
- * Copyright (C) 2013 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-import QtQuick 2.0
-import Ubuntu.Components 0.1
-import Unity.Application 0.1
-
-Item {
-    id: applicationScreenshot
-
-    property var application: null
-    property bool withBackground: false
-    property bool ready: applicationImage.ready || withBackground
-
-    function setApplication(application) {
-        applicationScreenshot.application = application
-    }
-
-    function clearApplication() {
-        applicationScreenshot.withBackground = false;
-        applicationScreenshot.application = null
-        applicationScreenshot.scheduleUpdate();
-    }
-
-    function scheduleUpdate() {
-        applicationImage.scheduleUpdate()
-    }
-
-    function updateFromCache() {
-        applicationImage.updateFromCache()
-    }
-
-    Rectangle {
-        id: background
-        anchors.fill: parent
-        color: "white" // FIXME should use normal background color of Suru theme
-        visible: applicationScreenshot.withBackground
-    }
-
-    ApplicationImage {
-        id: applicationImage
-        objectName: "screenshot image"
-        width: applicationScreenshot.application ? parent.width : 0
-        height: applicationScreenshot.application ? parent.height : 0
-        visible: applicationScreenshot.application != null && ready
-        source: ApplicationManager.findApplication((application) ? application.appId : "")
-    }
-}

=== removed file 'qml/Components/ApplicationsModelStageFiltered.qml'
--- qml/Components/ApplicationsModelStageFiltered.qml	2013-09-09 10:20:21 +0000
+++ qml/Components/ApplicationsModelStageFiltered.qml	1970-01-01 00:00:00 +0000
@@ -1,49 +0,0 @@
-/*
- * Copyright (C) 2013 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-import QtQuick 2.0
-import Utils 0.1
-import Unity.Application 0.1
-
-SortFilterProxyModel {
-    id: root
-    property int stage
-
-    function get(index) {
-        return model.get(mapRowToSource(index));
-    }
-
-    function move(from, to) {
-        var realFrom = mapRowToSource(from);
-        if (realFrom == -1) {
-            console.log("ERROR; invalid from=" + from + " index in move operation");
-            return;
-        }
-        var realTo = mapRowToSource(to);
-        if (realTo == -1) {
-            // assuming wanting to move to end of list
-            realTo = model.count - 1;
-        }
-
-        if (realFrom == realTo) return;
-        model.move(realFrom, realTo);
-    }
-
-    model: ApplicationManager
-    dynamicSortFilter: true
-    filterRole: ApplicationManager.RoleStage
-    filterRegExp: RegExp(stage)
-}

=== modified file 'qml/Components/ResponsiveFlowView.qml'
--- qml/Components/ResponsiveFlowView.qml	2013-06-05 22:03:08 +0000
+++ qml/Components/ResponsiveFlowView.qml	2014-04-01 18:39:46 +0000
@@ -27,9 +27,8 @@
     property alias verticalSpacing: flow.verticalSpacing
     property alias horizontalSpacing: flow.horizontalSpacing
     property int referenceDelegateWidth
-    property alias firstModel: repeater1.model
-    property alias secondModel: repeater2.model
-    property alias delegate: repeater1.delegate
+    property alias model: repeater.model
+    property alias delegate: repeater.delegate
     readonly property int cellWidth: referenceDelegateWidth + horizontalSpacing
     readonly property int cellHeight: referenceDelegateWidth + verticalSpacing
     property alias move: flow.move
@@ -69,13 +68,7 @@
         property int margin: allocatableVerticalSpace - columns * horizontalSpacing
 
         Repeater {
-            id: repeater1
-            model: (root.model) ? root.model[0] : null
-        }
-        Repeater {
-            id: repeater2
-            model: (root.model) ? root.model[1] : null
-            delegate: repeater1.delegate
+            id: repeater
         }
     }
 }

=== modified file 'qml/Dash/Apps/RunningApplicationTile.qml'
--- qml/Dash/Apps/RunningApplicationTile.qml	2014-03-12 10:44:18 +0000
+++ qml/Dash/Apps/RunningApplicationTile.qml	2014-04-01 18:39:46 +0000
@@ -23,7 +23,6 @@
 AbstractButton {
     id: root
     property var application
-    property bool __sideStageEnabled: shell.applicationManager.sideStageEnabled
 
     signal requestedApplicationActivation(var application)
     signal requestedApplicationTermination(var application)
@@ -34,7 +33,7 @@
     // To avoid "binding loop" warning
     height: shapedApplicationImage.height + labelContainer.height
 
-    width: shapedApplicationImage.width
+    width: shapedApplicationImage.width <= units.gu(11) ? units.gu(11) : height
 
     property bool terminationModeEnabled: false
 
@@ -51,32 +50,23 @@
         }
     }
 
-    function updateScreenshotFromCache() {
-        applicationImage.updateFromCache();
-    }
-
-    // FIXME: should use UbuntuShape from SDK
-    UbuntuShapeForItem {
+    UbuntuShape {
         id: shapedApplicationImage
-        anchors {
-            top: parent.top
-            horizontalCenter: parent.horizontalCenter
+        anchors { top: parent.top; horizontalCenter: parent.horizontalCenter }
+
+        height: units.gu(17)
+        width: applicationImage.width
+        radius: "medium"
+
+        image: Image {
+            id: applicationImage
+            source: application.screenshot
+            // height : width = ss.height : ss.width
+            height: shapedApplicationImage.height
+            fillMode: Image.PreserveAspectCrop
+            width: Math.min(height, height * sourceSize.width / sourceSize.height)
         }
 
-        // FIXME: width and height should be defined according to the
-        // application window's aspect ratio.
-        width: (application.stage === ApplicationInfo.MainStage && __sideStageEnabled) ?
-            units.gu(22) : units.gu(11)
-        height: (__sideStageEnabled) ? units.gu(22) : units.gu(19)
-        radius: "medium"
-        image: applicationImage
-    }
-
-    ApplicationImage {
-        id: applicationImage
-        source: ApplicationManager.findApplication((application) ? application.appId : "")
-        width: shapedApplicationImage.width
-        height: shapedApplicationImage.height
     }
 
     UbuntuShape {

=== modified file 'qml/Dash/Apps/RunningApplicationsGrid.qml'
--- qml/Dash/Apps/RunningApplicationsGrid.qml	2014-02-26 11:04:54 +0000
+++ qml/Dash/Apps/RunningApplicationsGrid.qml	2014-04-01 18:39:46 +0000
@@ -18,6 +18,7 @@
 import "../../Components"
 
 import Ubuntu.Gestures 0.1
+import Unity.Application 0.1
 
 ResponsiveFlowView {
     id: root
@@ -25,13 +26,7 @@
 
     signal updateScreenshots
     property alias enableHeightBehavior: heightBehaviour.enabled
-    property bool enableHeightBehaviorOnNextCreation: firstModel.count + secondModel.count == 0
-
-    Connections {
-        target: shell
-        onDashShownChanged: if (shell.dashShown && shell.stageScreenshotsReady) updateScreenshots();
-        onStageScreenshotsReadyChanged: if (shell.dashShown && shell.stageScreenshotsReady) updateScreenshots();
-    }
+    property bool enableHeightBehaviorOnNextCreation: model.count === 0
 
     Behavior on height {
         id: heightBehaviour
@@ -40,13 +35,7 @@
     }
 
     Connections {
-        target: root.firstModel
-        onCountChanged: {
-            heightBehaviour.enabled = true;
-        }
-    }
-    Connections {
-        target: root.secondModel
+        target: root.model
         onCountChanged: {
             heightBehaviour.enabled = true;
         }
@@ -85,17 +74,13 @@
                     root.terminationModeEnabled = true
             }
             onRequestedApplicationTermination: {
-                shell.applicationManager.stopApplication(model.appId)
+                ApplicationManager.stopApplication(model.appId)
             }
             onRequestedApplicationActivation: {
-                shell.activateApplication(model.appId)
+                ApplicationManager.requestFocusApplication(model.appId)
             }
 
             terminationModeEnabled: root.terminationModeEnabled
-
-            Component.onCompleted: {
-                root.updateScreenshots.connect(updateScreenshotFromCache);
-            }
         }
     }
 

=== modified file 'qml/Dash/DashApps.qml'
--- qml/Dash/DashApps.qml	2014-03-25 15:49:30 +0000
+++ qml/Dash/DashApps.qml	2014-04-01 18:39:46 +0000
@@ -17,6 +17,7 @@
 import QtQuick 2.0
 import Ubuntu.Components 0.1
 import Utils 0.1
+import Unity.Application 0.1
 import "../Components"
 import "../Components/ListItems"
 import "Apps"
@@ -25,17 +26,15 @@
     id: scopeView
     objectName: "DashApps"
 
-    // FIXME: a way to aggregate these models would be ideal
-    property var mainStageApplicationsModel: shell.applicationManager.mainStageApplications
-    property var sideStageApplicationModel: shell.applicationManager.sideStageApplications
+    property var runningApps: ApplicationManager
 
     QtObject {
         id: countObject
-        property int count: scopeView.scope.searchQuery.length == 0 ? (mainStageApplicationsModel.count + sideStageApplicationModel.count) : 0
+        property int count: scopeView.scope.searchQuery.length == 0 ? scopeView.runningApps.count : 0
     }
 
     onScopeChanged: {
         scopeView.scope.categories.addSpecialCategory("running.apps.category", i18n.tr("Recent"), "", "{ \"template\": { \"category-layout\": \"running-apps\" } }", countObject);
-        enableHeightBehaviorOnNextCreation = (mainStageApplicationsModel.count + sideStageApplicationModel.count == 0)
+        enableHeightBehaviorOnNextCreation = scopeView.runningApps.count === 0
     }
 }

=== modified file 'qml/Dash/GenericScopeView.qml'
--- qml/Dash/GenericScopeView.qml	2014-03-17 11:44:05 +0000
+++ qml/Dash/GenericScopeView.qml	2014-04-01 18:39:46 +0000
@@ -18,6 +18,7 @@
 import Ubuntu.Components 0.1
 import Utils 0.1
 import Unity 0.2
+import Unity.Application 0.1
 import "../Components"
 import "../Components/ListItems" as ListItems
 
@@ -167,8 +168,7 @@
                     if (source.toString().indexOf("Apps/RunningApplicationsGrid.qml") != -1) {
                         // TODO: this is still a kludge :D Ideally add some kind of hook so that we
                         // can do this from DashApps.qml or think a better way that needs no special casing
-                        item.firstModel = Qt.binding(function() { return mainStageApplicationsModel })
-                        item.secondModel = Qt.binding(function() { return sideStageApplicationModel })
+                        item.model = Qt.binding(function() { return runningApps; })
                         item.canEnableTerminationMode = Qt.binding(function() { return scopeView.isCurrent })
                     } else {
                         item.model = Qt.binding(function() { return results })

=== modified file 'qml/Launcher/Launcher.qml'
--- qml/Launcher/Launcher.qml	2013-12-11 12:57:14 +0000
+++ qml/Launcher/Launcher.qml	2014-04-01 18:39:46 +0000
@@ -29,7 +29,8 @@
     property int dragAreaWidth: units.gu(1)
     property int minimizeDistance: units.gu(26)
     property real progress: dragArea.dragging && dragArea.touchX > panelWidth ?
-                                (width * (dragArea.touchX-panelWidth) / (width - panelWidth)) : 0
+                                (width * (dragArea.touchX-panelWidth) / (width - panelWidth)) :
+                                (dragArea.dragging ? 0.001 : 0)
 
     readonly property bool shown: panel.x > -panel.width
 

=== modified file 'qml/Panel/Panel.qml'
--- qml/Panel/Panel.qml	2014-01-14 15:35:57 +0000
+++ qml/Panel/Panel.qml	2014-04-01 18:39:46 +0000
@@ -62,7 +62,7 @@
         height: __panelMinusSeparatorLineHeight
         y: 0
 
-        Behavior on y { StandardAnimation {} }
+        Behavior on y { StandardAnimation { duration: UbuntuAnimation.FastDuration } }
     }
 
     PanelSeparatorLine {

=== modified file 'qml/Shell.qml'
--- qml/Shell.qml	2014-03-19 22:21:57 +0000
+++ qml/Shell.qml	2014-04-01 18:39:46 +0000
@@ -31,7 +31,6 @@
 import "Hud"
 import "Components"
 import "Bottombar"
-import "SideStage"
 import "Notifications"
 import Unity.Notifications 1.0 as NotificationBackend
 
@@ -49,20 +48,24 @@
     readonly property real panelHeight: panel.panelHeight
 
     property bool dashShown: dash.shown
-    property bool stageScreenshotsReady: {
-        if (sideStage.shown) {
-            if (mainStage.applications.count > 0) {
-                return mainStage.usingScreenshots && sideStage.usingScreenshots;
-            } else {
-                return sideStage.usingScreenshots;
+
+    property bool sideStageEnabled: shell.width >= units.gu(100)
+    readonly property string focusedApplicationId: ApplicationManager.focusedApplicationId
+
+    function activateApplication(appId) {
+        if (ApplicationManager.findApplication(appId)) {
+            ApplicationManager.requestFocusApplication(appId);
+            stages.show(true);
+            if (stages.locked && ApplicationManager.focusedApplicationId == appId) {
+                applicationsDisplayLoader.item.select(appId);
             }
         } else {
-            return mainStage.usingScreenshots;
+            var execFlags = shell.sideStageEnabled ? ApplicationManager.NoFlag : ApplicationManager.ForceMainStage;
+            ApplicationManager.startApplication(appId, execFlags);
+            stages.show(false);
         }
     }
 
-    property var applicationManager: ApplicationManagerWrapper {}
-
     Binding {
         target: LauncherModel
         property: "applicationManager"
@@ -71,49 +74,6 @@
 
     Component.onCompleted: {
         Theme.name = "Ubuntu.Components.Themes.SuruGradient"
-
-        applicationManager.sideStageEnabled = Qt.binding(function() { return sideStage.enabled })
-
-        // FIXME: if application focused before shell starts, shell draws on top of it only.
-        // We should detect already running applications on shell start and bring them to the front.
-        applicationManager.unfocusCurrentApplication();
-    }
-
-    readonly property bool applicationFocused: !!applicationManager.mainStageFocusedApplication
-                                               || !!applicationManager.sideStageFocusedApplication
-    // Used for autopilot testing.
-    readonly property string currentFocusedAppId: ApplicationManager.focusedApplicationId
-
-    readonly property bool fullscreenMode: {
-        if (greeter.shown || lockscreen.shown) {
-            return false;
-        } else if (mainStage.usingScreenshots) { // Window Manager animating so want to re-evaluate fullscreen mode
-            return mainStage.switchingFromFullscreenToFullscreen;
-        } else if (applicationManager.mainStageFocusedApplication) {
-            return applicationManager.mainStageFocusedApplication.fullscreen;
-        } else {
-            return false;
-        }
-    }
-
-    function activateApplication(appId, argument) {
-        if (applicationManager) {
-            // For newly started applications, as it takes them time to draw their first frame
-            // we add a delay before we hide the animation screenshots to compensate.
-            var addDelay = !applicationManager.getApplicationFromDesktopFile(appId);
-
-            var application;
-            application = applicationManager.activateApplication(appId, argument);
-            if (application == null) {
-                return;
-            }
-            if (application.stage == ApplicationInfo.MainStage || !sideStage.enabled) {
-                mainStage.activateApplication(appId, addDelay);
-            } else {
-                sideStage.activateApplication(appId, addDelay);
-            }
-            stages.show();
-        }
     }
 
     GSettings {
@@ -133,244 +93,219 @@
     Keys.onVolumeDownPressed: volumeControl.volumeDown()
 
     Item {
-        id: underlay
-        objectName: "underlay"
+        id: underlayClipper
         anchors.fill: parent
-
-        // Whether the underlay is fully covered by opaque UI elements.
-        property bool fullyCovered: panel.indicators.fullyOpened && shell.width <= panel.indicatorsMenuWidth
-
-        readonly property bool applicationRunning: ((mainStage.applications && mainStage.applications.count > 0)
-                                           || (sideStage.applications && sideStage.applications.count > 0))
-
-        // Whether the user should see the topmost application surface (if there's one at all).
-        readonly property bool applicationSurfaceShouldBeSeen: applicationRunning && !stages.fullyHidden
-                                           && !mainStage.usingScreenshots // but want sideStage animating over app surface
-
-
-
-        // NB! Application surfaces are stacked behing the shell one. So they can only be seen by the user
-        // through the translucent parts of the shell surface.
-        visible: !fullyCovered && !applicationSurfaceShouldBeSeen
-
-        Rectangle {
-            anchors.fill: parent
-            color: "black"
-            opacity: dash.disappearingAnimationProgress
-        }
-
-        Image {
-            anchors.fill: dash
-            source: shell.width > shell.height ? "Dash/graphics/paper_landscape.png" : "Dash/graphics/paper_portrait.png"
-            fillMode: Image.PreserveAspectCrop
-            horizontalAlignment: Image.AlignRight
-            verticalAlignment: Image.AlignTop
-        }
-
-        Dash {
-            id: dash
-            objectName: "dash"
-
-            available: !greeter.shown && !lockscreen.shown
-            hides: [stages, launcher, panel.indicators]
-            shown: disappearingAnimationProgress !== 1.0
-            enabled: disappearingAnimationProgress === 0.0 && edgeDemo.dashEnabled
-            // FIXME: unfocus all applications when going back to the dash
-            onEnabledChanged: {
-                if (enabled) {
-                    shell.applicationManager.unfocusCurrentApplication()
-                }
-            }
-
-            anchors {
-                fill: parent
-                topMargin: panel.panelHeight
-            }
-
-            contentScale: 1.0 - 0.2 * disappearingAnimationProgress
-            opacity: 1.0 - disappearingAnimationProgress
-            property real disappearingAnimationProgress: {
-                if (greeter.shown) {
-                    return greeter.showProgress;
+        anchors.rightMargin: stages.overlayWidth
+        clip: stages.overlayMode && !stages.painting
+
+        InputFilterArea {
+            anchors.fill: parent
+            blockInput: parent.clip
+        }
+
+        Item {
+            id: underlay
+            objectName: "underlay"
+            anchors.fill: parent
+            anchors.rightMargin: -parent.anchors.rightMargin
+
+            // Whether the underlay is fully covered by opaque UI elements.
+            property bool fullyCovered: panel.indicators.fullyOpened && shell.width <= panel.indicatorsMenuWidth
+
+            // Whether the user should see the topmost application surface (if there's one at all).
+            readonly property bool applicationSurfaceShouldBeSeen: stages.shown && !stages.painting && !stages.overlayMode
+
+            // NB! Application surfaces are stacked behind the shell one. So they can only be seen by the user
+            // through the translucent parts of the shell surface.
+            visible: !fullyCovered && !applicationSurfaceShouldBeSeen
+
+            CrossFadeImage {
+                id: backgroundImage
+                objectName: "backgroundImage"
+
+                anchors.fill: parent
+                source: shell.background
+                fillMode: Image.PreserveAspectCrop
+            }
+
+            Rectangle {
+                anchors.fill: parent
+                color: "black"
+                opacity: dash.disappearingAnimationProgress
+            }
+
+            Image {
+                anchors.fill: dash
+                source: shell.width > shell.height ? "Dash/graphics/paper_landscape.png" : "Dash/graphics/paper_portrait.png"
+                fillMode: Image.PreserveAspectCrop
+                horizontalAlignment: Image.AlignRight
+                verticalAlignment: Image.AlignTop
+            }
+
+            Dash {
+                id: dash
+                objectName: "dash"
+
+                available: !greeter.shown && !lockscreen.shown
+                hides: [stages, launcher, panel.indicators]
+                shown: disappearingAnimationProgress !== 1.0
+                enabled: disappearingAnimationProgress === 0.0 && edgeDemo.dashEnabled
+
+                anchors {
+                    fill: parent
+                    topMargin: panel.panelHeight
+                }
+
+                contentScale: 1.0 - 0.2 * disappearingAnimationProgress
+                opacity: 1.0 - disappearingAnimationProgress
+                property real disappearingAnimationProgress: {
+                    if (greeter.shown) {
+                        return greeter.showProgress;
+                    } else {
+                        if (stages.overlayMode) {
+                            return 0;
+                        }
+                        return stages.showProgress
+                    }
+                }
+
+                // FIXME: only necessary because stages.showProgress and
+                // greeterRevealer.animatedProgress are not animated
+                Behavior on disappearingAnimationProgress { SmoothedAnimation { velocity: 5 }}
+            }
+        }
+    }
+
+    EdgeDragArea {
+        id: stagesDragHandle
+        direction: Direction.Leftwards
+
+        anchors { top: parent.top; right: parent.right; bottom: parent.bottom }
+        width: shell.edgeSize
+
+        property real progress: stages.width
+
+        onTouchXChanged: {
+            if (status == DirectionalDragArea.Recognized) {
+                if (ApplicationManager.count == 0) {
+                    progress = Math.max(stages.width - stagesDragHandle.width + touchX, stages.width * .3)
                 } else {
-                    return stagesOuterContainer.showProgress;
+                    progress = stages.width - stagesDragHandle.width + touchX
                 }
             }
+        }
 
-            // FIXME: only necessary because stagesOuterContainer.showProgress and
-            // greeterRevealer.animatedProgress are not animated
-            Behavior on disappearingAnimationProgress { SmoothedAnimation { velocity: 5 }}
+        onDraggingChanged: {
+            if (!dragging) {
+                if (ApplicationManager.count > 0 && progress < stages.width - units.gu(10)) {
+                    stages.show(true)
+                }
+                stagesDragHandle.progress = stages.width;
+            }
         }
     }
 
     Item {
-        id: stagesOuterContainer
-
+        id: stages
+        objectName: "stages"
         width: parent.width
         height: parent.height
-        x: launcher.progress
-        Behavior on x {SmoothedAnimation{velocity: 600}}
-
-        property real showProgress:
-            MathUtils.clamp(1 - (x + stages.x) / shell.width, 0, 1)
-
-        Showable {
-            id: stages
-            objectName: "stages"
-
-            x: width
-
-            property bool fullyShown: shown && x == 0 && parent.x == 0
-            property bool fullyHidden: !shown && x == width
-            available: !greeter.shown
-            hides: [panel.indicators]
-            shown: false
-            opacity: 1.0
-            showAnimation: StandardAnimation { property: "x"; duration: 350; to: 0; easing.type: Easing.OutCubic }
-            hideAnimation: StandardAnimation { property: "x"; duration: 350; to: width; easing.type: Easing.OutCubic }
-
-            width: parent.width
-            height: parent.height
-
-            // close the stages when no focused application remains
-            Connections {
-                target: shell.applicationManager
-                onMainStageFocusedApplicationChanged: stages.closeIfNoApplications()
-                onSideStageFocusedApplicationChanged: stages.closeIfNoApplications()
-                ignoreUnknownSignals: true
-            }
-
-            function closeIfNoApplications() {
-                if (!shell.applicationManager.mainStageFocusedApplication
-                 && !shell.applicationManager.sideStageFocusedApplication
-                 && shell.applicationManager.mainStageApplications.count == 0
-                 && shell.applicationManager.sideStageApplications.count == 0) {
+
+        x: {
+            if (shown) {
+                if (overlayMode || locked) {
+                    return 0;
+                }
+                return launcher.progress
+            } else {
+                return stagesDragHandle.progress
+            }
+        }
+
+        Behavior on x { SmoothedAnimation { velocity: 600; duration: UbuntuAnimation.FastDuration } }
+
+        property bool shown: false
+
+        property real showProgress: overlayMode ? 0 : MathUtils.clamp(1 - x / shell.width, 0, 1)
+
+        property bool fullyShown: x == 0
+        property bool fullyHidden: x == width
+
+        property bool painting: applicationsDisplayLoader.item ? applicationsDisplayLoader.item.painting : false
+        property bool fullscreen: applicationsDisplayLoader.item ? applicationsDisplayLoader.item.fullscreen : false
+        property bool overlayMode: applicationsDisplayLoader.item ? applicationsDisplayLoader.item.overlayMode : false
+        property int overlayWidth: applicationsDisplayLoader.item ? applicationsDisplayLoader.item.overlayWidth : false
+        property bool locked: applicationsDisplayLoader.item ? applicationsDisplayLoader.item.locked : false
+
+        function show(focusApp) {
+            shown = true;
+            panel.indicators.hide();
+            if (!ApplicationManager.focusedApplicationId && ApplicationManager.count > 0 && focusApp) {
+                ApplicationManager.focusApplication(ApplicationManager.get(0).appId);
+            }
+        }
+
+        function hide() {
+            shown = false;
+            if (ApplicationManager.focusedApplicationId) {
+                ApplicationManager.unfocusCurrentApplication();
+            }
+        }
+
+        Connections {
+            target: ApplicationManager
+
+            onFocusRequested: {
+                stages.show(true);
+            }
+
+            onFocusedApplicationIdChanged: {
+                if (ApplicationManager.focusedApplicationId.length > 0) {
+                    stages.show(false);
+                } else {
+                    if (!stages.overlayMode) {
+                        stages.hide();
+                    }
+                }
+
+                // If any app is focused when greeter is open, it's due to a user action
+                // like a snap decision (say, an incoming call).
+                // TODO: these should be protected to only unlock for certain applications / certain usecases
+                // potentially only in connection with a notification.
+                greeter.hide()
+            }
+
+            onApplicationAdded: {
+                stages.show(false);
+            }
+
+            onApplicationRemoved: {
+                if (ApplicationManager.focusedApplicationId.length == 0) {
                     stages.hide();
                 }
             }
-
-            // show the stages when an application gets the focus
-            Connections {
-                target: shell.applicationManager
-                onMainStageFocusedApplicationChanged: {
-                    if (shell.applicationManager.mainStageFocusedApplication) {
-                        mainStage.show();
-                        stages.show();
-                    }
-                }
-                onSideStageFocusedApplicationChanged: {
-                    if (shell.applicationManager.sideStageFocusedApplication) {
-                        sideStage.show();
-                        stages.show();
-                    }
-                }
-                ignoreUnknownSignals: true
-            }
-
-            Stage {
-                id: mainStage
-
-                anchors.fill: parent
-                fullyShown: stages.fullyShown
-                fullyHidden: stages.fullyHidden
-                shouldUseScreenshots: !fullyShown
-                rightEdgeEnabled: !sideStage.enabled
-
-                applicationManager: shell.applicationManager
-                rightEdgeDraggingAreaWidth: shell.edgeSize
-                normalApplicationY: shell.panelHeight
-
-                shown: true
-                function show() {
-                    stages.show();
-                }
-                function hide() {
-                }
-
-                // FIXME: workaround the fact that focusing a main stage application
-                // raises its surface on top of all other surfaces including the ones
-                // that belong to side stage applications.
-                onFocusedApplicationChanged: {
-                    if (focusedApplication && sideStage.focusedApplication && sideStage.fullyShown) {
-                        shell.applicationManager.focusApplication(sideStage.focusedApplication);
-                    }
-                }
-            }
-
-            SideStage {
-                id: sideStage
-
-                applicationManager: shell.applicationManager
-                rightEdgeDraggingAreaWidth: shell.edgeSize
-                normalApplicationY: shell.panelHeight
-
-                onShownChanged: {
-                    if (!shown && mainStage.applications.count == 0) {
-                        stages.hide();
-                    }
-                }
-                // FIXME: when hiding the side stage, refocus the main stage
-                // application so that it goes in front of the side stage
-                // application and hides it
-                onFullyShownChanged: {
-                    if (!fullyShown && stages.fullyShown && sideStage.focusedApplication != null) {
-                        shell.applicationManager.focusApplication(mainStage.focusedApplication);
-                    }
-                }
-
-                enabled: shell.width >= units.gu(100)
-                visible: enabled
-                fullyShown: stages.fullyShown && shown
-                            && sideStage[sideStageRevealer.boundProperty] == sideStageRevealer.openedValue
-                shouldUseScreenshots: !fullyShown || mainStage.usingScreenshots || sideStageRevealer.pressed
-
-                available: !greeter.shown && !lockscreen.shown && enabled
-                hides: [launcher, panel.indicators]
-                shown: false
-                showAnimation: StandardAnimation { property: "x"; duration: 350; to: sideStageRevealer.openedValue; easing.type: Easing.OutQuint }
-                hideAnimation: StandardAnimation { property: "x"; duration: 350; to: sideStageRevealer.closedValue; easing.type: Easing.OutQuint }
-
-                width: units.gu(40)
-                height: stages.height
-                handleExpanded: sideStageRevealer.pressed
-            }
-
-            Revealer {
-                id: sideStageRevealer
-
-                enabled: mainStage.applications.count > 0 && sideStage.applications.count > 0
-                         && sideStage.available
-                direction: Qt.RightToLeft
-                openedValue: parent.width - sideStage.width
-                hintDisplacement: units.gu(3)
-                /* The size of the sidestage handle needs to be bigger than the
-                   typical size used for edge detection otherwise it is really
-                   hard to grab.
-                */
-                handleSize: sideStage.shown ? units.gu(4) : shell.edgeSize
-                closedValue: parent.width + sideStage.handleSizeCollapsed
-                target: sideStage
-                x: parent.width - width
-                width: sideStage.width + handleSize * 0.7
-                height: sideStage.height
-                orientation: Qt.Horizontal
-            }
-
-            DragHandle {
-                id: stagesDragHandle
-
-                anchors.top: parent.top
-                anchors.bottom: parent.bottom
-                anchors.right: parent.left
-
-                width: shell.edgeSize
-                direction: Direction.Leftwards
-                enabled: greeter.showProgress == 0 && edgeDemo.dashEnabled
-                property bool haveApps: mainStage.applications.count > 0 || sideStage.applications.count > 0
-
-                maxTotalDragDistance: haveApps ? parent.width : parent.width * 0.7
-                // Make autocompletion impossible when !haveApps
-                edgeDragEvaluator.minDragDistance: haveApps ? maxTotalDragDistance * 0.1 : Number.MAX_VALUE
+        }
+
+        Loader {
+            id: applicationsDisplayLoader
+            anchors.fill: parent
+
+            source: shell.sideStageEnabled ? "Stages/StageWithSideStage.qml" : "Stages/PhoneStage.qml"
+
+            Binding {
+                target: applicationsDisplayLoader.item
+                property: "moving"
+                value: !stages.fullyShown
+            }
+            Binding {
+                target: applicationsDisplayLoader.item
+                property: "shown"
+                value: stages.shown
+            }
+            Binding {
+                target: applicationsDisplayLoader.item
+                property: "dragAreaWidth"
+                value: shell.edgeSize
             }
         }
     }
@@ -447,26 +382,6 @@
 
         dragHandleWidth: shell.edgeSize
 
-        property var previousMainApp: null
-        property var previousSideApp: null
-
-        function removeApplicationFocus() {
-            greeter.previousMainApp = applicationManager.mainStageFocusedApplication;
-            greeter.previousSideApp = applicationManager.sideStageFocusedApplication;
-            applicationManager.unfocusCurrentApplication();
-        }
-
-        function restoreApplicationFocus() {
-            if (greeter.previousMainApp) {
-                applicationManager.focusApplication(greeter.previousMainApp);
-                greeter.previousMainApp = null;
-            }
-            if (greeter.previousSideApp) {
-                applicationManager.focusApplication(greeter.previousSideApp);
-                greeter.previousSideApp = null;
-            }
-        }
-
         onShownChanged: {
             if (shown) {
                 lockscreen.reset();
@@ -476,9 +391,6 @@
                     LightDM.Greeter.authenticate(LightDM.Users.data(0, LightDM.UserRoles.NameRole));
                 }
                 greeter.forceActiveFocus();
-                removeApplicationFocus();
-            } else {
-                restoreApplicationFocus();
             }
         }
 
@@ -496,33 +408,16 @@
             }
         }
 
-        Connections {
-            target: applicationManager
-            ignoreUnknownSignals: true
-            // If any app is focused when greeter is open, it's due to a user action
-            // like a snap decision (say, an incoming call).
-            // TODO: these should be protected to only unlock for certain applications / certain usecases
-            // potentially only in connection with a notification.
-            onMainStageFocusedApplicationChanged: {
-                if (greeter.shown && applicationManager.mainStageFocusedApplication) {
-                    greeter.previousMainApp = null // make way for new focused app
-                    greeter.previousSideApp = null
-                    greeter.hide()
-                }
-            }
-            onSideStageFocusedApplicationChanged: {
-                if (greeter.shown && applicationManager.sideStageFocusedApplication) {
-                    greeter.previousMainApp = null // make way for new focused app
-                    greeter.previousSideApp = null
-                    greeter.hide()
-                }
-            }
+        Binding {
+            target: ApplicationManager
+            property: "suspended"
+            value: greeter.shown && greeter.showProgress == 1
         }
     }
 
     InputFilterArea {
         anchors.fill: parent
-        blockInput: !applicationFocused || greeter.shown || lockscreen.shown || launcher.shown
+        blockInput: ApplicationManager.focusedApplicationId.length === 0 || greeter.shown || lockscreen.shown || launcher.shown
                     || panel.indicators.shown || hud.shown
     }
 
@@ -571,7 +466,9 @@
                 available: edgeDemo.panelEnabled
                 contentEnabled: edgeDemo.panelContentEnabled
             }
-            fullscreenMode: shell.fullscreenMode
+            property string focusedAppId: ApplicationManager.focusedApplicationId
+            property var focusedApplication: ApplicationManager.findApplication(focusedAppId)
+            fullscreenMode: focusedApplication && stages.fullscreen && !greeter.shown && !lockscreen.shown
             searchVisible: !greeter.shown && !lockscreen.shown && dash.shown && dash.searchable
 
             InputFilterArea {
@@ -597,9 +494,8 @@
             hideAnimation: StandardAnimation { property: "y"; duration: hud.showableAnimationDuration; to: hudRevealer.closedValue; easing.type: Easing.Linear }
 
             Connections {
-                target: shell.applicationManager
-                onMainStageFocusedApplicationChanged: hud.hide()
-                onSideStageFocusedApplicationChanged: hud.hide()
+                target: ApplicationManager
+                onFocusedApplicationIdChanged: hud.hide()
             }
         }
 
@@ -624,7 +520,7 @@
             theHud: hud
             anchors.fill: parent
             enabled: hud.available
-            applicationIsOnForeground: applicationFocused
+            applicationIsOnForeground: ApplicationManager.focusedApplicationId
         }
 
         InputFilterArea {
@@ -655,9 +551,11 @@
                 showHome()
             }
             onDash: {
-                if (stages.shown) {
-                    stages.hide();
-                    launcher.hide();
+                if (stages.shown && !stages.overlayMode) {
+                    if (!stages.locked) {
+                        stages.hide();
+                        launcher.hide();
+                    }
                 }
             }
             onDashSwipeChanged: if (dashSwipe && stages.shown) dash.setCurrentScope("clickscope", false, true)
@@ -750,14 +648,14 @@
         anchors.bottom: parent.bottom
         anchors.left: parent.left
         anchors.right: parent.right
-        height: shell.applicationManager ? shell.applicationManager.keyboardHeight : 0
+        height: ApplicationManager.keyboardVisible ? ApplicationManager.keyboardHeight : 0
 
-        enabled: shell.applicationManager && shell.applicationManager.keyboardVisible
+        enabled: ApplicationManager.keyboardVisible
     }
 
     Label {
         anchors.centerIn: parent
-        visible: applicationManager.fake
+        visible: ApplicationManager.fake ? ApplicationManager.fake : false
         text: "EARLY ALPHA\nNOT READY FOR USE"
         color: "lightgrey"
         opacity: 0.2

=== removed directory 'qml/SideStage'
=== removed file 'qml/SideStage/SideStage.qml'
--- qml/SideStage/SideStage.qml	2014-02-03 13:31:28 +0000
+++ qml/SideStage/SideStage.qml	1970-01-01 00:00:00 +0000
@@ -1,73 +0,0 @@
-/*
- * Copyright (C) 2013 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-import QtQuick 2.0
-import Unity.Application 0.1
-import Ubuntu.Components 0.1
-import "../Components"
-
-Stage {
-    id: stage
-
-    type: ApplicationInfo.SideStage
-    property real handleSizeCollapsed: units.gu(2.5)
-    property real handleSizeExpanded: units.gu(4)
-    property bool handleExpanded
-
-    /* FIXME: workaround so that when a main stage app goes fullscreen
-       the sidestage's top is not transparent. Proper fix would be to
-       resize the side stage app.
-    */
-    Rectangle {
-        id: backgroundBeneathPanel
-        anchors {
-            top: parent.top
-            left: parent.left
-            right: parent.right
-        }
-        height: shell.panelHeight
-        color: background.color
-        z: -1
-    }
-
-    Rectangle {
-        id: background
-        anchors.fill: parent
-        color: "#2c2924"
-        z: -1
-        visible: stage.usingScreenshots
-    }
-
-    SidestageHandle {
-        id: handle
-        objectName: "sideStageHandle"
-
-        anchors {
-            top: parent.top
-            bottom: parent.bottom
-            left: parent.left
-            leftMargin: -width
-        }
-        width: handleExpanded ? handleSizeExpanded : handleSizeCollapsed
-        Behavior on width { NumberAnimation { easing.type: Easing.OutQuart} }
-        z: -1
-    }
-
-    InputFilterArea {
-        anchors.fill: handle
-        blockInput: visible
-    }
-}

=== removed directory 'qml/SideStage/graphics'
=== added directory 'qml/Stages'
=== added file 'qml/Stages/PhoneStage.qml'
--- qml/Stages/PhoneStage.qml	1970-01-01 00:00:00 +0000
+++ qml/Stages/PhoneStage.qml	2014-04-01 18:39:46 +0000
@@ -0,0 +1,499 @@
+/*
+ * Copyright (C) 2014 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.0
+import Ubuntu.Components 0.1
+import Ubuntu.Gestures 0.1
+import Unity.Application 0.1
+import Utils 0.1
+import "../Components"
+
+Item {
+    id: root
+
+    // Controls to be set from outside
+    property bool shown: false
+    property bool moving: false
+    property int dragAreaWidth
+
+    // State information propagated to the outside
+    readonly property bool painting: mainScreenshotImage.visible || fadeInScreenshotImage.visible || appSplash.visible || spreadView.visible
+    property bool fullscreen: priv.focusedApplication ? priv.focusedApplication.fullscreen : false
+    property bool locked: spreadView.visible
+
+    // Not used for PhoneStage, only useful for SideStage and similar
+    property bool overlayMode: false
+    property int overlayWidth: 0
+
+    function select(appId) {
+        spreadView.snapTo(priv.indexOf(appId))
+    }
+
+    onMovingChanged: {
+        if (moving) {
+            if (ApplicationManager.focusedApplicationId) {
+                priv.requestNewScreenshot();
+            } else {
+                mainScreenshotImage.anchors.leftMargin = 0;
+                mainScreenshotImage.source = ApplicationManager.get(0).screenshot;
+                mainScreenshotImage.visible = true;
+            }
+        } else {
+            mainScreenshotImage.visible = false;
+        }
+    }
+
+    Connections {
+        target: ApplicationManager
+
+        onFocusRequested: {
+            if (spreadView.visible) {
+                spreadView.snapTo(priv.indexOf(appId));
+            } else {
+                priv.switchToApp(appId);
+            }
+        }
+
+        onFocusedApplicationIdChanged: {
+            if (ApplicationManager.focusedApplicationId.length > 0) {
+                if (priv.secondApplicationStarting || priv.applicationStarting) {
+                    appSplashTimer.restart();
+                } else {
+                    var application = priv.focusedApplication;
+                    root.fullscreen = application.fullscreen;
+                    mainScreenshotImage.source = application.screenshot;
+                }
+            } else {
+                spreadView.selectedIndex = -1;
+                spreadView.phase = 0;
+                spreadView.contentX = -spreadView.shift;
+            }
+        }
+
+        onApplicationAdded: {
+            if (!priv.focusedApplication) {
+                mainScreenshotImage.source = "";
+                mainScreenshotImage.visible = false;
+                priv.applicationStarting = true;
+            } else {
+                mainScreenshotImage.source = "";
+                priv.newFocusedAppId = appId;
+                priv.secondApplicationStarting = true;
+                priv.requestNewScreenshot();
+            }
+
+            if (spreadView.visible) {
+                spreadView.snapTo(0);
+            }
+        }
+
+        onApplicationRemoved: {
+            if (ApplicationManager.count == 0) {
+                mainScreenshotImage.source = ""
+                mainScreenshotImage.visible = false;
+            } else {
+                mainScreenshotImage.source = ApplicationManager.get(0).screenshot;
+            }
+        }
+    }
+
+    QtObject {
+        id: priv
+
+        property string focusedAppId: ApplicationManager.focusedApplicationId
+        property var focusedApplication: ApplicationManager.findApplication(focusedAppId)
+        property url focusedScreenshot: focusedApplication ? focusedApplication.screenshot : ""
+
+        property bool waitingForScreenshot: false
+
+        property bool applicationStarting: false
+        property bool secondApplicationStarting: false
+
+        property string newFocusedAppId
+
+        onFocusedScreenshotChanged: {
+            if (root.moving && priv.waitingForScreenshot) {
+                mainScreenshotImage.anchors.leftMargin = 0;
+                mainScreenshotImage.source = priv.focusedScreenshot
+                mainScreenshotImage.visible = true;
+            } else if (priv.secondApplicationStarting && priv.waitingForScreenshot) {
+                applicationSwitchingAnimation.start();
+            }
+            waitingForScreenshot = false;
+        }
+
+        function requestNewScreenshot() {
+            waitingForScreenshot = true;
+            ApplicationManager.updateScreenshot(focusedAppId);
+        }
+
+        function switchToApp(appId) {
+            if (priv.focusedAppId) {
+                priv.newFocusedAppId = appId;
+                root.fullscreen = ApplicationManager.findApplication(appId).fullscreen;
+                applicationSwitchingAnimation.start();
+            } else {
+                ApplicationManager.focusApplication(appId);
+            }
+        }
+
+        function indexOf(appId) {
+            for (var i = 0; i < ApplicationManager.count; i++) {
+                if (ApplicationManager.get(i).appId == appId) {
+                    return i;
+                }
+            }
+            return -1;
+        }
+
+    }
+
+    // FIXME: the signal connections seems to get lost.
+    Connections {
+        target: priv.focusedApplication
+        onScreenshotChanged: priv.focusedScreenshot = priv.focusedApplication.screenshot
+    }
+    Binding {
+        target: root
+        property: "fullscreen"
+        value: priv.focusedApplication ? priv.focusedApplication.fullscreen : false
+    }
+
+    Timer {
+        id: appSplashTimer
+        // FIXME: We really need to show something meaningful in the app surface instead of guessing
+        // when it might be ready
+        interval: 500
+        repeat: false
+        onTriggered: {
+            priv.applicationStarting = false;
+            priv.secondApplicationStarting = false;
+        }
+    }
+
+    SequentialAnimation {
+        id: applicationSwitchingAnimation
+        // setup
+        PropertyAction { target: mainScreenshotImage; property: "anchors.leftMargin"; value: 0 }
+        PropertyAction { target: mainScreenshotImage; property: "source"; value: priv.focusedScreenshot }
+        PropertyAction { targets: [mainScreenshotImage, fadeInScreenshotImage]; property: "visible"; value: true }
+        PropertyAction { target: fadeInScreenshotImage; property: "source"; value: {
+                var newFocusedApp = ApplicationManager.findApplication(priv.newFocusedAppId);
+                return newFocusedApp ? newFocusedApp.screenshot : "" }
+        }
+        PropertyAction { target: fadeInScreenshotImage; property: "opacity"; value: 0 }
+        PropertyAction { target: fadeInScreenshotImage; property: "scale"; value: .8 }
+
+
+        // The actual animation
+        ParallelAnimation {
+            UbuntuNumberAnimation { target: mainScreenshotImage; property: "anchors.leftMargin"; to: root.width; duration: UbuntuAnimation.SlowDuration }
+            UbuntuNumberAnimation { target: fadeInScreenshotImage; properties: "opacity,scale"; to: 1; duration: UbuntuAnimation.SlowDuration }
+        }
+
+        // restore stuff
+        ScriptAction { script: ApplicationManager.focusApplication(priv.newFocusedAppId); }
+        PropertyAction { target: fadeInScreenshotImage; property: "visible"; value: false }
+        PropertyAction { target: mainScreenshotImage; property: "visible"; value: false }
+    }
+
+    // FIXME: Drop this and make the imageprovider show a splashscreen instead
+    Rectangle {
+        id: appSplash2
+        anchors.fill: parent
+        color: "white"
+        visible: priv.secondApplicationStarting
+    }
+    Image {
+        id: fadeInScreenshotImage
+        anchors { left: parent.left; bottom: parent.bottom }
+        width: parent.width
+        scale: .7
+        visible: false
+    }
+
+    Rectangle {
+        id: appSplash
+        anchors.fill: parent
+        color: "white"
+        visible: priv.applicationStarting
+    }
+    Image {
+        id: mainScreenshotImage
+        anchors { left: parent.left; bottom: parent.bottom }
+        width: parent.width
+        visible: false
+    }
+
+    EdgeDragArea {
+        id: spreadDragArea
+        direction: Direction.Leftwards
+        enabled: ApplicationManager.count > 1 && spreadView.phase != 2
+
+        anchors { top: parent.top; right: parent.right; bottom: parent.bottom }
+        width: root.dragAreaWidth
+
+        // Sitting at the right edge of the screen, this EdgeDragArea directly controls the spreadView when
+        // attachedToView is true. When the finger movement passes positionMarker3 we detach it from the
+        // spreadView and make the spreadView snap to positionMarker4.
+        property bool attachedToView: true
+
+        property var gesturePoints: new Array()
+
+        onTouchXChanged: {
+            if (!dragging && !priv.waitingForScreenshot) {
+                // Initial touch. Let's update the screenshot and reset the spreadView to the starting position.
+                priv.requestNewScreenshot();
+                spreadView.phase = 0;
+                spreadView.contentX = -spreadView.shift;
+            }
+            if (dragging && attachedToView) {
+                // Gesture recognized. Let's move the spreadView with the finger
+                spreadView.contentX = -touchX - spreadView.shift;
+            }
+            if (attachedToView && spreadView.shiftedContentX >= spreadView.width * spreadView.positionMarker3) {
+                // We passed positionMarker3. Detach from spreadView and snap it.
+                attachedToView = false;
+                spreadView.snap();
+            }
+            gesturePoints.push(touchX);
+        }
+
+        onStatusChanged: {
+            if (status == DirectionalDragArea.Recognized) {
+                attachedToView = true;
+            }
+        }
+
+        onDraggingChanged: {
+            if (dragging) {
+                // Gesture recognized. Start recording this gesture
+                gesturePoints = [];
+                return;
+            }
+
+            // Ok. The user released. Find out if it was a one-way movement.
+            var oneWayFlick = true;
+            var smallestX = spreadDragArea.width;
+            for (var i = 0; i < gesturePoints.length; i++) {
+                if (gesturePoints[i] >= smallestX) {
+                    oneWayFlick = false;
+                    break;
+                }
+                smallestX = gesturePoints[i];
+            }
+            gesturePoints = [];
+
+            if (oneWayFlick && spreadView.shiftedContentX > units.gu(2) &&
+                    spreadView.shiftedContentX < spreadView.positionMarker1 * spreadView.width) {
+                // If it was a short one-way movement, do the Alt+Tab switch
+                // no matter if we didn't cross positionMarker1 yet.
+                spreadView.snapTo(1);
+            } else if (!dragging && attachedToView) {
+                // otherwise snap to the closest snap position we can find
+                // (might be back to start, to app 1 or to spread)
+                spreadView.snap();
+            }
+        }
+    }
+
+    Rectangle {
+        id: coverFlipBackground
+        anchors.fill: parent
+        color: "black"
+        visible: spreadView.visible
+    }
+
+    InputFilterArea {
+        anchors.fill: root
+        blockInput: spreadView.visible
+    }
+
+    Flickable {
+        id: spreadView
+        objectName: "spreadView"
+        anchors.fill: parent
+        visible: spreadDragArea.status == DirectionalDragArea.Recognized || phase > 1 || snapAnimation.running
+        contentWidth: spreadRow.width - shift
+        contentX: -shift
+
+        // The flickable needs to fill the screen in order to get touch events all over.
+        // However, we don't want to the user to be able to scroll back all the way. For
+        // that, the beginning of the gesture starts with a negative value for contentX
+        // so the flickable wants to pull it into the view already. "shift" tunes the
+        // distance where to "lock" the content.
+        property real shift: width / 2
+        property real shiftedContentX: contentX + shift
+
+        property int tileDistance: width / 4
+
+        // Those markers mark the various positions in the spread (ratio to screen width from right to left):
+        // 0 - 1: following finger, snap back to the beginning on release
+        property real positionMarker1: 0.3
+        // 1 - 2: curved snapping movement, snap to app 1 on release
+        property real positionMarker2: 0.45
+        // 2 - 3: movement follows finger, snaps back to app 1 on release
+        property real positionMarker3: 0.6
+        // passing 3, we detach movement from the finger and snap to 4
+        property real positionMarker4: 0.9
+
+        // This is where the first app snaps to when bringing it in from the right edge.
+        property real snapPosition: 0.75
+
+        // Phase of the animation:
+        // 0: Starting from right edge, a new app (index 1) comes in from the right
+        // 1: The app has reached the first snap position.
+        // 2: The list is dragged further and snaps into the spread view when entering phase 2
+        property int phase: 0
+
+        property int selectedIndex: -1
+
+        onShiftedContentXChanged: {
+            switch (phase) {
+            case 0:
+                if (shiftedContentX > width * positionMarker2) {
+                    phase = 1;
+                }
+                break;
+            case 1:
+                if (shiftedContentX < width * positionMarker2) {
+                    phase = 0;
+                } else if (shiftedContentX >= width * positionMarker4) {
+                    phase = 2;
+                }
+                break;
+            }
+        }
+
+        function snap() {
+            if (shiftedContentX < positionMarker1 * width) {
+                snapAnimation.targetContentX = -shift;
+                snapAnimation.start();
+            } else if (shiftedContentX < positionMarker2 * width) {
+                snapTo(1)
+            } else if (shiftedContentX < positionMarker3 * width) {
+                snapTo(1)
+            } else if (phase < 2){
+                // Add 1 pixel to make sure we definitely hit positionMarker4 even with rounding errors of the animation.
+                snapAnimation.targetContentX = width * positionMarker4 + 1 - shift;
+                snapAnimation.start();
+            }
+        }
+        function snapTo(index) {
+            spreadView.selectedIndex = index;
+            root.fullscreen = ApplicationManager.get(index).fullscreen;
+            snapAnimation.targetContentX = -shift;
+            snapAnimation.start();
+        }
+
+        SequentialAnimation {
+            id: snapAnimation
+            property int targetContentX: -spreadView.shift
+
+            UbuntuNumberAnimation {
+                target: spreadView
+                property: "contentX"
+                to: snapAnimation.targetContentX
+                duration: UbuntuAnimation.FastDuration
+            }
+
+            ScriptAction {
+                script: {
+                    if (spreadView.selectedIndex >= 0) {
+                        ApplicationManager.focusApplication(ApplicationManager.get(spreadView.selectedIndex).appId);
+                        spreadView.selectedIndex = -1
+                        spreadView.phase = 0;
+                        spreadView.contentX = -spreadView.shift;
+                    }
+                }
+            }
+        }
+
+        Item {
+            id: spreadRow
+            // This width controls how much the spread can be flicked left/right. It's composed of:
+            //  tileDistance * app count (with a minimum of 3 apps, in order to also allow moving 1 and 2 apps a bit)
+            //  + some constant value (still scales with the screen width) which looks good and somewhat fills the screen
+            width: Math.max(3, ApplicationManager.count) * spreadView.tileDistance + (spreadView.width - spreadView.tileDistance) * 1.5
+
+            x: spreadView.contentX
+
+            Repeater {
+                id: spreadRepeater
+                model: ApplicationManager
+                delegate: TransformedSpreadDelegate {
+                    id: appDelegate
+                    objectName: "appDelegate" + index
+                    startAngle: 45
+                    endAngle: 5
+                    startScale: 1.1
+                    endScale: 0.7
+                    startDistance: spreadView.tileDistance
+                    endDistance: units.gu(.5)
+                    width: spreadView.width
+                    height: spreadView.height
+                    selected: spreadView.selectedIndex == index
+                    otherSelected: spreadView.selectedIndex >= 0 && !selected
+
+                    z: index
+                    x: index == 0 ? 0 : spreadView.width + (index - 1) * spreadView.tileDistance
+
+                    // Each tile has a different progress value running from 0 to 1.
+                    // A progress value of 0 means the tile is at the right edge. 1 means the tile has reched the left edge.
+                    progress: {
+                        var tileProgress = (spreadView.shiftedContentX - index * spreadView.tileDistance) / spreadView.width;
+                        // Tile 1 needs to move directly from the beginning...
+                        if (index == 1 && spreadView.phase < 2) {
+                            tileProgress += spreadView.tileDistance / spreadView.width;
+                        }
+                        return tileProgress;
+                    }
+
+                    // This mostly is the same as progress, just adds the snapping to phase 1 for tiles 0 and 1
+                    animatedProgress: {
+                        if (spreadView.phase == 0 && index < 2) {
+                            if (progress < spreadView.positionMarker1) {
+                                return progress;
+                            } else if (progress < spreadView.positionMarker1 + snappingCurve.period){
+                                return spreadView.positionMarker1 + snappingCurve.value * 3;
+                            } else {
+                                return spreadView.positionMarker2;
+                            }
+                        }
+                        return progress;
+                    }
+
+                    EasingCurve {
+                        id: snappingCurve
+                        type: EasingCurve.OutQuad
+                        period: 0.05
+                        progress: appDelegate.progress - spreadView.positionMarker1
+                    }
+
+                    onClicked: {
+                        if (spreadView.phase == 2) {
+                            if (ApplicationManager.focusedApplicationId == ApplicationManager.get(index).appId) {
+                                spreadView.snapTo(index);
+                            } else {
+                                ApplicationManager.requestFocusApplication(ApplicationManager.get(index).appId);
+                            }
+                        }
+                    }
+                }
+            }
+        }
+    }
+}

=== renamed file 'qml/SideStage/SidestageHandle.qml' => 'qml/Stages/SidestageHandle.qml'
=== added file 'qml/Stages/SpreadDelegate.qml'
--- qml/Stages/SpreadDelegate.qml	1970-01-01 00:00:00 +0000
+++ qml/Stages/SpreadDelegate.qml	2014-04-01 18:39:46 +0000
@@ -0,0 +1,55 @@
+/*
+ * Copyright 2014 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Michael Zanetti <[e-mail]>
+*/
+
+import QtQuick 2.0
+
+Item {
+    id: root
+
+    signal clicked()
+
+    property real topMarginProgress
+
+    QtObject {
+        id: priv
+        property real heightDifference: root.height - appImage.implicitHeight
+    }
+
+    Image {
+        id: dropShadow
+        anchors.fill: appImage
+        anchors.margins: -units.gu(2)
+        source: "graphics/dropshadow.png"
+        opacity: .4
+    }
+    Image {
+        id: appImage
+        anchors {
+            left: parent.left;
+            bottom: parent.bottom;
+            top: parent.top;
+            topMargin: priv.heightDifference * Math.max(0, 1 - root.topMarginProgress)
+        }
+        source: model.screenshot
+        antialiasing: true
+    }
+    MouseArea {
+        anchors.fill: appImage
+        onClicked: root.clicked()
+    }
+}

=== added file 'qml/Stages/StageWithSideStage.qml'
--- qml/Stages/StageWithSideStage.qml	1970-01-01 00:00:00 +0000
+++ qml/Stages/StageWithSideStage.qml	2014-04-01 18:39:46 +0000
@@ -0,0 +1,407 @@
+/*
+ * Copyright (C) 2014 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.0
+import Ubuntu.Components 0.1
+import "../Components"
+import Unity.Application 0.1
+import Ubuntu.Gestures 0.1
+
+Item {
+    id: root
+    objectName: "stages"
+    anchors.fill: parent
+
+    // Controls to be set from outside
+    property bool shown: false
+    property bool moving: false
+    property int dragAreaWidth
+
+    // State information propagated to the outside
+    readonly property bool painting: mainStageImage.visible || sideStageImage.visible || sideStageSnapAnimation.running
+    property bool fullscreen: priv.focusedApplication ? priv.focusedApplication.fullscreen : false
+    property bool overlayMode: (sideStageImage.shown && priv.mainStageAppId.length == 0) || priv.overlayOverride
+                               || (priv.mainStageAppId.length == 0 && sideStageSnapAnimation.running)
+
+    readonly property int overlayWidth: priv.overlayOverride ? 0 : priv.sideStageWidth
+
+    onShownChanged: {
+        if (!shown) {
+            priv.mainStageAppId = "";
+        }
+    }
+
+    onMovingChanged: {
+        if (moving) {
+            if (!priv.mainStageAppId && !priv.sideStageAppId) {
+                // Pulling in from the right, make the last used (topmost) app visible
+                var application = ApplicationManager.get(0);
+                if (application.stage == ApplicationInfoInterface.SideStage) {
+                    sideStageImage.application = application;
+                    sideStageImage.x = root.width - sideStageImage.width
+                    sideStageImage.visible = true;
+                } else {
+                    mainStageImage.application = application;
+                    mainStageImage.visible = true;
+                }
+            } else {
+                priv.requestNewScreenshot(ApplicationInfoInterface.MainStage)
+                if (priv.focusedApplicationId == priv.sideStageAppId) {
+                    priv.requestNewScreenshot(ApplicationInfoInterface.SideStage)
+                }
+            }
+        } else {
+            mainStageImage.visible = false;
+            sideStageImage.visible = false;
+        }
+    }
+
+    QtObject {
+        id: priv
+
+        property int sideStageWidth: units.gu(40)
+
+
+        property string sideStageAppId
+        property string mainStageAppId
+
+
+        property var sideStageApp: ApplicationManager.findApplication(sideStageAppId)
+        property var mainStageApp: ApplicationManager.findApplication(mainStageAppId)
+
+        property string sideStageScreenshot: sideStageApp ? sideStageApp.screenshot : ""
+        property string mainStageScreenshot: mainStageApp ? mainStageApp.screenshot : ""
+
+        property string focusedApplicationId: ApplicationManager.focusedApplicationId
+        property var focusedApplication: ApplicationManager.findApplication(focusedApplicationId)
+        property url focusedScreenshot: focusedApplication ? focusedApplication.screenshot : ""
+
+        property bool waitingForMainScreenshot: false
+        property bool waitingForSideScreenshot: false
+        property bool waitingForScreenshots: waitingForMainScreenshot || waitingForSideScreenshot
+
+        property string startingAppId: ""
+
+        // Keep overlayMode even if there is no focused app (to allow pulling in the sidestage from the right)
+        property bool overlayOverride: false
+
+        onFocusedApplicationChanged: {
+            if (focusedApplication) {
+                if (focusedApplication.stage == ApplicationInfoInterface.MainStage) {
+                    mainStageAppId = focusedApplicationId;
+                    priv.overlayOverride = false;
+                    if (priv.startingAppId == focusedApplicationId && sideStageImage.shown) {
+                        // There was already a sidestage app on top. bring it back!
+                        ApplicationManager.focusApplication(priv.sideStageAppId)
+                        priv.startingAppId = "";
+                    }
+                } else if (focusedApplication.stage == ApplicationInfoInterface.SideStage) {
+                    sideStageAppId = focusedApplicationId;
+                    if (priv.startingAppId == focusedApplicationId && !sideStageImage.shown) {
+                        sideStageImage.snapToApp(focusedApplication);
+                        priv.startingAppId = "";
+                    }
+                }
+            } else if (root.overlayMode){
+                sideStageImage.snapTo(root.width)
+            }
+        }
+
+        onMainStageScreenshotChanged: {
+            waitingForMainScreenshot = false;
+        }
+
+        onSideStageScreenshotChanged: {
+            waitingForSideScreenshot = false;
+        }
+
+        onFocusedScreenshotChanged: {
+            waitingForSideScreenshot = false;
+        }
+
+        onWaitingForScreenshotsChanged: {
+            if (waitingForScreenshots) {
+                return;
+            }
+
+            if (root.moving) {
+                if (mainStageAppId) {
+                    mainStageImage.application = mainStageApp
+                    mainStageImage.visible = true;
+                }
+                if (sideStageAppId && focusedApplicationId == sideStageAppId) {
+                    sideStageImage.application = sideStageApp;
+                    sideStageImage.x = root.width - sideStageImage.width
+                    sideStageImage.visible = true;
+                }
+            }
+            if (sideStageHandleMouseArea.pressed) {
+                if (sideStageAppId) {
+                    sideStageImage.application = sideStageApp;
+                    sideStageImage.x = root.width - sideStageImage.width
+                    sideStageImage.visible = true;
+                }
+                if (mainStageAppId) {
+                    mainStageImage.application = mainStageApp
+                    mainStageImage.visible = true;
+                }
+            }
+        }
+
+        function requestNewScreenshot(stage) {
+            if (stage == ApplicationInfoInterface.MainStage && mainStageAppId) {
+                waitingForMainScreenshot = true;
+                ApplicationManager.updateScreenshot(mainStageAppId);
+            } else if (stage == ApplicationInfoInterface.SideStage && sideStageAppId) {
+                waitingForSideScreenshot = true;
+                ApplicationManager.updateScreenshot(sideStageAppId);
+            }
+        }
+
+    }
+    // FIXME: the signal connection seems to get lost with the fake application manager.
+    Connections {
+        target: priv.sideStageApp
+        onScreenshotChanged: priv.sideStageScreenshot = priv.sideStageApp.screenshot
+    }
+    Connections {
+        target: priv.mainStageApp
+        onScreenshotChanged: priv.mainStageScreenshot = priv.mainStageApp.screenshot
+    }
+
+    Connections {
+        target: ApplicationManager
+
+        onApplicationAdded: {
+            priv.startingAppId = appId;
+            splashScreenTimer.start();
+            var application = ApplicationManager.findApplication(appId)
+            if (application.stage == ApplicationInfoInterface.SideStage) {
+                sideStageSplash.visible = true;
+            } else if (application.stage == ApplicationInfoInterface.MainStage) {
+                mainStageSplash.visible = true;
+            }
+        }
+
+        onFocusRequested: {
+            var application = ApplicationManager.findApplication(appId)
+            if (application.stage == ApplicationInfoInterface.SideStage) {
+                if (!root.shown) {
+                    priv.mainStageAppId = "";
+                    mainStageImage.application = null
+                }
+                if (sideStageImage.shown) {
+                    sideStageImage.switchTo(application);
+                    if (priv.mainStageAppId) {
+                        mainStageImage.application = priv.mainStageApp;
+                        mainStageImage.visible = true;
+                    }
+                } else {
+                    sideStageImage.application = application;
+                    sideStageImage.snapToApp(application);
+                }
+            } else if (application.stage == ApplicationInfoInterface.MainStage) {
+                if (root.shown) {
+                    if (sideStageImage.shown) {
+                        sideStageImage.application = priv.sideStageApp;
+                        sideStageImage.visible = true;
+                    }
+                    priv.mainStageAppId = application.appId;
+                    mainStageImage.switchTo(application)
+                    ApplicationManager.focusApplication(appId)
+                    if (sideStageImage.shown) {
+                        // There was already a focused SS app. Bring it back
+                        ApplicationManager.focusApplication(priv.sideStageAppId)
+                    }
+                } else {
+                    if (sideStageImage.shown) {
+                        sideStageImage.visible = false;
+                        sideStageImage.x = root.width;
+                    }
+
+                    mainStageImage.application = application;
+                    ApplicationManager.focusApplication(appId)
+                }
+            }
+        }
+
+        onApplicationRemoved: {
+            if (priv.mainStageAppId == appId) {
+                priv.mainStageAppId = "";
+            }
+            if (priv.sideStageAppId == appId) {
+                priv.sideStageAppId = "";
+            }
+            if (priv.sideStageAppId.length == 0) {
+                sideStageImage.shown = false;
+                priv.overlayOverride = false;
+            }
+        }
+
+    }
+
+    Timer {
+        id: splashScreenTimer
+        // FIXME: apart from removing this completely in the future and make the app surface paint
+        // meaningful stuff, also check for colin's stuff to land so we can shape 1.4 secs away from here
+        // https://code.launchpad.net/~cjwatson/upstart-app-launch/libclick-manifest/+merge/210520
+        // https://code.launchpad.net/~cjwatson/upstart-app-launch/libclick-pkgdir/+merge/209909
+        interval: 1700
+        repeat: false
+        onTriggered: {
+            mainStageSplash.visible = false;
+            sideStageSplash.visible = false;
+        }
+    }
+
+    SwitchingApplicationImage {
+        id: mainStageImage
+        anchors.bottom: parent.bottom
+        width: parent.width
+        visible: false
+
+        onSwitched: {
+            sideStageImage.visible = false;
+        }
+    }
+
+    Rectangle {
+        id: mainStageSplash
+        anchors.fill: root
+        anchors.rightMargin: root.width - sideStageImage.x
+        color: "white"
+    }
+
+    SidestageHandle {
+        id: sideStageHandle
+        anchors { top: parent.top; right: sideStageImage.left; bottom: parent.bottom }
+        width: root.dragAreaWidth
+        visible: root.shown && priv.sideStageAppId && sideStageImage.x < root.width
+
+    }
+    MouseArea {
+        id: sideStageHandleMouseArea
+        anchors { top: parent.top; right: parent.right; bottom: parent.bottom; rightMargin: sideStageImage.shown ? sideStageImage.width : 0}
+        width: root.dragAreaWidth
+        visible: priv.sideStageAppId
+
+        property var dragPoints: new Array()
+
+        onPressed: {
+            priv.requestNewScreenshot(ApplicationInfoInterface.SideStage)
+            if (priv.mainStageAppId) {
+                priv.requestNewScreenshot(ApplicationInfoInterface.MainStage)
+            }
+        }
+
+        onMouseXChanged: {
+            dragPoints.push(mouseX)
+
+            var dragPoint = root.width + mouseX;
+            if (sideStageImage.shown) {
+                dragPoint -= sideStageImage.width
+            }
+            sideStageImage.x = Math.max(root.width - sideStageImage.width, dragPoint)
+        }
+
+        onReleased: {
+            var distance = 0;
+            var lastX = dragPoints[0];
+            var oneWayFlick = true;
+            for (var i = 0; i < dragPoints.length; ++i) {
+                if (dragPoints[i] < lastX) {
+                    oneWayFlick = false;
+                }
+                distance += dragPoints[i] - lastX;
+                lastX = dragPoints[i];
+            }
+            dragPoints = [];
+
+            if (oneWayFlick || distance > sideStageImage.width / 2) {
+                sideStageImage.snapTo(root.width)
+            } else {
+                sideStageImage.snapToApp(priv.sideStageApp)
+            }
+        }
+    }
+
+    SwitchingApplicationImage {
+        id: sideStageImage
+        width: priv.sideStageWidth
+        height: root.height
+        x: root.width
+        anchors.bottom: parent.bottom
+        visible: true
+        property bool shown: false
+
+        onSwitched: {
+            mainStageImage.visible = false;
+            ApplicationManager.focusApplication(application.appId)
+        }
+
+        function snapTo(targetX) {
+            sideStageSnapAnimation.targetX = targetX
+            sideStageImage.visible = true;
+            if (priv.mainStageAppId) {
+                mainStageImage.application = priv.mainStageApp
+                mainStageImage.visible = true;
+            }
+            sideStageSnapAnimation.start();
+        }
+
+        function snapToApp(application) {
+            sideStageImage.application = application
+            sideStageSnapAnimation.snapToId = application.appId;
+            snapTo(root.width - sideStageImage.width);
+        }
+
+        SequentialAnimation {
+            id: sideStageSnapAnimation
+            property int targetX: root.width
+            property string snapToId
+
+            UbuntuNumberAnimation { target: sideStageImage; property: "x"; to: sideStageSnapAnimation.targetX; duration: UbuntuAnimation.SlowDuration }
+            ScriptAction {
+                script: {
+                    if (sideStageSnapAnimation.targetX == root.width) {
+                        if (priv.mainStageAppId) {
+                            ApplicationManager.focusApplication(priv.mainStageAppId)
+                        } else {
+                            priv.overlayOverride = true;
+                            ApplicationManager.unfocusCurrentApplication();
+                        }
+                        sideStageImage.shown = false;
+                    }
+                    if (sideStageSnapAnimation.snapToId) {
+                        ApplicationManager.focusApplication(sideStageSnapAnimation.snapToId)
+                        sideStageSnapAnimation.snapToId = "";
+                        sideStageImage.shown = true;
+                        priv.overlayOverride = false;
+                    }
+                    sideStageImage.visible = false;
+                    mainStageImage.visible = false;
+                }
+            }
+        }
+    }
+
+    Rectangle {
+        id: sideStageSplash
+        anchors.fill: parent
+        anchors.leftMargin: sideStageImage.x
+        color: "white"
+    }
+}

=== added file 'qml/Stages/SwitchingApplicationImage.qml'
--- qml/Stages/SwitchingApplicationImage.qml	1970-01-01 00:00:00 +0000
+++ qml/Stages/SwitchingApplicationImage.qml	2014-04-01 18:39:46 +0000
@@ -0,0 +1,81 @@
+/*
+ * Copyright 2014 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Michael Zanetti <[e-mail]>
+*/
+
+import QtQuick 2.0
+import Ubuntu.Components 0.1
+
+Rectangle {
+    id: root
+    implicitHeight: image.implicitHeight
+    implicitWidth: image.implicitWidth
+    color: "black"
+
+    property var application
+
+    signal switched()
+
+    function switchTo(application) {
+        if (root.application == application) {
+            root.switched();
+            return;
+        }
+
+        priv.newApplication = application
+        root.visible = true;
+        switchToAnimation.start()
+    }
+
+    QtObject {
+        id: priv
+        property var newApplication
+    }
+
+    Image {
+        id: newImage
+        anchors.bottom: parent.bottom
+        width: root.width
+        source: priv.newApplication ? priv.newApplication.screenshot : ""
+    }
+
+    Image {
+        id: image
+        visible: true
+        source: root.application ? root.application.screenshot : ""
+        width: root.width
+        height: sourceSize.height
+        anchors.bottom: parent.bottom
+
+    }
+
+    SequentialAnimation {
+        id: switchToAnimation
+        ParallelAnimation {
+            UbuntuNumberAnimation { target: image; property: "x"; from: 0; to: root.width; duration: UbuntuAnimation.SlowDuration }
+            UbuntuNumberAnimation { target: newImage; property: "scale"; from: 0.7; to: 1; duration: UbuntuAnimation.SlowDuration }
+        }
+        ScriptAction {
+            script: {
+                image.x = 0
+                root.application = priv.newApplication
+                root.visible = false;
+                priv.newApplication = null
+                root.switched();
+            }
+        }
+    }
+}

=== added file 'qml/Stages/TransformedSpreadDelegate.qml'
--- qml/Stages/TransformedSpreadDelegate.qml	1970-01-01 00:00:00 +0000
+++ qml/Stages/TransformedSpreadDelegate.qml	2014-04-01 18:39:46 +0000
@@ -0,0 +1,327 @@
+/*
+ * Copyright 2014 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Michael Zanetti <[e-mail]>
+*/
+
+import QtQuick 2.0
+import Utils 0.1
+import Ubuntu.Components 0.1
+
+SpreadDelegate {
+    id: root
+
+    property bool selected: false
+    property bool otherSelected: false
+
+    // The progress animates the tiles. A value > 0 makes it appear from the right edge. At 1 it reaches the end position.
+    property real progress: 0
+    // This is required to snap tile 1 during phase 1 and 2.
+    property real animatedProgress: 0
+
+    property real startAngle: 0
+    property real endAngle: 0
+
+    property real startScale: 1
+    property real endScale: 1
+
+    // Specific to just one tile
+    property real tile1StartScale: startScale + .4
+    property real tile0SnapAngle: 10
+
+    property real startDistance: units.gu(5)
+    property real endDistance: units.gu(.5)
+
+    onSelectedChanged: {
+        if (selected) {
+            priv.snapshot();
+        }
+        priv.isSelected = selected;
+    }
+
+    onOtherSelectedChanged: {
+        if (otherSelected) {
+            priv.snapshot();
+        }
+        priv.otherSelected = otherSelected;
+    }
+
+    Connections {
+        target: spreadView
+        onPhaseChanged: {
+            if (spreadView.phase == 1) {
+                if (index == 0) {
+                    priv.phase2startTranslate = priv.easingAnimation(0, spreadView.positionMarker4, 0, -spreadView.width, spreadView.positionMarker4) + spreadView.width;
+                    priv.phase2startAngle = priv.easingAnimation(0, spreadView.positionMarker4, root.startAngle, root.endAngle, spreadView.positionMarker4);
+                    priv.phase2startScale = priv.easingAnimation(0, spreadView.positionMarker4, root.startScale, root.endScale, spreadView.positionMarker4);
+                    priv.phase2startTopMarginProgress = priv.easingAnimation(0, 1, 0, 1, spreadView.positionMarker4);
+                } else if (index == 1) {
+                    // find where the main easing for Tile 1 would be when reaching phase 2
+                    var phase2Progress = spreadView.positionMarker4 - spreadView.tileDistance / spreadView.width;
+                    priv.phase2startTranslate = priv.easingAnimation(0, phase2Progress, 0, -spreadView.width + root.endDistance, phase2Progress);
+                    priv.phase2startAngle = priv.easingAnimation(0, phase2Progress, root.startAngle, root.endAngle, phase2Progress);
+                    priv.phase2startScale = priv.easingAnimation(0, phase2Progress, root.startScale, root.endScale, phase2Progress);
+                    priv.phase2startTopMarginProgress = priv.easingAnimation(0, 1, 0, spreadView.positionMarker4, phase2Progress);
+                }
+            }
+        }
+    }
+
+    QtObject {
+        id: priv
+        property bool isSelected: false
+        property bool otherSelected: false
+        property real selectedProgress
+        property real selectedXTranslate
+        property real selectedAngle
+        property real selectedScale
+        property real selectedOpacity
+        property real selectedTopMarginProgress
+
+        // Those values are needed as target values for the end of phase 1.
+        // As they are static values, lets calculate them once when entering phase 1 instead of calculating them in each animation pass.
+        property real phase2startTranslate
+        property real phase2startAngle
+        property real phase2startScale
+        property real phase2startTopMarginProgress
+
+        function snapshot() {
+            selectedProgress = root.progress;
+            selectedXTranslate = xTranslate;
+            selectedAngle = angle;
+            selectedScale = scale;
+            selectedOpacity = opacity;
+            selectedTopMarginProgress = topMarginProgress;
+        }
+
+        // This calculates how much negative progress there can be if unwinding the spread completely
+        // the progress for each tile starts at 0 when it crosses the right edge, so the later a tile comes in,
+        // the bigger its negativeProgress can be.
+        property real negativeProgress: {
+            if (index == 1 && spreadView.phase < 2) {
+                return 0;
+            }
+            return -index * spreadView.tileDistance / spreadView.width;
+        }
+
+        function linearAnimation(startProgress, endProgress, startValue, endValue, progress) {
+            // progress : progressDiff = value : valueDiff => value = progress * valueDiff / progressDiff
+            return (progress - startProgress) * (endValue - startValue) / (endProgress - startProgress) + startValue;
+        }
+
+        function easingAnimation(startProgress, endProgress, startValue, endValue, progress) {
+            helperEasingCurve.progress = progress - startProgress;
+            helperEasingCurve.period = endProgress - startProgress;
+            return helperEasingCurve.value * (endValue - startValue) + startValue;
+        }
+
+        property real animatedEndDistance: linearAnimation(0, 2, root.endDistance, 0, root.progress)
+
+        // The following blocks handle the animation of the tile in the spread.
+        // At the beginning, each tile is attached at the right edge, outside the screen.
+        // The progress for each tile starts at 0 and it reaches its end position at a progress of 1.
+        // The first phases are handled special for the first 2 tiles. as we do the alt-tab and snapping in there
+        // Once we reached phase 3, the animation is the same for all tiles.
+        // When a tile is selected, the animation state is snapshotted, and the spreadView is unwound (progress animates
+        // back to negativeProgress). All tiles are kept in place and faded out to 0 opacity except
+        // the selected tile, which is animated from the snapshotted position to be fullscreen.
+
+        property real xTranslate: {
+            if (otherSelected) {
+                if (spreadView.phase < 2 && index == 0) {
+                    return linearAnimation(selectedProgress, negativeProgress,
+                                           selectedXTranslate, selectedXTranslate - spreadView.tileDistance, root.progress);
+                }
+
+                return selectedXTranslate;
+            }
+
+            switch (index) {
+            case 0:
+                if (spreadView.phase == 0) {
+                    return Math.min(0, linearAnimation(0, spreadView.positionMarker2,
+                                                       0, -spreadView.width * .25, root.animatedProgress));
+                } else if (spreadView.phase == 1){
+                    return linearAnimation(spreadView.positionMarker2, spreadView.positionMarker4,
+                                           -spreadView.width * .25, priv.phase2startTranslate, root.progress);
+                } else if (!priv.isSelected){ // phase 2
+                    // Apply the same animation as with the rest but add spreadView.width to align it with the others.
+                    return -easingCurve.value * spreadView.width + spreadView.width;
+                } else if (priv.isSelected) {
+                    return linearAnimation(selectedProgress, negativeProgress, selectedXTranslate, 0, root.progress);
+                }
+
+            case 1:
+                if (spreadView.phase == 0 && !priv.isSelected) {
+                    return linearAnimation(0, spreadView.positionMarker2,
+                                           0, -spreadView.width * spreadView.snapPosition, root.animatedProgress);
+                } else if (spreadView.phase == 1 && !priv.isSelected) {
+                    return linearAnimation(spreadView.positionMarker2, spreadView.positionMarker4,
+                                           -spreadView.width * spreadView.snapPosition, priv.phase2startTranslate,
+                                           root.progress);
+                }
+            }
+
+            if (priv.isSelected) {
+                // Distance to left edge
+                var targetTranslate = -spreadView.width - ((index - 1) * root.startDistance);
+                return linearAnimation(selectedProgress, negativeProgress,
+                                       selectedXTranslate, targetTranslate, root.progress);
+            }
+
+            // Fix it at the right edge...
+            var rightEdgeOffset =  -((index - 1) * root.startDistance);
+            // ...and use our easing to move them to the left. Stop a bit earlier for each tile
+            return -easingCurve.value * spreadView.width + (index * animatedEndDistance) + rightEdgeOffset;
+
+        }
+
+        property real angle: {
+            if (priv.otherSelected) {
+                return priv.selectedAngle;
+            }
+            if (priv.isSelected) {
+                return linearAnimation(selectedProgress, negativeProgress, selectedAngle, 0, root.progress);
+            }
+            switch (index) {
+            case 0:
+                if (spreadView.phase == 0) {
+                    return Math.max(0, linearAnimation(0, spreadView.positionMarker2,
+                                                       0, root.tile0SnapAngle, root.animatedProgress));
+                } else if (spreadView.phase == 1) {
+                    return linearAnimation(spreadView.positionMarker2, spreadView.positionMarker4,
+                                           root.tile0SnapAngle, phase2startAngle, root.progress);
+                }
+            case 1:
+                if (spreadView.phase == 0) {
+                    return linearAnimation(0, spreadView.positionMarker2, root.startAngle,
+                                           root.startAngle * (1-spreadView.snapPosition), root.animatedProgress);
+                } else if (spreadView.phase == 1) {
+                    return linearAnimation(spreadView.positionMarker2, spreadView.positionMarker4,
+                                           root.startAngle * (1-spreadView.snapPosition), priv.phase2startAngle,
+                                           root.progress);
+                }
+            }
+            return root.startAngle - easingCurve.value * (root.startAngle - root.endAngle);
+        }
+
+        property real scale: {
+            if (priv.otherSelected) {
+                return priv.selectedScale;
+            }
+            if (priv.isSelected) {
+                return linearAnimation(selectedProgress, negativeProgress, selectedScale, 1, root.progress);
+            }
+
+            switch (index) {
+            case 0:
+                if (spreadView.phase == 0) {
+                    return 1;
+                } else if (spreadView.phase == 1) {
+                    return linearAnimation(spreadView.positionMarker2, spreadView.positionMarker4,
+                                           1, phase2startScale, root.progress);
+                }
+            case 1:
+                if (spreadView.phase == 0) {
+                    var targetScale = tile1StartScale - ((tile1StartScale - 1) * spreadView.snapPosition);
+                    return linearAnimation(0, spreadView.positionMarker2,
+                                           root.tile1StartScale, targetScale, root.animatedProgress);
+                } else if (spreadView.phase == 1) {
+                    var startScale = tile1StartScale - ((tile1StartScale - 1) * spreadView.snapPosition);
+                    return linearAnimation(spreadView.positionMarker2, spreadView.positionMarker4,
+                                           startScale, priv.phase2startScale, root.progress);
+                }
+            }
+            return root.startScale - easingCurve.value * (root.startScale - root.endScale);
+        }
+
+        property real opacity: {
+            if (priv.otherSelected) {
+                return linearAnimation (selectedProgress, Math.max(0, selectedProgress - .5),
+                                        selectedOpacity, 0, root.progress);
+            }
+            if (index == 0) {
+                switch (spreadView.phase) {
+                case 0:
+                    return linearAnimation(0, spreadView.positionMarker2, 1, .3, root.animatedProgress);
+                case 1:
+                    return linearAnimation(spreadView.positionMarker2, spreadView.positionMarker4,
+                                           .3, 1, root.animatedProgress);
+                }
+            }
+
+            return 1;
+        }
+
+        property real topMarginProgress: {
+            if (priv.isSelected) {
+                return linearAnimation(selectedProgress, negativeProgress, selectedTopMarginProgress, 0, root.progress);
+            }
+
+            switch (index) {
+            case 0:
+                if (spreadView.phase == 0) {
+                    return 0;
+                } else if (spreadView.phase == 1) {
+                    return linearAnimation(spreadView.positionMarker2, spreadView.positionMarker4,
+                                           0, priv.phase2startTopMarginProgress, root.progress);
+                }
+                break;
+            case 1:
+                if (spreadView.phase == 0) {
+                    return 0;
+                } else if (spreadView.phase == 1) {
+                    return linearAnimation(spreadView.positionMarker2, spreadView.positionMarker4,
+                                           0, priv.phase2startTopMarginProgress, root.progress);
+                }
+            }
+
+            return easingCurve.value;
+        }
+    }
+
+    transform: [
+        Rotation {
+            origin { x: 0; y: spreadView.height / 2 }
+            axis { x: 0; y: 1; z: 0 }
+            angle: priv.angle
+        },
+        Scale {
+            origin { x: 0; y: spreadView.height / 2 }
+            xScale: priv.scale
+            yScale: xScale
+        },
+        Translate {
+            x: priv.xTranslate
+        }
+    ]
+    opacity: priv.opacity
+    topMarginProgress: priv.topMarginProgress
+
+    EasingCurve {
+        id: easingCurve
+        type: EasingCurve.OutSine
+        period: 1 - spreadView.positionMarker2
+        progress: root.animatedProgress
+    }
+
+    // This is used as a calculation helper to figure values for progress other than the current one
+    // Do not bind anything to this...
+    EasingCurve {
+        id: helperEasingCurve
+        type: easingCurve.type
+        period: easingCurve.period
+    }
+}

=== added directory 'qml/Stages/graphics'
=== added file 'qml/Stages/graphics/dropshadow.png'
Binary files qml/Stages/graphics/dropshadow.png	1970-01-01 00:00:00 +0000 and qml/Stages/graphics/dropshadow.png	2014-04-01 18:39:46 +0000 differ
=== renamed file 'qml/SideStage/graphics/[e-mail]' => 'qml/Stages/graphics/[e-mail]'
=== renamed file 'qml/SideStage/graphics/[e-mail]' => 'qml/Stages/graphics/[e-mail]'
=== modified file 'tests/autopilot/unity8/shell/emulators/dash.py'
--- tests/autopilot/unity8/shell/emulators/dash.py	2014-03-17 10:42:57 +0000
+++ tests/autopilot/unity8/shell/emulators/dash.py	2014-04-01 18:39:46 +0000
@@ -80,10 +80,7 @@
                 'No scope found with id {0}'.format(scope_id))
 
     def _get_scope_from_loader(self, loader):
-        if loader.scopeId == 'clickscope':
-            return loader.select_single(DashApps)
-        else:
-            return loader.select_single(GenericScopeView)
+        return loader.get_children()[0]
 
     def _open_scope_scrolling(self, scope_loader):
         scroll = self._get_scroll_direction(scope_loader)

=== modified file 'tests/autopilot/unity8/shell/emulators/main_window.py'
--- tests/autopilot/unity8/shell/emulators/main_window.py	2014-03-02 04:44:30 +0000
+++ tests/autopilot/unity8/shell/emulators/main_window.py	2014-04-01 18:39:46 +0000
@@ -112,4 +112,4 @@
 
     def get_current_focused_app_id(self):
         """Return the id of the focused application."""
-        return self.select_single('Shell').currentFocusedAppId
+        return self.select_single('Shell').focusedApplicationId

=== modified file 'tests/mocks/Unity/Application/ApplicationInfo.cpp'
--- tests/mocks/Unity/Application/ApplicationInfo.cpp	2013-09-05 12:21:35 +0000
+++ tests/mocks/Unity/Application/ApplicationInfo.cpp	2014-04-01 18:39:46 +0000
@@ -20,6 +20,7 @@
 #include <QQuickItem>
 #include <QQuickView>
 #include <QQmlComponent>
+#include <QTimer>
 
 ApplicationInfo::ApplicationInfo(const QString &appId, QObject *parent)
     : ApplicationInfoInterface(appId, parent)
@@ -32,6 +33,7 @@
     ,m_windowComponent(0)
     ,m_parentItem(0)
 {
+    QTimer::singleShot(300, this, SLOT(setRunning()));
 }
 
 ApplicationInfo::ApplicationInfo(QObject *parent)
@@ -44,6 +46,7 @@
      ,m_windowComponent(0)
      ,m_parentItem(0)
 {
+    QTimer::singleShot(300, this, SLOT(setRunning()));
 }
 
 void ApplicationInfo::onWindowComponentStatusChanged(QQmlComponent::Status status)
@@ -52,6 +55,12 @@
         doCreateWindowItem();
 }
 
+void ApplicationInfo::setRunning()
+{
+    m_state = Running;
+    Q_EMIT stateChanged();
+}
+
 void ApplicationInfo::createWindowComponent()
 {
     // The assumptions I make here really should hold.

=== modified file 'tests/mocks/Unity/Application/ApplicationInfo.h'
--- tests/mocks/Unity/Application/ApplicationInfo.h	2013-10-11 11:37:04 +0000
+++ tests/mocks/Unity/Application/ApplicationInfo.h	2014-04-01 18:39:46 +0000
@@ -74,6 +74,7 @@
     IMPLEMENT_PROPERTY(fullscreen, Fullscreen, bool)
     IMPLEMENT_PROPERTY(imageQml, ImageQml, QString)
     IMPLEMENT_PROPERTY(windowQml, WindowQml, QString)
+    IMPLEMENT_PROPERTY(screenshot, Screenshot, QUrl)
 
     #undef IMPLEMENT_PROPERTY
 
@@ -83,6 +84,7 @@
 
  private Q_SLOTS:
     void onWindowComponentStatusChanged(QQmlComponent::Status status);
+    void setRunning();
 
  private:
     void createWindowItem();

=== modified file 'tests/mocks/Unity/Application/ApplicationManager.cpp'
--- tests/mocks/Unity/Application/ApplicationManager.cpp	2013-12-17 16:04:47 +0000
+++ tests/mocks/Unity/Application/ApplicationManager.cpp	2014-04-01 18:39:46 +0000
@@ -24,13 +24,17 @@
 #include <QQuickItem>
 #include <QQuickView>
 #include <QQmlComponent>
+#include <QTimer>
+#include <QDateTime>
 
 ApplicationManager::ApplicationManager(QObject *parent)
     : ApplicationManagerInterface(parent)
+    , m_suspended(false)
     , m_mainStageComponent(0)
     , m_mainStage(0)
     , m_sideStageComponent(0)
     , m_sideStage(0)
+    , m_rightMargin(0)
 {
     buildListOfAvailableApplications();
 }
@@ -63,6 +67,8 @@
         return app->state();
     case RoleFocused:
         return app->focused();
+    case RoleScreenshot:
+        return app->screenshot();
     default:
         return QVariant();
     }
@@ -84,13 +90,16 @@
 }
 
 void ApplicationManager::add(ApplicationInfo *application) {
-    if (!application)
+    if (!application) {
         return;
+    }
 
     beginInsertRows(QModelIndex(), m_runningApplications.size(), m_runningApplications.size());
     m_runningApplications.append(application);
     endInsertRows();
+    Q_EMIT applicationAdded(application->appId());
     Q_EMIT countChanged();
+    Q_EMIT focusRequested(application->appId());
 }
 
 void ApplicationManager::remove(ApplicationInfo *application) {
@@ -99,6 +108,7 @@
         beginRemoveRows(QModelIndex(), i, i);
         m_runningApplications.removeAt(i);
         endRemoveRows();
+        Q_EMIT applicationRemoved(application->appId());
         Q_EMIT countChanged();
     }
 }
@@ -171,6 +181,8 @@
     }
     add(application);
 
+    QMetaObject::invokeMethod(this, "focusApplication", Qt::QueuedConnection, Q_ARG(QString, appId));
+
     return application;
 }
 
@@ -180,8 +192,32 @@
     if (application == nullptr)
         return false;
 
+    if (application->appId() == focusedApplicationId()) {
+        unfocusCurrentApplication();
+    }
     remove(application);
-    Q_EMIT focusedApplicationIdChanged();
+    return true;
+}
+
+bool ApplicationManager::updateScreenshot(const QString &appId)
+{
+    int idx = -1;
+    ApplicationInfo *application = nullptr;
+    for (int i = 0; i < m_availableApplications.count(); ++i) {
+        application = m_availableApplications.at(i);
+        if (application->appId() == appId) {
+            idx = i;
+            break;
+        }
+    }
+
+    if (idx == -1) {
+        return false;
+    }
+
+    application->setScreenshot(QString("image://application/%1/%2").arg(appId).arg(QDateTime::currentMSecsSinceEpoch()));
+    QModelIndex appIndex = index(idx);
+    Q_EMIT dataChanged(appIndex, appIndex, QVector<int>() << RoleScreenshot);
     return true;
 }
 
@@ -194,6 +230,25 @@
     return QString();
 }
 
+bool ApplicationManager::suspended() const
+{
+    return m_suspended;
+}
+
+void ApplicationManager::setSuspended(bool suspended)
+{
+    ApplicationInfo *focusedApp = findApplication(focusedApplicationId());
+    if (focusedApp) {
+        if (suspended) {
+            focusedApp->setState(ApplicationInfo::Suspended);
+        } else {
+            focusedApp->setState(ApplicationInfo::Running);
+        }
+    }
+    m_suspended = suspended;
+    Q_EMIT suspendedChanged();
+}
+
 bool ApplicationManager::focusApplication(const QString &appId)
 {
     ApplicationInfo *application = findApplication(appId);
@@ -242,6 +297,15 @@
     return true;
 }
 
+bool ApplicationManager::requestFocusApplication(const QString &appId)
+{
+    if (appId != focusedApplicationId()) {
+        QMetaObject::invokeMethod(this, "focusRequested", Qt::QueuedConnection, Q_ARG(QString, appId));
+        return true;
+    }
+    return false;
+}
+
 void ApplicationManager::unfocusCurrentApplication()
 {
     for (ApplicationInfo *app : m_runningApplications) {
@@ -270,10 +334,12 @@
         "Image {\n"
         "   anchors.fill: parent\n"
         "   anchors.topMargin: %1\n"
-        "   source: \"file://%2/Dash/graphics/phone/screenshots/%3.png\"\n"
+        "   anchors.rightMargin: %2\n"
+        "   source: \"file://%3/Dash/graphics/phone/screenshots/%4.png\"\n"
         "   smooth: true\n"
         "   fillMode: Image.PreserveAspectCrop\n"
         "}").arg(topMargin)
+            .arg(m_rightMargin)
             .arg(qmlDirectory())
             .arg(application->icon().toString());
     application->setWindowQml(windowQml);
@@ -299,6 +365,7 @@
     application->setName("Phone");
     application->setIcon(QUrl("phone"));
     application->setStage(ApplicationInfo::SideStage);
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     generateQmlStrings(application);
     m_availableApplications.append(application);
 
@@ -307,6 +374,7 @@
     application->setName("Camera");
     application->setIcon(QUrl("camera"));
     application->setFullscreen(true);
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     generateQmlStrings(application);
     m_availableApplications.append(application);
 
@@ -314,6 +382,7 @@
     application->setAppId("gallery-app");
     application->setName("Gallery");
     application->setIcon(QUrl("gallery"));
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     generateQmlStrings(application);
     m_availableApplications.append(application);
 
@@ -322,13 +391,16 @@
     application->setName("Facebook");
     application->setIcon(QUrl("facebook"));
     application->setStage(ApplicationInfo::SideStage);
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     generateQmlStrings(application);
     m_availableApplications.append(application);
 
     application = new ApplicationInfo(this);
     application->setAppId("webbrowser-app");
+    application->setFullscreen(true);
     application->setName("Browser");
     application->setIcon(QUrl("browser"));
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     generateQmlStrings(application);
     m_availableApplications.append(application);
 
@@ -337,6 +409,7 @@
     application->setName("Twitter");
     application->setIcon(QUrl("twitter"));
     application->setStage(ApplicationInfo::SideStage);
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     generateQmlStrings(application);
     m_availableApplications.append(application);
 
@@ -344,6 +417,7 @@
     application->setAppId("gmail-webapp");
     application->setName("GMail");
     application->setIcon(QUrl("gmail"));
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     m_availableApplications.append(application);
 
     application = new ApplicationInfo(this);
@@ -351,6 +425,7 @@
     application->setName("Weather");
     application->setIcon(QUrl("weather"));
     application->setStage(ApplicationInfo::SideStage);
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     generateQmlStrings(application);
     m_availableApplications.append(application);
 
@@ -359,6 +434,7 @@
     application->setName("Notepad");
     application->setIcon(QUrl("notepad"));
     application->setStage(ApplicationInfo::SideStage);
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     m_availableApplications.append(application);
 
     application = new ApplicationInfo(this);
@@ -366,6 +442,7 @@
     application->setName("Calendar");
     application->setIcon(QUrl("calendar"));
     application->setStage(ApplicationInfo::SideStage);
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     m_availableApplications.append(application);
 
     application = new ApplicationInfo(this);
@@ -373,18 +450,21 @@
     application->setName("Media Player");
     application->setIcon(QUrl("mediaplayer-app"));
     application->setFullscreen(true);
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     m_availableApplications.append(application);
 
     application = new ApplicationInfo(this);
     application->setAppId("evernote");
     application->setName("Evernote");
     application->setIcon(QUrl("evernote"));
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     m_availableApplications.append(application);
 
     application = new ApplicationInfo(this);
     application->setAppId("map");
     application->setName("Map");
     application->setIcon(QUrl("map"));
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     generateQmlStrings(application);
     m_availableApplications.append(application);
 
@@ -392,24 +472,28 @@
     application->setAppId("pinterest");
     application->setName("Pinterest");
     application->setIcon(QUrl("pinterest"));
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     m_availableApplications.append(application);
 
     application = new ApplicationInfo(this);
     application->setAppId("soundcloud");
     application->setName("SoundCloud");
     application->setIcon(QUrl("soundcloud"));
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     m_availableApplications.append(application);
 
     application = new ApplicationInfo(this);
     application->setAppId("wikipedia");
     application->setName("Wikipedia");
     application->setIcon(QUrl("wikipedia"));
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     m_availableApplications.append(application);
 
     application = new ApplicationInfo(this);
     application->setAppId("youtube");
     application->setName("YouTube");
     application->setIcon(QUrl("youtube"));
+    application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
     m_availableApplications.append(application);
 }
 
@@ -484,3 +568,25 @@
     m_sideStage->setParentItem(shell);
     m_sideStage->setFlag(QQuickItem::ItemHasContents, false);
 }
+
+QStringList ApplicationManager::availableApplications()
+{
+    QStringList appIds;
+    Q_FOREACH(ApplicationInfo *app, m_availableApplications) {
+        appIds << app->appId();
+    }
+    return appIds;
+}
+
+int ApplicationManager::rightMargin() const
+{
+    return m_rightMargin;
+}
+
+void ApplicationManager::setRightMargin(int rightMargin)
+{
+    m_rightMargin = rightMargin;
+    Q_FOREACH(ApplicationInfo *app, m_availableApplications) {
+        generateQmlStrings(app);
+    }
+}

=== modified file 'tests/mocks/Unity/Application/ApplicationManager.h'
--- tests/mocks/Unity/Application/ApplicationManager.h	2013-10-11 11:37:04 +0000
+++ tests/mocks/Unity/Application/ApplicationManager.h	2014-04-01 18:39:46 +0000
@@ -45,6 +45,10 @@
 
     Q_PROPERTY(bool fake READ fake CONSTANT)
 
+    // Only for testing
+    // This can be used to place some controls to right, like make tryPhoneStage for example
+    Q_PROPERTY(int rightMargin READ rightMargin WRITE setRightMargin)
+
  public:
     ApplicationManager(QObject *parent = NULL);
     virtual ~ApplicationManager();
@@ -87,13 +91,22 @@
     Q_INVOKABLE void move(int from, int to);
 
     // Application control methods
+    Q_INVOKABLE bool requestFocusApplication(const QString &appId) override;
     Q_INVOKABLE bool focusApplication(const QString &appId) override;
     Q_INVOKABLE void unfocusCurrentApplication() override;
     Q_INVOKABLE ApplicationInfo *startApplication(const QString &appId, const QStringList &arguments = QStringList()) override;
     Q_INVOKABLE ApplicationInfo *startApplication(const QString &appId, ExecFlags flags, const QStringList &arguments = QStringList());
     Q_INVOKABLE bool stopApplication(const QString &appId) override;
+    Q_INVOKABLE bool updateScreenshot(const QString &appId) override;
 
     QString focusedApplicationId() const override;
+    bool suspended() const;
+    void setSuspended(bool suspended);
+
+    // Only for testing
+    Q_INVOKABLE QStringList availableApplications();
+    int rightMargin() const;
+    void setRightMargin(int rightMargin);
 
  Q_SIGNALS:
     void keyboardHeightChanged();
@@ -113,12 +126,15 @@
     void createSideStage();
     int m_keyboardHeight;
     bool m_keyboardVisible;
+    bool m_suspended;
     QList<ApplicationInfo*> m_runningApplications;
     QList<ApplicationInfo*> m_availableApplications;
     QQmlComponent *m_mainStageComponent;
     QQuickItem *m_mainStage;
     QQmlComponent *m_sideStageComponent;
     QQuickItem *m_sideStage;
+
+    int m_rightMargin;
 };
 
 Q_DECLARE_OPERATORS_FOR_FLAGS(ApplicationManager::ExecFlags)

=== added file 'tests/mocks/Unity/Application/ApplicationScreenshotProvider.cpp'
--- tests/mocks/Unity/Application/ApplicationScreenshotProvider.cpp	1970-01-01 00:00:00 +0000
+++ tests/mocks/Unity/Application/ApplicationScreenshotProvider.cpp	2014-04-01 18:39:46 +0000
@@ -0,0 +1,74 @@
+/*
+ * Copyright (C) 2014 Canonical, Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it under
+ * the terms of the GNU Lesser General Public License version 3, as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
+ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "ApplicationScreenshotProvider.h"
+#include "ApplicationManager.h"
+#include "ApplicationInfo.h"
+
+#include "paths.h"
+
+#include <QDebug>
+#include <QGuiApplication>
+#include <QWindow>
+#include <QQuickWindow>
+
+ApplicationScreenshotProvider::ApplicationScreenshotProvider(ApplicationManager *appManager)
+    : QQuickImageProvider(QQuickImageProvider::Image)
+    , m_appManager(appManager)
+{
+}
+
+QImage ApplicationScreenshotProvider::requestImage(const QString &imageId, QSize * size,
+                                                     const QSize &requestedSize)
+{
+    // We ignore requestedSize here intentionally to avoid keeping scaled copies around
+    Q_UNUSED(requestedSize)
+
+    QString appId = imageId.split('/').first();
+
+    ApplicationInfo* app = static_cast<ApplicationInfo*>(m_appManager->findApplication(appId));
+    if (app == nullptr) {
+        return QImage();
+    }
+
+    QString filePath = QString("%1/Dash/graphics/phone/screenshots/[e-mail]").arg(qmlDirectory()).arg(app->icon().toString());
+
+    QImage image;
+    if (!image.load(filePath)) {
+        qWarning() << "failed loading app image" << filePath;
+    }
+
+
+    if (app->stage() == ApplicationInfo::SideStage) {
+        QByteArray gus = qgetenv("GRID_UNIT_PX");
+        image = image.scaledToWidth(gus.toInt() * 48);
+    } else {
+        // Lets scale main stage applications to be the size of the screen/window.
+        QGuiApplication *unity = qobject_cast<QGuiApplication*>(qApp);
+        Q_FOREACH (QWindow *win, unity->allWindows()) {
+            QQuickWindow *quickWin = qobject_cast<QQuickWindow*>(win);
+            if (quickWin) {
+                image = image.scaledToWidth(quickWin->width() - m_appManager->rightMargin());
+                break;
+            }
+        }
+    }
+
+    size->setWidth(image.width());
+    size->setHeight(image.height());
+
+    return image;
+}

=== added file 'tests/mocks/Unity/Application/ApplicationScreenshotProvider.h'
--- tests/mocks/Unity/Application/ApplicationScreenshotProvider.h	1970-01-01 00:00:00 +0000
+++ tests/mocks/Unity/Application/ApplicationScreenshotProvider.h	2014-04-01 18:39:46 +0000
@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 201 Canonical, Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it under
+ * the terms of the GNU Lesser General Public License version 3, as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
+ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef APPLICATIONSCREENSHOTPROVIDER_H
+#define APPLICATIONSCREENSHOTPROVIDER_H
+
+#include <QQuickImageProvider>
+
+class ApplicationManager;
+class ApplicationScreenshotProvider : public QQuickImageProvider
+{
+public:
+    explicit ApplicationScreenshotProvider(ApplicationManager *appManager);
+
+    QImage requestImage(const QString &appId, QSize *size, const QSize &requestedSize) override;
+
+private:
+    ApplicationManager* m_appManager;
+};
+
+#endif // APPLICATIONSCREENSHOTPROVIDER_H

=== modified file 'tests/mocks/Unity/Application/CMakeLists.txt'
--- tests/mocks/Unity/Application/CMakeLists.txt	2013-12-13 01:02:53 +0000
+++ tests/mocks/Unity/Application/CMakeLists.txt	2014-04-01 18:39:46 +0000
@@ -5,6 +5,7 @@
     ApplicationInfo.cpp
     ApplicationImage.cpp
     ApplicationManager.cpp
+    ApplicationScreenshotProvider.cpp
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/ApplicationInfoInterface.h
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/ApplicationManagerInterface.h
 )

=== modified file 'tests/mocks/Unity/Application/plugin.cpp'
--- tests/mocks/Unity/Application/plugin.cpp	2013-09-11 15:33:02 +0000
+++ tests/mocks/Unity/Application/plugin.cpp	2014-04-01 18:39:46 +0000
@@ -18,13 +18,20 @@
 #include "ApplicationInfo.h"
 #include "ApplicationImage.h"
 #include "ApplicationManager.h"
+#include "ApplicationScreenshotProvider.h"
 
 #include <qqml.h>
+#include <QQmlEngine>
+
+ApplicationManager *s_appManager = 0;
 
 static QObject* applicationManagerSingleton(QQmlEngine* engine, QJSEngine* scriptEngine) {
-  Q_UNUSED(engine);
-  Q_UNUSED(scriptEngine);
-  return new ApplicationManager();
+    Q_UNUSED(engine);
+    Q_UNUSED(scriptEngine);
+    if (!s_appManager) {
+        s_appManager = new ApplicationManager();
+    }
+    return s_appManager;
 }
 
 void FakeUnityApplicationQmlPlugin::registerTypes(const char *uri)
@@ -37,3 +44,11 @@
 
     qmlRegisterType<ApplicationImage>(uri, 0, 1, "ApplicationImage");
 }
+
+void FakeUnityApplicationQmlPlugin::initializeEngine(QQmlEngine *engine, const char *uri)
+{
+    QQmlExtensionPlugin::initializeEngine(engine, uri);
+
+    ApplicationManager* appManager = static_cast<ApplicationManager*>(applicationManagerSingleton(engine, NULL));
+    engine->addImageProvider(QLatin1String("application"), new ApplicationScreenshotProvider(appManager));
+}

=== modified file 'tests/mocks/Unity/Application/plugin.h'
--- tests/mocks/Unity/Application/plugin.h	2013-09-04 13:42:27 +0000
+++ tests/mocks/Unity/Application/plugin.h	2014-04-01 18:39:46 +0000
@@ -25,6 +25,7 @@
     Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
 public:
     void registerTypes(const char *uri);
+    void initializeEngine(QQmlEngine *engine, const char *uri);
 };
 
 #endif

=== modified file 'tests/plugins/Unity/Launcher/launchermodeltest.cpp'
--- tests/plugins/Unity/Launcher/launchermodeltest.cpp	2013-09-16 17:59:13 +0000
+++ tests/plugins/Unity/Launcher/launchermodeltest.cpp	2014-04-01 18:39:46 +0000
@@ -39,6 +39,7 @@
     ApplicationInfoInterface::Stage stage() const { return ApplicationInfoInterface::MainStage; }
     ApplicationInfoInterface::State state() const { return ApplicationInfoInterface::Running; }
     bool focused() const { return m_focused; }
+    QUrl screenshot() const { return QUrl(); }
 
     // Methods used for mocking (not in the interface)
     void setFocused(bool focused) { m_focused = focused; Q_EMIT focusedChanged(focused); }
@@ -92,6 +93,10 @@
         m_list.takeAt(index)->deleteLater();
         endRemoveRows();
     }
+    bool updateScreenshot(const QString &appId) { Q_UNUSED(appId); return true; }
+    bool requestFocusApplication(const QString &appId) { Q_UNUSED(appId); return true; }
+    bool suspended() const { return false; }
+    void setSuspended(bool) {}
 
 private:
     QList<MockApp*> m_list;

=== modified file 'tests/qmltests/CMakeLists.txt'
--- tests/qmltests/CMakeLists.txt	2014-03-27 12:37:27 +0000
+++ tests/qmltests/CMakeLists.txt	2014-04-01 18:39:46 +0000
@@ -84,6 +84,6 @@
                                                   ENVIRONMENT "LD_LIBRARY_PATH=${CMAKE_BINARY_DIR}/tests/mocks/QMenuModel")
 add_qml_test(Panel/Indicators MenuItemFactory IMPORT_PATHS ${qmltest_DEFAULT_IMPORT_PATHS} ${CMAKE_BINARY_DIR}/plugins)
 add_qml_test(Panel/Indicators MessageMenuItemFactory IMPORT_PATHS ${qmltest_DEFAULT_IMPORT_PATHS} ${CMAKE_BINARY_DIR}/plugins)
-add_qml_test(SideStage SideStage IMPORT_PATHS ${qmltest_DEFAULT_IMPORT_PATHS}
+add_qml_test(Stages PhoneStage IMPORT_PATHS ${qmltest_DEFAULT_IMPORT_PATHS}
                                               ${CMAKE_BINARY_DIR}/tests/mocks
                                               ${CMAKE_BINARY_DIR}/plugins)

=== modified file 'tests/qmltests/Components/tst_ResponsiveFlowView.qml'
--- tests/qmltests/Components/tst_ResponsiveFlowView.qml	2013-12-17 16:04:47 +0000
+++ tests/qmltests/Components/tst_ResponsiveFlowView.qml	2014-04-01 18:39:46 +0000
@@ -82,8 +82,7 @@
         ResponsiveFlowView {
             id: flow
             anchors.fill: parent
-            firstModel: fakeModel
-            secondModel: fakeModel
+            model: fakeModel
             minimumHorizontalSpacing:
                 minHSpacingSelector.values[minHSpacingSelector.selectedIndex]
             verticalSpacing: units.gu(2)

=== modified file 'tests/qmltests/Dash/Apps/tst_RunningApplicationsGrid.qml'
--- tests/qmltests/Dash/Apps/tst_RunningApplicationsGrid.qml	2013-12-17 16:04:47 +0000
+++ tests/qmltests/Dash/Apps/tst_RunningApplicationsGrid.qml	2014-04-01 18:39:46 +0000
@@ -18,87 +18,20 @@
 import QtTest 1.0
 import "../../../../qml/Dash/Apps"
 import Unity.Test 0.1 as UT
+import Unity.Application 0.1
 
-Item {
+// Using Rectangle to have an opaque surface because AppManager paints app surfaces behind it.
+Rectangle {
     width: units.gu(50)
     height: units.gu(40)
 
-    QtObject {
-        id: fakeApplicationManager
-
-        property bool sideStageEnabled: false
-
-        function stopApplication(appId) {
-            for (var i=0, len=fakeRunningAppsModel.count; i<len; i++) {
-                if (appId == fakeRunningAppsModel.get(i).appId) {
-                    fakeRunningAppsModel.remove(i)
-                }
-            }
-        }
-    }
-
-    QtObject {
-        id: shell
-        property bool dashShown: true
-        property bool stageScreenshotsReady: false
-        property var applicationManager: fakeApplicationManager
-
-        function activateApplication(appId) {
-        }
-    }
-
-    ListModel {
-        id: fakeRunningAppsModel
-
-        function contains(appId) {
-            for (var i=0, len=fakeRunningAppsModel.count; i<len; i++) {
-                if (appId == fakeRunningAppsModel.get(i).appId) {
-                    return true;
-                }
-            }
-            return false;
-        }
-
-        function rePopulate() {
-            for (var i=0, len=availableAppsModel.count; i<len; i++) {
-                fakeRunningAppsModel.append(availableAppsModel.get(i));
-            }
-        }
-    }
-
-    ListModel {
-        id: availableAppsModel
-        ListElement {
-            name: "Phone"
-            icon: "phone-app"
-            exec: "/usr/bin/phone-app"
-            appId: "phone"
-            imageQml: "import QtQuick 2.0\n \
-                       Rectangle { \n \
-                          anchors.fill:parent \n \
-                          color:'darkgreen' \n \
-                          Text { anchors.centerIn: parent; text: 'PHONE' } \n \
-                      }"
-        }
-
-        ListElement {
-            name: "Calendar"
-            icon: "calendar-app"
-            exec: "/usr/bin/calendar-app"
-            appId: "calendar"
-            imageQml: "import QtQuick 2.0\n \
-                       Rectangle { \n \
-                           anchors.fill:parent \n \
-                           color:'darkblue' \n \
-                           Text { anchors.centerIn: parent; text: 'CALENDAR'\n \
-                                  color:'white'} \n \
-                      }"
-        }
-    }
-
     function resetRunningApplications() {
-        fakeRunningAppsModel.clear()
-        fakeRunningAppsModel.rePopulate()
+        while (ApplicationManager.count > 0) {
+            ApplicationManager.stopApplication(ApplicationManager.get(0).appId)
+        }
+
+        ApplicationManager.startApplication("phone-app");
+        ApplicationManager.startApplication("webbrowser-app");
     }
 
     Component.onCompleted: {
@@ -109,7 +42,7 @@
     RunningApplicationsGrid {
         id: runningApplicationsGrid
         anchors.fill: parent
-        firstModel: fakeRunningAppsModel
+        model: ApplicationManager
     }
 
     UT.UnityTestCase {
@@ -121,11 +54,11 @@
             resetRunningApplications()
         }
 
-        property var calendarTile
+        property var browserTile
         property var phoneTile
 
-        property var isCalendarLongPressed: false
-        function onCalendarLongPressed() {isCalendarLongPressed = true}
+        property var isBrowserLongPressed: false
+        function onBrowserLongPressed() {isBrowserLongPressed = true}
 
         property var isPhoneLongPressed: false
         function onPhoneLongPressed() {isPhoneLongPressed = true}
@@ -133,25 +66,25 @@
         // Tiles should go to termination mode when any one of them is long-pressed.
         // Long-pressing when they're in termination mode brings them back to activation mode
         function test_enterTerminationMode() {
-            calendarTile = findChild(runningApplicationsGrid, "runningAppTile Calendar")
-            verify(calendarTile != undefined)
-            calendarTile.onPressAndHold.connect(onCalendarLongPressed)
+            browserTile = findChild(runningApplicationsGrid, "runningAppTile Browser")
+            verify(browserTile != undefined)
+            browserTile.onPressAndHold.connect(onBrowserLongPressed)
 
             phoneTile = findChild(runningApplicationsGrid, "runningAppTile Phone")
             verify(phoneTile != undefined)
             phoneTile.onPressAndHold.connect(onPhoneLongPressed)
 
-            compare(calendarTile.terminationModeEnabled, false)
+            compare(browserTile.terminationModeEnabled, false)
             compare(phoneTile.terminationModeEnabled, false)
             compare(runningApplicationsGrid.terminationModeEnabled, false)
 
-            isCalendarLongPressed = false
-            mousePress(calendarTile, calendarTile.width/2, calendarTile.height/2)
+            isBrowserLongPressed = false
+            mousePress(browserTile, browserTile.width/2, browserTile.height/2)
             tryCompareFunction(checkSwitchToTerminationModeAfterLongPress, true)
 
-            mouseRelease(calendarTile, calendarTile.width/2, calendarTile.height/2)
+            mouseRelease(browserTile, browserTile.width/2, browserTile.height/2)
 
-            compare(calendarTile.terminationModeEnabled, true)
+            compare(browserTile.terminationModeEnabled, true)
             compare(phoneTile.terminationModeEnabled, true)
             compare(runningApplicationsGrid.terminationModeEnabled, true)
 
@@ -161,23 +94,23 @@
 
             mouseRelease(phoneTile, phoneTile.width/2, phoneTile.height/2)
 
-            compare(calendarTile.terminationModeEnabled, false)
+            compare(browserTile.terminationModeEnabled, false)
             compare(phoneTile.terminationModeEnabled, false)
             compare(runningApplicationsGrid.terminationModeEnabled, false)
 
-            calendarTile.onPressAndHold.disconnect(onCalendarLongPressed)
+            browserTile.onPressAndHold.disconnect(onBrowserLongPressed)
             phoneTile.onPressAndHold.disconnect(onPhoneLongPressed)
         }
 
         // Checks that components swicth to termination mode after (and only after) a long
-        // press happens on Calendar tile.
+        // press happens on Browser tile.
         function checkSwitchToTerminationModeAfterLongPress() {
-            compare(calendarTile.terminationModeEnabled, isCalendarLongPressed)
-            compare(phoneTile.terminationModeEnabled, isCalendarLongPressed)
-            compare(runningApplicationsGrid.terminationModeEnabled, isCalendarLongPressed)
+            compare(browserTile.terminationModeEnabled, isBrowserLongPressed)
+            compare(phoneTile.terminationModeEnabled, isBrowserLongPressed)
+            compare(runningApplicationsGrid.terminationModeEnabled, isBrowserLongPressed)
 
-            return isCalendarLongPressed &&
-                calendarTile.terminationModeEnabled &&
+            return isBrowserLongPressed &&
+                browserTile.terminationModeEnabled &&
                 phoneTile.terminationModeEnabled &&
                 runningApplicationsGrid.terminationModeEnabled
         }
@@ -185,12 +118,12 @@
         // Checks that components swicth to activation mode after (and only after) a long
         // press happens on Phone tile.
         function checkSwitchToActivationModeAfterLongPress() {
-            compare(calendarTile.terminationModeEnabled, !isPhoneLongPressed)
+            compare(browserTile.terminationModeEnabled, !isPhoneLongPressed)
             compare(phoneTile.terminationModeEnabled, !isPhoneLongPressed)
             compare(runningApplicationsGrid.terminationModeEnabled, !isPhoneLongPressed)
 
             return isPhoneLongPressed &&
-                !calendarTile.terminationModeEnabled &&
+                !browserTile.terminationModeEnabled &&
                 !phoneTile.terminationModeEnabled &&
                 !runningApplicationsGrid.terminationModeEnabled
         }
@@ -200,17 +133,17 @@
         function test_clickTileNotClose() {
             runningApplicationsGrid.terminationModeEnabled = true
 
-            var calendarTile = findChild(runningApplicationsGrid, "runningAppTile Calendar")
-            verify(calendarTile != undefined)
-
-            verify(fakeRunningAppsModel.contains("calendar"))
-
-            mouseClick(calendarTile, calendarTile.width/2, calendarTile.height/2)
-
-            verify(fakeRunningAppsModel.contains("calendar"))
-
-            // The tile for the Calendar app should stay there
-            tryCompareFunction(checkCalendarTileExists, true)
+            var browserTile = findChild(runningApplicationsGrid, "runningAppTile Browser")
+            verify(browserTile != undefined)
+
+            verify(ApplicationManager.findApplication("webbrowser-app") !== null)
+
+            mouseClick(browserTile, browserTile.width/2, browserTile.height/2)
+
+            verify(ApplicationManager.findApplication("webbrowser-app") !== null)
+
+            // The tile for the Browser app should stay there
+            tryCompareFunction(checkBrowserTileExists, true)
         }
 
         // While in termination mode, clicking on a running application tile's close icon
@@ -218,25 +151,25 @@
         function test_clickCloseIconToTerminateApp() {
             runningApplicationsGrid.terminationModeEnabled = true
 
-            var calendarTile = findChild(runningApplicationsGrid, "runningAppTile Calendar")
-            var calendarTileCloseButton = findChild(runningApplicationsGrid, "closeIcon Calendar")
-
-            verify(calendarTile != undefined)
-            verify(calendarTileCloseButton != undefined)
-            verify(fakeRunningAppsModel.contains("calendar"))
-
-            mouseClick(calendarTileCloseButton, calendarTileCloseButton.width/2, calendarTileCloseButton.height/2)
+            var browserTile = findChild(runningApplicationsGrid, "runningAppTile Browser")
+            var browserTileCloseButton = findChild(runningApplicationsGrid, "closeIcon Browser")
+
+            verify(browserTile != undefined)
+            verify(browserTileCloseButton != undefined)
+            verify(ApplicationManager.findApplication("webbrowser-app") !== 0)
+
+            mouseClick(browserTileCloseButton, browserTileCloseButton.width/2, browserTileCloseButton.height/2)
             wait(0) // spin event loop to start any pending animation
 
-            verify(!fakeRunningAppsModel.contains("calendar"))
+            verify(ApplicationManager.findApplication("webbrowser-app") === null)
 
-            // The tile for the Calendar app should eventually vanish since the
+            // The tile for the Browser app should eventually vanish since the
             // application has been terminated.
-            tryCompareFunction(checkCalendarTileExists, false)
+            tryCompareFunction(checkBrowserTileExists, false)
         }
 
-        function checkCalendarTileExists() {
-            return findChild(runningApplicationsGrid, "runningAppTile Calendar")
+        function checkBrowserTileExists() {
+            return findChild(runningApplicationsGrid, "runningAppTile Browser")
                     != undefined
         }
 
@@ -245,8 +178,8 @@
         function test_clickOutsideTilesDisablesTerminationMode() {
             runningApplicationsGrid.terminationModeEnabled = true
 
-            var calendarTile = findChild(runningApplicationsGrid, "runningAppTile Calendar")
-            verify(calendarTile != undefined)
+            var browserTile = findChild(runningApplicationsGrid, "runningAppTile Browser")
+            verify(browserTile != undefined)
 
             verify(runningApplicationsGrid.terminationModeEnabled);
 

=== added directory 'tests/qmltests/Stages'
=== added file 'tests/qmltests/Stages/tst_PhoneStage.qml'
--- tests/qmltests/Stages/tst_PhoneStage.qml	1970-01-01 00:00:00 +0000
+++ tests/qmltests/Stages/tst_PhoneStage.qml	2014-04-01 18:39:46 +0000
@@ -0,0 +1,288 @@
+/*
+ * Copyright 2014 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.0
+import QtTest 1.0
+import Unity.Test 0.1 as UT
+import ".."
+import "../../../qml/Stages"
+import Ubuntu.Components 0.1
+import Unity.Application 0.1
+
+Item {
+    width: units.gu(70)
+    height: units.gu(70)
+
+    Rectangle {
+
+    }
+
+    PhoneStage {
+        id: phoneStage
+        anchors { fill: parent; rightMargin: units.gu(30) }
+        shown: true
+        dragAreaWidth: units.gu(2)
+    }
+
+    Binding {
+        target: ApplicationManager
+        property: "rightMargin"
+        value: phoneStage.anchors.rightMargin
+    }
+
+    Rectangle {
+        anchors { fill: parent; leftMargin: phoneStage.width }
+//        color: "blue"
+
+        Column {
+            anchors { left: parent.left; right: parent.right; top: parent.top; margins: units.gu(1) }
+            spacing: units.gu(1)
+            Button {
+                anchors { left: parent.left; right: parent.right }
+                text: "Add App"
+                onClicked: {
+                    testCase.addApps();
+                }
+            }
+            Button {
+                anchors { left: parent.left; right: parent.right }
+                text: "Add App"
+            }
+        }
+    }
+
+    UT.UnityTestCase {
+        id: testCase
+        name: "PhoneStage"
+        when: windowShown
+
+        function addApps(count) {
+            if (count == undefined) count = 1;
+            for (var i = 0; i < count; i++) {
+                var app = ApplicationManager.startApplication(ApplicationManager.availableApplications()[ApplicationManager.count])
+                tryCompare(app, "state", ApplicationInfoInterface.Running)
+                // Fixme: Right now there is a timeout in the PhoneStage that displays a white splash
+                // screen rectangle when an app starts. This is because we don't yet have a way of
+                // knowing when an app has finished launching. That workaround and this wait() should
+                // go away at some point and the app's state only changing to Running when ready for real.
+//                wait(1000)
+                waitForRendering(phoneStage)
+            }
+        }
+
+        function goToSpread() {
+            var spreadView = findChild(phoneStage, "spreadView");
+
+            var startX = phoneStage.width;
+            var startY = phoneStage.height / 2;
+            var endY = startY;
+            var endX = units.gu(2);
+
+            touchFlick(phoneStage, startX, startY, endX, endY,
+                       true /* beginTouch */, true /* endTouch */, units.gu(10), 50);
+        }
+
+        function test_shortFlick() {
+            addApps(2)
+            var startX = phoneStage.width - units.gu(1);
+            var startY = phoneStage.height / 2;
+            var endX = phoneStage.width / 2;
+            var endY = startY;
+
+            var activeApp = ApplicationManager.get(0);
+            var inactiveApp = ApplicationManager.get(1);
+
+            touchFlick(phoneStage, startX, startY, endX, endY,
+                       true /* beginTouch */, true /* endTouch */, units.gu(10), 50);
+
+            tryCompare(ApplicationManager, "focusedApplicationId", inactiveApp.appId)
+
+            touchFlick(phoneStage, startX, startY, endX, endY,
+                       true /* beginTouch */, true /* endTouch */, units.gu(10), 50);
+
+            tryCompare(ApplicationManager, "focusedApplicationId", activeApp.appId)
+
+            tryCompare(phoneStage, "painting", false);
+        }
+
+        function test_enterSpread_data() {
+            return [
+                {tag: "<position1 (linear movement)", positionMarker: "positionMarker1", linear: true, offset: -1, endPhase: 0, targetPhase: 0, newFocusedIndex: 1 },
+                {tag: "<position1 (non-linear movement)", positionMarker: "positionMarker1", linear: false, offset: -1, endPhase: 0, targetPhase: 0, newFocusedIndex: 0 },
+                {tag: ">position1", positionMarker: "positionMarker1", linear: true, offset: +1, endPhase: 0, targetPhase: 0, newFocusedIndex: 1 },
+                {tag: "<position2 (linear)", positionMarker: "positionMarker2", linear: true, offset: -1, endPhase: 0, targetPhase: 0, newFocusedIndex: 1 },
+                {tag: "<position2 (non-linear)", positionMarker: "positionMarker2", linear: false, offset: -1, endPhase: 0, targetPhase: 0, newFocusedIndex: 1 },
+                {tag: ">position2", positionMarker: "positionMarker2", linear: true, offset: +1, endPhase: 1, targetPhase: 0, newFocusedIndex: 1 },
+                {tag: "<position3", positionMarker: "positionMarker3", linear: true, offset: -1, endPhase: 1, targetPhase: 0, newFocusedIndex: 1 },
+                {tag: ">position3", positionMarker: "positionMarker3", linear: true, offset: +1, endPhase: 2, targetPhase: 2, newFocusedIndex: 2 },
+            ];
+        }
+
+        function test_enterSpread(data) {
+            addApps(5)
+
+            var spreadView = findChild(phoneStage, "spreadView");
+
+            var startX = phoneStage.width;
+            var startY = phoneStage.height / 2;
+            var endY = startY;
+            var endX = spreadView.width - (spreadView.width * spreadView[data.positionMarker]) - data.offset - phoneStage.dragAreaWidth;
+
+            var oldFocusedApp = ApplicationManager.get(0);
+            var newFocusedApp = ApplicationManager.get(data.newFocusedIndex);
+
+            touchFlick(phoneStage, startX, startY, endX, endY,
+                       true /* beginTouch */, false /* endTouch */, units.gu(10), 50);
+
+            tryCompare(spreadView, "phase", data.endPhase)
+
+            if (!data.linear) {
+                touchFlick(phoneStage, endX, endY, endX + units.gu(.5), endY,
+                           false /* beginTouch */, false /* endTouch */, units.gu(10), 50);
+                touchFlick(phoneStage, endY + units.gu(.5), endY, endX, endY,
+                           false /* beginTouch */, false /* endTouch */, units.gu(10), 50);
+            }
+
+            touchRelease(phoneStage, endX, endY);
+
+            tryCompare(spreadView, "phase", data.targetPhase)
+
+            if (data.targetPhase == 2) {
+                var app2 = findChild(spreadView, "appDelegate2");
+                mouseClick(app2, units.gu(1), units.gu(1));
+            }
+
+            tryCompare(phoneStage, "painting", false);
+            tryCompare(ApplicationManager, "focusedApplicationId", newFocusedApp.appId);
+        }
+
+        function test_selectAppFromSpread_data() {
+            var appsToTest = 6;
+            var apps = new Array();
+            for (var i = 0; i < appsToTest; i++) {
+                var item = new Object();
+                item.tag = "App " + i;
+                item.index = i;
+                item.total = appsToTest;
+                apps.push(item)
+            }
+            return apps;
+        }
+
+        function test_selectAppFromSpread(data) {
+            addApps(data.total)
+
+            var spreadView = findChild(phoneStage, "spreadView");
+
+            goToSpread();
+
+            tryCompare(spreadView, "phase", 2);
+
+            var tile = findChild(spreadView, "appDelegate" + data.index);
+            var appId = ApplicationManager.get(data.index).appId;
+
+            if (tile.mapToItem(spreadView).x > spreadView.width) {
+                // Item is not visible... Need to flick the spread
+                var startX = phoneStage.width - units.gu(1);
+                var startY = phoneStage.height / 2;
+                var endY = startY;
+                var endX = units.gu(2);
+                touchFlick(phoneStage, startX, startY, endX, endY, true, true, units.gu(10), 50)
+                tryCompare(spreadView, "flicking", false);
+                tryCompare(spreadView, "moving", false);
+//                waitForRendering(phoneStage);
+            }
+
+            console.log("clicking app", data.index, "(", appId, ")")
+            mouseClick(spreadView, tile.mapToItem(spreadView).x + units.gu(1), spreadView.height / 2)
+            tryCompare(ApplicationManager, "focusedApplicationId", appId);
+            tryCompare(spreadView, "phase", 0);
+        }
+
+        function test_animateAppStartup() {
+            compare(phoneStage.painting, false);
+            addApps(2);
+            tryCompare(phoneStage, "painting", true);
+            tryCompare(phoneStage, "painting", false);
+            addApps(1);
+            tryCompare(phoneStage, "painting", true);
+            tryCompare(phoneStage, "painting", false);
+        }
+
+        function test_select_data() {
+            return [
+                { tag: "0", index: 0 },
+                { tag: "2", index: 2 },
+                { tag: "4", index: 4 },
+            ]
+        }
+
+        function test_select(data) {
+            addApps(5);
+
+            var spreadView = findChild(phoneStage, "spreadView");
+            var selectedApp = ApplicationManager.get(data.index);
+
+            goToSpread();
+
+            phoneStage.select(selectedApp.appId);
+
+            tryCompare(phoneStage, "painting", false);
+            compare(ApplicationManager.focusedApplicationId, selectedApp.appId);
+        }
+
+        function test_fullscreenMode() {
+            var fullscreenApp = null;
+            var normalApp = null;
+
+            for (var i = 0; i < 5; i++) {
+                addApps(1);
+                var newApp = ApplicationManager.get(0);
+                tryCompare(phoneStage, "fullscreen", newApp.fullscreen);
+                if (newApp.fullscreen && fullscreenApp == null) {
+                    fullscreenApp = newApp;
+                } else if (!newApp.fullscreen && normalApp == null){
+                    normalApp = newApp;
+                }
+            }
+            verify(fullscreenApp != null); // Can't continue the test without having a fullscreen app
+            verify(normalApp != null); // Can't continue the test without having a non-fullscreen app
+
+            // Select a normal app
+            goToSpread();
+            phoneStage.select(normalApp.appId);
+            tryCompare(phoneStage, "fullscreen", false);
+
+            // Select a fullscreen app
+            goToSpread();
+            phoneStage.select(fullscreenApp.appId);
+            tryCompare(phoneStage, "fullscreen", true);
+
+            // Select a normal app
+            goToSpread();
+            phoneStage.select(normalApp.appId);
+            tryCompare(phoneStage, "fullscreen", false);
+        }
+
+        function cleanup() {
+            while (ApplicationManager.count > 0) {
+                var oldCount = ApplicationManager.count;
+                ApplicationManager.stopApplication(ApplicationManager.get(0).appId)
+                tryCompare(ApplicationManager, "count", oldCount - 1)
+            }
+        }
+    }
+}

=== modified file 'tests/qmltests/tst_Shell.qml'
--- tests/qmltests/tst_Shell.qml	2014-03-19 10:48:06 +0000
+++ tests/qmltests/tst_Shell.qml	2014-04-01 18:39:46 +0000
@@ -117,6 +117,7 @@
             while (apps.count > 0) {
                 ApplicationManager.stopApplication(apps.get(0).appId);
             }
+            compare(ApplicationManager.count, 0)
         }
 
         /*
@@ -187,26 +188,34 @@
             tapOnAppIconInLauncher();
             waitUntilApplicationWindowIsFullyVisible();
 
-            var mainApp = ApplicationManager.focusedApplicationId;
-            verify(mainApp != "");
+            var mainAppId = ApplicationManager.focusedApplicationId;
+            verify(mainAppId != "");
+            var mainApp = ApplicationManager.findApplication(mainAppId);
+            verify(mainApp);
+            tryCompare(mainApp.state, ApplicationInfo.Running);
 
             // Try to suspend while proximity is engaged...
             Powerd.displayPowerStateChange(Powerd.Off, Powerd.UseProximity);
             tryCompare(greeter, "showProgress", 0);
 
             // Now really suspend
+            print("suspending")
             Powerd.displayPowerStateChange(Powerd.Off, 0);
+            print("done suspending")
             tryCompare(greeter, "showProgress", 1);
-            tryCompare(ApplicationManager, "focusedApplicationId", "");
+
+            tryCompare(ApplicationManager, "suspended", true);
+            compare(mainApp.state, ApplicationInfo.Suspended);
 
             // And wake up
             Powerd.displayPowerStateChange(Powerd.On, 0);
-            tryCompare(ApplicationManager, "focusedApplicationId", "");
             tryCompare(greeter, "showProgress", 1);
 
             // Swipe away greeter to focus app
             swipeAwayGreeter();
-            tryCompare(ApplicationManager, "focusedApplicationId", mainApp);
+            tryCompare(ApplicationManager, "suspended", false);
+            compare(mainApp.state, ApplicationInfo.Running);
+            tryCompare(ApplicationManager, "focusedApplicationId", mainAppId);
         }
 
         function swipeAwayGreeter() {
@@ -239,7 +248,7 @@
             tryCompare(dash, "opacity", 1.0);
 
             touchFlick(shell, touchX, touchY, shell.width * 0.1, touchY,
-                       true /* beginTouch */, false /* endTouch */);
+                       true /* beginTouch */, false /* endTouch */, units.gu(10), 50);
 
             // check that Dash has been scaled down and had its opacity reduced
             tryCompareFunction(function() { return dash.contentScale <= 0.9; }, true);
@@ -270,7 +279,7 @@
             tryCompare(dash, "opacity", 1.0);
 
             touchFlick(shell, touchX, touchY, shell.width * 0.1, touchY,
-                       true /* beginTouch */, false /* endTouch */);
+                       true /* beginTouch */, false /* endTouch */, units.gu(10), 50);
 
             // check that Dash has been scaled down and had its opacity reduced
             tryCompareFunction(function() { return dash.contentScale <= 0.9; }, true);
@@ -486,7 +495,6 @@
         }
 
         function test_DashShown(data) {
-
             if (data.greeter) {
                 // Swipe the greeter in
                 var greeter = findChild(shell, "greeter");