Merge lp:~unity-team/unity8/preview-rating-position-listview into lp:unity8

[Andrea Cimitan]

[lp:~unity-team/unity8/preview-rating-position-listview]

2228. By Andrea Cimitan on 2016-03-10

init to -1

[Michał Sawicz (saviq)]

There is makeSureVisible already, better to use that? And please include in the branch that changes the preview widget.

review: Disapprove

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2227
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~unity-team/unity8/preview-rating-position-listview/+merge/288707/+edit-commit-message

https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/668/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/876
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/892
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/892
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/890/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/668/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

2228. By Andrea Cimitan on 2016-03-10

init to -1

2227. By Andrea Cimitan on 2016-03-10

move the preview listview when touching the preview rating widget

=== modified file 'qml/Dash/Previews/PreviewRatingInput.qml'
--- qml/Dash/Previews/PreviewRatingInput.qml	2015-09-14 07:47:24 +0000
+++ qml/Dash/Previews/PreviewRatingInput.qml	2016-03-10 21:25:16 +0000
@@ -93,6 +93,7 @@
             }
             size: 5
             onValueChanged: {
+                parentFlickable.positionViewAtIndex(widgetIndex, ListView.Contain);
                 if (widgetData["visible"] === "rating") root.submit();
             }
 

=== modified file 'qml/Dash/Previews/PreviewWidget.qml'
--- qml/Dash/Previews/PreviewWidget.qml	2016-02-19 11:42:42 +0000
+++ qml/Dash/Previews/PreviewWidget.qml	2016-03-10 21:25:16 +0000
@@ -37,6 +37,9 @@
     /// The parent (vertical) flickable this widget is in (if any)
     property var parentFlickable: null
 
+    /// The index of this widget
+    property int widgetIndex: -1
+
     /*! \brief This signal should be emitted when a preview action was triggered.
      *
      *  \param widgetId, actionId Respective identifiers from widgetData.

=== modified file 'qml/Dash/Previews/PreviewWidgetFactory.qml'
--- qml/Dash/Previews/PreviewWidgetFactory.qml	2016-02-19 11:42:42 +0000
+++ qml/Dash/Previews/PreviewWidgetFactory.qml	2016-03-10 21:25:16 +0000
@@ -31,6 +31,9 @@
     //! Widget data, forwarded to the widget as is.
     property var widgetData: null
 
+    //! Index of the widget.
+    property int widgetIndex: -1
+
     //! The ScopeStyle component.
     property var scopeStyle: null
 
@@ -82,6 +85,7 @@
         item.expanded = Qt.binding(function() { return root.expanded } )
         item.scopeStyle = Qt.binding(function() { return root.scopeStyle } )
         item.parentFlickable = Qt.binding(function() { return root.parentFlickable } )
+        item.widgetIndex = Qt.binding(function() { return root.widgetIndex } )
     }
 
     Connections {