# copy qmldir file into build directory for shadow builds
file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/qmldir"
DESTINATION ${CMAKE_CURRENT_BINARY_DIR}
)
See in Ubuntu.Gestures for a better approach to this (using a custom target depending on the files to update when changed - I'll later go through our current codebase and fix it across the board; we should also use ${CMAKE_COMMAND} -E copy... etc.)
Hmm hmm... Why doesn't LauncherBackend have an API definition in lp:unity-api? Or is it just a stop-gap? Same for QuikcListEntry? Or is it even just a thing that the shell won't ever see?
=====
355 + QStringList storedApplications() const;
Shouldn't this be "pinnedApplications"?
=====
401 + //TODO: Fill in getters for all the other things needed from the .desktop file.
I'm not sure that's needed, we should have a generic "AppData" component or similar that would take an appId and expose all the data read from .desktop and potentially other places.
=====
One think we're missing is the Gettext domain to use to translate the strings. It could be considered a backend task, though.
78 + unity8-private | unity8- launcher- impl, launcher- impl-0. 2,
79 + unity8-
87 +Provides: unity-launcher- impl, impl-0. 2
88 + unity-launcher-
As mentioned on IRC: unity-launcher- impl, not unity8, and -0.2 should be what you set to VERSION in the unity-api MP.
=====
123 + ${CMAKE_ CURRENT_ BINARY_ DIR} API_INCLUDEDIR}
124 + ${LAUNCHER_
Is this required?
=====
# copy qmldir file into build directory for shadow builds CURRENT_ SOURCE_ DIR}/qmldir" CURRENT_ BINARY_ DIR}
file(COPY "${CMAKE_
DESTINATION ${CMAKE_
)
See in Ubuntu.Gestures for a better approach to this (using a custom target depending on the files to update when changed - I'll later go through our current codebase and fix it across the board; we should also use ${CMAKE_COMMAND} -E copy... etc.)
=====
Please put Authors below copyright.
=====
205 +LauncherBacken d::~LauncherBac kend()
206 +{
207 +
208 +}
Is it just a template thing, or do we want empty destructors as a rule?
=====
227 +QString LauncherBackend ::displayName( const QString &appId) const "phone- app.desktop" , "Phone"); "camera- app.desktop" , "Camera"); "gallery- app.desktop" , "Gallery"); "facebook- webapp. desktop" , "Facebook"); "webbrowser- app.desktop" , "Browser"); "twitter- webapp. desktop" , "Twitter"); "gmail- webapp. desktop" , "GMail"); "ubuntu- weather- app.desktop" , "Weather"); "notes- app.desktop" , "Notes"); "ubuntu- calendar- app.desktop" , "Calendar"); ::icon( const QString &appId) const "phone- app.desktop" , "phone-app"); "camera- app.desktop" , "camera"); "gallery- app.desktop" , "gallery"); "facebook- webapp. desktop" , "facebook"); "webbrowser- app.desktop" , "browser"); "twitter- webapp. desktop" , "twitter"); "gmail- webapp. desktop" , "gmail"); "ubuntu- weather- app.desktop" , "weather"); "notes- app.desktop" , "notepad"); "ubuntu- calendar- app.desktop" , "calendar");
228 +{
229 + // TODO: get stuff from desktop files instead this hardcoded map
230 + QHash<QString, QString> map;
231 + map.insert(
232 + map.insert(
233 + map.insert(
234 + map.insert(
235 + map.insert(
236 + map.insert(
237 + map.insert(
238 + map.insert(
239 + map.insert(
240 + map.insert(
241 + return map.value(appId);
242 +}
243 +
244 +QString LauncherBackend
245 +{
246 + // TODO: get stuff from desktop files instead this hardcoded map
247 + QHash<QString, QString> map;
248 + map.insert(
249 + map.insert(
250 + map.insert(
251 + map.insert(
252 + map.insert(
253 + map.insert(
254 + map.insert(
255 + map.insert(
256 + map.insert(
257 + map.insert(
258 + return map.value(appId);
I know that's temporary code, but making those static and only filling it once would save us some CPU cycles.
=====
301 +void LauncherBackend ::triggerQuickL istAction( const QString &appId, const QString &quickListId)
s/quickListId/ actionId/ maybe?
Hmm, from https:/ /code.launchpad .net/~mzanetti/ unity-api/ launcher- api-pinning/ +merge/ 173064
201 + Q_INVOKABLE virtual void quickListAction Invoked( const QString &appId, int quickListIndex) = 0;
=====
Hmm hmm... Why doesn't LauncherBackend have an API definition in lp:unity-api? Or is it just a stop-gap? Same for QuikcListEntry? Or is it even just a thing that the shell won't ever see?
=====
355 + QStringList storedApplicati ons() const;
Shouldn't this be "pinnedApplicat ions"?
=====
401 + //TODO: Fill in getters for all the other things needed from the .desktop file.
I'm not sure that's needed, we should have a generic "AppData" component or similar that would take an appId and expose all the data read from .desktop and potentially other places.
=====
One think we're missing is the Gettext domain to use to translate the strings. It could be considered a backend task, though.
=====
More to come.