Merge lp:~unity-team/unity8/fix-1239317 into lp:unity8
Proposed by
Andrea Cimitan
| Status: | Merged |
|---|---|
| Approved by: | Gerry Boland |
| Approved revision: | 483 |
| Merged at revision: | 496 |
| Proposed branch: | lp:~unity-team/unity8/fix-1239317 |
| Merge into: | lp:unity8 |
| Diff against target: |
11 lines (+1/-0) 1 file modified
Components/UbuntuShapeForItem.qml (+1/-0) |
| To merge this branch: | bzr merge lp:~unity-team/unity8/fix-1239317 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Gerry Boland (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Place ShaderEffectSource of UbuntuShapeForItem under the Shape Item
Description of the change
ShaderEffectSource has to be rendered on screen in order to be used by the shader (Shape from Ubuntu.Components uses it), thus it cannot be with width or height of 0 pixels, neither it can use visible: false.
Simplest solution is putting it underneath the Shape item, so it cannot be seen because it'll be under that Item.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Will have to do. When we drop SurfaceFlinger support, the ApplicationImage component will be replaced with an image provider, and thus this UbuntuShapeForItem can go away.