Code review comment for lp:~unity-team/unity8/dash-as-app

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> """
> Q_SIGNALS:
> void setCurrentScope(const QString &scopeId, bool animate, bool reset);
> """
>
> Naming signals like functions is never a good thing. I would make an effort to
> name it like a signal. "requestedScopeAsCurrent" or even
> "setCurrentScopeCalled" would do it.

That's in DashCommunicatorService and DBusDashCommunicatorService, to be clear.

« Back to merge proposal