Merge lp:~unity-team/unity/unity.bfb-reshuffle into lp:unity

[Jason Smith]

Places a BFB icon on the launcher

- Icon shows as active when dash is open
- Icon is always first item on launcher
- Icon is not desaturated when dash is open
- Icon does not (yet) have menus

[Tim Penhey (thumper)]

> BFBLauncherIcon::BFBLauncherIcon(Launcher* IconManager)
> : SimpleLauncherIcon(IconManager)

too many spaces :-)

Return type on the same line please:

nux::Color BFBLauncherIcon::BackgroundColor()
{
  return nux::Color(0xFF333333);
}

I wish we had a well defined colour rather than hard coding the values
everywhere. Are the objections to using something like
nux::color::DarkSlateGray (although it is 2F4F4F not 333333).

.cpp needs a carriage return at the end of the file.

Can you humour me and add "UNITYSHELL_" to the header include guards?
I'm trying to get people into the habit of adding the project or library bits
to the header guards.

Do you really need to declare a destructor that does nothing?

> Launcher::OnPlaceViewShow

> for (it = self->_model->begin(); it != self->_model->end(); it++)
> {
> (*it)->SetQuirk(LauncherIcon::QUIRK_DESAT, true);
> if ((*it)->Type () != LauncherIcon::TYPE_HOME)
> (*it)->SetQuirk(LauncherIcon::QUIRK_DESAT, true);
> (*it)->HideTooltip();
> }

for (auto icon : *(self->_model))
{
  icon->SetQuirk(LauncherIcon::QUIRK_DESAT, true);
  if (icon->Type () != LauncherIcon::TYPE_HOME)
    icon->SetQuirk(LauncherIcon::QUIRK_DESAT, true);
  icon->HideTooltip();
}

I have a feeling that the icons may be leaked from the LauncherController.
Not yet substantiated.

review: Needs Fixing

[Gord Allott (gordallott)]

review: Approve