Merge lp:~unity-team/unity/see-you-later-flow into lp:unity

Proposed by Michal Hruby
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 2685
Proposed branch: lp:~unity-team/unity/see-you-later-flow
Merge into: lp:unity
Diff against target: 19 lines (+3/-0)
1 file modified
dash/LensView.cpp (+3/-0)
To merge this branch: bzr merge lp:~unity-team/unity/see-you-later-flow
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
John Lea (community) design Approve
Review via email: mp+124199@code.launchpad.net

Commit message

Disable the flow renderer

Description of the change

Disables the flow renderer for now.

To post a comment you must log in.
Revision history for this message
John Lea (johnlea) :
review: Approve (design)
Revision history for this message
Andrea Azzarone (azzar1) :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1285/console reported an error when processing this lp:~unity-team/unity/see-you-later-flow branch.
Not merging it.

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1286/console reported an error when processing this lp:~unity-team/unity/see-you-later-flow branch.
Not merging it.

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

one more time...as this should be fixed...(merging wise)

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1287/console reported an error when processing this lp:~unity-team/unity/see-you-later-flow branch.
Not merging it.

Revision history for this message
Michal Hruby (mhr3) wrote :

And one last time...

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

It seems to be using the wrong compiz version...
Unpacking compiz-core (from .../compiz-core_0.9.8.2+bzr3371ubuntu0+3295_amd64.deb) ...

the fix is in 3373.. :(

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1288/console reported an error when processing this lp:~unity-team/unity/see-you-later-flow branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/LensView.cpp'
2--- dash/LensView.cpp 2012-08-31 15:46:18 +0000
3+++ dash/LensView.cpp 2012-09-13 13:32:31 +0000
4@@ -313,12 +313,15 @@
5 static_cast<ResultViewGrid*> (grid)->horizontal_spacing = CARD_VIEW_GAP_HORIZ;
6 static_cast<ResultViewGrid*> (grid)->vertical_spacing = CARD_VIEW_GAP_VERT;
7 }
8+ /*
9+ * The flow renderer is disabled for now, expecting return later
10 else if (renderer_name == "flow" && nux::GetWindowThread()->GetGraphicsEngine().UsingGLSLCodePath())
11 {
12 grid = new CoverflowResultView(NUX_TRACKER_LOCATION);
13 grid->SetModelRenderer(new ResultRendererTile(NUX_TRACKER_LOCATION));
14 group->SetHeaderCountVisible(false);
15 }
16+ */
17 else
18 {
19 grid = new ResultViewGrid(NUX_TRACKER_LOCATION);