Merge lp:~unity-team/unity/python3-ready into lp:unity

Proposed by Marco Trevisan (Treviño)
Status: Superseded
Proposed branch: lp:~unity-team/unity/python3-ready
Merge into: lp:unity
Diff against target: 2540 lines (+1895/-201)
12 files modified
AUTHORS (+29/-83)
CMakeLists.txt (+69/-56)
ChangeLog (+1721/-0)
UnityCore/Scope.h (+1/-1)
dash/previews/CMakeLists.txt (+6/-6)
debian/changelog (+13/-0)
debian/control (+4/-2)
debian/rules (+5/-8)
launcher/LauncherController.cpp (+4/-0)
tests/CMakeLists.txt (+1/-1)
tools/unity.cmake (+37/-38)
unity-shared/BamfApplicationManager.cpp (+5/-6)
To merge this branch: bzr merge lp:~unity-team/unity/python3-ready
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Unity Team Pending
Review via email: mp+276745@code.launchpad.net

Commit message

unity: ensure we use python3 for the launch script and python2.7 for autopilot

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AUTHORS'
2--- AUTHORS 2015-03-19 15:03:58 +0000
3+++ AUTHORS 2015-11-05 11:18:29 +0000
4@@ -1,59 +1,52 @@
5- 3v1n0 <mail@3v1n0.net>, Marco Trevisan (Treviño) <mail@3v1n0.net>
6+ 3v1n0 <mail@3v1n0.net>
7 Adam Conrad <adconrad@0c3.net>
8 agateau <aurelien.gateau@canonical.com>
9 alanbell@ubuntu.com
10+ Alan Pope <alan.pope@canonical.com>
11 Albert Astals <albert.astals@canonical.com>
12- Albert Astals <albert.astals@canonical.com>, Christopher Lee <chris.lee@canonical.com>, Christopher Lee <veebers@gmail.com>
13- Albert Astals <albert.astals@canonical.com>, Timo Jyrinki <timo.jyrinki@canonical.com>, Brandon Schaefer <brandon.schaefer@canonical.com>, Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>, MC Return <mc.return@gmx.net>, Didier Roche <didier.roche@canonical.com>, Andrea Azzarone <azzaronea@gmail.com>
14 Alejandro Piñeiro <apinheiro@igalia.com>
15- Alejandro Piñeiro <apinheiro@igalia.com>, Andrea Azzarone <azzaronea@gmail.com>
16+ Alexander Fougner <fougner89@gmail.com>
17 Alexandre Abreu <alexandre.abreu@canonical.com>
18 Alexandros Frantzis <alexandros.frantzis@linaro.org>
19- Alexandros Frantzis <alexandros.frantzis@linaro.org>, Marc Ordinas i Llopis <marc.ordinasillopis@linaro.org>, Jay Taoko <jay.taoko@canonical.com>
20 Alex Launi <alex.launi@canonical.com>
21- Alex Launi <alex.launi@canonical.com>, Allan LeSage <allanlesage@gmail.com>
22- Alex Launi <alex.launi@canonical.com>, Thomi Richards <thomi.richards@canonical.com>
23 Alfred Neumayer <dev.beidl@gmail.com>
24+ Allan LeSage <allanlesage@gmail.com>
25 Andrea Azzarone
26+ Andrea Azzarone andrea.azzarone@canonical.com
27 Andrea Azzarone <azzaronea@gmail.com>
28 Andrea Cimitan <andrea.cimitan@canonical.com>
29 Andrew Gaul <andrew@gaul.org>
30 Andrew McCarthy <me@andrewmccarthy.ie>
31 Andrey Logvinov <Andrey.Logvinov.81@gmail.com
32+ Angel Guzman Maeso <angel@quijost.com>
33+ asmoore82 <asmoore82@gmail.com>
34 Aurélien Gâteau <aurelien.gateau@canonical.com>
35+ Automatic PS uploader <ps-jenkins@lists.canonical.com>
36 Benjamin Kerensa <bkerensa@ubuntu.com>
37 Bilal Akhtar <bilalakhtar@ubuntu.com>
38- Bilal Akhtar <bilalakhtar@ubuntu.com>, Thomi Richards <thomi.richards@canonical.com>
39+ Bowmore <bowmores@telia.com>
40 Brandon Schaefer <brandon.schaefer@canonical.com>
41- Brandon Schaefer <brandon.schaefer@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>
42- Brandon Schaefer <brandon.schaefer@canonical.com>, MC Return <mc.return@gmx.net>
43- Brandon Schaefer <brandon.schaefer@canonical.com>, Nick Dedekind <nicholas.dedekind@gmail.com>
44 Brandon Schaefer <brandontschaefer@gmail.com
45 Brandon Schaefer <brandontschaefer@gmail.com>
46- Brandon Schaefer <brandontschaefer@gmail.com, Brandon Schaefer <brandontschaefer@gmail.com>
47- Brandon Schaefer <brandontschaefer@gmail.com, Jay Taoko <jay.taoko@canonical.com>
48- Brandon Schaefer <brandontschaefer@gmail.com>, Marco Trevisan (Treviño) <mail@3v1n0.net>
49- Brandon Schaefer <brandontschaefer@gmail.com>, Thomi Richards <thomi.richards@canonical.com>
50 Brandon Schaefer <schbra02@evergreen.edu>
51+ Cameron Hart <cam@bitshifter.net.nz>
52 Charles Kerr <charles.kerr@canonical.com>
53- Charles Kerr <charles.kerr@canonical.com>, Andrea Azzarone <azzaronea@gmail.com>
54 Chase Douglas <chase.douglas@canonical.com>
55 Chris Coulson <chris.coulson@canonical.com>
56 chris.gagnon <chris.gagnon@canonical.com>
57 Christopher James Halse Rogers <raof@ubuntu.com>
58 Christopher Lee <chris.lee@canonical.com>
59- Christopher Lee <chris.lee@canonical.com>, Thomi Richards <thomi.richards@canonical.com>
60 Christopher Lee <veebers@gmail.com>
61 Christopher Townsend <christopher.townsend@canonical.com>
62 Chris Townsend <christopher.townsend@canonical.com>
63 Daniel d'Andrada <daniel.dandrada@canonical.com>
64 Daniel van Vugt <vanvugt@gmail.com>
65- David Barth <david.barth@canonical.com>
66 David Gomes <davidrafagomes@gmail.com>
67 David Planella <david.planella@ubuntu.com>
68 Didier Roche <didier.roche@canonical.com>
69- Didier Roche <didier.roche@canonical.com>, Sebastien Bacher <seb128@ubuntu.com>, Marco Trevisan (Treviño) <mail@3v1n0.net>, Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>, Didier Roche <didrocks@ubuntu.com>, Neil Jagdish Patel <neil.patel@canonical.com>
70 Didier Roche <didrocks@ubuntu.com>
71+ Diego Sarmentero <diego.sarmentero@canonical.com>
72+ Diego Sarmentero <diego.sarmentero@gmail.com>
73 Dimitri John Ledkov <dimitri.ledkov@canonical.com>
74 Dimitri John Ledkov <xnox@ubuntu.com>
75 Eleni Maria Stea <elene.mst@gmail.com>
76@@ -64,63 +57,45 @@
77 Gabor Kelemen <kelemeng@ubuntu.com>
78 Gary Lasker <gary.lasker@canonical.com>
79 George Karavasilev <motorslav@gmail.com>
80+ Gerry Boland <gerry.boland@canonical.com>
81 Gordon Allott <gord.allott@canonical.com>
82 handsome_feng<445865575@qq.com>
83 Henri De Veene <henri.deveene@gmail.com>
84 Iain Lane <iain.lane@canonical.com>
85- Iain Lane <iain.lane@canonical.com>, Iain Lane <iain@orangesquash.org.uk>
86+ Iain Lane <iain@orangesquash.org.uk>
87 Jacob Edwards
88- Jani Monoses <jani.monoses@canonical.com>
89+ James Henstridge <james@jamesh.id.au>
90 Jani Monoses <jani@ubuntu.com>
91 Jason Conti <jason.conti@gmail.com>
92 Jason Smith <jason.smith@canonical.com>
93- Jason Smith <jason.smith@canonical.com>, Andrea Cimitan <andrea.cimitan@canonical.com>
94- Jason Smith <jason.smith@canonical.com>, Gordon Allott <gord.allott@canonical.com>
95- Jason Smith <jason.smith@canonical.com>, Jay Taoko <jay.taoko@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>
96- Jason Smith <jason.smith@canonical.com>, Marco Trevisan (Treviño) <mail@3v1n0.net>, Thomi Richards <thomi.richards@canonical.com>
97- Jason Smith <jason.smith@canonical.com>, smspillaz <sam.spilsbury@canonical.com>
98- Jason Smith <jason.smith@canonical.com>, Tim Penhey <tim.penhey@canonical.com>
99- jassmith@gmail.com
100 Jay Ó Broin <ismise@lavabit.com>
101 Jay Taoko <jay.taoko@canonical.com>
102- Jay Taoko <jay.taoko@canonical.com>, Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
103- Jay Taoko <jay.taoko@canonical.com>, Mirco Müller <mirco.mueller@ubuntu.com>
104- Jay Taoko <jay.taoko@canonical.com>, Robert Carr <racarr@canonical.com>
105 Jeremy Bicha <jbicha@ubuntu.com>
106 Jinkyu Yi <jincreator@jincreator.net>
107 jokerdino@bvm128.zdom.org
108+ Jonas Schwabe
109 Jussi Pakkanen <jussi.pakkanen@canonical.com>
110 Ken VanDine <ken.vandine@canonical.com>
111- Ken VanDine <ken.vandine@canonical.com>, Nick Dedekind <nicholas.dedekind@gmail.com>
112 Kevin DuBois <kevin.dubois@canonical.com>
113 Koichi Akabe <vbkaisetsu@gmail.com>
114+ Lars Uebernickel <lars@uebernic.de>
115 Lars Uebernickel <lars.uebernickel@canonical.com>
116 Leo Arias <leo.arias@canonical.com>
117- Loïc Molinari <loic.molinari@canonical.com>
118 Lorenzo Mattei <lore.mattei@gmail.com>
119+ Lukas Vacek <lucas.vacek@gmail.com>
120 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
121 Luke Yelavich <luke.yelavich@canonical.com>
122 Manuel de la Pena <manuel@canonical.com>
123- Manuel de la Pena <manuel@canonical.com>, Nick Dedekind <nicholas.dedekind@gmail.com>, Pawel Stolowski <pawel.stolowski@canonical.com>, Michal Hruby <michal.mhr@gmail.com>, Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>, Marco Trevisan (Treviño) <mail@3v1n0.net>, Automatic PS uploader <ps-jenkins@lists.canonical.com>, Chris Townsend <christopher.townsend@canonical.com>, Andrea Azzarone <azzaronea@gmail.com>
124+ Manuel Nicetto <manuel.nicetto@gmail.com>
125 Marc Deslauriers <marc.deslauriers@ubuntu.com>
126 Marco Biscaro <marcobiscaro2112@gmail.com>
127- Marco Biscaro <marcobiscaro2112@gmail.com>, Rick Spencer <rick.spencer@canonical.com>
128- Marco Mariani <dfly720@gmail.com>, Thomi Richards <thomi.richards@canonical.com>
129+ Marco Mariani <dfly720@gmail.com>
130+ Marc Ordinas i Llopis <marc.ordinasillopis@linaro.org>
131 Marco Trevisan
132 Marco Trevisan <mail@3v1n0.net>
133 Marco Trevisan <marco.trevisan@canonical.com>
134+ Marco Trevisan (Treviño)
135 Marco Trevisan (Treviño) <mail@3v1n0.net>
136- Marco Trevisan (Treviño) <mail@3v1n0.net>, 3v1n0 <mail@3v1n0.net>
137- Marco Trevisan (Treviño) <mail@3v1n0.net>, Andrea Azzarone <azzaronea@gmail.com>
138- Marco Trevisan (Treviño) <mail@3v1n0.net>, Andrea Cimitan <andrea.cimitan@canonical.com>
139- Marco Trevisan (Treviño) <mail@3v1n0.net>, Brandon Schaefer <brandon.schaefer@canonical.com>
140- Marco Trevisan (Treviño) <mail@3v1n0.net>, Brandon Schaefer <brandontschaefer@gmail.com>, Tim Penhey <tim.penhey@canonical.com>
141- Marco Trevisan (Treviño) <mail@3v1n0.net>, Eleni Maria Stea <elenimaria.stea@canonical.com>
142- Marco Trevisan (Treviño) <mail@3v1n0.net>, Lukas Vacek <lucas.vacek@gmail.com>
143- Marco Trevisan (Treviño) <mail@3v1n0.net>, Michal Hruby <michal.mhr@gmail.com>
144- Marco Trevisan (Treviño) <mail@3v1n0.net>, Sam Spilsbury <sam.spilsbury@canonical.com>
145- Marco Trevisan (Treviño) <mail@3v1n0.net>, Thomi Richards <thomi.richards@canonical.com>
146- Marco Trevisan (Treviño), Marco Trevisan (Treviño) <mail@3v1n0.net>
147 Marius Gedminas <marius@gedmin.as>
148 Martin Albisetti <argentina@gmail.com>
149 Martin Mrazik <martin.mrazik@canonical.com>
150@@ -129,9 +104,11 @@
151 Martin Pitt <martin.pitt@ubuntu.com>
152 Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
153 Matthias Alles
154+ Matthieu Baerts <matttbe@gmail.com>
155 Matthieu James <matthieu.james@canonical.com>
156 Maxim Ermilov <maxim.ermilov@canonical.com>
157 MC Return <mc.return@gmx.net>
158+ Michael Hofmann <mh21@piware.de>
159 Michael Rawson <michaelrawson76@gmail.com>
160 Michael Terry <michael.terry@canonical.com>
161 Michael Terry <mike@mterry.name>
162@@ -140,87 +117,56 @@
163 Michal Hruby <michal.mhr@gmail.com>
164 Michi Henning <michi.henning@canonical.com>
165 Mikkel Kamstrup Erlandsen <mikkel.kamstrup@gmail.com>
166+ Miklos Juhasz <juhasz.miklos.1@gmail.com>
167 Mirco Müller <mirco.mueller@ubuntu.com>
168 Mitsuya Shibata
169 Neil Jagdish Patel <neil.patel@canonical.com>
170 Nic d'Offay <nicolas.doffay@canonical.com>
171 Nick Dedekind <nicholas.dedekind@gmail.com>
172- Nick Dedekind <nicholas.dedekind@gmail.com>, Gordon Allott <gord.allott@canonical.com>
173- Nick Dedekind <nicholas.dedekind@gmail.com>, Michal Hruby <michal.mhr@gmail.com>
174 Nick Dedekind <nick.dedekind@canonical.com>
175- Nick Dedekind <nick.dedekind@canonical.com>, Christopher Lee <chris.lee@canonical.com>
176 Nicolas Delvaux <contact@nicolas-delvaux.org>
177 Nicolas d'Offay <nicolas.doffay@canonical.com>
178- Nicolas d'Offay <nicolas.doffay@canonical.com>, Nic d'Offay <nicolas.doffay@canonical.com>, Neil Jagdish Patel <neil.patel@canonical.com>
179 Nico van der Walt <nico@kimburu.co.za>
180 Niklas Steger <niklas.steger@gmx.net>
181+ Oier Mees <oier.mees@gmail.com>
182+ Oliver Grawert <ogra@ubuntu.com>
183 Oliver Sauder <os@esite.ch>
184 Omer Akram <om26er@ubuntu.com>
185 Omer Akram <omer.akram@canonical.com>
186 Paolo Rotolo <paolorotolo@ubuntu.com>
187 Paolo Rotolo <paolorotolo@ubuntu-it.org>
188 Paul Sladen <sladen@canonical.com>
189- Paul Sladen <sladen@canonical.com>, Andrea Cimitan <andrea.cimitan@canonical.com>
190 Pawel Stolowski <pawel.stolowski@canonical.com>
191- Pawel Stolowski <pawel.stolowski@canonical.com>, Michal Hruby <michal.mhr@gmail.com>
192 Pawel Stolowski <stolowski@gmail.com>
193 Pawel Szubert
194 Rafał Cieślak <rafalcieslak256@gmail.com>
195 Renato Araujo Oliveira Filho <renato.filho@canonical.com>
196 Ricardo Mendoza <ricardo.mendoza@canonical.com>
197 Ricardo Salveti de Araujo <ricardo.salveti@canonical.com>
198+ Rick Spencer <rick.spencer@canonical.com>
199 Robert Ancell <robert.ancell@canonical.com>
200 Robert Carr <racarr@canonical.com>
201- Robert Carr <racarr@canonical.com>, Ken VanDine <ken.vandine@canonical.com>
202 Robert Carr <robert.carr@canonical.com>
203- Rodrigo Moya <rodrigo.moya@canonical.com>
204 Romain Perier <rperier@ubuntu.com>
205 Ryan Lortie <desrt@desrt.ca>
206 Sami Jaktholm <sjakthol@outlook.com>
207 Sam Spilsbury <sam.spilsbury@canonical.com>
208- Sam Spilsbury <sam.spilsbury@canonical.com>, Andrea Azzarone <azzaronea@gmail.com>
209- Sam Spilsbury <sam.spilsbury@canonical.com>, Daniel van Vugt <vanvugt@gmail.com>
210- Sam Spilsbury <sam.spilsbury@canonical.com>, Didier Roche <didier.roche@canonical.com>
211- Sam Spilsbury <sam.spilsbury@canonical.com>, Michal Hruby <michal.mhr@gmail.com>
212 Sebastien Bacher <seb128@ubuntu.com>
213 smspillaz <sam.spilsbury@canonical.com>
214- smspillaz <sam.spilsbury@canonical.com>, Daniel van Vugt <vanvugt@gmail.com>
215- smspillaz <sam.spilsbury@canonical.com>, Sam Spilsbury <sam.spilsbury@canonical.com>
216 Stephen M. Webb <stephen.webb@canonical.com>
217 Steve Langasek <steve.langasek@canonical.com>
218 Sven Baars <svenb.linux@gmail.com>
219 Ted Gould <ted@gould.cx>
220- Thomas Voß <thomas.voss@canonical.com>, Didier Roche <didier.roche@canonical.com>
221+ Thomas Voß <thomas.voss@canonical.com>
222 Thomas Voß <thomas.voss@rub.de>
223 Thomi Richards <thomir@gmail.com>
224- Thomi Richards <thomir@gmail.com>, Alex Launi <alex.launi@canonical.com>
225- Thomi Richards <thomir@gmail.com>, Thomi Richards <thomi.richards@canonical.com>
226 Thomi Richards <thomi.richards@canonical.com>
227- Thomi Richards <thomi.richards@canonical.com>, Albert Astals <albert.astals@canonical.com>
228- Thomi Richards <thomi.richards@canonical.com>, Alex Launi <alex.launi@canonical.com>
229- Thomi Richards <thomi.richards@canonical.com>, Brandon Schaefer <brandon.schaefer@canonical.com>
230- Thomi Richards <thomi.richards@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>
231- Thomi Richards <thomi.richards@canonical.com>, Christopher Lee <chris.lee@canonical.com>
232- Thomi Richards <thomi.richards@canonical.com>, Gordon Allott <gord.allott@canonical.com>
233- Thomi Richards <thomi.richards@canonical.com>, Jason Smith <jason.smith@canonical.com>
234- Thomi Richards <thomi.richards@canonical.com>, Miklos Juhasz <juhasz.miklos.1@gmail.com>
235- Thomi Richards <thomi.richards@canonical.com>, Ted Gould <ted@gould.cx>
236- Thomi Richards <thomi.richards@canonical.com>, Thomi Richards <thomir@gmail.com>
237- Thomi Richards <thomi.richards@canonical.com>, Tim Penhey <tim.penhey@canonical.com>
238 Tigran Gabrielyan <tigrangab@gmail.com>
239- Tim Lunn <tim@feathertop.org>
240 timo.jyrinki@canonical.com
241 Timo Jyrinki <timo.jyrinki@canonical.com>
242 Tim Penhey <tim.penhey@canonical.com>
243- Tim Penhey <tim.penhey@canonical.com>, Bowmore <bowmores@telia.com>
244- Tim Penhey <tim.penhey@canonical.com>, Gordon Allott <gord.allott@canonical.com>
245- Tim Penhey <tim.penhey@canonical.com>, Jason Smith <jason.smith@canonical.com>
246- Tim Penhey <tim.penhey@canonical.com>, Jay Taoko <jay.taoko@canonical.com>
247- Tim Penhey <tim.penhey@canonical.com>, Neil Jagdish Patel <neil.patel@canonical.com>
248 Ugo Riboni <ugo.riboni@canonical.com>
249- Unity Merger <unity.merger@gmail.com>
250 Victor Eduardo <victormartinez79@gmail.com>
251- William Grant <william.grant@canonical.com>
252 William Hua <william.hua@canonical.com>
253 Xiao-Long Chen <chenxiaolong@cxl.epac.to>
254 Zaid Yeganeh <zaid.yeganeh@gmail.com>
255
256=== modified file 'CMakeLists.txt'
257--- CMakeLists.txt 2015-09-30 20:58:41 +0000
258+++ CMakeLists.txt 2015-11-05 11:18:29 +0000
259@@ -9,8 +9,8 @@
260 #
261 set (PROJECT_NAME "unity")
262 set (UNITY_MAJOR 7)
263-set (UNITY_MINOR 3)
264-set (UNITY_MICRO 2)
265+set (UNITY_MINOR 4)
266+set (UNITY_MICRO 0)
267 set (UNITY_VERSION "${UNITY_MAJOR}.${UNITY_MINOR}.${UNITY_MICRO}")
268 set (UNITY_API_VERSION "6.0")
269 set (UNITY_COMPONENTS_VERSION "6")
270@@ -25,6 +25,12 @@
271 ON
272 )
273
274+option(
275+ ENABLE_UNIT_TESTS
276+ "Enable Unity Unit Tests"
277+ ON
278+)
279+
280 # This is due to bug lp:668799 - qemu-arm segfaults executing msgmerge
281 option(
282 I18N_SUPPORT
283@@ -101,7 +107,7 @@
284 && echo "• Generating ChangeLog"
285 && bzr log --gnu-changelog > ChangeLog
286 && echo "• Generating AUTHORS"
287- && bzr log --long --levels=0 | grep -e "^\\s*author:" -e "^\\s*committer:" | cut -d ":" -f 2 | sed -r -f AUTHOR-glue | sort -u > AUTHORS
288+ && bzr log --long --levels=0 | grep -e "^\\s*author:" | cut -d ":" -f 2 | sed "s/,/\n/g" | sed -r -f AUTHOR-glue | sort -u | uniq -i > AUTHORS
289 && echo "• Running Distcheck"
290 )
291
292@@ -226,7 +232,7 @@
293 gtk+-3.0>=3.1
294 indicator3-0.4>=0.4.90
295 json-glib-1.0
296- libbamf3>=0.5.0
297+ libbamf3>=0.5.2
298 gnome-desktop-3.0
299 libnotify
300 libstartup-notification-1.0
301@@ -260,6 +266,7 @@
302 add_subdirectory(dash)
303 add_subdirectory(launcher)
304 add_subdirectory(data)
305+
306 if (ENABLE_X_SUPPORT)
307 add_subdirectory(hud)
308 add_subdirectory(lockscreen)
309@@ -273,65 +280,71 @@
310 add_subdirectory(unity-standalone)
311 endif ()
312
313-# subdirs
314 add_subdirectory(doc)
315-
316-# Check for google test and build it locally
317-set (
318- GMOCK_ROOT_DIR
319- "/usr/src/gmock"
320- CACHE
321- PATH
322- "Path to Google mock srcs"
323-)
324-
325-set (
326- GMOCK_INCLUDE_DIR
327- "/usr/include/gmock/include"
328- CACHE
329- PATH
330- "Path to Google mock include"
331-)
332-
333-set(
334- GTEST_ROOT_DIR
335- "${GMOCK_ROOT_DIR}/gtest" # Default value, adjustable by user with e.g., ccmake
336- CACHE
337- PATH
338- "Path to Google test srcs"
339-)
340-
341-set(
342- GTEST_INCLUDE_DIR
343- "${GMOCK_ROOT_DIR}/gtest/include"
344- CACHE
345- PATH
346- "Path to Google tests include"
347-)
348-
349-if (GTEST_INCLUDE_DIR AND GMOCK_INCLUDE_DIR)
350- include_directories (
351- ${GMOCK_INCLUDE_DIR}
352- ${GTEST_INCLUDE_DIR}
353- )
354- add_subdirectory(
355- ${GMOCK_ROOT_DIR}
356- "${CMAKE_CURRENT_BINARY_DIR}/gmock"
357- )
358-elseif (GTEST_INCLUDE_DIR AND NOT GMOCK_INCLUDE_DIR)
359- include_directories (
360- ${GTEST_INCLUDE_DIR}
361- )
362-endif(GTEST_INCLUDE_DIR AND GMOCK_INCLUDE_DIR)
363-
364 add_subdirectory(services)
365-add_subdirectory(tests)
366 add_subdirectory(tools)
367 add_subdirectory(UnityCore)
368 add_subdirectory(guides)
369-
370 add_subdirectory(gnome)
371
372+if (ENABLE_UNIT_TESTS)
373+ # Check for google test and build it locally
374+ set (
375+ GMOCK_ROOT_DIR
376+ "/usr/src/gmock"
377+ CACHE
378+ PATH
379+ "Path to Google mock srcs"
380+ )
381+
382+ set (
383+ GMOCK_INCLUDE_DIR
384+ "/usr/include/gmock/include"
385+ CACHE
386+ PATH
387+ "Path to Google mock include"
388+ )
389+
390+ set(
391+ GTEST_ROOT_DIR
392+ "${GMOCK_ROOT_DIR}/gtest" # Default value, adjustable by user with e.g., ccmake
393+ CACHE
394+ PATH
395+ "Path to Google test srcs"
396+ )
397+
398+ set(
399+ GTEST_INCLUDE_DIR
400+ "${GMOCK_ROOT_DIR}/gtest/include"
401+ CACHE
402+ PATH
403+ "Path to Google tests include"
404+ )
405+
406+ if (GTEST_INCLUDE_DIR AND GMOCK_INCLUDE_DIR)
407+ include_directories (
408+ ${GMOCK_INCLUDE_DIR}
409+ ${GTEST_INCLUDE_DIR}
410+ )
411+ add_subdirectory(
412+ ${GMOCK_ROOT_DIR}
413+ "${CMAKE_CURRENT_BINARY_DIR}/gmock"
414+ )
415+ elseif (GTEST_INCLUDE_DIR AND NOT GMOCK_INCLUDE_DIR)
416+ include_directories (
417+ ${GTEST_INCLUDE_DIR}
418+ )
419+ endif(GTEST_INCLUDE_DIR AND GMOCK_INCLUDE_DIR)
420+
421+ add_subdirectory(tests)
422+
423+else (ENABLE_UNIT_TESTS)
424+ set (MISSING_TESTS_MSG "-- Tests disabled, compile with -DENABLE_UNIT_TESTS=ON")
425+ add_custom_target (check COMMAND echo ${MISSING_TESTS_MSG})
426+ add_custom_target (check-headless COMMAND echo ${MISSING_TESTS_MSG})
427+ add_custom_target (gcheck COMMAND echo ${MISSING_TESTS_MSG})
428+endif (ENABLE_UNIT_TESTS)
429+
430 #
431 # GSettings Schema
432 #
433
434=== modified file 'ChangeLog'
435--- ChangeLog 2015-03-19 15:03:58 +0000
436+++ ChangeLog 2015-11-05 11:18:29 +0000
437@@ -1,3 +1,1724 @@
438+2015-10-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
439+
440+ Upstream release 7.3.3
441+
442+2015-10-16 Andrea Azzarone <azzaronea@gmail.com>
443+
444+ Avoid test failures on jenkins.
445+ Approved by: Marco Trevisan (Treviño)
446+
447+2015-10-13 Andrea Azzarone <azzaronea@gmail.com>
448+
449+ Avoid test failures on jenkins.
450+
451+2015-10-16 CI Train Bot <ci-train-bot@canonical.com>
452+
453+ UnityScreen: close the session dialog in case it's open and we're requested to lock
454+
455+ Otherwise a grab conflict will will cause the lockscreen not to show up. Fixes: #1505234
456+ Approved by: Andrea Azzarone
457+
458+2015-10-16 Marco Trevisan (Treviño) <mail@3v1n0.net>
459+
460+ PanelService: ensure that we free the "fake" IndicatorEntry's we create for dropdowns Fixes: #1503348
461+ Approved by: Andrea Azzarone
462+
463+2015-10-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
464+
465+ PanelService: don't hide 'l' list parameter with another one
466+
467+2015-10-06 Marco Trevisan (Treviño) <mail@3v1n0.net>
468+
469+ PanelService: remove a dropdown IndicatorEntry if not shown anymore
470+
471+ When its geometry is not valid anymore we can assume it's not needed.
472+
473+2015-10-06 Marco Trevisan (Treviño) <mail@3v1n0.net>
474+
475+ PanelService: ensure that we free the "fake" IndicatorEntry's we create for dropdowns
476+
477+2015-10-16 Marco Trevisan (Treviño) <mail@3v1n0.net>
478+
479+ LauncherIcon: force lookup icon by scaling it at the requested size
480+
481+ As bonus, remove unused GtkWrapper class Fixes: #1446081, #1501973
482+ Approved by: Andrea Azzarone
483+
484+2015-10-05 Marco Trevisan (Treviño) <mail@3v1n0.net>
485+
486+ GtkWrapper: remove it as it's not needed anymore
487+
488+2015-10-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
489+
490+ Use GTK_ICON_LOOKUP_FORCE_SIZE when loading icons everywhere
491+
492+2015-10-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
493+
494+ LauncherIcon: force lookup icon by scaling it at the requested size
495+
496+2015-10-16 Marco Trevisan (Treviño) <mail@3v1n0.net>
497+
498+ ResultRendererTile: consider global scaling when scaling a not-squared icon Fixes: #1499286
499+ Approved by: Andrea Azzarone
500+
501+2015-10-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
502+
503+ ResultRendererTile: consider global scaling when scaling a not-squared icon
504+
505+2015-10-16 Marco Trevisan (Treviño) <mail@3v1n0.net>
506+
507+ TestDash: Use local results in PreviewNavigateTests instead of online ones
508+
509+ They're just more reliable
510+ Approved by: Andrea Azzarone
511+
512+2015-10-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
513+
514+ TestMain: unset UPSTART_SESSION not to mess with real system
515+
516+2015-10-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
517+
518+ TestLauncher: no need to wait pending events here, there's no async call involved
519+
520+2015-10-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
521+
522+ TestIconLoader: wait pending events before on TearDown
523+
524+2015-10-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
525+
526+ UpstartWrapper: start in test-mode if UPSTART_SESSION is not defined
527+
528+2015-10-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
529+
530+ TestDash: Use local results in PreviewNavigateTests instead of online ones
531+
532+ They're just more reliable
533+
534+2015-10-16 Marco Trevisan (Treviño) <mail@3v1n0.net>
535+
536+ UnityScreen: close the session dialog in case it's open and we're requested to lock
537+
538+ Otherwise a grab conflict will will cause the lockscreen not to show up. Fixes: #1505234
539+ Approved by: Andrea Azzarone
540+
541+2015-10-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
542+
543+ debian/changelog: sync with proposed
544+
545+2015-10-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
546+
547+ UnityScreen: close the session dialog in case it's open and we're requested to lock
548+
549+ Otherwise a grab conflict will will cause the lockscreen not to show up.
550+
551+2015-10-02 CI Train Bot <ci-train-bot@canonical.com>
552+
553+ Releasing 7.3.2+15.10.20151002.2-0ubuntu1
554+
555+2015-10-02 Marco Trevisan (Treviño) <mail@3v1n0.net>
556+
557+ GnomeKeyGrabber: Don't allow an action to be grabbed multiple times
558+
559+ And always return the same action id for a specific key binding. Fixes: #1459571
560+ Approved by: Andrea Azzarone
561+
562+2015-10-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
563+
564+ GnomeKeyGrabber: use some better naming for variables and methods
565+
566+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
567+
568+ TestGnomeSessionManager: mark NoLockWhenLockingDisabled as unstable
569+
570+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
571+
572+ TestUtils: define UNSTABLE_TEST macro, and disable unstable tests on release
573+
574+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
575+
576+ CMakeLists.txt: define UNITY_DEBUG_BUILD when building with debug flag
577+
578+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
579+
580+ GnomeKeyGrabber: don't re-check for method parameters type
581+
582+ That's already checked at lower level
583+
584+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
585+
586+ TestIconLoader: enable some disabled tests
587+
588+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
589+
590+ TestGDBusProxy: make tests more robusts when using a cancellable
591+
592+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
593+
594+ GnomeKeyGrabber: emit the AcceleratorActivated to all the subscribers for that action
595+
596+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
597+
598+ GnomeKeyGrabber: don't use overloaded functions, just use different names
599+
600+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
601+
602+ GnomeKeyGrabberTests: fix tests to match current behavior
603+
604+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
605+
606+ GnomeKeyGrabber: don't remove an action if shared by multiple senders
607+
608+ If an action is used by multiple applications, we don't remove it until we don't
609+ have customers for that.
610+ Added some more debug logging.
611+
612+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
613+
614+ GnomeKeyGrabber: don't allow any client to Ungrab an accelerator requested from different sender
615+
616+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
617+
618+ StandalonePanel: fix KeyGrabber definition
619+
620+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
621+
622+ TestMainDBus: use glib::DBusNameWatcher
623+
624+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
625+
626+ GnomeKeyGrabber: only emit AcceleratorActivated signal to the requestor.
627+
628+ Also, delete actions when the name-owner vanished.
629+
630+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
631+
632+ GLibDBusNameWatcher: new wrapper class for monitoring DBus names
633+
634+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
635+
636+ KeyGrabber: update implementations with new interface
637+
638+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
639+
640+ GLibDBusServer: implement SetMethodsCallsHandlerFull
641+
642+2015-09-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
643+
644+ GnomeKeyGrabber: return always the same action ID for a keybinding
645+
646+2015-09-29 Marco Trevisan (Treviño) <mail@3v1n0.net>
647+
648+ GnomeKeyGrabber: Don't allow an action to be grabbed multiple times
649+
650+2015-09-29 Marco Trevisan (Treviño) <mail@3v1n0.net>
651+
652+ MenuManager: use action IDs instead of storing actions
653+
654+2015-09-29 Marco Trevisan (Treviño) <mail@3v1n0.net>
655+
656+ KeyGrabber: return action IDs and add ability to remove an action by ID
657+
658+2015-09-29 Marco Trevisan (Treviño) <mail@3v1n0.net>
659+
660+ GnomeKeyGrabber: simpify code, just use two vector for keeping track of actions
661+
662+ Unfortunately we can't use pointers here as CompAction's are statically allocated
663+
664+2015-09-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
665+
666+ GLibDBusServer: allow to emit a signal to a single listener
667+
668+2015-09-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
669+
670+ glib::Object: add SetMethodsCallsHandlerFull to get all call parameters
671+
672+2015-10-02 Marco Trevisan (Treviño) <mail@3v1n0.net>
673+
674+ PanelService, DBusIndicators: drop support for EntryShowNowChanged signal
675+
676+ We do handle this internally inside unity since long time now, so there's no need
677+ bother the bus for such thing.
678+ Approved by: Andrea Azzarone
679+
680+2015-10-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
681+
682+ PanelService, DBusIndicators: drop support for EntryShowNowChanged signal
683+
684+ We do handle this internally inside unity since long time now, so there's no need
685+ bother the bus for such thing.
686+
687+2015-09-21 CI Train Bot <ci-train-bot@canonical.com>
688+
689+ Releasing 7.3.2+15.10.20150921-0ubuntu1
690+
691+2015-09-21 Iain Lane <iain@orangesquash.org.uk>
692+
693+ launcher: Always make sure we check the right file when seeing if .desktop files have been deleted. Fixes disappearing launcher icons when applications are upgraded when we are using glib > 2.44. Fixes: #1498106
694+ Approved by: Marco Trevisan (Treviño)
695+
696+2015-09-21 Iain Lane <iain@orangesquash.org.uk>
697+
698+ one more place
699+
700+2015-09-21 Iain Lane <iain@orangesquash.org.uk>
701+
702+ No need to ref it explicitly, this is done for us
703+
704+2015-09-18 Iain Lane <iain@orangesquash.org.uk>
705+
706+ launcher: Always make sure we check the right file when seeing if .desktop files have been deleted.
707+
708+ We were checking the GFile which came in via the changed signal, but sometimes
709+ (e.g. for paired delete/create events caused by moves), this can be a file that
710+ is being moved onto our target.
711+
712+ Always check the target file that we wateched initially.
713+
714+ This fixes disappearing launcher icons when applications are updated with glib
715+ > 2.44.
716+
717+2015-09-21 Andrea Azzarone <azzaronea@gmail.com>
718+
719+ Avoid to open adjacent menu when moving from an indicator icon to its dropdown menu. Fixes: #552920
720+ Approved by: Marco Trevisan (Treviño)
721+
722+2015-09-21 Andrea Azzarone <azzaronea@gmail.com>
723+
724+ Minor changes.
725+
726+2015-09-21 Andrea Azzarone <azzaronea@gmail.com>
727+
728+ Merging with trunk.
729+
730+2015-08-11 Andrea Azzarone andrea.azzarone@canonical.com
731+
732+ Avoid to open adjacent menu when moving from an indicator icon to its dropdown menu.
733+
734+2015-09-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
735+
736+ MenuManager: add a new setting to control the show-now delay Fixes: #1497915
737+ Approved by: Andrea Azzarone
738+
739+2015-09-17 Marco Trevisan (Treviño) <mail@3v1n0.net>
740+
741+ MenuManager: add a new setting to control the show-now delay
742+
743+2015-09-21 Lars Uebernickel <lars@uebernic.de>
744+
745+ DevicesSettingsImp: dont't feed garbage to gsettings
746+
747+ Use a const reference for the iteration variable in the loop over _blacklist so that the pointers returned from c_str() are still valid when feeding them to g_settings_set_strv().
748+
749+ In the best case, this only wrote garbage to the "blacklist" key (making that setting useless). In the worst case, it led to a crash because the garbage was invalid utf8, which gsettings refuses to accept.
750+
751+ Fixes LP: #1495173 Fixes: #1495173
752+ Approved by: Andrea Azzarone
753+
754+2015-09-17 Lars Uebernickel <lars@uebernic.de>
755+
756+ DevicesSettingsImp: dont't feed garbage to gsettings
757+
758+ Use a const reference for the iteration variable in the loop over
759+ _blacklist so that the pointers returned from c_str() are still valid
760+ when feeding them to g_settings_set_strv().
761+
762+ In the best case, this only wrote garbage to the "blacklist" key (making
763+ that setting useless). In the worst case, it led to a crash because the
764+ garbage was invalid utf8, which gsettings refuses to accept.
765+
766+ Fixes LP: #1495173
767+
768+2015-09-21 Andrea Azzarone <azzaronea@gmail.com>
769+
770+ Make sure to restore the state before the call to glDisable(GL_SCISSOR_TEST). Fixes: #1485727
771+ Approved by: Marco Trevisan (Treviño), Eleni Maria Stea
772+
773+2015-09-16 Andrea Azzarone <azzaronea@gmail.com>
774+
775+ Remove double ;
776+
777+2015-09-16 Andrea Azzarone <azzaronea@gmail.com>
778+
779+ Minor change.
780+
781+2015-09-16 Andrea Azzarone <azzaronea@gmail.com>
782+
783+ Make sure to restore the state before calling glDisable(GL_SCISSOR_TEST)
784+
785+2015-09-21 Luke Yelavich <luke.yelavich@canonical.com>
786+
787+ Make a copy of a quicklist menu item plain text label
788+
789+ Likely due to changes in the gcc transition, Orca stopped speaking quicklist menu items. It seems that keeping a separate copy of the label string for a11y use allows quicklist menu items to be spoken again.
790+ Approved by: Marco Trevisan (Treviño)
791+
792+2015-09-21 Luke Yelavich <luke.yelavich@canonical.com>
793+
794+ Whoops, add missing brace
795+
796+2015-09-11 Luke Yelavich <luke.yelavich@canonical.com>
797+
798+ Make sure we free used memory before we get a new label string.
799+
800+2015-09-11 Luke Yelavich <luke.yelavich@canonical.com>
801+
802+ Make a copy of a quicklist menu item plain text label
803+
804+ Likely due to changes in the gcc transition, Orca stopped speaking quicklist
805+ menu items. It seems that keeping a separate copy of the label string for a11y
806+ use allows quicklist menu items to be spoken again.
807+
808+2015-09-21 Luke Yelavich <luke.yelavich@canonical.com>
809+
810+ Make a copy of a quicklist menu item plain text label
811+
812+ Similar to the fix for quicklist menu items, keep a copy of the session
813+ button label for a11y use to allow for the buttons in the session dialog
814+ to be spoken by Orca.
815+ Approved by: Marco Trevisan (Treviño)
816+
817+2015-09-14 Luke Yelavich <luke.yelavich@canonical.com>
818+
819+ Make a copy of a quicklist menu item plain text label
820+
821+ Similar to the fix for quicklist menu items, keep a copy of the session button
822+ label for a11y use to allow for the buttons in the session dialog to be spoken
823+ by Orca.
824+
825+2015-09-10 CI Train Bot <ci-train-bot@canonical.com>
826+
827+ Releasing 7.3.2+15.10.20150910.1-0ubuntu1
828+
829+2015-09-10 Andrea Azzarone andrea.azzarone@canonical.com
830+
831+ Merge patch from https://launchpadlibrarian.net/216192448/llvm-fix.patch Fixes: #1491555
832+ Approved by: Marco Trevisan (Treviño)
833+
834+2015-09-08 Andrea Azzarone andrea.azzarone@canonical.com
835+
836+ Merge patch from https://launchpadlibrarian.net/216192448/llvm-fix.patch
837+
838+2015-09-10 Andrea Azzarone andrea.azzarone@canonical.com
839+
840+ Merge patch from https://launchpadlibrarian.net/216276242/low-gfx-override.patch Fixes: #1491913
841+ Approved by: Marco Trevisan (Treviño)
842+
843+2015-09-08 Andrea Azzarone andrea.azzarone@canonical.com
844+
845+ Merge the patch from https://launchpadlibrarian.net/216276242/low-gfx-override.patch
846+
847+2015-09-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
848+
849+ UnityScreen: force shell to be on top when there's a window fullscreen and we've a menu open.
850+
851+ This allows to see the panel and control menus properly. Added support for fullscreen
852+ windows to WindowsManager, in order to handle properly the LIM mode. Fixes: #591189
853+
854+2015-09-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
855+
856+ Merging with trunk
857+
858+2015-09-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
859+
860+ PanelMenuView: consider fullscreen windows as maximized, in any case.
861+
862+ In this way in LIM-mode, we've menus available for them, and eventually
863+ panel shows proper title (when unfocused).
864+
865+ RESUBMITTED r3969, to hopefully fix criss-cross
866+
867+2015-09-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
868+
869+ Merging with lp:~azzar1/unity/lp-1485559
870+
871+2015-09-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
872+
873+ Autpilot, launcher: make dragging tests more reliable
874+
875+2015-09-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
876+
877+ Autopilot, TestIconBehavior: add utility function to get a running application
878+
879+ This waits, if needed
880+
881+2015-06-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
882+
883+ Autopilot, TestPanel: fix open menu on new focused window in LIM mode
884+
885+ Since LIM works for unfocused windows as well, no menu should be closed by
886+ an app being mapped.
887+
888+2015-06-08 Marco Trevisan (Treviño) <mail@3v1n0.net>
889+
890+ PanelMenuView: consider fullscreen windows as maximized, in any case.
891+
892+ In this way in LIM-mode, we've menus available for them, and eventually
893+ panel shows proper title (when unfocused).
894+
895+2015-06-05 Marco Trevisan (Treviño) <mail@3v1n0.net>
896+
897+ WindowManager: add IsWindowFullscreen and related signals when fullscreen is toggled
898+
899+2015-06-05 Marco Trevisan (Treviño) <mail@3v1n0.net>
900+
901+ UnityScreen: force shell to be on top when there's a window fullscreen and we've a menu open.
902+
903+2015-06-05 Marco Trevisan (Treviño) <mail@3v1n0.net>
904+
905+ MenuManager: add a menu_open property that is true when a menu is opened
906+
907+2015-06-05 Marco Trevisan (Treviño) <mail@3v1n0.net>
908+
909+ Indicators: add a method to get the active entry
910+
911+2015-09-10 Andrea Azzarone andrea.azzarone@canonical.com
912+
913+ Make sure we update the maximized window when "show desktop"/"restore desktop". Fixes: #1485559
914+ Approved by: Marco Trevisan (Treviño)
915+
916+2015-08-17 Andrea Azzarone andrea.azzarone@canonical.com
917+
918+ Make sure we update the maximized window when "show desktop"/"restore desktop".
919+
920+2015-08-14 Andrea Azzarone andrea.azzarone@canonical.com
921+
922+ Merge with trunk.
923+
924+2015-09-10 Andrea Azzarone azzaronea@gmail.com
925+
926+ Properly hide decorations when on "Show Desktop" mode. Fixes: #1485073
927+ Approved by: Marco Trevisan (Treviño)
928+
929+2015-08-14 Andrea Azzarone azzaronea@gmail.com
930+
931+ Properly hide decorations when on "Show Desktop" mode.
932+
933+2015-09-10 Andrea Azzarone andrea.azzarone@canonical.com
934+
935+ Do not allow shutdown when screen is locked. Fixes: #1460626
936+ Approved by: Marco Trevisan (Treviño)
937+
938+2015-06-19 Andrea Azzarone andrea.azzarone@canonical.com
939+
940+ Do not allow shutdown when screen is locked.
941+
942+2015-09-10 Andrea Azzarone andrea.azzarone@canonical.com
943+
944+ Add/Update tests for gnome session manager.
945+ Approved by: PS Jenkins bot, Marco Trevisan (Treviño)
946+
947+2015-09-08 Andrea Azzarone andrea.azzarone@canonical.com
948+
949+ Resolve conflicts.
950+
951+2014-04-19 Andrea Azzarone <azzaronea@gmail.com>
952+
953+ Add/Updates tests for gnome session manager.
954+
955+2015-09-10 Andrea Azzarone andrea.azzarone@canonical.com
956+
957+ Add unit tests for unity::lockscreen::DBusManager.
958+ Approved by: PS Jenkins bot, Marco Trevisan (Treviño)
959+
960+2015-09-08 Andrea Azzarone andrea.azzarone@canonical.com
961+
962+ Some minor change.
963+
964+2015-09-08 Andrea Azzarone andrea.azzarone@canonical.com
965+
966+ Merge with trunk.
967+
968+2014-04-16 Andrea Azzarone <azzaronea@gmail.com>
969+
970+ No need for DBusManager to be trackable. The impl class will do all the job.
971+
972+2014-04-16 Andrea Azzarone <azzaronea@gmail.com>
973+
974+ Add tests for unity::lockscreen::DBusManager
975+
976+2015-08-25 CI Train Bot <ci-train-bot@canonical.com>
977+
978+ Releasing 7.3.2+15.10.20150825-0ubuntu1
979+
980+2015-08-25 Iain Lane <iain@orangesquash.org.uk>
981+
982+ Depend on v5-renamed xpathselect package
983+ Approved by: Marco Trevisan (Treviño)
984+
985+2015-08-24 Iain Lane <iain@orangesquash.org.uk>
986+
987+ Merge archive upload
988+
989+2015-08-19 CI Train Bot <ci-train-bot@canonical.com>
990+
991+ Releasing 7.3.2+15.10.20150819-0ubuntu1
992+
993+2015-08-19 Andrea Azzarone andrea.azzarone@canonical.com
994+
995+ Do not handle events coming from viewports not actually containing the window. Fixes: #1449654
996+ Approved by: PS Jenkins bot, Marco Trevisan (Treviño)
997+
998+2015-08-19 Chris Townsend <christopher.townsend@canonical.com>
999+
1000+ When using keyboard navigation in the Dash, skip category headers that are not expandable. Also, do not highlight the category header when the mouse cursor is over it. Fixes: #1045933
1001+ Approved by: PS Jenkins bot, Marco Trevisan (Treviño)
1002+
1003+2015-08-19 Chris Townsend <christopher.townsend@canonical.com>
1004+
1005+ Also use the Compiz show() method when forcing an unmapped window to be visible when clicking on it's active Launcher icon. Fixes: #989588
1006+ Approved by: PS Jenkins bot, Marco Trevisan (Treviño)
1007+
1008+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1009+
1010+ Autopilot: modernize some tests, use stronger methods to ensure false positive
1011+ Approved by: Andrea Azzarone
1012+
1013+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1014+
1015+ DecorationsForceQuitDialog: override the background of the window with transparent color Fixes: #1470292
1016+ Approved by: PS Jenkins bot, Stephen M. Webb
1017+
1018+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1019+
1020+ SessionButton: set button opacity to 75% when pressed Fixes: #1301655
1021+ Approved by: PS Jenkins bot, Stephen M. Webb
1022+
1023+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1024+
1025+ PlacesGroup: connect to view changes using a function instead of a lambda
1026+
1027+ This prevents crashes as there's automatic disconnection. Fixes: #1470298
1028+ Approved by: PS Jenkins bot, Stephen M. Webb
1029+
1030+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1031+
1032+ PanelMenuView: ensure that we connect to window signals as soon as the AppManager knows it Fixes: #1472326
1033+ Approved by: PS Jenkins bot, Stephen M. Webb
1034+
1035+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1036+
1037+ Launcher: Always unfold an active icon Fixes: #1472339
1038+ Approved by: Andrea Azzarone, PS Jenkins bot, Stephen M. Webb
1039+
1040+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1041+
1042+ ApplicationManager: rely on windows monitor property changes for updating Pips
1043+
1044+ Removing the expensive calls that rely on Compiz window moved events which
1045+ are fired for every window, also if outside the scope of an Icon, so we don't
1046+ have to filter these signals out, but we can just get the monitor.changed signal
1047+ and depend on that.
1048+ This fixes the launcher pips not to be properly initialized in multi-monitor environments. Fixes: #1027191
1049+ Approved by: PS Jenkins bot
1050+
1051+2015-08-24 Iain Lane <iain@orangesquash.org.uk>
1052+
1053+ Update hardcoded libxpathselect1.4 dep (dlopened) to the new v5 name
1054+
1055+2015-08-25 Andrea Azzarone andrea.azzarone@canonical.com
1056+
1057+ Do not handle events coming from viewports not actually containing the window. Fixes: #1449654
1058+ Approved by: PS Jenkins bot, Marco Trevisan (Treviño)
1059+
1060+2015-08-07 Andrea Azzarone andrea.azzarone@canonical.com
1061+
1062+ Minor change.
1063+
1064+2015-08-07 Andrea Azzarone andrea.azzarone@canonical.com
1065+
1066+ Use nullptr.
1067+
1068+2015-08-07 Andrea Azzarone andrea.azzarone@canonical.com
1069+
1070+ Do not handle events coming from viewports not actually containing the window.
1071+
1072+2015-08-25 Chris Townsend <christopher.townsend@canonical.com>
1073+
1074+ When using keyboard navigation in the Dash, skip category headers that are not expandable. Also, do not highlight the category header when the mouse cursor is over it. Fixes: #1045933
1075+ Approved by: PS Jenkins bot, Marco Trevisan (Treviño)
1076+
1077+2015-05-08 Chris Townsend <christopher.townsend@canonical.com>
1078+
1079+ Make returning from SkipUnexpandableHeaderKeyNav() a bit more efficient.
1080+
1081+2015-05-05 Chris Townsend <christopher.townsend@canonical.com>
1082+
1083+ When using keyboard navigation in the Dash, skip category headers that are not expandable. Also, do not highlight the category header when the mosue cursor is over it.
1084+
1085+2015-08-25 Chris Townsend <christopher.townsend@canonical.com>
1086+
1087+ Also use the Compiz show() method when forcing an unmapped window to be visible when clicking on it's active Launcher icon. Fixes: #989588
1088+ Approved by: PS Jenkins bot, Marco Trevisan (Treviño)
1089+
1090+2015-05-29 Chris Townsend <christopher.townsend@canonical.com>
1091+
1092+ Also add the show() method in PluginAdapter::UnMinimize().
1093+
1094+2015-05-27 Chris Townsend <christopher.townsend@canonical.com>
1095+
1096+ Also use the Compiz show() method when forcing an unmapped window to be visible when clicking on it's active Launcher icon.
1097+
1098+2015-08-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
1099+
1100+ Autopilot: modernize some tests, use stronger methods to ensure false positive
1101+ Approved by: Andrea Azzarone
1102+
1103+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1104+
1105+ AP, TestSwitcher: use eventually in mouse selection tests
1106+
1107+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1108+
1109+ AP, TestPanel: use proper grab_area path
1110+
1111+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1112+
1113+ AP: dash, fix typo
1114+
1115+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1116+
1117+ AP, TestDash: use valid property for eventual check
1118+
1119+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1120+
1121+ AP, TestPanel: add a lambda to verify app/win status
1122+
1123+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1124+
1125+ AP, test dash: fix issues on refactoring
1126+
1127+ Properly click object and return geometry of the view (controller has no geo)
1128+
1129+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1130+
1131+ AP, TestSwitcherMouseInteraction: move mouse at origin before testing
1132+
1133+ Otherwise our technology to prevent small mouse movements might
1134+ ignore the events and make the test fail.
1135+
1136+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1137+
1138+ AP, TestSpread: increase the wait time before moving to a window
1139+
1140+ Unfortunately this seems to be needed to get input in some machines
1141+
1142+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1143+
1144+ AP, TestPanel: get active indicator using a lambda
1145+
1146+ In this way we ensure that it gets called repeatdly until there's a result
1147+
1148+2015-08-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1149+
1150+ panel: ignore WindowButtons that have not been placed yet, as they're not visible
1151+
1152+2015-08-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1153+
1154+ Autopilot: use new globalRect property as alias for geometry
1155+
1156+2015-08-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1157+
1158+ Autopilot: use some new facilities to move and click over items
1159+
1160+2015-08-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1161+
1162+ UnityIntrospectionObject: make customization of repr easier
1163+
1164+2015-08-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1165+
1166+ UnityIntrospectionObject: implement proper __eq__, __ne__ and __repr__ methods
1167+
1168+2015-08-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
1169+
1170+ AP, TestDash: fix tab category key nav test to match recent changes
1171+
1172+ AS per a rencent fix, the first element is selected if the category is not exapandible
1173+
1174+2015-08-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
1175+
1176+ DecorationsForceQuitDialog: override the background of the window with transparent color Fixes: #1470292
1177+ Approved by: PS Jenkins bot, Stephen M. Webb
1178+
1179+2015-07-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
1180+
1181+ DecorationsForceQuitDialog: override the background of the window with transparent color
1182+
1183+2015-08-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
1184+
1185+ SessionButton: set button opacity to 75% when pressed Fixes: #1301655
1186+ Approved by: PS Jenkins bot, Stephen M. Webb
1187+
1188+2015-07-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
1189+
1190+ SessionButton: set button opacity to 75% when pressed
1191+
1192+2015-07-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
1193+
1194+ IconTexture: only redraw if opacity actually changed
1195+
1196+2015-07-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
1197+
1198+ SessionView: don't show Lock button if session is currently locked
1199+
1200+ Yay, double-lock! :)
1201+
1202+2015-08-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
1203+
1204+ PlacesGroup: connect to view changes using a function instead of a lambda
1205+
1206+ This prevents crashes as there's automatic disconnection. Fixes: #1470298
1207+ Approved by: PS Jenkins bot, Stephen M. Webb
1208+
1209+2015-07-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
1210+
1211+ PlacesGroup: connect to view changes using a function instead of a lambda
1212+
1213+ This prevents crashes as there's automatic disconnection.
1214+
1215+2015-07-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
1216+
1217+ ResultViewGrid: use sigc::mem_fun to connect to QueueDraw
1218+
1219+2015-08-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
1220+
1221+ PanelMenuView: ensure that we connect to window signals as soon as the AppManager knows it Fixes: #1472326
1222+ Approved by: PS Jenkins bot, Stephen M. Webb
1223+
1224+2015-07-07 Marco Trevisan (Treviño) <mail@3v1n0.net>
1225+
1226+ PanelMenuView: ensure that we connect to window signals as soon as the AppManager knows it
1227+
1228+2015-07-07 Marco Trevisan (Treviño) <mail@3v1n0.net>
1229+
1230+ PanelMenuView: add back connection to window_closed signal
1231+
1232+ This was a leftover of the previous refactor.
1233+
1234+2015-08-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
1235+
1236+ Launcher: Always unfold an active icon Fixes: #1472339
1237+ Approved by: PS Jenkins bot, Andrea Azzarone, Stephen M. Webb
1238+
1239+2015-07-07 Marco Trevisan (Treviño) <mail@3v1n0.net>
1240+
1241+ Launcher: Always unfold an active icon
1242+
1243+2015-08-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
1244+
1245+ ApplicationManager: rely on windows monitor property changes for updating Pips
1246+
1247+ Removing the expensive calls that rely on Compiz window moved events which
1248+ are fired for every window, also if outside the scope of an Icon, so we don't
1249+ have to filter these signals out, but we can just get the monitor.changed signal
1250+ and depend on that.
1251+ This fixes the launcher pips not to be properly initialized in multi-monitor environments. Fixes: #1027191
1252+ Approved by: PS Jenkins bot
1253+
1254+2015-07-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
1255+
1256+ TestBamfApplication: veridy children addition properly
1257+
1258+2015-07-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
1259+
1260+ BamfMockApplication: emit child-{added,removed} signals when setting children
1261+
1262+2015-07-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
1263+
1264+ ApplicationManager: rely on windows monitor property changes for updating Pips
1265+
1266+ Removing the expensive calls that rely on Compiz window moved events which
1267+ are fired for every window, also if outside the scope of an Icon, so we don't
1268+ have to filter these signals out, but we can just get the monitor.changed signal
1269+ and depend on that.
1270+ This fixes the launcher pips not to be properly initialized in multi-monitor environments.
1271+
1272+2015-07-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
1273+
1274+ StandaloneAppManager: connect to window events also for newly opend windows
1275+
1276+2015-07-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
1277+
1278+ StandaloneAppManager: list monitor changes as well
1279+
1280+2015-07-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
1281+
1282+ BamfApplicationManager: UpdateWindows on App creation as it might be already running
1283+
1284+2015-07-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1285+
1286+ MockApplication: use explicit return type with const& or Lambda will fail
1287+
1288+2015-07-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1289+
1290+ ApplicationManager: return a const& WindowList in GetWindows
1291+
1292+ Since we don't have to fetch anything, we can just avoid copies here.
1293+
1294+2015-07-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1295+
1296+ BamfApplicationManager: save windows for each app emitting window_{opened,closed} signal
1297+
1298+ Reduce the creation of windows, emit opened or closed signals properly when windows
1299+ are added or removed, this fixes the problem of not getting these signals with sticky apps
1300+
1301+2015-07-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1302+
1303+ BamfApplicationManager: try to use cached windows in GetWindowForId at first try
1304+
1305+2015-07-08 Marco Trevisan (Treviño) <mail@3v1n0.net>
1306+
1307+ BamfApplicationManager: remove cached Apps/Windows on 'closed' signal
1308+
1309+ This happens as the last thing, then we can be sure that that app or window
1310+ won't be re-created for further signals (as it happened before).
1311+
1312+ Also don't remove sticky apps, until they are unsticked (and closed).
1313+
1314+2015-07-08 Marco Trevisan (Treviño) <mail@3v1n0.net>
1315+
1316+ ApplicationManager: use monitor as property and emit changes
1317+
1318+2015-08-03 CI Train Bot <ci-train-bot@canonical.com>
1319+
1320+ Releasing 7.3.2+15.10.20150803.1-0ubuntu1
1321+
1322+2015-08-03 Stephen M. Webb <stephen.webb@canonical.com>
1323+
1324+ unity-shared/DebugDBusInterface.cpp: include <iostream> to fix a FTBFS
1325+ Approved by: Eleni Maria Stea
1326+
1327+2015-08-03 Stephen M. Webb <stephen.webb@canonical.com>
1328+
1329+ fix a FTBFS with GCC-5 on arm64 due to missing required standard header
1330+
1331+2015-08-03 Andrea Azzarone andrea.azzarone@canonical.com
1332+
1333+ Enable building unity form source with gcc5.
1334+ Approved by: PS Jenkins bot, Stephen M. Webb
1335+
1336+2015-07-31 Andrea Azzarone andrea.azzarone@canonical.com
1337+
1338+ Fix for gcc5.
1339+
1340+2015-08-03 Andrea Azzarone andrea.azzarone@canonical.com
1341+
1342+ Fixes that enable building unity from sources with cmake3 (wily).
1343+ Approved by: PS Jenkins bot, Stephen M. Webb
1344+
1345+2015-07-31 Andrea Azzarone andrea.azzarone@canonical.com
1346+
1347+ Fix for cmake 3.0
1348+
1349+2015-06-27 CI Train Bot <ci-train-bot@canonical.com>
1350+
1351+ Releasing 7.3.2+15.10.20150627.1-0ubuntu1
1352+
1353+2015-06-27 Luke Yelavich <luke.yelavich@canonical.com>
1354+
1355+ Implement filter results controls accessibility Fixes: #1457071
1356+ Approved by: PS Jenkins bot, Marco Trevisan (Treviño)
1357+
1358+2015-05-25 Luke Yelavich <luke.yelavich@canonical.com>
1359+
1360+ Switch header include order, hoefully fixes Rm64 FTBFs.
1361+
1362+2015-05-08 Luke Yelavich <luke.yelavich@canonical.com>
1363+
1364+ Some code cleanup and improvement, thanks to Marco Trevisan (Treviño)" for the pointers.
1365+
1366+2015-05-06 Luke Yelavich <luke.yelavich@canonical.com>
1367+
1368+ Remove some commented out code that is not needed
1369+
1370+2015-05-05 Luke Yelavich <luke.yelavich@canonical.com>
1371+
1372+ Whoops, accidently dropped some member variables when moving code around for testing
1373+
1374+2015-05-05 Luke Yelavich <luke.yelavich@canonical.com>
1375+
1376+ Implement filter results controls accessibility
1377+
1378+2015-06-27 Andrea Azzarone andrea.azzarone@canonical.com
1379+
1380+ This likely could fix https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1451613. At least the backtraces posted there suggest this. But I think that those backtraces are just leftovers of old crashes-on-unloading.
1381+ Approved by: Marco Trevisan (Treviño)
1382+
1383+2015-05-28 Andrea Azzarone andrea.azzarone@canonical.com
1384+
1385+ Avoid using lambda in EdgeBarrierController.
1386+
1387+2015-06-27 Andrea Azzarone andrea.azzarone@canonical.com
1388+
1389+ Make sure new icons are added to the model before calling SortAndUpdate. Fixes: #1458950
1390+ Approved by: PS Jenkins bot, Stephen M. Webb
1391+
1392+2015-05-29 Andrea Azzarone andrea.azzarone@canonical.com
1393+
1394+ Make sure new icons are added to the model before calling SortAndUpdate.
1395+
1396+2015-06-27 Andrea Azzarone andrea.azzarone@canonical.com
1397+
1398+ Fix a regression with urgent icons not showing up if launcher is hidden. Fixes: #1450991
1399+ Approved by: PS Jenkins bot, Stephen M. Webb
1400+
1401+2015-05-21 Andrea Azzarone andrea.azzarone@canonical.com
1402+
1403+ Properly render urgent icons.
1404+
1405+2015-06-27 Marco Trevisan (Treviño) <mail@3v1n0.net>
1406+
1407+ DecorationsForceQuitDialog: remove deprecated override style functions, use CSS
1408+ Approved by: PS Jenkins bot, Christopher Townsend
1409+
1410+2015-06-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
1411+
1412+ DecorationsForceQuitDialog: remove deprecated override style functions, use CSS
1413+
1414+2015-06-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
1415+
1416+ DecorationsForceQuitDialog: remove alignment deprecated functions
1417+
1418+ Replace them with gtkwidget parameters
1419+
1420+2015-06-27 Marco Trevisan (Treviño) <mail@3v1n0.net>
1421+
1422+ OverlayWindowButtons: trigger a queuedraw also when a child requires a redraw Fixes: #1461618
1423+ Approved by: PS Jenkins bot, Christopher Townsend
1424+
1425+2015-06-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
1426+
1427+ OverlayWindowButtons: trigger a queuedraw also when a child requires a redraw
1428+
1429+2015-06-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
1430+
1431+ WindowButton: emit visual_state_change signal when we change the state
1432+
1433+2015-06-27 Marco Trevisan (Treviño) <mail@3v1n0.net>
1434+
1435+ PanelMenuView: connect to target window / application title changes
1436+
1437+ This will be smart enough to work with LIM and global menus Fixes: #1418449
1438+ Approved by: PS Jenkins bot, Christopher Townsend
1439+
1440+2015-04-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
1441+
1442+ Merging with lp:~3v1n0/unity/application-manager-new
1443+
1444+2015-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
1445+
1446+ BamfApplicationManager: use bamf_matcher_get_application_for_xid to get windows for id
1447+
1448+ This reduces the DBus traffic
1449+
1450+2015-04-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
1451+
1452+ PanelMenuView: connect to target window / application title changes
1453+
1454+ This will be smart enough to work with LIM and global menus
1455+
1456+2015-06-27 Marco Trevisan (Treviño) <mail@3v1n0.net>
1457+
1458+ ApplicationManager: add missing features, keep a copy of views around
1459+
1460+ Use this in PanelMenuView, getting rid of the BAMF internal at this level.
1461+ Approved by: PS Jenkins bot, Christopher Townsend
1462+
1463+2015-05-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
1464+
1465+ TestAppliactionLauncherIcon: ensure window is activ
1466+
1467+2015-05-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
1468+
1469+ MockApplicationWindow: make LocalFocus to activate the window as well
1470+
1471+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1472+
1473+ ApplicationLauncherIcon: use window active state for generating quicklist
1474+
1475+2015-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
1476+
1477+ ApplicationLauncherIcon: add "natuilus.desktop" back to the fliemanager list
1478+
1479+2015-04-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
1480+
1481+ PanelMenuView: add RefreshAndRedraw utility function
1482+
1483+ Instead of duplicating the same code everywhere
1484+
1485+2015-04-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
1486+
1487+ Merging with trunk
1488+
1489+2015-03-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
1490+
1491+ Merging with trunk
1492+
1493+2015-02-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1494+
1495+ StandaloneAppManager: add missing mock type in switch
1496+
1497+2015-02-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1498+
1499+ Merging with lim-everywhere again
1500+
1501+2015-02-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1502+
1503+ Merging with lp:~3v1n0/unity/lim-everywhere
1504+
1505+2015-02-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1506+
1507+ ApplicationManager: add MOCK {App,Window}Type
1508+
1509+2015-02-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1510+
1511+ panel: link standalone version with unity-shared-bamf
1512+
1513+2015-02-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
1514+
1515+ BamfApplicationManager: do safer convertion from bamf window type to unity::WindowType
1516+
1517+2015-02-05 Marco Trevisan (Treviño) <mail@3v1n0.net>
1518+
1519+ PanelMenuView: use ApplicationManager to handle windows
1520+
1521+ Remove the usage of BAMF internals, this allows better testability
1522+ and less resources usage.
1523+
1524+2015-02-05 Marco Trevisan (Treviño) <mail@3v1n0.net>
1525+
1526+ BamfApplicationManager: make sure we don't emit signals with null apps
1527+
1528+2015-02-05 Marco Trevisan (Treviño) <mail@3v1n0.net>
1529+
1530+ ApplicationManager: add missing features, keep a copy of views around
1531+
1532+ This might be still improved when BAMF crashes/reloads, so that we can rebuild the table
1533+
1534+2015-06-27 Marco Trevisan (Treviño) <mail@3v1n0.net>
1535+
1536+ GnomeSessionManager: Request ScreenSaver (de)activation on VT changes
1537+
1538+ Connect to login1 session active property, and monitor its state.
1539+ When the session is active we can safely request the screensaver to stop. Fixes: #1405349
1540+ Approved by: PS Jenkins bot, Christopher Townsend
1541+
1542+2015-05-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1543+
1544+ GnomeSessionManager: Request ScreenSaver (de)activation on VT changes
1545+
1546+ Connect to login1 session active property, and monitor its state.
1547+ When the session is active we can safely request the screensaver to stop.
1548+
1549+2015-05-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
1550+
1551+ GLibDBusProxy: Notify invalidated properties as well, by emitting a null value for them
1552+
1553+ It's then up to the client to get the value.
1554+ And plus fix the signature of the OnPropertyChanged callback.
1555+
1556+2015-06-27 Chris Townsend <christopher.townsend@canonical.com>
1557+
1558+ Allow mouse clicks that are not in the visible area of the Quicklist to pass through down to the Launcher icon. Fixes a failing AP test. Fixes: #1456245
1559+ Approved by: Marco Trevisan (Treviño)
1560+
1561+2015-05-20 Chris Townsend <christopher.townsend@canonical.com>
1562+
1563+ Use CairoBaseWindow::FindAreaUnderMouse.
1564+ Use _anchorX instead of _padding.
1565+
1566+2015-05-20 Chris Townsend <christopher.townsend@canonical.com>
1567+
1568+ Add override to the new method.
1569+
1570+2015-05-20 Chris Townsend <christopher.townsend@canonical.com>
1571+
1572+ Allow mouse clicks that are not in the visible area of the Quicklist to pass through down to the Launcher icon. Fixes a failing AP test.
1573+
1574+2015-05-22 CI Train Bot <ci-train-bot@canonical.com>
1575+
1576+ Releasing 7.3.2+15.10.20150522-0ubuntu1
1577+
1578+2015-05-22 Luke Yelavich <luke.yelavich@canonical.com>
1579+
1580+ Implement scope bar icon accessibility Fixes: #1457073
1581+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1582+
1583+2015-03-25 Luke Yelavich <luke.yelavich@canonical.com>
1584+
1585+ Implement scope bar icon accessibility
1586+
1587+2015-05-22 Chris Townsend <christopher.townsend@canonical.com>
1588+
1589+ Enable real page up/page down key navigation in the Dash. When using these keys the view scrolls the length of the visible view. Fixes: #913612
1590+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1591+
1592+2015-05-05 Chris Townsend <christopher.townsend@canonical.com>
1593+
1594+ Use a signal instead of a nux::Property since we are not storing any value.
1595+
1596+2015-05-04 Chris Townsend <christopher.townsend@canonical.com>
1597+
1598+ Move the ScrollDir enum class to the anonymous namespace and use ScrollDir instead of a bool when signalling which direction to page.
1599+
1600+2015-04-30 Chris Townsend <christopher.townsend@canonical.com>
1601+
1602+ Clean up the case handling of the page up and page down keys and also only do these when a preview is not showing.
1603+
1604+2015-04-29 Chris Townsend <christopher.townsend@canonical.com>
1605+
1606+ Enable real page up/page down key navigation in the Dash. When using these keys the view scrolls the length of the visible view.
1607+
1608+2015-05-22 Chris Townsend <christopher.townsend@canonical.com>
1609+
1610+ If dragging an application:// uri type from the Dash to the desktop, change it to a file:// uri type so Nautilus can understand the type a make a copy of it on the desktop. Fixes: #1241972
1611+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1612+
1613+2015-04-28 Chris Townsend <christopher.townsend@canonical.com>
1614+
1615+ Make changes as suggested by Marco's review.
1616+
1617+2015-04-27 Chris Townsend <christopher.townsend@canonical.com>
1618+
1619+ If dragging an application:// uri type from the Dash to the desktop, change it to a file:// uri type so Nautilus can understand the type a make a copy of it on the desktop.
1620+
1621+2015-05-22 Chris Townsend <christopher.townsend@canonical.com>
1622+
1623+ If Spread/Expo is active, then terminate it when entering Launcher keynav mode. Fixes: #1447810
1624+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1625+
1626+2015-05-08 Chris Townsend <christopher.townsend@canonical.com>
1627+
1628+ Move the 'key_nav_mode_requested=false' inside the test so we don't always set that even if it's not needed.
1629+
1630+2015-04-24 Chris Townsend <christopher.townsend@canonical.com>
1631+
1632+ If Spread/Expo is active, then terminate it when entering Launcher keynav mode.
1633+
1634+2015-05-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
1635+
1636+
1637+
1638+ ResultViewGrid: wait for double-click event only if the relative result needs the Preview
1639+
1640+ This was causing a 500ms delay between the user click and some results (apps) activation.
1641+ Also, at this point, we can get rid of PREVIEW_LEFT_BUTTON activation type. Fixes: #1291950, #1447372
1642+ Approved by: Christopher Townsend, Brandon Schaefer, PS Jenkins bot
1643+
1644+2015-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
1645+
1646+ DashView: use new SearchBar in_live_search property
1647+
1648+2015-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
1649+
1650+ SearchBar: add in_live_search ROProperty, add more lambdas
1651+
1652+2015-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
1653+
1654+ DashView: reduce delay on key-activation of first result
1655+
1656+ If user hits enter, then the first result has to be activated quickly.
1657+ So, we now wait 300ms since the live search has ended (this doesn't mean
1658+ we already have all the results, but we might have some of them) and
1659+ at this point if the user has already hit Enter key we activate the first result.
1660+ In case the user hits Enter after 300ms that the live search has ended,
1661+ we simply and promptly activate the first result.
1662+
1663+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1664+
1665+ BGHash: request redraw only if WindowThread is initialized
1666+
1667+ This was causing a crash in standalone dash
1668+
1669+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1670+
1671+ Unity: remove various unneeded g{d,t}k inclusions...
1672+
1673+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1674+
1675+ ResultViewGrid: don't wait double-click if a local result doesn't support preview
1676+
1677+ This fixes slow click events on Alt+F2 scope
1678+
1679+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1680+
1681+ ResultView: add GetLocalResultActivateType that returns how a result should be activated
1682+
1683+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1684+
1685+ ResultView: define default_click_activation getter to make it depends on Settings
1686+
1687+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1688+
1689+ ScopeView: initialize results_view in any case.
1690+
1691+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1692+
1693+ ResultViewGrid: wait for double-click event only if the default_click_activation is PREVIEW
1694+
1695+ This was causing a 500ms delay between the user click and some results (apps) activation.
1696+ Also, at this point, we can get rid of PREVIEW_LEFT_BUTTON activation type.
1697+
1698+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1699+
1700+ ScopeView: set default_click_activation on ResultViewGrid to DIRECT on apps
1701+
1702+ This property has to be DIRECT when we handle apps or when the user has
1703+ requested this behavior using settings.
1704+
1705+2015-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
1706+
1707+ ResultView: add default_click_activation property
1708+
1709+ This is set to DIRECT by default, also move to enum class
1710+
1711+2015-05-22 Chris Townsend <christopher.townsend@canonical.com>
1712+
1713+ Wait on Spread to be terminated before showing the Quicklist. Fixes: #1441626
1714+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1715+
1716+2015-04-23 Chris Townsend <christopher.townsend@canonical.com>
1717+
1718+ Wait on Spread to be terminated before showing the Quicklist.
1719+
1720+2015-05-22 Chris Townsend <christopher.townsend@canonical.com>
1721+
1722+ Add necessary signaling to set the BFB icon's tooltip and the Home Scope's default search string to accurately reflect if searching online is enabled or disabled in unity-system-settings. Fixes: #1101662, #1202160
1723+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1724+
1725+2015-04-23 Chris Townsend <christopher.townsend@canonical.com>
1726+
1727+ Fixed formatting in last commit.
1728+
1729+2015-04-23 Chris Townsend <christopher.townsend@canonical.com>
1730+
1731+ Make sure the Home Scope is valid before setting it's search hint. Fixes seg faults in the unit tests.
1732+
1733+2015-04-23 Chris Townsend <christopher.townsend@canonical.com>
1734+
1735+ Rename some functions to be more descriptive.
1736+ Use a property instead of a signal.
1737+
1738+2015-04-22 Chris Townsend <christopher.townsend@canonical.com>
1739+
1740+ Add necessary signaling to set the BFB icon's tooltip and the Home Scope's default search string to accurately reflect if searching online is enabled or disabled in unity-system-settings.
1741+
1742+2015-05-12 CI Train Bot <ci-train-bot@canonical.com>
1743+
1744+ Releasing 7.3.2+15.10.20150512-0ubuntu1
1745+
1746+2015-05-12 Eleni Maria Stea <elenimaria.stea@canonical.com>
1747+
1748+ The skydome rendering of the cube plugin was wrong with unity because transformation matrices set by the unityshell plugin were left in the opengl matrix stacks affecting other compiz plugins. Saving the compiz state at the beginning of the unityshell plugin rendering functions and restoring it at the end of them fixes the problem. Fixes: #1446165
1749+ Approved by: Stephen M. Webb, PS Jenkins bot
1750+
1751+2015-04-27 Eleni Maria Stea <elenimaria.stea@canonical.com>
1752+
1753+ renamed static functions
1754+
1755+2015-04-21 Eleni Maria Stea <elenimaria.stea@canonical.com>
1756+
1757+ cleanup diff (removed empty line)
1758+
1759+2015-04-21 Eleni Maria Stea <elenimaria.stea@canonical.com>
1760+
1761+ renamed push_all/pop_all to something more relevant
1762+
1763+2015-04-21 Eleni Maria Stea <elenimaria.stea@canonical.com>
1764+
1765+ cleanup diff (newlines/spaces)
1766+
1767+2015-04-21 Eleni Maria Stea <elenimaria.stea@canonical.com>
1768+
1769+ use the minimum push and pop possible to not see errors in compiz
1770+
1771+2015-04-20 Eleni Maria Stea <elenimaria.stea@canonical.com>
1772+
1773+ added #ifndef USE_GLES
1774+
1775+2015-04-20 Eleni Maria Stea <elenimaria.stea@canonical.com>
1776+
1777+ removed save/restore framebuffer (it's not necessary)
1778+
1779+2015-04-17 Eleni Maria Stea <elenimaria.stea@canonical.com>
1780+
1781+ removed unused function
1782+
1783+2015-04-17 Eleni Maria Stea <elenimaria.stea@canonical.com>
1784+
1785+ save and restore fbo
1786+
1787+2015-04-16 Eleni Maria Stea <elenimaria.stea@canonical.com>
1788+
1789+ restore shader as well
1790+
1791+2015-04-15 Eleni Maria Stea <elenimaria.stea@canonical.com>
1792+
1793+ preserving the compiz state before applying the unity transformations
1794+ (fixes the compiz skydome and other issues)
1795+
1796+2015-05-12 Chris Townsend <christopher.townsend@canonical.com>
1797+
1798+ Add option to enable and disable Unity low graphics mode on the fly in ccsm or via gsettings. Fixes: #1412937
1799+ Approved by: Marco Trevisan (Treviño)
1800+
1801+2015-04-21 Chris Townsend <christopher.townsend@canonical.com>
1802+
1803+ Add check to whether the low graphics mode has really changed before emitting the signal.
1804+
1805+2015-04-21 Chris Townsend <christopher.townsend@canonical.com>
1806+
1807+ Add option to enable and disable Unity low graphics mode on the fly in ccsm or via gsettings.
1808+
1809+2015-05-12 Chris Townsend <christopher.townsend@canonical.com>
1810+
1811+ Save the active window when showing the Dash so the correct window is focused when hiding the Dash. Fixes issue when "Always on Top" windows are present. Fixes: #1446634
1812+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1813+
1814+2015-04-21 Chris Townsend <christopher.townsend@canonical.com>
1815+
1816+ Save the active window when showing the Dash so the correct window is focused when hiding the Dash. Fixes issue when "Always on Top" windows are present.
1817+
1818+2015-05-12 Chris Townsend <christopher.townsend@canonical.com>
1819+
1820+ Save the active window when showing the Hud so the correct window is focused when hiding the Hud. Fixes issue when "Always on Top" windows are present. Fixes: #1366583
1821+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1822+
1823+2015-04-17 Chris Townsend <christopher.townsend@canonical.com>
1824+
1825+ Save the active window when showing the Hud so the correct window is focused when hiding the Hud. Fixes issue when "Always on Top" windows are present.
1826+
1827+2015-05-12 Chris Townsend <christopher.townsend@canonical.com>
1828+
1829+ When using the left arrow to exit a Quicklist, Launcher keynav is implied and should be active regardless of how the Quicklist was opened. Fixes: #1444626
1830+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1831+
1832+2015-04-16 Chris Townsend <christopher.townsend@canonical.com>
1833+
1834+ When using the left arrow to exit a Quicklist, Launcher keynav is implied and should be active regardless of how the Quicklist was opened.
1835+
1836+2015-04-16 Chris Townsend <christopher.townsend@canonical.com>
1837+
1838+ Merge lp:~townsend/unity/fix-keynav-bfb-quicklist since it's a prerequisite.
1839+
1840+2015-05-12 Chris Townsend <christopher.townsend@canonical.com>
1841+
1842+ Add new signal to tell the Launcher to terminate keynav mode and use that signal when a BFB quicklist item is chosen. Fixes: #1052024, #1444643
1843+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1844+
1845+2015-04-16 Chris Townsend <christopher.townsend@canonical.com>
1846+
1847+ Move the logic to terminate Launcher keynav inside the code that has already determined a Launcher icon was clicked.
1848+
1849+2015-04-15 Chris Townsend <christopher.townsend@canonical.com>
1850+
1851+ Revert the previous fix of using a UBus message. Instead, use a signal in which the Launcher will signal the LauncherController to disable KeyNav if the Launcher is clicked with a mouse.
1852+
1853+2015-04-14 Chris Townsend <christopher.townsend@canonical.com>
1854+
1855+ Add new signal to tell the Launcher to terminate keynav mode and use that signal when a BFB quicklist item is chosen.
1856+
1857+2015-05-12 Chris Townsend <christopher.townsend@canonical.com>
1858+
1859+ Send signal to ensure the Dash will show when entering keynav mode since the first icon always highlighted is the BFB. Fixes: #1444113
1860+ Approved by: Marco Trevisan (Treviño)
1861+
1862+2015-04-16 Chris Townsend <christopher.townsend@canonical.com>
1863+
1864+ In the KeyNav movement functions, add a check to see if the icon is the BFB and if so, send message to ensure the Dash will show.
1865+
1866+2015-04-14 Chris Townsend <christopher.townsend@canonical.com>
1867+
1868+ Send signal to ensure the Dash will show when entering keynav mode since the first icon always highlighted is the BFB.
1869+
1870+2015-05-12 Chris Townsend <christopher.townsend@canonical.com>
1871+
1872+ Remove code that is no longer needed and broke opening application spread while in Launcher keynav mode. Fixes: #1445082
1873+ Approved by: Marco Trevisan (Treviño)
1874+
1875+2015-04-17 Chris Townsend <christopher.townsend@canonical.com>
1876+
1877+ Remove code that is no longer needed and broke opening application spread while in Launcher keynav mode.
1878+
1879+2015-05-12 Chris Townsend <christopher.townsend@canonical.com>
1880+
1881+ When looking for the top-most valid window in a VP, also check if the window is focused if the window is set to Always on Top. This allows Launcher icon spread to work properly when a window is minimized an Always on Top exists in the group.
1882+ Fixes: #1131385
1883+ Approved by: Marco Trevisan (Treviño), PS Jenkins bot
1884+
1885+2015-04-09 Chris Townsend <christopher.townsend@canonical.com>
1886+
1887+ When looking for the top-most valid window in a VP, also check if the window is focused if the window is set to Always on Top. This allows Launcher icon spread to work properly when a window is minimized an Always on Top exists in the group.
1888+
1889+2015-04-20 CI Train Bot <ci-train-bot@canonical.com>
1890+
1891+ Releasing 7.3.2+15.04.20150420-0ubuntu1
1892+
1893+2015-04-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
1894+
1895+ MenuManager, settings: go back to Global Menus as default
1896+
1897+ As per design decision. Fixes: #1446256
1898+ Approved by: Stephen M. Webb
1899+
1900+2015-04-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
1901+
1902+ MenuManager, settings: go back to Global Menus as default
1903+
1904+ As per design decision.
1905+
1906+2015-04-10 CI Train Bot <ci-train-bot@canonical.com>
1907+
1908+ Releasing 7.3.2+15.04.20150410.1-0ubuntu1
1909+
1910+2015-04-10 Marco Trevisan (Treviño) <mail@3v1n0.net>
1911+
1912+ UnityScreen: terminate spread if active when initiating Switcher
1913+
1914+ Also avodon't make the SpreadFilter to unset the nux key-focus area on destruction. Fixes: #1412001
1915+ Approved by: Christopher Townsend, PS Jenkins bot
1916+
1917+2015-04-08 Marco Trevisan (Treviño) <mail@3v1n0.net>
1918+
1919+ TestSpreadFilter: include SearchBar
1920+
1921+2015-04-08 Marco Trevisan (Treviño) <mail@3v1n0.net>
1922+
1923+ SpreadFilter: no need to manually unset the key-focus area or remove from layout queue
1924+
1925+ This is now done inside nux::Area::~Area, and leaves the focus to the upcoming views
1926+ (such as the switcher view).
1927+
1928+2015-04-08 Marco Trevisan (Treviño) <mail@3v1n0.net>
1929+
1930+ UnityScreen: terminate spread if active when initiating Switcher
1931+
1932+2015-04-10 Gerry Boland <gerry.boland@canonical.com>
1933+
1934+ SwitcherController: add first selection mode property, to decide what to select at first
1935+
1936+ Add option to have Switcher strictly between applications, and not select the previously focused window as first selection (even if that window part of the same application) Fixes: #998285
1937+ Approved by: Gerry Boland, Christopher Townsend, PS Jenkins bot
1938+
1939+2015-04-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
1940+
1941+ SwitcherController: set FirstSelectionMode::LAST_ACTIVE_VIEW as default
1942+
1943+2015-04-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
1944+
1945+ Merging with trunk
1946+
1947+2015-04-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
1948+
1949+ SwitcherController: use properties better
1950+
1951+2015-04-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
1952+
1953+ SwitcherController: save settings in controller, and update them from compiz
1954+
1955+2015-02-04 Gerry Boland <gerry.boland@canonical.com>
1956+
1957+ Add option to have Switcher strictly between applications, and not select the previously focused window as first selection (even if that window part of the same application)
1958+
1959+2015-04-10 Brandon Schaefer <brandontschaefer@gmail.com>
1960+
1961+ When we get a launcher key press (ie. super key). We check if the command lens is open. If it is then just switch the lens to the home lens. This way we dont close the dash. Fixes: #1108956
1962+ Approved by: Stephen M. Webb, Christopher Townsend, PS Jenkins bot
1963+
1964+2015-04-10 Brandon Schaefer <brandontschaefer@gmail.com>
1965+
1966+ * Fix AP tests
1967+
1968+2015-03-31 Brandon Schaefer <brandontschaefer@gmail.com>
1969+
1970+ * Finally fixes the issue where you cant go from the command lens to the home dash
1971+
1972+2015-04-10 Stephen M. Webb <stephen.webb@canonical.com>
1973+
1974+ test_wm_keybindings: fix AP failures caused by upstream Compiz change Fixes: #1294864
1975+ Approved by: Christopher Townsend
1976+
1977+2015-04-10 Stephen M. Webb <stephen.webb@canonical.com>
1978+
1979+ adjust previous fix to use floating-point division
1980+
1981+2015-04-10 Stephen M. Webb <stephen.webb@canonical.com>
1982+
1983+ test_wm_keybindings: fix AP failures caused by upstream Compiz change
1984+
1985+2015-04-10 Stephen M. Webb <stephen.webb@canonical.com>
1986+
1987+ (Ubuntu packaging) move the session migration scripts to Python3 Fixes: #1440560
1988+ Approved by: Christopher Townsend, PS Jenkins bot
1989+
1990+2015-04-06 Stephen M. Webb <stephen.webb@canonical.com>
1991+
1992+ migration scripts: used /usr/bin/python3 shebang instead of Python-recommended /usr/bin/env
1993+
1994+2015-04-05 Stephen M. Webb <stephen.webb@canonical.com>
1995+
1996+ move migration scripts to python3
1997+
1998+2015-04-10 Stephen M. Webb <stephen.webb@canonical.com>
1999+
2000+ fixed the Panel title string expected by Launcher keynav AP tests Fixes: #1435830
2001+ Approved by: Christopher Townsend, PS Jenkins bot
2002+
2003+2015-03-26 Stephen M. Webb <stephen.webb@canonical.com>
2004+
2005+ made the test_launcher_keynav_changes_panel test conform to design requirements
2006+
2007+2015-03-24 Stephen M. Webb <stephen.webb@canonical.com>
2008+
2009+ AP tests: updated panel title expectd during keynav tests
2010+
2011+2015-03-30 CI Train Bot <ci-train-bot@canonical.com>
2012+
2013+ Releasing 7.3.2+15.04.20150330-0ubuntu1
2014+
2015+2015-03-30 Sebastien Bacher <seb128@ubuntu.com>
2016+
2017+ use the new nautilus .desktop name Fixes: #1436297
2018+ Approved by: Stephen M. Webb, PS Jenkins bot
2019+
2020+2015-03-25 Sebastien Bacher <seb128@ubuntu.com>
2021+
2022+ use the new nautilus .desktop name
2023+
2024+2015-03-30 Stephen M. Webb <stephen.webb@canonical.com>
2025+
2026+ AP tests: accounted for arbitrarily-raised exceptions in checking scaled windows Fixes: #1436095
2027+ Approved by: Christopher Townsend, PS Jenkins bot
2028+
2029+2015-03-24 Stephen M. Webb <stephen.webb@canonical.com>
2030+
2031+ AP tests: accounted for arbitrarily-raised exceptions in checking scaled windows
2032+
2033+2015-03-30 Andrea Azzarone <azzaronea@gmail.com>
2034+
2035+ Make sure that signals are auto-desconnected when XdndStartStopNotifierImp is destroyed.
2036+ Fixes: #1432231
2037+ Approved by: Stephen M. Webb, PS Jenkins bot
2038+
2039+2015-03-27 Andrea Azzarone <azzaronea@gmail.com>
2040+
2041+ Make sure that signal are auto-desconnected when XdndStartStopNotifierImp is destroyed.
2042+
2043+2015-03-30 Andrea Azzarone <azzaronea@gmail.com>
2044+
2045+ Forward first key event that happens on top of the blank window to the lockscreen. Fixes: #1308265
2046+ Approved by: Christopher Townsend, PS Jenkins bot
2047+
2048+2015-03-24 Andrea Azzarone <azzaronea@gmail.com>
2049+
2050+ Forward first key event that happens on top of the blank window to the lockscreen.
2051+
2052+2015-03-30 Andrea Azzarone <azzaronea@gmail.com>
2053+
2054+ Release pointer barrier if launcher is in lock_hide state.
2055+ Fixes: #1029114
2056+ Approved by: Christopher Townsend, PS Jenkins bot
2057+
2058+2015-03-23 Andrea Azzarone <azzaronea@gmail.com>
2059+
2060+ Release pointer barrier if launcher is in lock_hide state.
2061+
2062+2015-03-30 Andrea Azzarone <azzaronea@gmail.com>
2063+
2064+ Hide launcher to avoid damaging window when not needed. Also make sure that pressure effect works fine (previous fix has been reverted because of this!). Fixes: #1301394
2065+ Approved by: Marco Trevisan (Treviño)
2066+
2067+2015-03-23 Andrea Azzarone <azzaronea@gmail.com>
2068+
2069+ Impre readability.
2070+
2071+2015-03-23 Andrea Azzarone <azzaronea@gmail.com>
2072+
2073+ Hide launcher to avoid damaging window when not needed. Also make sure that pressure effect works fine.
2074+
2075+2015-03-30 Andrea Azzarone <azzaronea@gmail.com>
2076+
2077+ Make sure scope_views_[filter.id] exists before using operator[] on it. Fixes: #926979
2078+ Approved by: Stephen M. Webb, PS Jenkins bot
2079+
2080+2015-03-20 Andrea Azzarone <azzaronea@gmail.com>
2081+
2082+ Check the use of std::*map::operator[].
2083+
2084+2015-03-30 Andrea Azzarone <azzaronea@gmail.com>
2085+
2086+ Do not restore focus if a quicklist is opened during launcher key navigation. Fixes: #932486
2087+ Approved by: Stephen M. Webb, PS Jenkins bot
2088+
2089+2015-03-20 Andrea Azzarone <azzaronea@gmail.com>
2090+
2091+ Do not refocus window when opening a quicklist during launcher key navigation.
2092+
2093+2015-03-24 CI Train Bot <ci-train-bot@canonical.com>
2094+
2095+ Releasing 7.3.2+15.04.20150324.1-0ubuntu1
2096+
2097+2015-03-24 Brandon Schaefer <brandontschaefer@gmail.com>
2098+
2099+ When we quit the quicklist it would check if the mouse was over the launcher, if it wasn't it would fold the launcher. We don't need to check this if we are in keynav as we want all the icons to be unfolded. Fixes: #1246891
2100+ Approved by: Christopher Townsend
2101+
2102+2015-03-13 Brandon Schaefer <brandontschaefer@gmail.com>
2103+
2104+ * If we are in KeyNav mode do not check if we should set hover or not.
2105+
2106+2015-03-24 Stephen M. Webb <stephen.webb@canonical.com>
2107+
2108+ silenced GCC 5 warnings Fixes: #1430784
2109+ Approved by: Christopher Townsend, PS Jenkins bot
2110+
2111+2015-03-13 Stephen M. Webb <stephen.webb@canonical.com>
2112+
2113+ work around new GCC 5 warnings in GTest code
2114+
2115+2015-03-12 Stephen M. Webb <stephen.webb@canonical.com>
2116+
2117+ HudController.cpp: bind value of correct type to signal
2118+
2119+2015-03-24 Stephen M. Webb <stephen.webb@canonical.com>
2120+
2121+ uses the new upstream .desktop file for D-Bus activated Nautilus instances Fixes: #1428837
2122+ Approved by: Christopher Townsend, PS Jenkins bot
2123+
2124+2015-03-05 Stephen M. Webb <stephen.webb@canonical.com>
2125+
2126+ used D-bus activation .desktop file for Nautilus in AP tests
2127+
2128+2015-03-24 Chris Townsend <christopher.townsend@canonical.com>
2129+
2130+ Use a 2 second delay before showing the first run shortcut hints to workaround a race condition on input handling. Fixes: #1313597
2131+ Approved by: Stephen M. Webb
2132+
2133+2015-03-05 Chris Townsend <christopher.townsend@canonical.com>
2134+
2135+ Use a 2 second delay before showing the first run shortcut hints to workaround a race condition on input handling.
2136+
2137+2015-03-24 Stephen M. Webb <stephen.webb@canonical.com>
2138+
2139+ fix AP test failure due to new parameter added to key grabbing Fixes: #1433648
2140+ Approved by: Christopher Townsend, Marco Trevisan (Treviño)
2141+
2142+2015-03-24 Stephen M. Webb <stephen.webb@canonical.com>
2143+
2144+ fixed AP tests to match code changes
2145+
2146+2015-03-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
2147+
2148+ GnomeKeyGrabber: add timestamp support to accelerators Fixes: #1433648
2149+ Approved by: Sebastien Bacher, Christopher Townsend, PS Jenkins bot
2150+
2151+2015-03-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
2152+
2153+ GnomeKeyGrabber: add timestamp support to accelerators
2154+
2155+2015-03-19 Stephen M. Webb <stephen.webb@canonical.com>
2156+
2157+ Upstream release 7.3.2.
2158+
2159 2015-02-27 CI Train Bot <ci-train-bot@canonical.com>
2160
2161 Releasing 7.3.1+15.04.20150227-0ubuntu1
2162
2163=== modified file 'UnityCore/Scope.h'
2164--- UnityCore/Scope.h 2014-07-30 00:49:35 +0000
2165+++ UnityCore/Scope.h 2015-11-05 11:18:29 +0000
2166@@ -36,7 +36,7 @@
2167 typedef enum
2168 {
2169 G_SCOPE_ERROR_NO_ACTIVATION_HANDLER = (1 << 0),
2170- G_SCOPE_ERROR_INVALID_PREVIEW = (2 << 0)
2171+ G_SCOPE_ERROR_INVALID_PREVIEW = (1 << 1)
2172 } GScopeError;
2173
2174 GQuark
2175
2176=== modified file 'dash/previews/CMakeLists.txt'
2177--- dash/previews/CMakeLists.txt 2013-05-06 11:57:14 +0000
2178+++ dash/previews/CMakeLists.txt 2015-11-05 11:18:29 +0000
2179@@ -48,36 +48,36 @@
2180 # Application Standalone variant
2181 #
2182 add_executable (app_previews StandaloneApplicationPreview.cpp)
2183-target_link_libraries (app_previews previews-lib unity-shared)
2184+target_link_libraries (app_previews previews-lib unity-shared unity-shared-standalone)
2185
2186 #
2187 # Music Standalone variant
2188 #
2189 add_executable (music_previews StandaloneMusicPreview.cpp)
2190-target_link_libraries (music_previews previews-lib unity-shared)
2191+target_link_libraries (music_previews previews-lib unity-shared unity-shared-standalone)
2192
2193 #
2194 # Social Standalone variant
2195 #
2196 add_executable (social_previews StandaloneSocialPreview.cpp)
2197-target_link_libraries (social_previews previews-lib unity-shared)
2198+target_link_libraries (social_previews previews-lib unity-shared unity-shared-standalone)
2199
2200 #
2201 # Movie Standalone variant
2202 #
2203 add_executable (movie_previews StandaloneMoviePreview.cpp)
2204-target_link_libraries (movie_previews previews-lib unity-shared)
2205+target_link_libraries (movie_previews previews-lib unity-shared unity-shared-standalone)
2206
2207 #
2208 # Payment Standalone variant
2209 #
2210 add_executable (payment_previews StandaloneMusicPaymentPreview.cpp)
2211 add_dependencies (payment_previews previews-lib)
2212-target_link_libraries (payment_previews previews-lib unity-shared)
2213+target_link_libraries (payment_previews previews-lib unity-shared unity-shared-standalone)
2214
2215 #
2216 # Error Standalone variant
2217 #
2218 add_executable (error_previews StandaloneErrorPreview.cpp)
2219 add_dependencies (error_previews previews-lib)
2220-target_link_libraries (error_previews previews-lib unity-shared)
2221+target_link_libraries (error_previews previews-lib unity-shared unity-shared-standalone)
2222
2223=== modified file 'debian/changelog'
2224--- debian/changelog 2015-10-16 08:46:34 +0000
2225+++ debian/changelog 2015-11-05 11:18:29 +0000
2226@@ -1,3 +1,16 @@
2227+unity (7.4.0-0ubuntu1) UNRELEASED; urgency=medium
2228+
2229+ * Bumping version to 7.4.0
2230+ * Fix building in xenial
2231+
2232+ -- Marco Trevisan (Treviño) <marco@ubuntu.com> Mon, 26 Oct 2015 15:37:22 +0100
2233+
2234+unity (7.3.3-0ubuntu1) UNRELEASED; urgency=medium
2235+
2236+ * Releasing Unity 7.3.3
2237+
2238+ -- Marco Trevisan (Treviño) <marco@ubuntu.com> Mon, 26 Oct 2015 15:37:22 +0100
2239+
2240 unity (7.3.2+15.10.20151016-0ubuntu1) wily; urgency=medium
2241
2242 [ Marco Trevisan (Treviño) ]
2243
2244=== modified file 'debian/control'
2245--- debian/control 2015-08-24 16:03:38 +0000
2246+++ debian/control 2015-11-05 11:18:29 +0000
2247@@ -8,12 +8,13 @@
2248 dbus-test-runner,
2249 dh-migrations,
2250 dh-translations (>= 94),
2251+ dh-python,
2252 google-mock (>= 1.6.0+svn437),
2253 gsettings-desktop-schemas-dev,
2254 gsettings-ubuntu-schemas (>= 0.0.1+14.04.20140219),
2255 intltool (>= 0.35.0),
2256 libatk1.0-dev,
2257- libbamf3-dev (>= 0.5.0+13.10.20130731),
2258+ libbamf3-dev (>= 0.5.2~bzr0),
2259 libboost-dev,
2260 libcairo2-dev,
2261 libdbus-1-dev,
2262@@ -48,6 +49,7 @@
2263 libzeitgeist-2.0-dev,
2264 pkg-config,
2265 python (>= 2.7),
2266+ python3 (>= 3.4),
2267 python-setuptools,
2268 quilt,
2269 xserver-xorg-video-dummy,
2270@@ -62,7 +64,7 @@
2271 Architecture: any
2272 Depends: ${shlibs:Depends},
2273 ${misc:Depends},
2274- ${python:Depends},
2275+ ${python3:Depends},
2276 libunity-core-6.0-9 (= ${binary:Version}),
2277 compiz,
2278 compiz-core, compiz-core-abiversion-${coreabiversion},
2279
2280=== modified file 'debian/rules'
2281--- debian/rules 2015-02-05 14:07:05 +0000
2282+++ debian/rules 2015-11-05 11:18:29 +0000
2283@@ -9,10 +9,6 @@
2284
2285 DEB_VERSION := $(shell dpkg-parsechangelog | egrep '^Version:' | cut -f 2 -d ' ')
2286
2287-# avoid template instance removal (lp:1286284)
2288-export DEB_CXXFLAGS_MAINT_STRIP=-O3
2289-export DEB_CXXFLAGS_MAINT_APPEND=-O2
2290-
2291 # http://ccache.samba.org/manual.html#_precompiled_headers
2292 CCACHE_SLOPPINESS=time_macros
2293
2294@@ -27,11 +23,12 @@
2295 ifeq ($(DEB_HOST_ARCH),$(findstring $(DEB_HOST_ARCH), $(gles2_architectures)))
2296 cmake_gl_options := -DBUILD_GLES=TRUE -DDISABLE_MAINTAINER_CFLAGS=ON
2297 endif
2298+
2299+# Workaround for bug #1511542
2300 ifeq ($(DEB_HOST_ARCH),$(findstring $(DEB_HOST_ARCH), arm64))
2301- cmake_pch_options := -Duse_pch=OFF
2302+ cmake_pch_options := -DENABLE_UNIT_TESTS=OFF
2303 endif
2304
2305-
2306 override_dh_auto_configure:
2307 dh_auto_configure -- $(cmake_base_options) $(cmake_gl_options) $(cmake_pch_options)
2308
2309@@ -45,7 +42,7 @@
2310 find debian/tmp/usr/lib -name \*.*a -exec rm {} \;
2311 rm -f debian/tmp/usr/share/compiz/networkarearegion.xml
2312 rm -f debian/tmp//usr/lib/compiz/libnetworkarearegion.so
2313- rm -rf debian/tmp/usr/share/gconf/schemas/
2314+ rm -rf debian/tmp/usr/share/gconf/schemas/
2315 dh_install --fail-missing
2316
2317 override_dh_gencontrol:
2318@@ -63,4 +60,4 @@
2319 endif
2320
2321 %:
2322- dh $@ --with translations,quilt,python2,migrations --parallel
2323+ dh $@ --with translations,quilt,python2,python3,migrations --parallel
2324
2325=== modified file 'launcher/LauncherController.cpp'
2326--- launcher/LauncherController.cpp 2015-05-29 12:41:38 +0000
2327+++ launcher/LauncherController.cpp 2015-11-05 11:18:29 +0000
2328@@ -150,7 +150,11 @@
2329
2330 WindowManager& wm = WindowManager::Default();
2331 wm.window_focus_changed.connect(sigc::mem_fun(this, &Controller::Impl::OnWindowFocusChanged));
2332+#if SIGCXX_MAJOR_VERSION >= 2 && SIGCXX_MINOR_VERSION >= 5
2333+ wm.viewport_layout_changed.connect(sigc::track_obj([this] (int w, int h) { UpdateNumWorkspaces(w * h); }, *this));
2334+#else
2335 wm.viewport_layout_changed.connect(sigc::group(sigc::mem_fun(this, &Controller::Impl::UpdateNumWorkspaces), sigc::_1 * sigc::_2));
2336+#endif
2337 average_color_connection_ = wm.average_color.changed.connect([this] (nux::Color const& color) {
2338 parent_->options()->background_color = color;
2339 });
2340
2341=== modified file 'tests/CMakeLists.txt'
2342--- tests/CMakeLists.txt 2015-10-16 08:46:03 +0000
2343+++ tests/CMakeLists.txt 2015-11-05 11:18:29 +0000
2344@@ -388,5 +388,5 @@
2345 # make target to allow devs to run "make autopilot" from build dir:
2346 set (AUTOPILOTDIR "${CMAKE_CURRENT_SOURCE_DIR}/autopilot")
2347 # Rules to install autopilot files and executable script:
2348-install(CODE "execute_process(COMMAND python setup.py install --prefix ${CMAKE_INSTALL_PREFIX} WORKING_DIRECTORY ${AUTOPILOTDIR})")
2349+install(CODE "execute_process(COMMAND python2.7 setup.py install --prefix ${CMAKE_INSTALL_PREFIX} WORKING_DIRECTORY ${AUTOPILOTDIR})")
2350 add_custom_target (autopilot COMMAND cd ${AUTOPILOTDIR} && make check)
2351
2352=== modified file 'tools/unity.cmake'
2353--- tools/unity.cmake 2014-07-08 14:28:27 +0000
2354+++ tools/unity.cmake 2015-11-05 11:18:29 +0000
2355@@ -1,4 +1,4 @@
2356-#!/usr/bin/python
2357+#!/usr/bin/python3
2358 # -*- coding: utf-8 -*-
2359 # Copyright (C) 2010 Canonical
2360 #
2361@@ -18,7 +18,6 @@
2362 # this program; if not, write to the Free Software Foundation, Inc.,
2363 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2364
2365-import glib
2366 import glob
2367 from optparse import OptionParser
2368 import os
2369@@ -58,21 +57,21 @@
2370 '''set variable environnement for unity to run'''
2371
2372 os.environ['COMPIZ_CONFIG_PROFILE'] = 'ubuntu'
2373-
2374+
2375 if not 'DISPLAY' in os.environ:
2376 # take an optimistic chance and warn about it :)
2377- print "WARNING: no DISPLAY variable set, setting it to :0"
2378+ print("WARNING: no DISPLAY variable set, setting it to :0")
2379 os.environ['DISPLAY'] = ':0'
2380
2381 def reset_launcher_icons ():
2382 '''Reset the default launcher icon and restart it.'''
2383- subprocess.Popen(["gsettings", "reset" ,"com.canonical.Unity.Launcher" , "favorites"])
2384+ subprocess.Popen(["gsettings", "reset" ,"com.canonical.Unity.Launcher" , "favorites"])
2385
2386 def process_and_start_unity (verbose, debug_mode, compiz_path, compiz_args, log_file):
2387 '''launch unity under compiz (replace the current shell in any case)'''
2388-
2389+
2390 cli = []
2391-
2392+
2393 if debug_mode > 0:
2394 # we can do more check later as if it's in PATH...
2395 if not os.path.isfile('/usr/bin/gdb'):
2396@@ -85,7 +84,7 @@
2397 sys.exit(1)
2398 else:
2399 cli.extend(['gdb', '--args'])
2400-
2401+
2402 if options.compiz_path:
2403 cli.extend([options.compiz_path, '--replace'])
2404 else:
2405@@ -95,7 +94,7 @@
2406 cli.append("--debug")
2407 if args:
2408 cli.extend(compiz_args)
2409-
2410+
2411 if log_file:
2412 cli.extend(['2>&1', '|', 'tee', log_file])
2413
2414@@ -119,7 +118,7 @@
2415 # In this case, we need a string and not a list
2416 # FIXME: still some bug with 2>&1 not showing everything before wait()
2417 return subprocess.Popen(" ".join(cli), env=dict(os.environ), shell=True)
2418-
2419+
2420
2421 def run_unity (verbose, debug, advanced_debug, compiz_path, compiz_args, log_file):
2422 '''run the unity shell and handle Ctrl + C'''
2423@@ -130,7 +129,7 @@
2424 unity_instance = process_and_start_unity (verbose, debug_mode, compiz_path, compiz_args, log_file)
2425 subprocess.call(["start", "unity-panel-service"])
2426 unity_instance.wait()
2427- except KeyboardInterrupt, e:
2428+ except KeyboardInterrupt as e:
2429 try:
2430 os.kill(unity_instance.pid, signal.SIGKILL)
2431 except:
2432@@ -139,31 +138,31 @@
2433 sys.exit(unity_instance.returncode)
2434
2435 def reset_to_distro():
2436- ''' remove all known default local installation path '''
2437-
2438- # check if we are root, we need to be root
2439- if os.getuid() != 0:
2440- print "Error: You need to be root to remove your local unity installation"
2441- return 1
2442- error = False
2443-
2444- for filedir in well_known_local_path:
2445- for elem in glob.glob(filedir):
2446- try:
2447- shutil.rmtree(elem)
2448- except OSError, e:
2449- if os.path.isfile(elem) or os.path.islink(elem):
2450- os.remove(elem)
2451- else:
2452- print "ERROR: Cannot remove %s: %s" % (elem, e)
2453- error = True
2454-
2455- if error:
2456- print "See above: some error happened and you should clean them before trying to restart unity"
2457- return 1
2458- else:
2459- print "Unity local install cleaned, you can now restart unity"
2460- return 0
2461+ ''' remove all known default local installation path '''
2462+
2463+ # check if we are root, we need to be root
2464+ if os.getuid() != 0:
2465+ print("Error: You need to be root to remove your local unity installation")
2466+ return 1
2467+ error = False
2468+
2469+ for filedir in well_known_local_path:
2470+ for elem in glob.glob(filedir):
2471+ try:
2472+ shutil.rmtree(elem)
2473+ except OSError as e:
2474+ if os.path.isfile(elem) or os.path.islink(elem):
2475+ os.remove(elem)
2476+ else:
2477+ print("ERROR: Cannot remove %s: %s" % (elem, e))
2478+ error = True
2479+
2480+ if error:
2481+ print("See above: some error happened and you should clean them before trying to restart unity")
2482+ return 1
2483+ else:
2484+ print("Unity local install cleaned, you can now restart unity")
2485+ return 0
2486
2487 if __name__ == '__main__':
2488 usage = "usage: %prog [options]"
2489@@ -176,7 +175,7 @@
2490 parser.add_option("--debug", action="store_true",
2491 help="Run unity under gdb and print a backtrace on crash. /!\ Only if devs ask for it.")
2492 parser.add_option("--distro", action="store_true",
2493- help="Remove local build if present with default values to return to the package value (this doesn't run unity and need root access)")
2494+ help="Remove local build if present with default values to return to the package value (this doesn't run unity and need root access)")
2495 parser.add_option("--log", action="store",
2496 help="Store log under filename.")
2497 parser.add_option("--replace", action="store_true",
2498@@ -184,7 +183,7 @@
2499 parser.add_option("--reset", action="store_true",
2500 help="Reset is not supported anymore. Deprecated option")
2501 parser.add_option("--reset-icons", action="store_true",
2502- help="Reset the default launcher icon.")
2503+ help="Reset the default launcher icon.")
2504 parser.add_option("-v", "--verbose", action="store_true",
2505 help="Get additional debug output from unity.")
2506 (options, args) = parser.parse_args()
2507
2508=== modified file 'unity-shared/BamfApplicationManager.cpp'
2509--- unity-shared/BamfApplicationManager.cpp 2015-07-10 10:16:03 +0000
2510+++ unity-shared/BamfApplicationManager.cpp 2015-11-05 11:18:29 +0000
2511@@ -425,8 +425,7 @@
2512
2513 bool was_empty = windows_.empty();
2514
2515- std::shared_ptr<GList> children(bamf_view_get_children(bamf_view_), g_list_free);
2516- for (GList* l = children.get(); l; l = l->next)
2517+ for (GList* l = bamf_view_peek_children(bamf_view_); l; l = l->next)
2518 {
2519 if (ApplicationWindowPtr const& window = pool::EnsureWindow(manager_, static_cast<BamfView*>(l->data)))
2520 {
2521@@ -686,15 +685,15 @@
2522 return win_pair.second;
2523 }
2524
2525- // TODO: use bamf_matcher_get_window_for_xid
2526+ if (BamfWindow* win = bamf_matcher_get_window_for_xid(matcher_, xid))
2527+ return pool::EnsureWindow(*this, reinterpret_cast<BamfView*>(win));
2528+
2529 auto* app = bamf_matcher_get_application_for_xid(matcher_, xid);
2530
2531 if (!app)
2532 return nullptr;
2533
2534- std::shared_ptr<GList> windows(bamf_view_get_children(reinterpret_cast<BamfView*>(app)), g_list_free);
2535-
2536- for (GList* l = windows.get(); l; l = l->next)
2537+ for (GList* l = bamf_view_peek_children(reinterpret_cast<BamfView*>(app)); l; l = l->next)
2538 {
2539 if (!BAMF_IS_WINDOW(l->data))
2540 continue;