Merge lp:~unity-team/unity/places-fixes-2010-09-22 into lp:unity
Proposed by
Neil J. Patel
Status: | Merged | ||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 544 | ||||||||||||||||||||||||||||||||||||||||
Proposed branch: | lp:~unity-team/unity/places-fixes-2010-09-22 | ||||||||||||||||||||||||||||||||||||||||
Merge into: | lp:unity | ||||||||||||||||||||||||||||||||||||||||
Diff against target: |
493 lines (+155/-26) 13 files modified
targets/mutter/plugin.vala (+4/-4) unity-private/launcher/application-controller.vala (+9/-4) unity-private/places/places-controller.vala (+1/-0) unity-private/places/places-default-renderer-group.vala (+1/-1) unity-private/places/places-default-renderer.vala (+7/-1) unity-private/places/places-place-home-renderer.vala (+2/-1) unity-private/places/places-place-home.vala (+61/-1) unity-private/places/places-place-search-bar.vala (+28/-2) unity-private/places/places-place-search-navigation.vala (+9/-0) unity-private/places/places-place.vala (+3/-3) unity-private/places/places-view.vala (+28/-8) unity-private/unity-utils.c (+1/-0) unity/theme.vala (+1/-1) |
||||||||||||||||||||||||||||||||||||||||
To merge this branch: | bzr merge lp:~unity-team/unity/places-fixes-2010-09-22 | ||||||||||||||||||||||||||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen (community) | Approve | ||
Review via email: mp+36332@code.launchpad.net |
Description of the change
All bug reports linked
To post a comment you must log in.
CODE REVIEW: places/ places- place-home. vala:
unity-private/
You are using ObjectRegistry to look up the view. This seems like a pretty big hack, abusing the testing infrastructure..?
FUNCTIONAL REVIEW:
Bug #607821: Search Field does not behave as specified when the search fails
- Fix confirmed
Bug #607829: Clicking a Place icon while viewing the same place in the Dash should return to the Home screen of that place and clear the search
- Fix confirmed
Bug #612562: URI activation in global view
- Fix confirmed
Bug #634364: unity crashed with SIGSEGV in unity_places_ place_entry_ remote_ set_active( ) paste.ubuntu. com/498597/. I can't exactly figure out where to insert the null checks. And frankly I am more concerned why u-p-a fails to come up...
- I could reproduce this now. See http://
Bug #637136: launchers should act like if the application was not focussed in the place views
- Fix confirmed
Bug #638402: clicking on a category from CoFs does not directly take you to the desired category
- Fix confirmed
Bug #638857: dash initial icons states
- Fix confirmed
Bug #641554: cropping an image in shotwell crashes unity
- Not tested
Bug #641669: Launcher loads 48 px icons instead of 32 px
- Fix confirmed
Bug #641894: Clicking on the "Files & Folders" icon while a folder is already displayed in the overlay view causes unity to crash and re-start
- I get a crash here still. 100% reproducible.
Bug #642669: mutter crashes when closing pop-up dialog
- I still get very rare crashes when I close the 'bzr gcommit' dialog, in maximized state, when clicking the commit button
Bug #643627: mutter crashed with SIGSEGV in unity_places_ place_entry_ get_parent( )
-
Bug #644215: "Applications" and "Files & Folders" tooltips are not translatable
- Fix confirmed
CONCLUSION
* Can you recheck the fix for bug #641894?
* Bug #634364 scares me a bit... I don't have a ready fix right now.