Merge lp:~unity-team/unity/panel-introspection into lp:unity

Proposed by Neil J. Patel
Status: Merged
Approved by: Alex Launi
Approved revision: no longer in the source branch.
Merged at revision: 656
Proposed branch: lp:~unity-team/unity/panel-introspection
Merge into: lp:unity
Diff against target: 0 lines
To merge this branch: bzr merge lp:~unity-team/unity/panel-introspection
Reviewer Review Type Date Requested Status
Alex Launi (community) Approve
Review via email: mp+42466@code.launchpad.net

Description of the change

Implements panel introspection plus some cleanups in the Introspect function:

- Adds support for dumping all the info from the panel (some might be missing, will try and add that too)

- Adds GetChildsName() to Introspectable so we can have nicer names for the lists of children in the output. Completely optional for sub-classes

- I cleaned up the Introspect function to isolate adding children's properties from the normal properties

- If a Introspectable sub-class returns NULL for the GetName, it's skipped. This is needed to reduce warnings and so we aren't dumping information about hidden views that we're just keeping around for performance reasons.

To post a comment you must log in.
Revision history for this message
Alex Launi (alexlauni) wrote :

35 + g_variant_builder_add (builder, "{sv}", "service-unique-name", g_variant_new_string (name));

Should this be using uname?

Other than that this looks great. Thanks Neil. Merge.

review: Approve
Revision history for this message
Neil J. Patel (njpatel) wrote :

It sure should, fixed and merged, thanks!

Preview Diff

Empty