Merge lp:~unity-team/unity-scopes-api/require-g++-4.9 into lp:unity-scopes-api

Proposed by Thomas Voß
Status: Merged
Approved by: Michal Hruby
Approved revision: 400
Merged at revision: 226
Proposed branch: lp:~unity-team/unity-scopes-api/require-g++-4.9
Merge into: lp:unity-scopes-api
Diff against target: 69 lines (+14/-8)
4 files modified
CMakeLists.txt (+8/-5)
debian/control (+2/-1)
debian/libunity-scopes2.symbols (+0/-2)
debian/rules (+4/-0)
To merge this branch: bzr merge lp:~unity-team/unity-scopes-api/require-g++-4.9
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Steve Langasek Pending
Review via email: mp+227386@code.launchpad.net

Commit message

Force building with g++ 4.9

Description of the change

Allow different gcc micro versions

To post a comment you must log in.
400. By Thomas Voß

[ Michal Hruby ]
* Sync with devel.
[ Pete Woods ]
* Sync with devel.
[ Marcus Tomlinson ]
* Sync with devel.
[ Tarmac ]
* Sync with devel.
[ CI bot ]
* Sync with devel.
[ Michi Henning ]
* Sync with devel.
[ Michal Hruby ]
* Added CannedQuery parameter to Category
[ Michi Henning ]
* Added support for scope settings.
[ Ubuntu daily release ]
* debian/*symbols: auto-update new symbols to released version
* New rebuild forced

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-07-07 06:21:59 +0000
3+++ CMakeLists.txt 2014-07-18 19:29:21 +0000
4@@ -122,11 +122,14 @@
5 ${OTHER_INCLUDE_DIRS}
6 )
7
8-# When building the library, we set the default symbol visibility
9-# to "hidden", so we don't export things by default.
10-# Exported functions and classes are prefixed by a UNITY_API macro,
11-# which explicitly exports a symbol if UNITY_DLL_EXPORTS is defined.
12-add_definitions(-DUNITY_DLL_EXPORTS)
13+# We require g++ 4.9, to avoid ABI breakage with earlier version.
14+# Note that this must match what is specifed in debian/control.
15+set(cxx_version_required 4.9)
16+if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
17+ if (NOT CMAKE_CXX_COMPILER_VERSION MATCHES "^${cxx_version_required}")
18+ message(FATAL_ERROR "g++ version must be ${cxx_version_required}!")
19+ endif()
20+endif()
21
22 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -pedantic -Wno-variadic-macros -Wextra -fPIC")
23
24
25=== modified file 'debian/control'
26--- debian/control 2014-06-24 15:20:03 +0000
27+++ debian/control 2014-07-18 19:29:21 +0000
28@@ -1,7 +1,8 @@
29 Source: unity-scopes-api
30 Priority: optional
31 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
32-Build-Depends: debhelper (>= 9),
33+Build-Depends: g++-4.9,
34+ debhelper (>= 9),
35 click-dev (>= 0.2.2),
36 cmake,
37 doxygen,
38
39=== modified file 'debian/libunity-scopes2.symbols'
40--- debian/libunity-scopes2.symbols 2014-07-09 14:26:28 +0000
41+++ debian/libunity-scopes2.symbols 2014-07-18 19:29:21 +0000
42@@ -382,13 +382,11 @@
43 (c++)"unity::scopes::testing::OutOfProcessBenchmark::~OutOfProcessBenchmark()@Base" 0.4.0+14.04.20140312.1
44 (c++)"unity::scopes::testing::Result::Result()@Base" 0.4.0+14.04.20140312.1
45 (c++)"unity::scopes::testing::Result::~Result()@Base" 0.4.0+14.04.20140312.1
46- (c++)"unity::scopes::testing::Sample::~Sample()@Base" 0.4.0+14.04.20140312.1
47 (c++)"unity::scopes::testing::Benchmark::Result::save_to_xml(std::basic_ostream<char, std::char_traits<char> >&)@Base" 0.4.0+14.04.20140312.1
48 (c++)"unity::scopes::testing::Benchmark::Result::load_from_xml(std::basic_istream<char, std::char_traits<char> >&)@Base" 0.4.0+14.04.20140312.1
49 (c++)"unity::scopes::testing::Benchmark::Result::Timing::~Timing()@Base" 0.4.0+14.04.20140312.1
50 (c++)"unity::scopes::testing::Benchmark::Result::save_to(std::basic_ostream<char, std::char_traits<char> >&)@Base" 0.4.0+14.04.20140312.1
51 (c++)"unity::scopes::testing::Benchmark::Result::load_from(std::basic_istream<char, std::char_traits<char> >&)@Base" 0.4.0+14.04.20140312.1
52- (c++)"unity::scopes::testing::Benchmark::~Benchmark()@Base" 0.4.0+14.04.20140312.1
53 (c++)"unity::scopes::testing::operator==(unity::scopes::testing::Benchmark::Result const&, unity::scopes::testing::Benchmark::Result const&)@Base" 0.4.0+14.04.20140312.1
54 (c++)"unity::scopes::testing::operator<<(std::basic_ostream<char, std::char_traits<char> >&, unity::scopes::testing::Benchmark::Result const&)@Base" 0.4.0+14.04.20140312.1
55 (c++)"unity::scopes::Category::Category(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unity::scopes::CategoryRenderer const&)@Base" 0.4.0+14.04.20140312.1
56
57=== modified file 'debian/rules'
58--- debian/rules 2014-04-04 14:03:41 +0000
59+++ debian/rules 2014-07-18 19:29:21 +0000
60@@ -5,6 +5,10 @@
61 #export DH_VERBOSE=1
62 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
63
64+# We require a specific gcc version to avoid ABI breakage.
65+export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
66+export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
67+
68 %:
69 dh $@ --parallel --fail-missing --with click
70

Subscribers

People subscribed via source and target branches

to all changes: