Merge lp:~unity-team/unity-lens-video/unity-scope-video-remote-precise into lp:ubuntu/precise/unity-scope-video-remote

Proposed by Timo Jyrinki
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~unity-team/unity-lens-video/unity-scope-video-remote-precise
Merge into: lp:ubuntu/precise/unity-scope-video-remote
Diff against target: 117 lines (+42/-16)
4 files modified
MANIFEST.in (+4/-0)
debian/changelog (+15/-0)
debian/control (+3/-1)
src/unity-scope-video-remote (+20/-15)
To merge this branch: bzr merge lp:~unity-team/unity-lens-video/unity-scope-video-remote-precise
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+158864@code.launchpad.net

Commit message

* Cherry-pick a fix from upstream:
  - Use https connection when talking to the server (LP: #1071079)

Description of the change

* Cherry-pick a fix from upstream:
  - Use https connection when talking to the server (LP: #1071079)

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Tested manually with a built package (from ppa:unity-team/sru) with tcpdump.

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks, I've uploaded that to the precise SRU queue

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MANIFEST.in'
2--- MANIFEST.in 2012-01-31 15:55:00 +0000
3+++ MANIFEST.in 2013-04-15 08:48:32 +0000
4@@ -2,3 +2,7 @@
5 include video-remote.scope
6 include src/unity-scope-video-remote
7 include COPYING
8+include unity-scope-video-remote.service
9+include video-remote.scope
10+include src/unity-scope-video-remote
11+include COPYING
12
13=== modified file 'debian/changelog'
14--- debian/changelog 2012-04-06 20:56:42 +0000
15+++ debian/changelog 2013-04-15 08:48:32 +0000
16@@ -1,3 +1,18 @@
17+unity-scope-video-remote (0.3.5-0ubuntu2.2) UNRELEASED; urgency=low
18+
19+ * Cherry-pick a fix from upstream:
20+ - Use https connection when talking to the server (LP: #1071079)
21+ * Update maintainer to be Ubuntu Developers
22+
23+ -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Mon, 25 Feb 2013 11:44:03 +0200
24+
25+unity-scope-video-remote (0.3.5-0ubuntu2.1) precise-proposed; urgency=low
26+
27+ * Exit on DBus hickup at startup, Unity will restart the scope (LP: #950862)
28+ * Depends on gvfs-bin (LP: #972304)
29+
30+ -- David Callé <davidc@framli.eu> Wed, 27 Jun 2012 20:33:46 +0200
31+
32 unity-scope-video-remote (0.3.5-0ubuntu2) precise; urgency=low
33
34 * src/unity-scope-video-remote
35
36=== modified file 'debian/control'
37--- debian/control 2012-03-02 20:24:25 +0000
38+++ debian/control 2013-04-15 08:48:32 +0000
39@@ -1,7 +1,8 @@
40 Source: unity-scope-video-remote
41 Section: gnome
42 Priority: optional
43-Maintainer: David Calle <davidc@framli.eu>
44+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
45+XSBC-Original-Maintainer: David Calle <davidc@framli.eu>
46 Build-Depends: debhelper (>= 8), python, python-distutils-extra
47 Standards-Version: 3.9.2
48 Homepage: https://launchpad.net/unity-lens-videos
49@@ -15,6 +16,7 @@
50 gir1.2-soup-2.4,
51 gir1.2-glib-2.0,
52 python-zeitgeist,
53+ gvfs-bin,
54 unity-lens-video
55 Enhances: unity-lens-video
56 Description: Remote videos engine
57
58=== modified file 'debian/rules' (properties changed: +x to -x)
59=== modified file 'src/unity-scope-video-remote'
60--- src/unity-scope-video-remote 2012-04-06 20:56:42 +0000
61+++ src/unity-scope-video-remote 2013-04-15 08:48:32 +0000
62@@ -43,7 +43,7 @@
63 #pylint: enable=E0611
64
65 BUS_NAME = "net.launchpad.scope.RemoteVideos"
66-SERVER = "http://videosearch.ubuntu.com/v0"
67+SERVER = "https://videosearch.ubuntu.com/v0"
68
69 REFRESH_INTERVAL = 3600 # fetch sources & recommendations once an hour
70 RETRY_INTERVAL = 60 # retry sources/recommendations after a minute
71@@ -76,6 +76,8 @@
72 self.scope.connect ("activate-uri", self.on_activate_uri)
73 self.session = Soup.SessionAsync()
74 self.session.props.user_agent = "Unity Video Lens Remote Scope v0.4"
75+ self.session.props.ssl_use_system_ca_file = True
76+ self.session.props.ssl_strict = True
77 self.session.add_feature_by_type(SoupGNOME.ProxyResolverGNOME)
78 self.query_list_of_sources()
79 self.update_recommendations()
80@@ -287,20 +289,23 @@
81
82 def main():
83 """Connect to the session bus, exit if there is a running instance."""
84- session_bus_connection = Gio.bus_get_sync(Gio.BusType.SESSION, None)
85- session_bus = Gio.DBusProxy.new_sync(session_bus_connection, 0, None,
86- 'org.freedesktop.DBus',
87- '/org/freedesktop/DBus',
88- 'org.freedesktop.DBus', None)
89- result = session_bus.call_sync('RequestName',
90- GLib.Variant("(su)", (BUS_NAME, 0x4)),
91- 0, -1, None)
92-
93- # Unpack variant response with signature "(u)". 1 means we got it.
94- result = result.unpack()[0]
95-
96- if result != 1:
97- print >> sys.stderr, "Failed to own name %s. Bailing out." % BUS_NAME
98+ try:
99+ session_bus_connection = Gio.bus_get_sync(Gio.BusType.SESSION, None)
100+ session_bus = Gio.DBusProxy.new_sync(session_bus_connection, 0, None,
101+ 'org.freedesktop.DBus',
102+ '/org/freedesktop/DBus',
103+ 'org.freedesktop.DBus', None)
104+ result = session_bus.call_sync('RequestName',
105+ GLib.Variant("(su)", (BUS_NAME, 0x4)),
106+ 0, -1, None)
107+
108+ # Unpack variant response with signature "(u)". 1 means we got it.
109+ result = result.unpack()[0]
110+
111+ if result != 1:
112+ print >> sys.stderr, "Failed to own name %s. Bailing out." % BUS_NAME
113+ raise SystemExit(1)
114+ except:
115 raise SystemExit(1)
116
117 Daemon()

Subscribers

People subscribed via source and target branches

to all changes: