Merge lp:~unity-team/ubuntu-settings-components/local-translation-update into lp:~registry/ubuntu-settings-components/trunk

Proposed by Nick Dedekind
Status: Merged
Approved by: Michael Zanetti
Approved revision: 113
Merged at revision: 142
Proposed branch: lp:~unity-team/ubuntu-settings-components/local-translation-update
Merge into: lp:~registry/ubuntu-settings-components/trunk
Diff against target: 21 lines (+2/-2)
1 file modified
plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml (+2/-2)
To merge this branch: bzr merge lp:~unity-team/ubuntu-settings-components/local-translation-update
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
Jonas G. Drange (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Unity8 CI Bot (community) continuous-integration Approve
Review via email: mp+288935@code.launchpad.net

Commit message

Fixed ModemInfoItem translation to use ubuntu-settings-components domain.

Description of the change

Fixed ModemInfoItem translation to use ubuntu-settings-components domain.

To post a comment you must log in.
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Unfortunately we loose all unity8 translations of this now... can they be transfered across easily?

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:112
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/18/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/960
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/976
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/976
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/974
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/974/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/974
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/974/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/974
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/974/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/974
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/974/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/974
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/974/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/974
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/974/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/18/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
113. By Nick Dedekind

merged trunk

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:114
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/19/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1004
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1020
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1020
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1018
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1018/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1018
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1018/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1018
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1018/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1018
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1018/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1018
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1018/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1018
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1018/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/19/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM

review: Approve
Revision history for this message
Michael Zanetti (mzanetti) wrote :

+1, however we can't land this before OTA-10 as we're in string freeze

review: Approve
Revision history for this message
Michael Zanetti (mzanetti) wrote :

> +1, however we can't land this before OTA-10 as we're in string freeze

ok. scratch this... looks like this doesn't kill existing translation like mentioned in comment one.

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

We need to land this to fix lpbug:#1560039

114. By Michał Sawicz

Merge trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml'
2--- plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml 2016-01-27 13:13:15 +0000
3+++ plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml 2016-05-05 17:35:58 +0000
4@@ -97,7 +97,7 @@
5 id: labelRoaming
6 elide: Text.ElideRight
7 fontSize: "x-small"
8- text: i18n.tr("Roaming")
9+ text: i18n.dtr("ubuntu-settings-components", "Roaming")
10 opacity: 0.6
11 }
12
13@@ -119,7 +119,7 @@
14 objectName: "buttonUnlockSim"
15 visible: menu.locked
16
17- text: i18n.tr("Unlock SIM")
18+ text: i18n.dtr("ubuntu-settings-components", "Unlock SIM")
19 Layout.preferredWidth: implicitWidth + units.gu(5)
20
21 onTriggered: menu.unlock()

Subscribers

People subscribed via source and target branches

to all changes: