Merge lp:~unity-team/platform-api/exposeOrientation-fix-android into lp:platform-api

Proposed by Gerry Boland
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 264
Merged at revision: 271
Proposed branch: lp:~unity-team/platform-api/exposeOrientation-fix-android
Merge into: lp:platform-api
Diff against target: 14 lines (+3/-3)
1 file modified
android/default/default_ubuntu_application_ui.cpp (+3/-3)
To merge this branch: bzr merge lp:~unity-team/platform-api/exposeOrientation-fix-android
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Approve
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+236154@code.launchpad.net

Commit message

For for exposeOrientation breaking hybris side

Description of the change

For for exposeOrientation breaking hybris side

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

This will probably do it, but for some reason I'm unable to build the android bits right now. Can someone else please try?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Looks good, fixes the build.

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

Was able to build with sbuild for armhf and released mir

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'android/default/default_ubuntu_application_ui.cpp'
2--- android/default/default_ubuntu_application_ui.cpp 2014-08-20 17:13:47 +0000
3+++ android/default/default_ubuntu_application_ui.cpp 2014-09-26 16:03:15 +0000
4@@ -449,8 +449,8 @@
5 UAUiWindow *window)
6 {
7 ALOGI("%s():%d", __PRETTY_FUNCTION__, __LINE__);
8-
9- auto p = static_cast<Holder<ubuntu::application::ui::Surface::Ptr>*>(window);
10- return p->value->get_orientation();
11+ (void*) window;
12+ // Orientation flag not available with android, return default
13+ return U_ORIENTATION_NORMAL;
14 }
15

Subscribers

People subscribed via source and target branches