Nux

Merge lp:~unity-team/nux/nux.libgeis-optional-package into lp:nux

Proposed by Jay Taoko on 2012-08-02
Status: Merged
Approved by: Jay Taoko on 2012-08-03
Approved revision: 644
Merged at revision: 644
Proposed branch: lp:~unity-team/nux/nux.libgeis-optional-package
Merge into: lp:nux
Diff against target: 36 lines (+4/-1)
2 files modified
NuxGraphics/nux-graphics.pc.in (+1/-1)
configure.ac (+3/-0)
To merge this branch: bzr merge lp:~unity-team/nux/nux.libgeis-optional-package
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) 2012-08-02 Approve on 2012-08-02
Review via email: mp+117942@code.launchpad.net

Commit Message

* Make libgeis package optional in nux-graphics.pc.in. For instance libgeis is not available on Ubuntu Precise.

Description of the Change

* Make libgeis package optional in nux-graphics.pc.in. For instance libgeis is not available on Ubuntu Precise.

To post a comment you must log in.
643. By Jay Taoko on 2012-08-02

* Fix

Daniel d'Andrada (dandrader) wrote :

You're using two names by accident: GEIS_PKGS and GEIS_PKG
Thus: s/GEIS_PKGS/GEIS_PKG

Other than that it looks ok.

review: Needs Fixing
644. By Jay Taoko on 2012-08-02

* Fix

Daniel d'Andrada (dandrader) wrote :

looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NuxGraphics/nux-graphics.pc.in'
2--- NuxGraphics/nux-graphics.pc.in 2012-08-01 19:41:37 +0000
3+++ NuxGraphics/nux-graphics.pc.in 2012-08-02 19:00:25 +0000
4@@ -9,4 +9,4 @@
5 Libs: -L${libdir} -lnux-graphics-@NUX_API_VERSION@
6 Cflags: -I${includedir}/Nux-@NUX_API_VERSION@
7
8-Requires: glib-2.0 cairo libpng gdk-pixbuf-2.0 nux-core-@NUX_API_VERSION@ @GL_PKGS@ xxf86vm xinerama libgeis
9+Requires: glib-2.0 cairo libpng gdk-pixbuf-2.0 nux-core-@NUX_API_VERSION@ @GL_PKGS@ xxf86vm xinerama @GEIS_PKGS@
10
11=== modified file 'configure.ac'
12--- configure.ac 2012-08-01 19:41:37 +0000
13+++ configure.ac 2012-08-02 19:00:25 +0000
14@@ -196,6 +196,7 @@
15 dnl Enable/disable gestures (geis, from Open Input Framework)
16 dnl *********************************************************
17
18+GEIS_PKGS="libgeis"
19 AC_ARG_ENABLE(gestures,
20 AC_HELP_STRING(--disable-gestures, Disables multitouch gestures support (default: auto-detect)),
21 [],
22@@ -234,12 +235,14 @@
23 [
24 NUX_GESTURES_SUPPORT="NUX_NO_GESTURES_SUPPORT"
25 AM_CONDITIONAL(HAVE_GEIS, false)
26+ GEIS_PKGS=""
27 ])
28
29 AC_SUBST(NUX_GESTURES_SUPPORT)
30
31 AC_SUBST(GEIS_CFLAGS)
32 AC_SUBST(GEIS_LIBS)
33+AC_SUBST(GEIS_PKGS)
34
35 dnl ************************************
36 dnl Enable/disable tests

Subscribers

People subscribed via source and target branches