Code review comment for lp:~unity-team/nux/nux-fix-810182

Tim Penhey (thumper) wrote :

Hi Jay,

I'd keep the display check first, that way you don't have to check it multiple

Instead of the explicit checks, can we just use !?

  if (!display || !glx_supported) {
    if (!display)
      results.error = strdup ("unable to open display");

But the code looks sound.

review: Approve

« Back to merge proposal