Merge lp:~unity-team/libunity/fix-latest-glib-unity7 into lp:~unity-team/libunity/libunity-7.0

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 345
Merged at revision: 344
Proposed branch: lp:~unity-team/libunity/fix-latest-glib-unity7
Merge into: lp:~unity-team/libunity/libunity-7.0
Diff against target: 86 lines (+7/-7)
6 files modified
test/data/applications/asdasdasd.desktop (+1/-1)
test/data/applications/rhythmbox.desktop (+1/-1)
test/data/applications/testapp1.desktop (+1/-1)
test/data/applications/ubuntu-about.desktop (+1/-1)
test/data/test_desktop_file.desktop (+1/-1)
test/vala/test-io.vala (+2/-2)
To merge this branch: bzr merge lp:~unity-team/libunity/fix-latest-glib-unity7
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michal Hruby (community) Approve
Review via email: mp+155202@code.launchpad.net

This proposal supersedes a proposal from 2013-03-25.

Commit message

Fix tests failing due to latest glib

Description of the change

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Let's see if this works now...

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/data/applications/asdasdasd.desktop'
2--- test/data/applications/asdasdasd.desktop 2011-12-05 12:18:16 +0000
3+++ test/data/applications/asdasdasd.desktop 2013-03-25 11:33:20 +0000
4@@ -2,7 +2,7 @@
5 Encoding=UTF-8
6 Name=libunity bogus app
7 Comment=For testing non-exisiting apps
8-Exec=xterm
9+Exec=/bin/true
10 Icon=distributor-logo
11 Terminal=false
12 Type=Application
13
14=== modified file 'test/data/applications/rhythmbox.desktop'
15--- test/data/applications/rhythmbox.desktop 2011-11-25 10:56:19 +0000
16+++ test/data/applications/rhythmbox.desktop 2013-03-25 11:33:20 +0000
17@@ -3,7 +3,7 @@
18 GenericName=Music Player
19 X-GNOME-FullName=Rhythmbox Music Player
20 Comment=Play and organize your music collection
21-Exec=rhythmbox %U
22+Exec=/bin/true
23 Terminal=false
24 Type=Application
25 Icon=rhythmbox
26
27=== modified file 'test/data/applications/testapp1.desktop'
28--- test/data/applications/testapp1.desktop 2011-12-05 13:36:37 +0000
29+++ test/data/applications/testapp1.desktop 2013-03-25 11:33:20 +0000
30@@ -2,7 +2,7 @@
31 Encoding=UTF-8
32 Name=libunity test app 1
33 Comment=Test App 1 for testing non-exisiting apps
34-Exec=xterm
35+Exec=/bin/true
36 Icon=distributor-logo
37 Terminal=false
38 Type=Application
39
40=== modified file 'test/data/applications/ubuntu-about.desktop'
41--- test/data/applications/ubuntu-about.desktop 2012-02-27 09:05:54 +0000
42+++ test/data/applications/ubuntu-about.desktop 2013-03-25 11:33:20 +0000
43@@ -2,7 +2,7 @@
44 Encoding=UTF-8
45 Name=About Ubuntu
46 Comment=Learn more about Ubuntu
47-Exec=yelp ghelp:about-ubuntu
48+Exec=/bin/true
49 Icon=distributor-logo
50 Terminal=false
51 Type=Application
52
53=== modified file 'test/data/test_desktop_file.desktop'
54--- test/data/test_desktop_file.desktop 2011-09-27 09:48:39 +0000
55+++ test/data/test_desktop_file.desktop 2013-03-25 11:33:20 +0000
56@@ -1,7 +1,7 @@
57 [Desktop Entry]
58 Name=Test Application
59 Comment=This is a test application desktop file
60-Exec=xclock
61+Exec=/bin/true
62 Terminal=false
63 Type=Application
64 StartupNotify=false
65
66=== modified file 'test/vala/test-io.vala'
67--- test/vala/test-io.vala 2013-02-28 23:14:50 +0000
68+++ test/vala/test-io.vala 2013-03-25 11:33:20 +0000
69@@ -27,7 +27,7 @@
70 static string TEST_DATA = """[Desktop Entry]
71 Name=Test Application
72 Comment=This is a test application desktop file
73-Exec=xclock
74+Exec=/bin/true
75 Terminal=false
76 Type=Application
77 StartupNotify=false
78@@ -87,7 +87,7 @@
79 Priority.LOW, null,
80 out data, out data_size);
81
82- /* The test file is 177 bytes long */
83+ /* Test file bytes size */
84 if (data_size != TEST_DATA.length)
85 {
86 critical (@"Expected file size $(TEST_DATA.length), but found $data_size");

Subscribers

People subscribed via source and target branches

to all changes: